René's URL Explorer Experiment


Title: gh-128978: Fix a `NameError` in `sysconfig.expand_makefile_vars` by picnixz · Pull Request #128979 · python/cpython · GitHub

Open Graph Title: gh-128978: Fix a `NameError` in `sysconfig.expand_makefile_vars` by picnixz · Pull Request #128979 · python/cpython

X Title: gh-128978: Fix a `NameError` in `sysconfig.expand_makefile_vars` by picnixz · Pull Request #128979 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Issue: Leftover code in sysconfig.expand_makefile_vars #128978

X Description: Issue: Leftover code in sysconfig.expand_makefile_vars #128978

Opengraph URL: https://github.com/python/cpython/pull/128979

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:edbe7a6b-b422-8a59-51a7-9e9ca44f8ba3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD418:1148D3:416A23A:534F6F5:6B022C84
html-safe-nonce4deb948526256f01df7b0c1c947151e906548858d6f1dbb32f79bf5750bc2017
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDE4OjExNDhEMzo0MTZBMjNBOjUzNEY2RjU6NkIwMjJDODQiLCJ2aXNpdG9yX2lkIjoiNjA4NjAxMzU1MTIyNTQ4MjM3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8abfda51212aa1f33454da1980d53d4387661fb97f0766c03fbe9f914367eddd
hovercard-subject-tagpull_request:2285595859
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/128979/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ba30094816e777a137aed99e0554dcfa916d7add82286814e75e04f7a0ac1660/python/cpython/pull/128979
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ba30094816e777a137aed99e0554dcfa916d7add82286814e75e04f7a0ac1660/python/cpython/pull/128979
og:image:altIssue: Leftover code in sysconfig.expand_makefile_vars #128978
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/128979#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128979
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128979
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/128979
Reloadhttps://github.com/python/cpython/pull/128979
Reloadhttps://github.com/python/cpython/pull/128979
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/sysconfig/relic-128978https://github.com/picnixz/cpython/tree/fix/sysconfig/relic-128978
Conversationhttps://github.com/python/cpython/pull/128979
Commits4 (4)https://github.com/python/cpython/pull/128979/commits
Checkshttps://github.com/python/cpython/pull/128979/checks
Files changedhttps://github.com/python/cpython/pull/128979/files
gh-128978: Fix a NameError in sysconfig.expand_makefile_varshttps://github.com/python/cpython/pull/128979#top
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/sysconfig/relic-128978https://github.com/picnixz/cpython/tree/fix/sysconfig/relic-128978
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Jan 18, 2025https://github.com/python/cpython/pull/128979#issue-2796895240
Please reload this pagehttps://github.com/python/cpython/pull/128979
Leftover code in sysconfig.expand_makefile_vars #128978https://github.com/python/cpython/issues/128978
Please reload this pagehttps://github.com/python/cpython/pull/128979
picnixzhttps://github.com/picnixz
January 18, 2025 11:05https://github.com/python/cpython/pull/128979#commits-pushed-e604f5d
https://github.com/picnixz
Fix a NameError in sysconfig.expand_makefile_vars.https://github.com/python/cpython/pull/128979/commits/e604f5d0709a3fda991d7619b6efc634b1442344
e604f5dhttps://github.com/python/cpython/pull/128979/commits/e604f5d0709a3fda991d7619b6efc634b1442344
https://github.com/picnixz
blurbhttps://github.com/python/cpython/pull/128979/commits/c6554fe2c36b3c122a8ee8ada6a8e225dc7e19d9
c6554fehttps://github.com/python/cpython/pull/128979/commits/c6554fe2c36b3c122a8ee8ada6a8e225dc7e19d9
https://github.com/picnixz
picnixzhttps://github.com/picnixz
FFY00https://github.com/FFY00
code ownerhttps://github.com/python/cpython/blob/4dade055f4e18a7e91bc70293abb4db745ad16ca/.github/CODEOWNERS#L245
January 18, 2025 10:05https://github.com/python/cpython/pull/128979#event-15985504269
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jan 18, 2025 https://github.com/python/cpython/pull/128979#ref-issue-2796894296
Leftover code in sysconfig.expand_makefile_vars #128978 https://github.com/python/cpython/issues/128978
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 18, 2025https://github.com/python/cpython/pull/128979#event-15985504483
https://github.com/picnixz
picnixzhttps://github.com/picnixz
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 18, 2025https://github.com/python/cpython/pull/128979#event-15985504508
https://github.com/picnixz
Merge branch 'main' into fix/sysconfig/relic-128978https://github.com/python/cpython/pull/128979/commits/b913882f545ebdfed173c9c4a84cd514c508788b
b913882https://github.com/python/cpython/pull/128979/commits/b913882f545ebdfed173c9c4a84cd514c508788b
https://github.com/picnixz
picnixzhttps://github.com/picnixz
vstinnerhttps://github.com/vstinner
January 20, 2025 12:41https://github.com/python/cpython/pull/128979#event-15998360553
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jan 20, 2025 https://github.com/python/cpython/pull/128979#pullrequestreview-2562320217
View reviewed changes https://github.com/python/cpython/pull/128979/files/b913882f545ebdfed173c9c4a84cd514c508788b
Lib/sysconfig/__init__.pyhttps://github.com/python/cpython/pull/128979/files/b913882f545ebdfed173c9c4a84cd514c508788b#diff-ff3de3c657b8e6d0d7071b2f0672c8a7b03c45b3176557a99fc39c7bdcb571b9
Please reload this pagehttps://github.com/python/cpython/pull/128979
https://github.com/picnixz
use sysconfig.__main__ code insteadhttps://github.com/python/cpython/pull/128979/commits/cbd3b51d79b38bfba0aba7f740ba3b0e71538824
cbd3b51https://github.com/python/cpython/pull/128979/commits/cbd3b51d79b38bfba0aba7f740ba3b0e71538824
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jan 20, 2025 https://github.com/python/cpython/pull/128979#pullrequestreview-2562358337
View reviewed changes https://github.com/python/cpython/pull/128979/files/cbd3b51d79b38bfba0aba7f740ba3b0e71538824
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/128979#pullrequestreview-2562358337
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/128979
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jan 20, 2025https://github.com/python/cpython/pull/128979#event-15998741793
https://github.com/picnixz
picnixzhttps://github.com/picnixz
January 20, 2025 13:24https://github.com/python/cpython/pull/128979#event-15998910963
https://github.com/picnixz
picnixzhttps://github.com/picnixz
df66ff1https://github.com/python/cpython/commit/df66ff14b49f4388625212f6bc86b754cb51d4eb
Jan 20, 2025https://github.com/python/cpython/pull/128979#event-15998953478
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Jan 20, 2025https://github.com/python/cpython/pull/128979#issuecomment-2602427682
@picnixzhttps://github.com/picnixz
Please reload this pagehttps://github.com/python/cpython/pull/128979
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jan 20, 2025https://github.com/python/cpython/pull/128979#event-15998954252
miss-islingtonhttps://github.com/miss-islington
Jan 20, 2025 https://github.com/python/cpython/pull/128979#ref-commit-9356f95
https://github.com/picnixz
https://github.com/miss-islington
pythongh-128978https://github.com/python/cpython/issues/128978
: Fix ahttps://github.com/miss-islington/cpython/commit/9356f95a265e54b5e4d62c0e6d45da2bb30d6a14
NameErrorhttps://github.com/miss-islington/cpython/commit/9356f95a265e54b5e4d62c0e6d45da2bb30d6a14
inhttps://github.com/miss-islington/cpython/commit/9356f95a265e54b5e4d62c0e6d45da2bb30d6a14
sysconfig.expand_makefile_varshttps://github.com/miss-islington/cpython/commit/9356f95a265e54b5e4d62c0e6d45da2bb30d6a14
(https://github.com/miss-islington/cpython/commit/9356f95a265e54b5e4d62c0e6d45da2bb30d6a14
9356f95https://github.com/miss-islington/cpython/commit/9356f95a265e54b5e4d62c0e6d45da2bb30d6a14
pythonGH-128979https://github.com/python/cpython/pull/128979
4a53a39https://github.com/miss-islington/cpython/commit/4a53a397c311567f05553bc25a28aebaba4f6f65
df66ff1https://github.com/miss-islington/cpython/commit/df66ff14b49f4388625212f6bc86b754cb51d4eb
miss-islingtonhttps://github.com/miss-islington
Jan 20, 2025 https://github.com/python/cpython/pull/128979#ref-commit-837e5d2
https://github.com/picnixz
https://github.com/miss-islington
pythongh-128978https://github.com/python/cpython/issues/128978
: Fix ahttps://github.com/miss-islington/cpython/commit/837e5d27fc97903b519f283c08d859a233323836
NameErrorhttps://github.com/miss-islington/cpython/commit/837e5d27fc97903b519f283c08d859a233323836
inhttps://github.com/miss-islington/cpython/commit/837e5d27fc97903b519f283c08d859a233323836
sysconfig.expand_makefile_varshttps://github.com/miss-islington/cpython/commit/837e5d27fc97903b519f283c08d859a233323836
(https://github.com/miss-islington/cpython/commit/837e5d27fc97903b519f283c08d859a233323836
837e5d2https://github.com/miss-islington/cpython/commit/837e5d27fc97903b519f283c08d859a233323836
pythonGH-128979https://github.com/python/cpython/pull/128979
4a53a39https://github.com/miss-islington/cpython/commit/4a53a397c311567f05553bc25a28aebaba4f6f65
df66ff1https://github.com/miss-islington/cpython/commit/df66ff14b49f4388625212f6bc86b754cb51d4eb
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jan 20, 2025https://github.com/python/cpython/pull/128979#issuecomment-2602428170
GH-129065https://github.com/python/cpython/pull/129065
3.13 branchhttps://github.com/python/cpython/tree/3.13
Please reload this pagehttps://github.com/python/cpython/pull/128979
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Jan 20, 2025https://github.com/python/cpython/pull/128979#event-15998957807
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jan 20, 2025https://github.com/python/cpython/pull/128979#issuecomment-2602428355
GH-129066https://github.com/python/cpython/pull/129066
3.12 branchhttps://github.com/python/cpython/tree/3.12
Please reload this pagehttps://github.com/python/cpython/pull/128979
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Jan 20, 2025https://github.com/python/cpython/pull/128979#event-15998958978
https://github.com/picnixz
picnixzhttps://github.com/picnixz
January 20, 2025 13:27https://github.com/python/cpython/pull/128979#event-15998963327
picnixzhttps://github.com/picnixz
Jan 20, 2025 https://github.com/python/cpython/pull/128979#ref-commit-55d3d81
https://github.com/miss-islington
https://github.com/picnixz
[3.13]https://github.com/python/cpython/commit/55d3d8165c0aa522d90fe92b92ade74beb27d9f9
gh-128978https://github.com/python/cpython/issues/128978
: Fix ahttps://github.com/python/cpython/commit/55d3d8165c0aa522d90fe92b92ade74beb27d9f9
NameErrorhttps://github.com/python/cpython/commit/55d3d8165c0aa522d90fe92b92ade74beb27d9f9
in `sysconfig.expand_makefile_var…https://github.com/python/cpython/commit/55d3d8165c0aa522d90fe92b92ade74beb27d9f9
55d3d81https://github.com/python/cpython/commit/55d3d8165c0aa522d90fe92b92ade74beb27d9f9
GH-128979https://github.com/python/cpython/pull/128979
#129065https://github.com/python/cpython/pull/129065
gh-128978https://github.com/python/cpython/issues/128978
GH-128979https://github.com/python/cpython/pull/128979
4a53a39https://github.com/python/cpython/commit/4a53a397c311567f05553bc25a28aebaba4f6f65
df66ff1https://github.com/python/cpython/commit/df66ff14b49f4388625212f6bc86b754cb51d4eb
srinivasreddyhttps://github.com/srinivasreddy
Jan 21, 2025 https://github.com/python/cpython/pull/128979#ref-commit-598cb08
https://github.com/picnixz
https://github.com/srinivasreddy
pythongh-128978https://github.com/python/cpython/issues/128978
: Fix ahttps://github.com/srinivasreddy/cpython/commit/598cb086e2a666cc5af9fbfeec8949bf56839a89
NameErrorhttps://github.com/srinivasreddy/cpython/commit/598cb086e2a666cc5af9fbfeec8949bf56839a89
inhttps://github.com/srinivasreddy/cpython/commit/598cb086e2a666cc5af9fbfeec8949bf56839a89
sysconfig.expand_makefile_varshttps://github.com/srinivasreddy/cpython/commit/598cb086e2a666cc5af9fbfeec8949bf56839a89
(https://github.com/srinivasreddy/cpython/commit/598cb086e2a666cc5af9fbfeec8949bf56839a89
598cb08https://github.com/srinivasreddy/cpython/commit/598cb086e2a666cc5af9fbfeec8949bf56839a89
python#128979https://github.com/python/cpython/pull/128979
4a53a39https://github.com/srinivasreddy/cpython/commit/4a53a397c311567f05553bc25a28aebaba4f6f65
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128979
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/128979/files/cbd3b51d79b38bfba0aba7f740ba3b0e71538824
https://github.com/FFY00
FFY00 https://github.com/FFY00
Please reload this pagehttps://github.com/python/cpython/pull/128979
Please reload this pagehttps://github.com/python/cpython/pull/128979
https://github.com/picnixz
https://github.com/vstinner
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.