| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:edbe7a6b-b422-8a59-51a7-9e9ca44f8ba3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D418:1148D3:416A23A:534F6F5:6B022C84 |
| html-safe-nonce | 4deb948526256f01df7b0c1c947151e906548858d6f1dbb32f79bf5750bc2017 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDE4OjExNDhEMzo0MTZBMjNBOjUzNEY2RjU6NkIwMjJDODQiLCJ2aXNpdG9yX2lkIjoiNjA4NjAxMzU1MTIyNTQ4MjM3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8abfda51212aa1f33454da1980d53d4387661fb97f0766c03fbe9f914367eddd |
| hovercard-subject-tag | pull_request:2285595859 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/128979/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ba30094816e777a137aed99e0554dcfa916d7add82286814e75e04f7a0ac1660/python/cpython/pull/128979 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ba30094816e777a137aed99e0554dcfa916d7add82286814e75e04f7a0ac1660/python/cpython/pull/128979 |
| og:image:alt | Issue: Leftover code in sysconfig.expand_makefile_vars #128978 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | picnixz |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/cpython/pull/128979#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128979 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128979 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/128979 |
| Reload | https://github.com/python/cpython/pull/128979 |
| Reload | https://github.com/python/cpython/pull/128979 |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| https://github.com/python/cpython |
| picnixz | https://github.com/picnixz |
| python:main | https://github.com/python/cpython/tree/main |
| picnixz:fix/sysconfig/relic-128978 | https://github.com/picnixz/cpython/tree/fix/sysconfig/relic-128978 |
| Conversation | https://github.com/python/cpython/pull/128979 |
| Commits4 (4) | https://github.com/python/cpython/pull/128979/commits |
| Checks | https://github.com/python/cpython/pull/128979/checks |
| Files changed | https://github.com/python/cpython/pull/128979/files |
| gh-128978: Fix a NameError in sysconfig.expand_makefile_vars | https://github.com/python/cpython/pull/128979#top |
| picnixz | https://github.com/picnixz |
| python:main | https://github.com/python/cpython/tree/main |
| picnixz:fix/sysconfig/relic-128978 | https://github.com/picnixz/cpython/tree/fix/sysconfig/relic-128978 |
|
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
| Jan 18, 2025 | https://github.com/python/cpython/pull/128979#issue-2796895240 |
| Please reload this page | https://github.com/python/cpython/pull/128979 |
| Leftover code in sysconfig.expand_makefile_vars #128978 | https://github.com/python/cpython/issues/128978 |
| Please reload this page | https://github.com/python/cpython/pull/128979 |
| picnixz | https://github.com/picnixz |
| January 18, 2025 11:05 | https://github.com/python/cpython/pull/128979#commits-pushed-e604f5d |
|
| https://github.com/picnixz |
| Fix a NameError in sysconfig.expand_makefile_vars. | https://github.com/python/cpython/pull/128979/commits/e604f5d0709a3fda991d7619b6efc634b1442344 |
| e604f5d | https://github.com/python/cpython/pull/128979/commits/e604f5d0709a3fda991d7619b6efc634b1442344 |
|
| https://github.com/picnixz |
| blurb | https://github.com/python/cpython/pull/128979/commits/c6554fe2c36b3c122a8ee8ada6a8e225dc7e19d9 |
| c6554fe | https://github.com/python/cpython/pull/128979/commits/c6554fe2c36b3c122a8ee8ada6a8e225dc7e19d9 |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
| FFY00 | https://github.com/FFY00 |
| code owner | https://github.com/python/cpython/blob/4dade055f4e18a7e91bc70293abb4db745ad16ca/.github/CODEOWNERS#L245 |
| January 18, 2025 10:05 | https://github.com/python/cpython/pull/128979#event-15985504269 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
Jan 18, 2025
| https://github.com/python/cpython/pull/128979#ref-issue-2796894296 |
|
Leftover code in sysconfig.expand_makefile_vars
#128978
| https://github.com/python/cpython/issues/128978 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Jan 18, 2025 | https://github.com/python/cpython/pull/128979#event-15985504483 |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
|
needs backport to 3.13
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22 |
|
needs backport to 3.12
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Jan 18, 2025 | https://github.com/python/cpython/pull/128979#event-15985504508 |
|
| https://github.com/picnixz |
| Merge branch 'main' into fix/sysconfig/relic-128978 | https://github.com/python/cpython/pull/128979/commits/b913882f545ebdfed173c9c4a84cd514c508788b |
| b913882 | https://github.com/python/cpython/pull/128979/commits/b913882f545ebdfed173c9c4a84cd514c508788b |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
| vstinner | https://github.com/vstinner |
| January 20, 2025 12:41 | https://github.com/python/cpython/pull/128979#event-15998360553 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Jan 20, 2025
| https://github.com/python/cpython/pull/128979#pullrequestreview-2562320217 |
|
View reviewed changes
| https://github.com/python/cpython/pull/128979/files/b913882f545ebdfed173c9c4a84cd514c508788b |
| Lib/sysconfig/__init__.py | https://github.com/python/cpython/pull/128979/files/b913882f545ebdfed173c9c4a84cd514c508788b#diff-ff3de3c657b8e6d0d7071b2f0672c8a7b03c45b3176557a99fc39c7bdcb571b9 |
| Please reload this page | https://github.com/python/cpython/pull/128979 |
|
| https://github.com/picnixz |
| use sysconfig.__main__ code instead | https://github.com/python/cpython/pull/128979/commits/cbd3b51d79b38bfba0aba7f740ba3b0e71538824 |
| cbd3b51 | https://github.com/python/cpython/pull/128979/commits/cbd3b51d79b38bfba0aba7f740ba3b0e71538824 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Jan 20, 2025
| https://github.com/python/cpython/pull/128979#pullrequestreview-2562358337 |
|
View reviewed changes
| https://github.com/python/cpython/pull/128979/files/cbd3b51d79b38bfba0aba7f740ba3b0e71538824 |
| vstinner | https://github.com/vstinner |
| https://github.com/python/cpython/pull/128979#pullrequestreview-2562358337 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/128979 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Jan 20, 2025 | https://github.com/python/cpython/pull/128979#event-15998741793 |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
| January 20, 2025 13:24 | https://github.com/python/cpython/pull/128979#event-15998910963 |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
| df66ff1 | https://github.com/python/cpython/commit/df66ff14b49f4388625212f6bc86b754cb51d4eb |
| Jan 20, 2025 | https://github.com/python/cpython/pull/128979#event-15998953478 |
| https://github.com/apps/miss-islington-app |
| miss-islington-app | https://github.com/apps/miss-islington-app |
| Jan 20, 2025 | https://github.com/python/cpython/pull/128979#issuecomment-2602427682 |
| @picnixz | https://github.com/picnixz |
| Please reload this page | https://github.com/python/cpython/pull/128979 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Jan 20, 2025 | https://github.com/python/cpython/pull/128979#event-15998954252 |
| miss-islington | https://github.com/miss-islington |
|
Jan 20, 2025
| https://github.com/python/cpython/pull/128979#ref-commit-9356f95 |
|
| https://github.com/picnixz |
|
| https://github.com/miss-islington |
| pythongh-128978 | https://github.com/python/cpython/issues/128978 |
| : Fix a | https://github.com/miss-islington/cpython/commit/9356f95a265e54b5e4d62c0e6d45da2bb30d6a14 |
| NameError | https://github.com/miss-islington/cpython/commit/9356f95a265e54b5e4d62c0e6d45da2bb30d6a14 |
| in | https://github.com/miss-islington/cpython/commit/9356f95a265e54b5e4d62c0e6d45da2bb30d6a14 |
| sysconfig.expand_makefile_vars | https://github.com/miss-islington/cpython/commit/9356f95a265e54b5e4d62c0e6d45da2bb30d6a14 |
| ( | https://github.com/miss-islington/cpython/commit/9356f95a265e54b5e4d62c0e6d45da2bb30d6a14 |
| 9356f95 | https://github.com/miss-islington/cpython/commit/9356f95a265e54b5e4d62c0e6d45da2bb30d6a14 |
| pythonGH-128979 | https://github.com/python/cpython/pull/128979 |
| 4a53a39 | https://github.com/miss-islington/cpython/commit/4a53a397c311567f05553bc25a28aebaba4f6f65 |
| df66ff1 | https://github.com/miss-islington/cpython/commit/df66ff14b49f4388625212f6bc86b754cb51d4eb |
| miss-islington | https://github.com/miss-islington |
|
Jan 20, 2025
| https://github.com/python/cpython/pull/128979#ref-commit-837e5d2 |
|
| https://github.com/picnixz |
|
| https://github.com/miss-islington |
| pythongh-128978 | https://github.com/python/cpython/issues/128978 |
| : Fix a | https://github.com/miss-islington/cpython/commit/837e5d27fc97903b519f283c08d859a233323836 |
| NameError | https://github.com/miss-islington/cpython/commit/837e5d27fc97903b519f283c08d859a233323836 |
| in | https://github.com/miss-islington/cpython/commit/837e5d27fc97903b519f283c08d859a233323836 |
| sysconfig.expand_makefile_vars | https://github.com/miss-islington/cpython/commit/837e5d27fc97903b519f283c08d859a233323836 |
| ( | https://github.com/miss-islington/cpython/commit/837e5d27fc97903b519f283c08d859a233323836 |
| 837e5d2 | https://github.com/miss-islington/cpython/commit/837e5d27fc97903b519f283c08d859a233323836 |
| pythonGH-128979 | https://github.com/python/cpython/pull/128979 |
| 4a53a39 | https://github.com/miss-islington/cpython/commit/4a53a397c311567f05553bc25a28aebaba4f6f65 |
| df66ff1 | https://github.com/miss-islington/cpython/commit/df66ff14b49f4388625212f6bc86b754cb51d4eb |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
| Jan 20, 2025 | https://github.com/python/cpython/pull/128979#issuecomment-2602428170 |
| GH-129065 | https://github.com/python/cpython/pull/129065 |
| 3.13 branch | https://github.com/python/cpython/tree/3.13 |
| Please reload this page | https://github.com/python/cpython/pull/128979 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
needs backport to 3.13
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22 |
| Jan 20, 2025 | https://github.com/python/cpython/pull/128979#event-15998957807 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
| Jan 20, 2025 | https://github.com/python/cpython/pull/128979#issuecomment-2602428355 |
| GH-129066 | https://github.com/python/cpython/pull/129066 |
| 3.12 branch | https://github.com/python/cpython/tree/3.12 |
| Please reload this page | https://github.com/python/cpython/pull/128979 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
needs backport to 3.12
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22 |
| Jan 20, 2025 | https://github.com/python/cpython/pull/128979#event-15998958978 |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
| January 20, 2025 13:27 | https://github.com/python/cpython/pull/128979#event-15998963327 |
| picnixz | https://github.com/picnixz |
|
Jan 20, 2025
| https://github.com/python/cpython/pull/128979#ref-commit-55d3d81 |
|
| https://github.com/miss-islington |
|
| https://github.com/picnixz |
| [3.13] | https://github.com/python/cpython/commit/55d3d8165c0aa522d90fe92b92ade74beb27d9f9 |
| gh-128978 | https://github.com/python/cpython/issues/128978 |
| : Fix a | https://github.com/python/cpython/commit/55d3d8165c0aa522d90fe92b92ade74beb27d9f9 |
| NameError | https://github.com/python/cpython/commit/55d3d8165c0aa522d90fe92b92ade74beb27d9f9 |
| in `sysconfig.expand_makefile_var… | https://github.com/python/cpython/commit/55d3d8165c0aa522d90fe92b92ade74beb27d9f9 |
| 55d3d81 | https://github.com/python/cpython/commit/55d3d8165c0aa522d90fe92b92ade74beb27d9f9 |
| GH-128979 | https://github.com/python/cpython/pull/128979 |
| #129065 | https://github.com/python/cpython/pull/129065 |
| gh-128978 | https://github.com/python/cpython/issues/128978 |
| GH-128979 | https://github.com/python/cpython/pull/128979 |
| 4a53a39 | https://github.com/python/cpython/commit/4a53a397c311567f05553bc25a28aebaba4f6f65 |
| df66ff1 | https://github.com/python/cpython/commit/df66ff14b49f4388625212f6bc86b754cb51d4eb |
| srinivasreddy | https://github.com/srinivasreddy |
|
Jan 21, 2025
| https://github.com/python/cpython/pull/128979#ref-commit-598cb08 |
|
| https://github.com/picnixz |
|
| https://github.com/srinivasreddy |
| pythongh-128978 | https://github.com/python/cpython/issues/128978 |
| : Fix a | https://github.com/srinivasreddy/cpython/commit/598cb086e2a666cc5af9fbfeec8949bf56839a89 |
| NameError | https://github.com/srinivasreddy/cpython/commit/598cb086e2a666cc5af9fbfeec8949bf56839a89 |
| in | https://github.com/srinivasreddy/cpython/commit/598cb086e2a666cc5af9fbfeec8949bf56839a89 |
| sysconfig.expand_makefile_vars | https://github.com/srinivasreddy/cpython/commit/598cb086e2a666cc5af9fbfeec8949bf56839a89 |
| ( | https://github.com/srinivasreddy/cpython/commit/598cb086e2a666cc5af9fbfeec8949bf56839a89 |
| 598cb08 | https://github.com/srinivasreddy/cpython/commit/598cb086e2a666cc5af9fbfeec8949bf56839a89 |
| python#128979 | https://github.com/python/cpython/pull/128979 |
| 4a53a39 | https://github.com/srinivasreddy/cpython/commit/4a53a397c311567f05553bc25a28aebaba4f6f65 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128979 |
|
| https://github.com/vstinner |
|
vstinner
| https://github.com/vstinner |
|
| https://github.com/python/cpython/pull/128979/files/cbd3b51d79b38bfba0aba7f740ba3b0e71538824 |
|
| https://github.com/FFY00 |
|
FFY00
| https://github.com/FFY00 |
| Please reload this page | https://github.com/python/cpython/pull/128979 |
| Please reload this page | https://github.com/python/cpython/pull/128979 |
|
| https://github.com/picnixz |
|
| https://github.com/vstinner |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |