René's URL Explorer Experiment


Title: gh-58689: Fix os.kill() error handling on Windows by vstinner · Pull Request #128932 · python/cpython · GitHub

Open Graph Title: gh-58689: Fix os.kill() error handling on Windows by vstinner · Pull Request #128932 · python/cpython

X Title: gh-58689: Fix os.kill() error handling on Windows by vstinner · Pull Request #128932 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Issue: missing return in win32_kill? #58689

X Description: Issue: missing return in win32_kill? #58689

Opengraph URL: https://github.com/python/cpython/pull/128932

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f1917fe1-dbf5-782b-6086-9e45ec34d2db
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE03E:2086C7:297C975:38F29EC:6A4EFF36
html-safe-nonce94cb90403da46e0440e2be6f355e6786bdc8dd760630232c2aa4d52dfe3a8dbd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDNFOjIwODZDNzoyOTdDOTc1OjM4RjI5RUM6NkE0RUZGMzYiLCJ2aXNpdG9yX2lkIjoiODc1MzkwMzkxMjQzMDI3MjMxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac89d9d9543d7e33d1f1f1301072af2753db8171ea1aada80704fb287caf219c96
hovercard-subject-tagpull_request:2283955384
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/128932/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ee9c482f84c0347e22cea86e4990b76c7ab77898a50b3072159c7efba9c67a16/python/cpython/pull/128932
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ee9c482f84c0347e22cea86e4990b76c7ab77898a50b3072159c7efba9c67a16/python/cpython/pull/128932
og:image:altIssue: missing return in win32_kill? #58689
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevstinner
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/128932#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128932
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128932
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/128932
Reloadhttps://github.com/python/cpython/pull/128932
Reloadhttps://github.com/python/cpython/pull/128932
Please reload this pagehttps://github.com/python/cpython/pull/128932
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/128932
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:os_kill_errhttps://github.com/vstinner/cpython/tree/os_kill_err
Conversationhttps://github.com/python/cpython/pull/128932
Commits1 (1)https://github.com/python/cpython/pull/128932/commits
Checkshttps://github.com/python/cpython/pull/128932/checks
Files changedhttps://github.com/python/cpython/pull/128932/files
gh-58689: Fix os.kill() error handling on Windowshttps://github.com/python/cpython/pull/128932#top
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:os_kill_errhttps://github.com/vstinner/cpython/tree/os_kill_err
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jan 17, 2025https://github.com/python/cpython/pull/128932#issue-2795076689
Please reload this pagehttps://github.com/python/cpython/pull/128932
missing return in win32_kill? #58689https://github.com/python/cpython/issues/58689
Please reload this pagehttps://github.com/python/cpython/pull/128932
https://github.com/vstinner
pythongh-58689https://github.com/python/cpython/issues/58689
: Fix os.kill() error handling on Windowshttps://github.com/python/cpython/pull/128932/commits/cac70524a1c4d969755f9c36ebcec3986cf1ef5a
cac7052https://github.com/python/cpython/pull/128932/commits/cac70524a1c4d969755f9c36ebcec3986cf1ef5a
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Jan 17, 2025https://github.com/python/cpython/pull/128932#event-15974657127
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jan 17, 2025 https://github.com/python/cpython/pull/128932#ref-issue-1198879771
missing return in win32_kill? #58689 https://github.com/python/cpython/issues/58689
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 17, 2025https://github.com/python/cpython/pull/128932#event-15974658764
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jan 17, 2025https://github.com/python/cpython/pull/128932#issuecomment-2597902528
@pitrouhttps://github.com/pitrou
Please reload this pagehttps://github.com/python/cpython/pull/128932
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jan 17, 2025https://github.com/python/cpython/pull/128932#issuecomment-2597910064
@rruuaannghttps://github.com/rruuaanng
Please reload this pagehttps://github.com/python/cpython/pull/128932
https://github.com/zooba
zoobahttps://github.com/zooba
Jan 17, 2025 https://github.com/python/cpython/pull/128932#pullrequestreview-2558890569
View reviewed changes https://github.com/python/cpython/pull/128932/files/cac70524a1c4d969755f9c36ebcec3986cf1ef5a
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 17, 2025https://github.com/python/cpython/pull/128932#event-15976737542
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
939df0fhttps://github.com/python/cpython/commit/939df0f9f6a76e0916b3ba53841e1413ab90952e
Jan 17, 2025https://github.com/python/cpython/pull/128932#event-15976803795
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
January 17, 2025 12:30https://github.com/python/cpython/pull/128932#event-15976804380
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jan 17, 2025https://github.com/python/cpython/pull/128932#event-15976804683
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Jan 17, 2025https://github.com/python/cpython/pull/128932#issuecomment-2598265048
@vstinnerhttps://github.com/vstinner
Please reload this pagehttps://github.com/python/cpython/pull/128932
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jan 17, 2025https://github.com/python/cpython/pull/128932#issuecomment-2598265260
@zoobahttps://github.com/zooba
Please reload this pagehttps://github.com/python/cpython/pull/128932
miss-islingtonhttps://github.com/miss-islington
Jan 17, 2025 https://github.com/python/cpython/pull/128932#ref-commit-5c4ce41
https://github.com/vstinner
https://github.com/miss-islington
pythongh-58689https://github.com/python/cpython/issues/58689
: Fix os.kill() error handling on Windows (https://github.com/miss-islington/cpython/commit/5c4ce41c83915c17c0296645cd2cf4e73732cbc9
pythonGH-128932https://github.com/python/cpython/pull/128932
5c4ce41https://github.com/miss-islington/cpython/commit/5c4ce41c83915c17c0296645cd2cf4e73732cbc9
https://github.com/python/cpython/pull/128932
939df0fhttps://github.com/miss-islington/cpython/commit/939df0f9f6a76e0916b3ba53841e1413ab90952e
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jan 17, 2025https://github.com/python/cpython/pull/128932#issuecomment-2598265645
GH-128937https://github.com/python/cpython/pull/128937
3.13 branchhttps://github.com/python/cpython/tree/3.13
Please reload this pagehttps://github.com/python/cpython/pull/128932
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Jan 17, 2025https://github.com/python/cpython/pull/128932#event-15976808753
miss-islingtonhttps://github.com/miss-islington
Jan 17, 2025 https://github.com/python/cpython/pull/128932#ref-commit-299cba4
https://github.com/vstinner
https://github.com/miss-islington
pythongh-58689https://github.com/python/cpython/issues/58689
: Fix os.kill() error handling on Windows (https://github.com/miss-islington/cpython/commit/299cba4c42b3497642f1394e59dbd64a4ec7b815
pythonGH-128932https://github.com/python/cpython/pull/128932
299cba4https://github.com/miss-islington/cpython/commit/299cba4c42b3497642f1394e59dbd64a4ec7b815
https://github.com/python/cpython/pull/128932
939df0fhttps://github.com/miss-islington/cpython/commit/939df0f9f6a76e0916b3ba53841e1413ab90952e
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jan 17, 2025https://github.com/python/cpython/pull/128932#issuecomment-2598265834
GH-128938https://github.com/python/cpython/pull/128938
3.12 branchhttps://github.com/python/cpython/tree/3.12
Please reload this pagehttps://github.com/python/cpython/pull/128932
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Jan 17, 2025https://github.com/python/cpython/pull/128932#event-15976810246
vstinnerhttps://github.com/vstinner
Jan 17, 2025 https://github.com/python/cpython/pull/128932#ref-commit-dfd75df
https://github.com/miss-islington
https://github.com/vstinner
[3.12]https://github.com/python/cpython/commit/dfd75dfeed60144978ed0e33978242b95276f056
gh-58689https://github.com/python/cpython/issues/58689
: Fix os.kill() error handling on Windows (https://github.com/python/cpython/commit/dfd75dfeed60144978ed0e33978242b95276f056
GH-128932https://github.com/python/cpython/pull/128932
) (https://github.com/python/cpython/commit/dfd75dfeed60144978ed0e33978242b95276f056
#…https://github.com/python/cpython/pull/128938
dfd75dfhttps://github.com/python/cpython/commit/dfd75dfeed60144978ed0e33978242b95276f056
…128938https://github.com/python/cpython/pull/128938
gh-58689https://github.com/python/cpython/issues/58689
GH-128932https://github.com/python/cpython/pull/128932
939df0fhttps://github.com/python/cpython/commit/939df0f9f6a76e0916b3ba53841e1413ab90952e
vstinnerhttps://github.com/vstinner
Jan 17, 2025 https://github.com/python/cpython/pull/128932#ref-commit-d997ba4
https://github.com/miss-islington
https://github.com/vstinner
[3.13]https://github.com/python/cpython/commit/d997ba45ed9155279bd91752ffb4be8b8ce69dd6
gh-58689https://github.com/python/cpython/issues/58689
: Fix os.kill() error handling on Windows (https://github.com/python/cpython/commit/d997ba45ed9155279bd91752ffb4be8b8ce69dd6
GH-128932https://github.com/python/cpython/pull/128932
) (https://github.com/python/cpython/commit/d997ba45ed9155279bd91752ffb4be8b8ce69dd6
#…https://github.com/python/cpython/pull/128937
d997ba4https://github.com/python/cpython/commit/d997ba45ed9155279bd91752ffb4be8b8ce69dd6
…128937https://github.com/python/cpython/pull/128937
gh-58689https://github.com/python/cpython/issues/58689
GH-128932https://github.com/python/cpython/pull/128932
939df0fhttps://github.com/python/cpython/commit/939df0f9f6a76e0916b3ba53841e1413ab90952e
https://github.com/rruuaanng
rruuaannghttps://github.com/rruuaanng
Jan 17, 2025https://github.com/python/cpython/pull/128932#issuecomment-2598371289
@vstinnerhttps://github.com/vstinner
Please reload this pagehttps://github.com/python/cpython/pull/128932
srinivasreddyhttps://github.com/srinivasreddy
Jan 21, 2025 https://github.com/python/cpython/pull/128932#ref-commit-5c4cbf1
https://github.com/vstinner
https://github.com/srinivasreddy
pythongh-58689https://github.com/python/cpython/issues/58689
: Fix os.kill() error handling on Windows (https://github.com/srinivasreddy/cpython/commit/5c4cbf1add2b4e5353051de7d37d68a6749771a1
python#128932https://github.com/python/cpython/pull/128932
)https://github.com/srinivasreddy/cpython/commit/5c4cbf1add2b4e5353051de7d37d68a6749771a1
5c4cbf1https://github.com/srinivasreddy/cpython/commit/5c4cbf1add2b4e5353051de7d37d68a6749771a1
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128932
https://github.com/zooba
zooba https://github.com/zooba
https://github.com/python/cpython/pull/128932/files/cac70524a1c4d969755f9c36ebcec3986cf1ef5a
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/128932
https://github.com/vstinner
https://github.com/rruuaanng
https://github.com/zooba
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.