René's URL Explorer Experiment


Title: gh-128770: fix ResourceWarning in test_pyrepl by graingert · Pull Request #128906 · python/cpython · GitHub

Open Graph Title: gh-128770: fix ResourceWarning in test_pyrepl by graingert · Pull Request #128906 · python/cpython

X Title: gh-128770: fix ResourceWarning in test_pyrepl by graingert · Pull Request #128906 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Issue: configure warnings as errors in the test suite #128770

X Description: Issue: configure warnings as errors in the test suite #128770

Opengraph URL: https://github.com/python/cpython/pull/128906

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8338cc0a-323f-6d5c-cd3c-06c0a90cc6de
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC1A:1A6FEB:D9E996:12D66D3:6A53AFF2
html-safe-noncef65a75e8b93baba4497ed491d5e5b21e37985e8e99aa8553e31a170616803184
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzFBOjFBNkZFQjpEOUU5OTY6MTJENjZEMzo2QTUzQUZGMiIsInZpc2l0b3JfaWQiOiIzMjc3OTgxNjk3MDczOTgzNDc0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca1bc7591b8baee20097a9e1ab62c679c737b3ca1988483b02d3ee0fd8f6c095b
hovercard-subject-tagpull_request:2281084911
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/128906/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/74375fbb7df6396e5f71890703442cf7c50f8c39d40ab0986f406b686b734c06/python/cpython/pull/128906
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/74375fbb7df6396e5f71890703442cf7c50f8c39d40ab0986f406b686b734c06/python/cpython/pull/128906
og:image:altIssue: configure warnings as errors in the test suite #128770
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegraingert
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/128906#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128906
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128906
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/128906
Reloadhttps://github.com/python/cpython/pull/128906
Reloadhttps://github.com/python/cpython/pull/128906
Please reload this pagehttps://github.com/python/cpython/pull/128906
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/128906
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
graingert:fix-resource-warning-in-test-pyreplhttps://github.com/graingert/cpython/tree/fix-resource-warning-in-test-pyrepl
Conversationhttps://github.com/python/cpython/pull/128906
Commits1 (1)https://github.com/python/cpython/pull/128906/commits
Checkshttps://github.com/python/cpython/pull/128906/checks
Files changedhttps://github.com/python/cpython/pull/128906/files
gh-128770: fix ResourceWarning in test_pyreplhttps://github.com/python/cpython/pull/128906#top
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
graingert:fix-resource-warning-in-test-pyreplhttps://github.com/graingert/cpython/tree/fix-resource-warning-in-test-pyrepl
https://github.com/graingert
graingerthttps://github.com/graingert
Jan 16, 2025https://github.com/python/cpython/pull/128906#issue-2791913636
Please reload this pagehttps://github.com/python/cpython/pull/128906
configure warnings as errors in the test suite #128770https://github.com/python/cpython/issues/128770
Please reload this pagehttps://github.com/python/cpython/pull/128906
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jan 16, 2025 https://github.com/python/cpython/pull/128906#ref-issue-1916822318
test_socket generates several warnings #110012 https://github.com/python/cpython/issues/110012
https://github.com/graingert
fix ResourceWarning in test_pyreplhttps://github.com/python/cpython/pull/128906/commits/ca5eb671d8d5075c659033310b075063f0e51b30
ca5eb67https://github.com/python/cpython/pull/128906/commits/ca5eb671d8d5075c659033310b075063f0e51b30
https://github.com/graingert
graingerthttps://github.com/graingert
force-pushedhttps://github.com/python/cpython/compare/4536f9ced37408e373e6a1378631e8bf73ca7a09..ca5eb671d8d5075c659033310b075063f0e51b30
4536f9chttps://github.com/python/cpython/commit/4536f9ced37408e373e6a1378631e8bf73ca7a09
ca5eb67https://github.com/python/cpython/commit/ca5eb671d8d5075c659033310b075063f0e51b30
Compare https://github.com/python/cpython/compare/4536f9ced37408e373e6a1378631e8bf73ca7a09..ca5eb671d8d5075c659033310b075063f0e51b30
January 16, 2025 07:31https://github.com/python/cpython/pull/128906#event-15952818330
https://github.com/graingert
graingerthttps://github.com/graingert
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Jan 16, 2025https://github.com/python/cpython/pull/128906#event-15952820469
https://github.com/graingert
graingerthttps://github.com/graingert
Jan 16, 2025https://github.com/python/cpython/pull/128906#event-15952828904
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jan 16, 2025 https://github.com/python/cpython/pull/128906#ref-issue-2783265878
configure warnings as errors in the test suite #128770 https://github.com/python/cpython/issues/128770
https://github.com/graingert
graingerthttps://github.com/graingert
January 16, 2025 07:58https://github.com/python/cpython/pull/128906#event-15953083558
https://github.com/graingert
graingerthttps://github.com/graingert
ambvhttps://github.com/ambv
lysnikolaouhttps://github.com/lysnikolaou
pablogsalhttps://github.com/pablogsal
code ownershttps://github.com/python/cpython/blob/d05140f9f77d7dfc753dd1e5ac3a5962aaa03eff/.github/CODEOWNERS#L53
January 16, 2025 07:58https://github.com/python/cpython/pull/128906#event-15953083638
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jan 16, 2025https://github.com/python/cpython/pull/128906#event-15953084026
https://github.com/graingert
graingerthttps://github.com/graingert
Jan 16, 2025 https://github.com/python/cpython/pull/128906#ref-pullrequest-2781730034
gh-128770: raise warnings as errors in test suite - except for test_socket which still logs warnings #128726 https://github.com/python/cpython/pull/128726
https://github.com/graingert
graingerthttps://github.com/graingert
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Jan 16, 2025https://github.com/python/cpython/pull/128906#event-15953101214
https://github.com/hugovk
hugovkhttps://github.com/hugovk
Jan 16, 2025 https://github.com/python/cpython/pull/128906#pullrequestreview-2555061120
View reviewed changes https://github.com/python/cpython/pull/128906/files/ca5eb671d8d5075c659033310b075063f0e51b30
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jan 16, 2025https://github.com/python/cpython/pull/128906#event-15953146437
https://github.com/graingert
graingerthttps://github.com/graingert
hugovkhttps://github.com/hugovk
January 17, 2025 09:58https://github.com/python/cpython/pull/128906#event-15974432351
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Jan 22, 2025 https://github.com/python/cpython/pull/128906#pullrequestreview-2567116163
View reviewed changes https://github.com/python/cpython/pull/128906/files/ca5eb671d8d5075c659033310b075063f0e51b30
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
24c84d8https://github.com/python/cpython/commit/24c84d816f2f2ecb76b80328c3f1d8c05ead0b10
Jan 22, 2025https://github.com/python/cpython/pull/128906#event-16028570381
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Jan 22, 2025https://github.com/python/cpython/pull/128906#issuecomment-2607162113
@graingerthttps://github.com/graingert
@pablogsalhttps://github.com/pablogsal
Please reload this pagehttps://github.com/python/cpython/pull/128906
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jan 22, 2025https://github.com/python/cpython/pull/128906#event-16028571070
miss-islingtonhttps://github.com/miss-islington
Jan 22, 2025 https://github.com/python/cpython/pull/128906#ref-commit-79bba48
https://github.com/graingert
https://github.com/miss-islington
pythongh-128770https://github.com/python/cpython/issues/128770
: fix ResourceWarning in test_pyrepl (https://github.com/miss-islington/cpython/commit/79bba4809be3519972c8bd31137aaf7dd39c048b
pythonGH-128906https://github.com/python/cpython/pull/128906
)https://github.com/miss-islington/cpython/commit/79bba4809be3519972c8bd31137aaf7dd39c048b
79bba48https://github.com/miss-islington/cpython/commit/79bba4809be3519972c8bd31137aaf7dd39c048b
24c84d8https://github.com/miss-islington/cpython/commit/24c84d816f2f2ecb76b80328c3f1d8c05ead0b10
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Jan 22, 2025https://github.com/python/cpython/pull/128906#issuecomment-2607162491
@graingerthttps://github.com/graingert
@pablogsalhttps://github.com/pablogsal
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/128906
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jan 22, 2025https://github.com/python/cpython/pull/128906#issuecomment-2607162532
GH-129179https://github.com/python/cpython/pull/129179
3.13 branchhttps://github.com/python/cpython/tree/3.13
Please reload this pagehttps://github.com/python/cpython/pull/128906
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
pablogsalhttps://github.com/pablogsal
Jan 22, 2025https://github.com/python/cpython/pull/128906#event-16028573223
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Jan 22, 2025https://github.com/python/cpython/pull/128906#event-16028573362
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Jan 22, 2025https://github.com/python/cpython/pull/128906#issuecomment-2607164020
Please reload this pagehttps://github.com/python/cpython/pull/128906
https://github.com/graingert
graingerthttps://github.com/graingert
January 22, 2025 12:50https://github.com/python/cpython/pull/128906#event-16028592815
https://github.com/graingert
graingerthttps://github.com/graingert
Jan 22, 2025https://github.com/python/cpython/pull/128906#issuecomment-2607165936
Please reload this pagehttps://github.com/python/cpython/pull/128906
https://github.com/hugovk
hugovkhttps://github.com/hugovk
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Jan 22, 2025https://github.com/python/cpython/pull/128906#event-16028734304
pablogsalhttps://github.com/pablogsal
Jan 22, 2025 https://github.com/python/cpython/pull/128906#ref-commit-67971cd
https://github.com/miss-islington
[3.13]https://github.com/python/cpython/commit/67971cd605246ce4390cd56218aa4ae3366cb54e
gh-128770https://github.com/python/cpython/issues/128770
: fix ResourceWarning in test_pyrepl (https://github.com/python/cpython/commit/67971cd605246ce4390cd56218aa4ae3366cb54e
GH-128906https://github.com/python/cpython/pull/128906
) (https://github.com/python/cpython/commit/67971cd605246ce4390cd56218aa4ae3366cb54e
#12…https://github.com/python/cpython/pull/129179
67971cdhttps://github.com/python/cpython/commit/67971cd605246ce4390cd56218aa4ae3366cb54e
…9179https://github.com/python/cpython/pull/129179
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128906
https://github.com/pablogsal
pablogsal https://github.com/pablogsal
https://github.com/python/cpython/pull/128906/files/ca5eb671d8d5075c659033310b075063f0e51b30
https://github.com/lysnikolaou
lysnikolaou https://github.com/lysnikolaou
https://github.com/ambv
ambv https://github.com/ambv
https://github.com/hugovk
hugovk https://github.com/hugovk
https://github.com/pablogsal
pablogsal https://github.com/pablogsal
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/128906
https://github.com/graingert
https://github.com/pablogsal
https://github.com/hugovk
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.