René's URL Explorer Experiment


Title: [3.13] gh-128679: Fix tracemalloc.stop() race conditions by vstinner · Pull Request #128897 · python/cpython · GitHub

Open Graph Title: [3.13] gh-128679: Fix tracemalloc.stop() race conditions by vstinner · Pull Request #128897 · python/cpython

X Title: [3.13] gh-128679: Fix tracemalloc.stop() race conditions by vstinner · Pull Request #128897 · python/cpython

Description: tracemalloc_alloc(), tracemalloc_realloc(), PyTraceMalloc_Track(), PyTraceMalloc_Untrack() and _PyTraceMalloc_TraceRef() now check tracemalloc_config.tracing after calling TABLES_LOCK(). _PyTraceMalloc_Stop() now protects more code with TABLES_LOCK(), especially setting tracemalloc_config.tracing to 1. Add a test using PyTraceMalloc_Track() to test tracemalloc.stop() race condition. Issue: gh-128679

Open Graph Description: tracemalloc_alloc(), tracemalloc_realloc(), PyTraceMalloc_Track(), PyTraceMalloc_Untrack() and _PyTraceMalloc_TraceRef() now check tracemalloc_config.tracing after calling TABLES_LOCK(). _PyTraceMa...

X Description: tracemalloc_alloc(), tracemalloc_realloc(), PyTraceMalloc_Track(), PyTraceMalloc_Untrack() and _PyTraceMalloc_TraceRef() now check tracemalloc_config.tracing after calling TABLES_LOCK(). _PyTraceMa...

Opengraph URL: https://github.com/python/cpython/pull/128897

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:40756605-c157-31c9-c399-b6c9a2ef2ceb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCBE6:6365:3745224:49AF33A:6B02163C
html-safe-noncecda7ba8b2b29d2dcfda41197b381c5dbb60341324f4a532f482e5d709ec34738
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQkU2OjYzNjU6Mzc0NTIyNDo0OUFGMzNBOjZCMDIxNjNDIiwidmlzaXRvcl9pZCI6Ijg4Njk5MDIyNjc4OTExMTM1NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac000adcf7ebf87334f54e1cc259bb90fd6799bf52c3caf591ea5edcc3c1d2a80f
hovercard-subject-tagpull_request:2280204499
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/128897/files
twitter:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
og:image:alttracemalloc_alloc(), tracemalloc_realloc(), PyTraceMalloc_Track(), PyTraceMalloc_Untrack() and _PyTraceMalloc_TraceRef() now check tracemalloc_config.tracing after calling TABLES_LOCK(). _PyTraceMa...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/128897/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128897%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128897%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/128897/files
Reloadhttps://github.com/python/cpython/pull/128897/files
Reloadhttps://github.com/python/cpython/pull/128897/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:3.13https://github.com/python/cpython/tree/3.13
vstinner:tracemalloc_stop13https://github.com/vstinner/cpython/tree/tracemalloc_stop13
Conversation 22 https://github.com/python/cpython/pull/128897
Commits 6 https://github.com/python/cpython/pull/128897/commits
Checks 0 https://github.com/python/cpython/pull/128897/checks
Files changed https://github.com/python/cpython/pull/128897/files
Please reload this pagehttps://github.com/python/cpython/pull/128897/files
[3.13] gh-128679: Fix tracemalloc.stop() race conditions https://github.com/python/cpython/pull/128897/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/128897/files
545053f gh-128679: Fix tracemalloc.stop() race conditions vstinner Jan 15, 2025 https://github.com/python/cpython/pull/128897/commits/545053f43e39c82f1cd8ed9f04cdeba9b1142aa2
be6f0e2 Fix the race condition in more functions vstinner Jan 16, 2025 https://github.com/python/cpython/pull/128897/commits/be6f0e27236f1b5942d07e04e303ca6b6ebf7172
ef1718b Lock also in _PyTraceMalloc_IsTracing() vstinner Jan 16, 2025 https://github.com/python/cpython/pull/128897/commits/ef1718b0ed70089e3933be586bcfbf549649e19f
99d27fe _PyTraceMalloc_Start(): lock before reading tracing vstinner Jan 16, 2025 https://github.com/python/cpython/pull/128897/commits/99d27fe54e727d4ed684e023eb5c1450c10aea90
54c8f9e Call _PyTraceMalloc_Init() at Python startup vstinner Jan 16, 2025 https://github.com/python/cpython/pull/128897/commits/54c8f9e679d28c27b53ed2f50714ac72e912975f
aa85a70 gh-128679: Skip test_tracemalloc_track_race() on debug build (#128988) vstinner Jan 18, 2025 https://github.com/python/cpython/pull/128897/commits/aa85a7059c79f866326669f11648a4cc539578c1
Clear filters https://github.com/python/cpython/pull/128897/files
Please reload this pagehttps://github.com/python/cpython/pull/128897/files
Please reload this pagehttps://github.com/python/cpython/pull/128897/files
pycore_tracemalloc.h https://github.com/python/cpython/pull/128897/files#diff-1dcb95883ba8c854435490b39f36ac943b7262637b9867dc16b9d804e0ded5fa
test_tracemalloc.py https://github.com/python/cpython/pull/128897/files#diff-a524f4d355d64e7e33ce0a48a10acc4877bd2748c8f123b692e4204f162c220a
2025-01-10-15-43-52.gh-issue-128679.KcfVVR.rst https://github.com/python/cpython/pull/128897/files#diff-7cf171fdd0e983a30b19cec014be323834acebbc4a554f3d9f8ad6ac8b03616e
_testcapimodule.c https://github.com/python/cpython/pull/128897/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
_tracemalloc.c https://github.com/python/cpython/pull/128897/files#diff-e3c46632586859324a8cb7de0a3d6c60fcba118b5a0a262640102530ceca3a2a
pylifecycle.c https://github.com/python/cpython/pull/128897/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
tracemalloc.c https://github.com/python/cpython/pull/128897/files#diff-8c15a6d7bef47a331a3ded43da887ac1fb4c53d2374067e0c0ffe1dc32cf9450
Include/internal/pycore_tracemalloc.hhttps://github.com/python/cpython/pull/128897/files#diff-1dcb95883ba8c854435490b39f36ac943b7262637b9867dc16b9d804e0ded5fa
View file https://github.com/vstinner/cpython/blob/aa85a7059c79f866326669f11648a4cc539578c1/Include/internal/pycore_tracemalloc.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128897/{{ revealButtonHref }}
https://github.com/python/cpython/pull/128897/files#diff-1dcb95883ba8c854435490b39f36ac943b7262637b9867dc16b9d804e0ded5fa
https://github.com/python/cpython/pull/128897/files#diff-1dcb95883ba8c854435490b39f36ac943b7262637b9867dc16b9d804e0ded5fa
Lib/test/test_tracemalloc.pyhttps://github.com/python/cpython/pull/128897/files#diff-a524f4d355d64e7e33ce0a48a10acc4877bd2748c8f123b692e4204f162c220a
View file https://github.com/vstinner/cpython/blob/aa85a7059c79f866326669f11648a4cc539578c1/Lib/test/test_tracemalloc.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128897/{{ revealButtonHref }}
https://github.com/python/cpython/pull/128897/files#diff-a524f4d355d64e7e33ce0a48a10acc4877bd2748c8f123b692e4204f162c220a
https://github.com/python/cpython/pull/128897/files#diff-a524f4d355d64e7e33ce0a48a10acc4877bd2748c8f123b692e4204f162c220a
https://github.com/python/cpython/pull/128897/files#diff-a524f4d355d64e7e33ce0a48a10acc4877bd2748c8f123b692e4204f162c220a
https://github.com/python/cpython/pull/128897/files#diff-a524f4d355d64e7e33ce0a48a10acc4877bd2748c8f123b692e4204f162c220a
https://github.com/python/cpython/pull/128897/files#diff-a524f4d355d64e7e33ce0a48a10acc4877bd2748c8f123b692e4204f162c220a
Misc/NEWS.d/next/Library/2025-01-10-15-43-52.gh-issue-128679.KcfVVR.rsthttps://github.com/python/cpython/pull/128897/files#diff-7cf171fdd0e983a30b19cec014be323834acebbc4a554f3d9f8ad6ac8b03616e
View file https://github.com/vstinner/cpython/blob/aa85a7059c79f866326669f11648a4cc539578c1/Misc/NEWS.d/next/Library/2025-01-10-15-43-52.gh-issue-128679.KcfVVR.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128897/{{ revealButtonHref }}
Modules/_testcapimodule.chttps://github.com/python/cpython/pull/128897/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
View file https://github.com/vstinner/cpython/blob/aa85a7059c79f866326669f11648a4cc539578c1/Modules/_testcapimodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128897/{{ revealButtonHref }}
https://github.com/python/cpython/pull/128897/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
https://github.com/python/cpython/pull/128897/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
https://github.com/python/cpython/pull/128897/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
https://github.com/python/cpython/pull/128897/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
Modules/_tracemalloc.chttps://github.com/python/cpython/pull/128897/files#diff-e3c46632586859324a8cb7de0a3d6c60fcba118b5a0a262640102530ceca3a2a
View file https://github.com/vstinner/cpython/blob/aa85a7059c79f866326669f11648a4cc539578c1/Modules/_tracemalloc.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128897/{{ revealButtonHref }}
https://github.com/python/cpython/pull/128897/files#diff-e3c46632586859324a8cb7de0a3d6c60fcba118b5a0a262640102530ceca3a2a
https://github.com/python/cpython/blob/3.13/.github/CODEOWNERS#L56
Python/pylifecycle.chttps://github.com/python/cpython/pull/128897/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
View file https://github.com/vstinner/cpython/blob/aa85a7059c79f866326669f11648a4cc539578c1/Python/pylifecycle.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128897/{{ revealButtonHref }}
https://github.com/python/cpython/pull/128897/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
https://github.com/python/cpython/pull/128897/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
Please reload this pagehttps://github.com/python/cpython/pull/128897/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.