René's URL Explorer Experiment


Title: gh-128690: temporarily do not use test_embed in PGO profile builds by ned-deily · Pull Request #128771 · python/cpython · GitHub

Open Graph Title: gh-128690: temporarily do not use test_embed in PGO profile builds by ned-deily · Pull Request #128771 · python/cpython

X Title: gh-128690: temporarily do not use test_embed in PGO profile builds by ned-deily · Pull Request #128771 · python/cpython

Description: As documented in #128690, under certain configurations test case test_init_pyvenv_cfg of test_embed fails apparently since 34e840f. This behavior was not seen in 3.14.0a3, the most recent alpha before this change. Unfortunately, test_embed is included in the subset of tests used for PGO profile builds when Python is built with --enable-optimizations. If any of the tests included in the PGO profile build fails, including test_embed, the whole Python build fails. Besides the originally reported case, I have now seen this failure in two other macOS build configurations, both rather complex; one is for the build of the python.org installer package. (At the moment, I haven't had time to produce a manageable reproducible test case.) It could be that this is just an existing test case issue that was brought to the fore by the above change. Since the failure involves sys._base_executable, it's possible that the behavior documented in #128670 might be the root cause. If necessary for 3.14.0a4, I could apply this PR manually to avoid using test_embed in the profile builds. But I would prefer to either have the test failure resolved prior to a4 or merge this PR to temporarily avoid using test_embed. Marking as release-blocker for release manager decision. cc: @hugovk @FFY00 Issue: gh-128690

Open Graph Description: As documented in #128690, under certain configurations test case test_init_pyvenv_cfg of test_embed fails apparently since 34e840f. This behavior was not seen in 3.14.0a3, the most recent alpha bef...

X Description: As documented in #128690, under certain configurations test case test_init_pyvenv_cfg of test_embed fails apparently since 34e840f. This behavior was not seen in 3.14.0a3, the most recent alpha bef...

Opengraph URL: https://github.com/python/cpython/pull/128771

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e8dade10-bf3d-66cf-387a-0885430af3da
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE89E:13DDC4:A2B23D6:E486328:6A50DCB5
html-safe-nonce499ba04deaa5e0c0d4a9c3b4d55d832dba59d73b99617cbdcfd06ad37515de7f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODlFOjEzRERDNDpBMkIyM0Q2OkU0ODYzMjg6NkE1MERDQjUiLCJ2aXNpdG9yX2lkIjoiNzYwNzA1MzAzNDg1ODc5ODI2MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8cc6d71e9b29e32b7e19e96ee5d0750fd2c0ac3efc34cd7df65063029cb76cab
hovercard-subject-tagpull_request:2273238957
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/128771/files
twitter:imagehttps://avatars.githubusercontent.com/u/5833005?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5833005?s=400&v=4
og:image:altAs documented in #128690, under certain configurations test case test_init_pyvenv_cfg of test_embed fails apparently since 34e840f. This behavior was not seen in 3.14.0a3, the most recent alpha bef...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None72b13e0e8d0319acdd27a145cfe73f4f06c791713d0ac4690e41fb68ad28cac0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release17290b65caabb92b271e0949d1bf147b63deab41
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/128771/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128771%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128771%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/128771/files
Reloadhttps://github.com/python/cpython/pull/128771/files
Reloadhttps://github.com/python/cpython/pull/128771/files
Please reload this pagehttps://github.com/python/cpython/pull/128771/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/128771/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ned-deilyhttps://github.com/ned-deily
python:mainhttps://github.com/python/cpython/tree/main
ned-deily:gh-128690-test_embed-pgohttps://github.com/ned-deily/cpython/tree/gh-128690-test_embed-pgo
Conversation 1 https://github.com/python/cpython/pull/128771
Commits 1 https://github.com/python/cpython/pull/128771/commits
Checks 0 https://github.com/python/cpython/pull/128771/checks
Files changed https://github.com/python/cpython/pull/128771/files
Please reload this pagehttps://github.com/python/cpython/pull/128771/files
gh-128690: temporarily do not use test_embed in PGO profile builds https://github.com/python/cpython/pull/128771/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/128771/files
34ab420 gh-128690: temporarily do not use test_embed in PGO profile builds ned-deily Jan 13, 2025 https://github.com/python/cpython/pull/128771/commits/34ab42071f4893dd559fd111054d07a83afefa5a
Clear filters https://github.com/python/cpython/pull/128771/files
Please reload this pagehttps://github.com/python/cpython/pull/128771/files
Please reload this pagehttps://github.com/python/cpython/pull/128771/files
pgo.py https://github.com/python/cpython/pull/128771/files#diff-fc08d02347d3ba59b6caf7adae3f39f5e96d2c26d62baaa66209fe3bcef37e3b
2025-01-13-01-29-08.gh-issue-128690.cPFVDb.rst https://github.com/python/cpython/pull/128771/files#diff-ba1b5fdd39427ec1ac02156e323669d2cbbeaaa6cf8f40b87187bc34eaa6d318
Lib/test/libregrtest/pgo.pyhttps://github.com/python/cpython/pull/128771/files#diff-fc08d02347d3ba59b6caf7adae3f39f5e96d2c26d62baaa66209fe3bcef37e3b
View file https://github.com/ned-deily/cpython/blob/34ab42071f4893dd559fd111054d07a83afefa5a/Lib/test/libregrtest/pgo.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128771/{{ revealButtonHref }}
https://github.com/python/cpython/pull/128771/files#diff-fc08d02347d3ba59b6caf7adae3f39f5e96d2c26d62baaa66209fe3bcef37e3b
https://github.com/python/cpython/pull/128771/files#diff-fc08d02347d3ba59b6caf7adae3f39f5e96d2c26d62baaa66209fe3bcef37e3b
Misc/NEWS.d/next/Tests/2025-01-13-01-29-08.gh-issue-128690.cPFVDb.rsthttps://github.com/python/cpython/pull/128771/files#diff-ba1b5fdd39427ec1ac02156e323669d2cbbeaaa6cf8f40b87187bc34eaa6d318
View file https://github.com/ned-deily/cpython/blob/34ab42071f4893dd559fd111054d07a83afefa5a/Misc/NEWS.d/next/Tests/2025-01-13-01-29-08.gh-issue-128690.cPFVDb.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128771/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.