| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b0df50c3-b9ff-b886-4bdc-8184166ccf6a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AA8E:2E90F6:1F27AA:2CCAF2:6A549344 |
| html-safe-nonce | 6f8921a9833313b09bef28dd50dfa575f43f17acd75ae22f8de311a62aa8fe21 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQThFOjJFOTBGNjoxRjI3QUE6MkNDQUYyOjZBNTQ5MzQ0IiwidmlzaXRvcl9pZCI6IjUzNTg4MDk2MDAxMjM3Njk2NjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5113dafc6b5f1b3e48e38f26c0bf2cb5b5420d5a91424e5162f7cc0fc2a2ddec |
| hovercard-subject-tag | pull_request:2271904693 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/128726/files |
| twitter:image | https://avatars.githubusercontent.com/u/413772?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/413772?s=400&v=4 |
| og:image:alt | Issue: gh-128770 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f8cfff6384f62259baea531c7f58bc7040f8dd92 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/128726/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128726%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128726%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/128726/files |
| Reload | https://github.com/python/cpython/pull/128726/files |
| Reload | https://github.com/python/cpython/pull/128726/files |
| Please reload this page | https://github.com/python/cpython/pull/128726/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/128726/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
35k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| hugovk | https://github.com/hugovk |
| python:main | https://github.com/python/cpython/tree/main |
| graingert:run-test-suite-with-warnings-as-error | https://github.com/graingert/cpython/tree/run-test-suite-with-warnings-as-error |
|
Conversation
16
| https://github.com/python/cpython/pull/128726 |
|
Commits
21
| https://github.com/python/cpython/pull/128726/commits |
|
Checks
0
| https://github.com/python/cpython/pull/128726/checks |
|
Files changed
| https://github.com/python/cpython/pull/128726/files |
| Please reload this page | https://github.com/python/cpython/pull/128726/files |
|
gh-128770: raise warnings as errors in test suite - except for test_socket which still logs warnings
| https://github.com/python/cpython/pull/128726/files#top |
|
Show all changes
21 commits
| https://github.com/python/cpython/pull/128726/files |
|
0d28ddd
gh-110012: Fix `RuntimeWarning` in `test_socket`
sobolevn Sep 28, 2023
| https://github.com/python/cpython/pull/128726/commits/0d28dddbf82f5b4603cae7d6bdb426ff64aad8b4 |
|
da358cc
Typos!
sobolevn Sep 28, 2023
| https://github.com/python/cpython/pull/128726/commits/da358cc5d2a78715bc21563ef4487fc336ad8ae9 |
|
cf0cfd0
Typos!
sobolevn Sep 28, 2023
| https://github.com/python/cpython/pull/128726/commits/cf0cfd052691703a2311d6242b6bbdea0f156935 |
|
dfda254
Use `quiet=True` by default
sobolevn Sep 28, 2023
| https://github.com/python/cpython/pull/128726/commits/dfda2548a56ed73cb78ac076fcdf52f28e456afd |
|
ec6a368
fix warnings in test_importlib.test_abc
graingert Jan 16, 2025
| https://github.com/python/cpython/pull/128726/commits/ec6a368c717fe9649fef0a8d4a0091c5eb5a6802 |
|
a5c2b7a
fix warnings found in test_importlib.test_windows
graingert Jan 16, 2025
| https://github.com/python/cpython/pull/128726/commits/a5c2b7a9553596a50b8d2f2839242c7cac612a96 |
|
0f2afcd
set warnings as errors everywhere
graingert Jan 11, 2025
| https://github.com/python/cpython/pull/128726/commits/0f2afcdf4db078f97c2d1014890812df4b23f0f9 |
|
8e97f04
Merge branch 'main' into issue110012
graingert Jan 16, 2025
| https://github.com/python/cpython/pull/128726/commits/8e97f04a301076aeaef59953f0bf03372155d3b1 |
|
4982ba4
Merge branch 'issue110012' into run-test-suite-with-warnings-as-error
graingert Jan 16, 2025
| https://github.com/python/cpython/pull/128726/commits/4982ba4cbd946a4a5588e0fbf78725341d80c7bd |
|
f45b3b8
Update test_socket.py
graingert Jan 16, 2025
| https://github.com/python/cpython/pull/128726/commits/f45b3b89fdfc1e7c8fd24261efb1568bbfa54d47 |
|
0bc4c2a
Merge branch 'issue110012' into run-test-suite-with-warnings-as-error
graingert Jan 16, 2025
| https://github.com/python/cpython/pull/128726/commits/0bc4c2a398aa2ecfcbc11140267ffc6e5ce90ddb |
|
ca5eb67
fix ResourceWarning in test_pyrepl
graingert Jan 16, 2025
| https://github.com/python/cpython/pull/128726/commits/ca5eb671d8d5075c659033310b075063f0e51b30 |
|
a13e948
Merge branch 'fix-resource-warning-in-test-pyrepl' into run-test-suit…
graingert Jan 16, 2025
| https://github.com/python/cpython/pull/128726/commits/a13e9480bf5c519444048557c5c739cf1e54f92f |
|
7b2b437
downgrade rather than ignore malformed socket warning
graingert Jan 16, 2025
| https://github.com/python/cpython/pull/128726/commits/7b2b43717214f13a334bbc9d4108fb2791c5d2d7 |
|
f2cb9b4
Merge branch 'main' into run-test-suite-with-warnings-as-error
graingert Jan 16, 2025
| https://github.com/python/cpython/pull/128726/commits/f2cb9b47411ed84a4fdb95186ead211adf7b4448 |
|
32cd095
Update Lib/test/test_socket.py
graingert Jan 16, 2025
| https://github.com/python/cpython/pull/128726/commits/32cd095faf1847846fbaead53c3608765f9fffc9 |
|
db0cb51
Update Lib/test/test_socket.py
graingert Jan 16, 2025
| https://github.com/python/cpython/pull/128726/commits/db0cb51533f90468722155ffa9703b66153f16aa |
|
61eb61f
Update Lib/test/test_socket.py
graingert Jan 16, 2025
| https://github.com/python/cpython/pull/128726/commits/61eb61f419cb863c570e28d8963491a70fe6247b |
|
91ee5ee
oops, it's not pytest
graingert Jan 16, 2025
| https://github.com/python/cpython/pull/128726/commits/91ee5ee998d265c4dd0b6d230fbd0fab3c5e9a0b |
|
720cca0
Merge branch 'main' into run-test-suite-with-warnings-as-error
brettcannon Jan 16, 2025
| https://github.com/python/cpython/pull/128726/commits/720cca0307a93cb5f7893d21b229cdf0fd5ce404 |
|
23469c3
Merge branch 'main' into run-test-suite-with-warnings-as-error
graingert Jan 17, 2025
| https://github.com/python/cpython/pull/128726/commits/23469c3989424f2e6943d3d35a926d8fd79f7e7c |
|
Clear filters
| https://github.com/python/cpython/pull/128726/files |
| Please reload this page | https://github.com/python/cpython/pull/128726/files |
| Please reload this page | https://github.com/python/cpython/pull/128726/files |
|
main.py
| https://github.com/python/cpython/pull/128726/files#diff-90b1258926545f5c3c67e7de0cb5f50dc293b41c7a075a3eb316df99f3b875d5 |
|
test_pyrepl.py
| https://github.com/python/cpython/pull/128726/files#diff-527def17e95277d68de9ccbef2358e5b89aba5407163ff8d0777936bb3f3bfab |
|
test_socket.py
| https://github.com/python/cpython/pull/128726/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389 |
| Lib/test/libregrtest/main.py | https://github.com/python/cpython/pull/128726/files#diff-90b1258926545f5c3c67e7de0cb5f50dc293b41c7a075a3eb316df99f3b875d5 |
|
View file
| https://github.com/graingert/cpython/blob/23469c3989424f2e6943d3d35a926d8fd79f7e7c/Lib/test/libregrtest/main.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/128726/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/128726/files#diff-90b1258926545f5c3c67e7de0cb5f50dc293b41c7a075a3eb316df99f3b875d5 |
|
| https://github.com/python/cpython/pull/128726/files#diff-90b1258926545f5c3c67e7de0cb5f50dc293b41c7a075a3eb316df99f3b875d5 |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L562 |
| Lib/test/test_pyrepl/test_pyrepl.py | https://github.com/python/cpython/pull/128726/files#diff-527def17e95277d68de9ccbef2358e5b89aba5407163ff8d0777936bb3f3bfab |
|
View file
| https://github.com/graingert/cpython/blob/23469c3989424f2e6943d3d35a926d8fd79f7e7c/Lib/test/test_pyrepl/test_pyrepl.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/128726/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/128726/files#diff-527def17e95277d68de9ccbef2358e5b89aba5407163ff8d0777936bb3f3bfab |
|
| https://github.com/python/cpython/pull/128726/files#diff-527def17e95277d68de9ccbef2358e5b89aba5407163ff8d0777936bb3f3bfab |
| Lib/test/test_socket.py | https://github.com/python/cpython/pull/128726/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389 |
|
View file
| https://github.com/graingert/cpython/blob/23469c3989424f2e6943d3d35a926d8fd79f7e7c/Lib/test/test_socket.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/128726/{{ revealButtonHref }} |
| Please reload this page | https://github.com/python/cpython/pull/128726/files |
|
| https://github.com/python/cpython/pull/128726/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389 |
|
| https://github.com/python/cpython/pull/128726/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389 |
|
| https://github.com/python/cpython/pull/128726/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389 |
|
| https://github.com/python/cpython/pull/128726/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389 |
|
| https://github.com/python/cpython/pull/128726/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389 |
|
| https://github.com/python/cpython/pull/128726/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389 |
|
| https://github.com/python/cpython/pull/128726/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389 |
|
| https://github.com/python/cpython/pull/128726/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389 |
|
| https://github.com/python/cpython/pull/128726/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |