René's URL Explorer Experiment


Title: gh-128679: Fix tracemalloc.stop() race condition by vstinner · Pull Request #128710 · python/cpython · GitHub

Open Graph Title: gh-128679: Fix tracemalloc.stop() race condition by vstinner · Pull Request #128710 · python/cpython

X Title: gh-128679: Fix tracemalloc.stop() race condition by vstinner · Pull Request #128710 · python/cpython

Description: Check again 'tracemalloc_config.tracing' once the GIL is held in tracemalloc_raw_alloc() and PyTraceMalloc_Track(), since another thread can call tracemalloc.stop() during PyGILState_Ensure() call. Issue: gh-128679

Open Graph Description: Check again 'tracemalloc_config.tracing' once the GIL is held in tracemalloc_raw_alloc() and PyTraceMalloc_Track(), since another thread can call tracemalloc.stop() during PyGILState_Ensure...

X Description: Check again 'tracemalloc_config.tracing' once the GIL is held in tracemalloc_raw_alloc() and PyTraceMalloc_Track(), since another thread can call tracemalloc.stop() during PyGILStat...

Opengraph URL: https://github.com/python/cpython/pull/128710

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5d8e8f2b-f3bd-4941-1f47-367330a2934e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF8A:2AF0D8:6B03C8:85D22A:6B020A48
html-safe-nonce0386948651e89fc54df815b6d19a7b80bcd8c012b09acf278012005607b58b51
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjhBOjJBRjBEODo2QjAzQzg6ODVEMjJBOjZCMDIwQTQ4IiwidmlzaXRvcl9pZCI6IjU3NjE1NDY2MjYxOTE3MjMwODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac82e32802d5c3b2a237baf998231362bf6d8266a72b493433830642cd92d3476d
hovercard-subject-tagpull_request:2270647335
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/128710/files
twitter:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
og:image:altCheck again 'tracemalloc_config.tracing' once the GIL is held in tracemalloc_raw_alloc() and PyTraceMalloc_Track(), since another thread can call tracemalloc.stop() during PyGILState_Ensure...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/128710/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128710%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128710%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/128710/files
Reloadhttps://github.com/python/cpython/pull/128710/files
Reloadhttps://github.com/python/cpython/pull/128710/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:tracemallochttps://github.com/vstinner/cpython/tree/tracemalloc
Conversation 25 https://github.com/python/cpython/pull/128710
Commits 11 https://github.com/python/cpython/pull/128710/commits
Checks 0 https://github.com/python/cpython/pull/128710/checks
Files changed https://github.com/python/cpython/pull/128710/files
Please reload this pagehttps://github.com/python/cpython/pull/128710/files
gh-128679: Fix tracemalloc.stop() race condition https://github.com/python/cpython/pull/128710/files#top
Show all changes 11 commits https://github.com/python/cpython/pull/128710/files
8f58d77 gh-128679: Fix tracemalloc.stop() race condition vstinner Jan 10, 2025 https://github.com/python/cpython/pull/128710/commits/8f58d77bc462a86048fd73dbe4f65d52028c426f
1e3eac3 Define 'res' in PyTraceMalloc_Track() vstinner Jan 10, 2025 https://github.com/python/cpython/pull/128710/commits/1e3eac33065787d38c64ae8ab378fcae4e103a5b
59fd8de Fix the race condition in the PyMem_RawFree() hook vstinner Jan 13, 2025 https://github.com/python/cpython/pull/128710/commits/59fd8de85c86df81d319c265400a760d2bfc8213
0e6de65 Add test vstinner Jan 13, 2025 https://github.com/python/cpython/pull/128710/commits/0e6de65784dfd29945570aacd6aac056f16cd1cf
48e172d Fix test on Windows vstinner Jan 13, 2025 https://github.com/python/cpython/pull/128710/commits/48e172d76fdb4f9231d1781a8791ba2ed648547d
146167b Fix refleak on error vstinner Jan 13, 2025 https://github.com/python/cpython/pull/128710/commits/146167b0ff92adec3444eb2a072b9393529ba23a
aceff9b test: add #include vstinner Jan 13, 2025 https://github.com/python/cpython/pull/128710/commits/aceff9bd0b99339e87ba9964439264754624adeb
61edb4c Skip test on WASI vstinner Jan 13, 2025 https://github.com/python/cpython/pull/128710/commits/61edb4cfa18500d37633df66bfe61ec973786917
9df058a Rewrite the test without sleep vstinner Jan 14, 2025 https://github.com/python/cpython/pull/128710/commits/9df058a7c945c99eff1a16286f70348cef4d9849
ecfa30b revert unwanted change vstinner Jan 14, 2025 https://github.com/python/cpython/pull/128710/commits/ecfa30b96716e3fa0ed8930d17d76a1bc7f7224b
997148b Fix refleak in the test vstinner Jan 15, 2025 https://github.com/python/cpython/pull/128710/commits/997148b227281d5e40b3f7c98c9f0c8b4cb9c98b
Clear filters https://github.com/python/cpython/pull/128710/files
Please reload this pagehttps://github.com/python/cpython/pull/128710/files
Please reload this pagehttps://github.com/python/cpython/pull/128710/files
test_tracemalloc.py https://github.com/python/cpython/pull/128710/files#diff-a524f4d355d64e7e33ce0a48a10acc4877bd2748c8f123b692e4204f162c220a
2025-01-10-15-43-52.gh-issue-128679.KcfVVR.rst https://github.com/python/cpython/pull/128710/files#diff-7cf171fdd0e983a30b19cec014be323834acebbc4a554f3d9f8ad6ac8b03616e
_testcapimodule.c https://github.com/python/cpython/pull/128710/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
tracemalloc.c https://github.com/python/cpython/pull/128710/files#diff-8c15a6d7bef47a331a3ded43da887ac1fb4c53d2374067e0c0ffe1dc32cf9450
Lib/test/test_tracemalloc.pyhttps://github.com/python/cpython/pull/128710/files#diff-a524f4d355d64e7e33ce0a48a10acc4877bd2748c8f123b692e4204f162c220a
View file https://github.com/vstinner/cpython/blob/997148b227281d5e40b3f7c98c9f0c8b4cb9c98b/Lib/test/test_tracemalloc.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128710/{{ revealButtonHref }}
https://github.com/python/cpython/pull/128710/files#diff-a524f4d355d64e7e33ce0a48a10acc4877bd2748c8f123b692e4204f162c220a
https://github.com/python/cpython/pull/128710/files#diff-a524f4d355d64e7e33ce0a48a10acc4877bd2748c8f123b692e4204f162c220a
https://github.com/python/cpython/pull/128710/files#diff-a524f4d355d64e7e33ce0a48a10acc4877bd2748c8f123b692e4204f162c220a
https://github.com/python/cpython/pull/128710/files#diff-a524f4d355d64e7e33ce0a48a10acc4877bd2748c8f123b692e4204f162c220a
https://github.com/python/cpython/pull/128710/files#diff-a524f4d355d64e7e33ce0a48a10acc4877bd2748c8f123b692e4204f162c220a
Misc/NEWS.d/next/Library/2025-01-10-15-43-52.gh-issue-128679.KcfVVR.rsthttps://github.com/python/cpython/pull/128710/files#diff-7cf171fdd0e983a30b19cec014be323834acebbc4a554f3d9f8ad6ac8b03616e
View file https://github.com/vstinner/cpython/blob/997148b227281d5e40b3f7c98c9f0c8b4cb9c98b/Misc/NEWS.d/next/Library/2025-01-10-15-43-52.gh-issue-128679.KcfVVR.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128710/{{ revealButtonHref }}
Modules/_testcapimodule.chttps://github.com/python/cpython/pull/128710/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
View file https://github.com/vstinner/cpython/blob/997148b227281d5e40b3f7c98c9f0c8b4cb9c98b/Modules/_testcapimodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128710/{{ revealButtonHref }}
https://github.com/python/cpython/pull/128710/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
ZeroIntensityhttps://github.com/ZeroIntensity
Jan 14, 2025https://github.com/python/cpython/pull/128710/files#r1915537059
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/128710/files
Please reload this pagehttps://github.com/python/cpython/pull/128710/files
https://github.com/python/cpython/pull/128710/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
https://github.com/python/cpython/pull/128710/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
https://github.com/python/cpython/pull/128710/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
Python/tracemalloc.chttps://github.com/python/cpython/pull/128710/files#diff-8c15a6d7bef47a331a3ded43da887ac1fb4c53d2374067e0c0ffe1dc32cf9450
View file https://github.com/vstinner/cpython/blob/997148b227281d5e40b3f7c98c9f0c8b4cb9c98b/Python/tracemalloc.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128710/{{ revealButtonHref }}
https://github.com/python/cpython/pull/128710/files#diff-8c15a6d7bef47a331a3ded43da887ac1fb4c53d2374067e0c0ffe1dc32cf9450
ZeroIntensityhttps://github.com/ZeroIntensity
Jan 14, 2025https://github.com/python/cpython/pull/128710/files#r1915543006
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/128710/files
https://github.com/python/cpython/pull/128710/files#diff-8c15a6d7bef47a331a3ded43da887ac1fb4c53d2374067e0c0ffe1dc32cf9450
https://github.com/python/cpython/pull/128710/files#diff-8c15a6d7bef47a331a3ded43da887ac1fb4c53d2374067e0c0ffe1dc32cf9450
https://github.com/python/cpython/pull/128710/files#diff-8c15a6d7bef47a331a3ded43da887ac1fb4c53d2374067e0c0ffe1dc32cf9450
https://github.com/python/cpython/pull/128710/files#diff-8c15a6d7bef47a331a3ded43da887ac1fb4c53d2374067e0c0ffe1dc32cf9450
https://github.com/python/cpython/pull/128710/files#diff-8c15a6d7bef47a331a3ded43da887ac1fb4c53d2374067e0c0ffe1dc32cf9450
https://github.com/python/cpython/pull/128710/files#diff-8c15a6d7bef47a331a3ded43da887ac1fb4c53d2374067e0c0ffe1dc32cf9450
https://github.com/python/cpython/pull/128710/files#diff-8c15a6d7bef47a331a3ded43da887ac1fb4c53d2374067e0c0ffe1dc32cf9450
https://github.com/python/cpython/pull/128710/files#diff-8c15a6d7bef47a331a3ded43da887ac1fb4c53d2374067e0c0ffe1dc32cf9450
ZeroIntensityhttps://github.com/ZeroIntensity
Jan 14, 2025https://github.com/python/cpython/pull/128710/files#r1915552689
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/128710/files
vstinnerhttps://github.com/vstinner
Jan 15, 2025https://github.com/python/cpython/pull/128710/files#r1916050271
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/128710/files
ZeroIntensityhttps://github.com/ZeroIntensity
Jan 15, 2025https://github.com/python/cpython/pull/128710/files#r1916655913
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#128710 (comment)https://github.com/python/cpython/pull/128710#issuecomment-2592865609
Please reload this pagehttps://github.com/python/cpython/pull/128710/files
https://github.com/python/cpython/pull/128710/files#diff-8c15a6d7bef47a331a3ded43da887ac1fb4c53d2374067e0c0ffe1dc32cf9450
https://github.com/python/cpython/pull/128710/files#diff-8c15a6d7bef47a331a3ded43da887ac1fb4c53d2374067e0c0ffe1dc32cf9450
https://github.com/python/cpython/pull/128710/files#diff-8c15a6d7bef47a331a3ded43da887ac1fb4c53d2374067e0c0ffe1dc32cf9450
ZeroIntensityhttps://github.com/ZeroIntensity
Jan 15, 2025https://github.com/python/cpython/pull/128710/files#r1917250883
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/128710/files
vstinnerhttps://github.com/vstinner
Jan 15, 2025https://github.com/python/cpython/pull/128710/files#r1917359107
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#128897https://github.com/python/cpython/pull/128897
Please reload this pagehttps://github.com/python/cpython/pull/128710/files
https://github.com/python/cpython/pull/128710/files#diff-8c15a6d7bef47a331a3ded43da887ac1fb4c53d2374067e0c0ffe1dc32cf9450
https://github.com/python/cpython/pull/128710/files#diff-8c15a6d7bef47a331a3ded43da887ac1fb4c53d2374067e0c0ffe1dc32cf9450
https://github.com/python/cpython/pull/128710/files#diff-8c15a6d7bef47a331a3ded43da887ac1fb4c53d2374067e0c0ffe1dc32cf9450
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.