René's URL Explorer Experiment


Title: gh-128636: Fix crash in PyREPL when `os.environ` is overwritten with an invalid value by tomasr8 · Pull Request #128653 · python/cpython · GitHub

Open Graph Title: gh-128636: Fix crash in PyREPL when `os.environ` is overwritten with an invalid value by tomasr8 · Pull Request #128653 · python/cpython

X Title: gh-128636: Fix crash in PyREPL when `os.environ` is overwritten with an invalid value by tomasr8 · Pull Request #128653 · python/cpython

Description: This fixes the crash by catching TypeError and ValueError in addition to KeyError. I'm not sure if this the best fix, but it's the least invasive one. Feedback welcome! Issue: gh-128636

Open Graph Description: This fixes the crash by catching TypeError and ValueError in addition to KeyError. I'm not sure if this the best fix, but it's the least invasive one. Feedback welcome! Issue: gh-128636

X Description: This fixes the crash by catching TypeError and ValueError in addition to KeyError. I'm not sure if this the best fix, but it's the least invasive one. Feedback welcome! Issue: gh-128636

Opengraph URL: https://github.com/python/cpython/pull/128653

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7debf566-1fe7-f660-c518-f6613716cfcf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE02C:360707:976335:DDD291:6A54AFC2
html-safe-nonce9f00eb14eb46470f71633cc947a47e07431032b348e0ed3ce05547670434e584
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDJDOjM2MDcwNzo5NzYzMzU6REREMjkxOjZBNTRBRkMyIiwidmlzaXRvcl9pZCI6IjY4ODcyODQ4MTQ2MTkzODk4OTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2a40843258c0ca21ac26b93c7d305d78db6218068ad4d143d3f18fe43b47a179
hovercard-subject-tagpull_request:2267109312
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/128653/files
twitter:imagehttps://avatars.githubusercontent.com/u/8739637?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8739637?s=400&v=4
og:image:altThis fixes the crash by catching TypeError and ValueError in addition to KeyError. I'm not sure if this the best fix, but it's the least invasive one. Feedback welcome! Issue: gh-128636
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef8cfff6384f62259baea531c7f58bc7040f8dd92
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/128653/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128653%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128653%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/128653/files
Reloadhttps://github.com/python/cpython/pull/128653/files
Reloadhttps://github.com/python/cpython/pull/128653/files
Please reload this pagehttps://github.com/python/cpython/pull/128653/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/128653/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
tomasr8:pyrepl-environhttps://github.com/tomasr8/cpython/tree/pyrepl-environ
Conversation 5 https://github.com/python/cpython/pull/128653
Commits 4 https://github.com/python/cpython/pull/128653/commits
Checks 0 https://github.com/python/cpython/pull/128653/checks
Files changed https://github.com/python/cpython/pull/128653/files
Please reload this pagehttps://github.com/python/cpython/pull/128653/files
gh-128636: Fix crash in PyREPL when os.environ is overwritten with an invalid value https://github.com/python/cpython/pull/128653/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/128653/files
b9582da Fix PyREPL failure when os.environ is overwritten tomasr8 Jan 8, 2025 https://github.com/python/cpython/pull/128653/commits/b9582dab762e7257cd61664cdf456fe8880fd708
48ae6c2 Add news entry tomasr8 Jan 8, 2025 https://github.com/python/cpython/pull/128653/commits/48ae6c2aa0e9f27ba192bb592c42983011a861da
df63da0 ioctl can raise OSError tomasr8 Jan 9, 2025 https://github.com/python/cpython/pull/128653/commits/df63da0c7ecc6be979ceb743f22d8470c808e3f4
ef7e598 Merge branch 'main' into pyrepl-environ tomasr8 Jan 22, 2025 https://github.com/python/cpython/pull/128653/commits/ef7e5987c494dedf12cdcc7855ddd87be8c68d06
Clear filters https://github.com/python/cpython/pull/128653/files
Please reload this pagehttps://github.com/python/cpython/pull/128653/files
Please reload this pagehttps://github.com/python/cpython/pull/128653/files
unix_console.py https://github.com/python/cpython/pull/128653/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
test_unix_console.py https://github.com/python/cpython/pull/128653/files#diff-bd56b95d174a8939e71984be3453d3a41315d3fdab37649a87f5c79703f9d304
2025-01-08-22-30-38.gh-issue-128636.jQfWXj.rst https://github.com/python/cpython/pull/128653/files#diff-f29f4dd20a3c8433bae83e0f9a5dfc418397822f1c9cd7eb8fe5127c4f16d674
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L561
Lib/_pyrepl/unix_console.pyhttps://github.com/python/cpython/pull/128653/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
View file https://github.com/tomasr8/cpython/blob/ef7e5987c494dedf12cdcc7855ddd87be8c68d06/Lib/_pyrepl/unix_console.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128653/{{ revealButtonHref }}
https://github.com/python/cpython/pull/128653/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
https://github.com/python/cpython/pull/128653/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
https://github.com/python/cpython/pull/128653/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L562
Lib/test/test_pyrepl/test_unix_console.pyhttps://github.com/python/cpython/pull/128653/files#diff-bd56b95d174a8939e71984be3453d3a41315d3fdab37649a87f5c79703f9d304
View file https://github.com/tomasr8/cpython/blob/ef7e5987c494dedf12cdcc7855ddd87be8c68d06/Lib/test/test_pyrepl/test_unix_console.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128653/{{ revealButtonHref }}
https://github.com/python/cpython/pull/128653/files#diff-bd56b95d174a8939e71984be3453d3a41315d3fdab37649a87f5c79703f9d304
https://github.com/python/cpython/pull/128653/files#diff-bd56b95d174a8939e71984be3453d3a41315d3fdab37649a87f5c79703f9d304
Misc/NEWS.d/next/Library/2025-01-08-22-30-38.gh-issue-128636.jQfWXj.rsthttps://github.com/python/cpython/pull/128653/files#diff-f29f4dd20a3c8433bae83e0f9a5dfc418397822f1c9cd7eb8fe5127c4f16d674
View file https://github.com/tomasr8/cpython/blob/ef7e5987c494dedf12cdcc7855ddd87be8c68d06/Misc/NEWS.d/next/Library/2025-01-08-22-30-38.gh-issue-128636.jQfWXj.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128653/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.