René's URL Explorer Experiment


Title: [3.12] gh-128588: gh-128550: gh-128552: fix refcycles in eager task creation (#128553) and remove eager tasks optimization that missed and introduced incorrect cancellations (python#129063) by graingert · Pull Request #128586 · python/cpython · GitHub

Open Graph Title: [3.12] gh-128588: gh-128550: gh-128552: fix refcycles in eager task creation (#128553) and remove eager tasks optimization that missed and introduced incorrect cancellations (python#129063) by graingert · Pull Request #128586 · python/cpython

X Title: [3.12] gh-128588: gh-128550: gh-128552: fix refcycles in eager task creation (#128553) and remove eager tasks optimization that missed and introduced incorrect cancellations (python#129063) by graingert · Pull Request #128586 · python/cpython

Description: (cherry picked from commit 61b9811) Issue: TaskGroup's task's exception's participate in a reference cycle, via TaskGroup.create_task -> task -> exception and loop.create_task -> task -> excepti...

Open Graph Description: (cherry picked from commit 61b9811) Issue: TaskGroup's task's exception's participate in a reference cycle, via TaskGroup.create_task -> task -> exception and loop.create_task ...

X Description: (cherry picked from commit 61b9811) Issue: TaskGroup's task's exception's participate in a reference cycle, via TaskGroup.create_task -> task -> exception a...

Opengraph URL: https://github.com/python/cpython/pull/128586

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:08e6f7df-4a58-c0a3-d2d2-baaf86032a75
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB40C:309720:144447E:1BFE968:696AA365
html-safe-noncef42586b9b93e35a35546f54229f92cf117735d9f21d81fa695836b02d46c02e3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDBDOjMwOTcyMDoxNDQ0NDdFOjFCRkU5Njg6Njk2QUEzNjUiLCJ2aXNpdG9yX2lkIjoiMzc5NjgzMDMwNjU0NjkwMTQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacef1c8de85937253b3c3812ecd7a986e84202b22e4acd2da75cd36c721c0f3860
hovercard-subject-tagpull_request:2263781921
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/128586/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/af1b0084fe3e4b294d740dfd97a379dc80569aeb910a044df155c167505ce375/python/cpython/pull/128586
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/af1b0084fe3e4b294d740dfd97a379dc80569aeb910a044df155c167505ce375/python/cpython/pull/128586
og:image:alt(cherry picked from commit 61b9811) Issue: TaskGroup's task's exception's participate in a reference cycle, via TaskGroup.create_task -> task -> exception and loop.create_task ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegraingert
hostnamegithub.com
expected-hostnamegithub.com
Nonea51f97dbb9326f71c08ecb61577457d543c602124d1a2672871258ef37ac5261
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4bd0eac606c70914085176ef312ebdcd97a8cdf1
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/128586#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128586
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128586
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/128586
Reloadhttps://github.com/python/cpython/pull/128586
Reloadhttps://github.com/python/cpython/pull/128586
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/128586
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/128586
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/128586#issue-comment-box
kumaraditya303https://github.com/kumaraditya303
python:3.12https://github.com/python/cpython/tree/3.12
graingert:backport-61b9811-3.12https://github.com/graingert/cpython/tree/backport-61b9811-3.12
[3.12] gh-128588: gh-128550: gh-128552: fix refcycles in eager task creation (#128553) and remove eager tasks optimization that missed and introduced incorrect cancellations (python#129063) https://github.com/python/cpython/pull/128586#top
kumaraditya303https://github.com/kumaraditya303
python:3.12https://github.com/python/cpython/tree/3.12
graingert:backport-61b9811-3.12https://github.com/graingert/cpython/tree/backport-61b9811-3.12
Conversation 2 https://github.com/python/cpython/pull/128586
Commits 6 https://github.com/python/cpython/pull/128586/commits
Checks 27 https://github.com/python/cpython/pull/128586/checks
Files changed https://github.com/python/cpython/pull/128586/files
Please reload this pagehttps://github.com/python/cpython/pull/128586
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/graingert
graingerthttps://github.com/graingert
Jan 7, 2025https://github.com/python/cpython/pull/128586#issue-2772714353
Please reload this pagehttps://github.com/python/cpython/pull/128586
61b9811https://github.com/python/cpython/commit/61b9811ac6843e22b5896ef96030d421b79cd892
TaskGroup's task's exception's participate in a reference cycle, via TaskGroup.create_task -> task -> exception and loop.create_task -> task -> exception #128552https://github.com/python/cpython/issues/128552
TaskGroup fails to cancel tasks pending creation, if that task starts a failing task #128550https://github.com/python/cpython/issues/128550
Cancellation leaks out of asyncio.TaskGroup on 3.12 when using eager tasks #128588https://github.com/python/cpython/issues/128588
Please reload this pagehttps://github.com/python/cpython/pull/128586
https://github.com/graingert
pythongh-128552https://github.com/python/cpython/issues/128552
: fix refcycles in eager task creation (https://github.com/python/cpython/pull/128586/commits/5f624a0bcb308fd700f8e774e8216e18638b40f8
python#128553https://github.com/python/cpython/pull/128553
)https://github.com/python/cpython/pull/128586/commits/5f624a0bcb308fd700f8e774e8216e18638b40f8
5f624a0https://github.com/python/cpython/pull/128586/commits/5f624a0bcb308fd700f8e774e8216e18638b40f8
61b9811https://github.com/graingert/cpython/commit/61b9811ac6843e22b5896ef96030d421b79cd892
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jan 7, 2025 https://github.com/python/cpython/pull/128586#ref-issue-2771186544
TaskGroup's task's exception's participate in a reference cycle, via TaskGroup.create_task -> task -> exception and loop.create_task -> task -> exception #128552 https://github.com/python/cpython/issues/128552
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
topic-asyncio https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-asyncio
Jan 7, 2025https://github.com/python/cpython/pull/128586#event-15838177578
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jan 7, 2025 https://github.com/python/cpython/pull/128586#ref-pullrequest-2771192162
gh-128552: fix refcycles in eager task creation #128553 https://github.com/python/cpython/pull/128553
https://github.com/graingert
graingerthttps://github.com/graingert
Jan 7, 2025 https://github.com/python/cpython/pull/128586#pullrequestreview-2534206918
View reviewed changes https://github.com/python/cpython/pull/128586/files/5f624a0bcb308fd700f8e774e8216e18638b40f8
Lib/test/test_asyncio/test_taskgroups.pyhttps://github.com/python/cpython/pull/128586/files/5f624a0bcb308fd700f8e774e8216e18638b40f8#diff-6f3f42fe6cdf1387de256a705e9f0d4c809ba04a2da04c317c9c79cfc4c5bc69
Please reload this pagehttps://github.com/python/cpython/pull/128586
graingerthttps://github.com/graingert
January 7, 2025 12:24https://github.com/python/cpython/pull/128586#commits-pushed-9df724e
https://github.com/graingert
Update Lib/test/test_asyncio/test_taskgroups.pyhttps://github.com/python/cpython/pull/128586/commits/9df724eea736d2117961444573a2c10912eb1073
9df724ehttps://github.com/python/cpython/pull/128586/commits/9df724eea736d2117961444573a2c10912eb1073
https://github.com/graingert
remove tests only valid in 3.13https://github.com/python/cpython/pull/128586/commits/e92aed11b27aa66e7cf348ee6dc2780a22b82737
e92aed1https://github.com/python/cpython/pull/128586/commits/e92aed11b27aa66e7cf348ee6dc2780a22b82737
https://github.com/graingert
graingerthttps://github.com/graingert
Jan 7, 2025 https://github.com/python/cpython/pull/128586#pullrequestreview-2534216508
View reviewed changes https://github.com/python/cpython/pull/128586/files/e92aed11b27aa66e7cf348ee6dc2780a22b82737
Lib/test/test_asyncio/test_taskgroups.pyhttps://github.com/python/cpython/pull/128586/files/e92aed11b27aa66e7cf348ee6dc2780a22b82737#diff-6f3f42fe6cdf1387de256a705e9f0d4c809ba04a2da04c317c9c79cfc4c5bc69
Please reload this pagehttps://github.com/python/cpython/pull/128586
graingerthttps://github.com/graingert
January 20, 2025 12:44https://github.com/python/cpython/pull/128586#commits-pushed-2246cfa
https://github.com/graingert
Merge branch '3.12' into backport-61b9811-3.12https://github.com/python/cpython/pull/128586/commits/2246cfac9efdf1f9f74503f370b2cfdbf97217ca
2246cfahttps://github.com/python/cpython/pull/128586/commits/2246cfac9efdf1f9f74503f370b2cfdbf97217ca
https://github.com/graingert
Merge branch '3.12' into backport-61b9811-3.12https://github.com/python/cpython/pull/128586/commits/958bb1ce6f008e3b29a61362642f1e6483bc3ce8
958bb1chttps://github.com/python/cpython/pull/128586/commits/958bb1ce6f008e3b29a61362642f1e6483bc3ce8
https://github.com/graingert
https://github.com/kumaraditya303
pythongh-128588https://github.com/python/cpython/issues/128588
:https://github.com/python/cpython/pull/128586/commits/59aff22c2666a0d75d8dc05e56774763c698ca08
pythongh-128550https://github.com/python/cpython/issues/128550
: remove eager tasks optimization tha…https://github.com/python/cpython/pull/128586/commits/59aff22c2666a0d75d8dc05e56774763c698ca08
59aff22https://github.com/python/cpython/pull/128586/commits/59aff22c2666a0d75d8dc05e56774763c698ca08
python#129063https://github.com/python/cpython/pull/129063
https://github.com/graingert
graingerthttps://github.com/graingert
Jan 20, 2025https://github.com/python/cpython/pull/128586#event-16003114245
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jan 20, 2025 https://github.com/python/cpython/pull/128586#ref-issue-2772905335
Cancellation leaks out of asyncio.TaskGroup on 3.12 when using eager tasks #128588 https://github.com/python/cpython/issues/128588
https://github.com/graingert
graingerthttps://github.com/graingert
January 20, 2025 18:02https://github.com/python/cpython/pull/128586#event-16003133709
https://github.com/graingert
graingerthttps://github.com/graingert
1st1https://github.com/1st1
asvetlovhttps://github.com/asvetlov
gvanrossumhttps://github.com/gvanrossum
kumaraditya303https://github.com/kumaraditya303
willingchttps://github.com/willingc
code ownershttps://github.com/python/cpython/blob/e6cb31a098a5036519fe270b4d73b2b0e8e774ba/.github/CODEOWNERS#L18
January 20, 2025 18:02https://github.com/python/cpython/pull/128586#event-16003133779
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jan 20, 2025https://github.com/python/cpython/pull/128586#event-16003134182
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Jan 21, 2025 https://github.com/python/cpython/pull/128586#pullrequestreview-2563521455
View reviewed changes https://github.com/python/cpython/pull/128586/files/59aff22c2666a0d75d8dc05e56774763c698ca08
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jan 21, 2025https://github.com/python/cpython/pull/128586#event-16008325376
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
bc21454https://github.com/python/cpython/commit/bc214545f9f6b0288330dd8afe0a33a280406df5
Jan 21, 2025https://github.com/python/cpython/pull/128586#event-16008331365
Please reload this pagehttps://github.com/python/cpython/pull/128586
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jan 21, 2025https://github.com/python/cpython/pull/128586#event-16008331773
https://github.com/graingert
graingerthttps://github.com/graingert
January 21, 2025 05:41https://github.com/python/cpython/pull/128586#event-16008331992
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128586
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
https://github.com/python/cpython/pull/128586/files/59aff22c2666a0d75d8dc05e56774763c698ca08
https://github.com/1st1
1st1 https://github.com/1st1
https://github.com/asvetlov
asvetlov https://github.com/asvetlov
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/willingc
willingc https://github.com/willingc
topic-asyncio https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-asyncio
Please reload this pagehttps://github.com/python/cpython/pull/128586
https://github.com/graingert
https://github.com/kumaraditya303
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.