René's URL Explorer Experiment


Title: gh-128595: Default to stdout isatty for colour detection instead of stderr by hugovk · Pull Request #128498 · python/cpython · GitHub

Open Graph Title: gh-128595: Default to stdout isatty for colour detection instead of stderr by hugovk · Pull Request #128498 · python/cpython

X Title: gh-128595: Default to stdout isatty for colour detection instead of stderr by hugovk · Pull Request #128498 · python/cpython

Description: As suggested at #128317 (comment), default to checking stdout's isatty rather than stderr's. Also using the @force_not_colorized_test_class decorator from #127877 to run some tests without worrying about colour. BeforeAfter Issue: gh-128595

Open Graph Description: As suggested at #128317 (comment), default to checking stdout's isatty rather than stderr's. Also using the @force_not_colorized_test_class decorator from #127877 to run some tests without ...

X Description: As suggested at #128317 (comment), default to checking stdout's isatty rather than stderr's. Also using the @force_not_colorized_test_class decorator from #127877 to run some tests ...

Opengraph URL: https://github.com/python/cpython/pull/128498

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:25f9f5d2-ac99-3cfd-7c53-17ddae332cea
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8D96:155AC0:98ECC9:D393DA:6A513278
html-safe-nonce521b460d4829f3f31e2b3c2fe0cb2c83d2ed3527ad7e46c4869436d88d971bdd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDk2OjE1NUFDMDo5OEVDQzk6RDM5M0RBOjZBNTEzMjc4IiwidmlzaXRvcl9pZCI6Ijc0NzkwOTg4ODk1OTQ4MTEwMDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac80f58ba2329a7cf75846b14d67e3af3bd8329fdddc1d85a072ebe4accd12dff5
hovercard-subject-tagpull_request:2260523450
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/128498/files
twitter:imagehttps://avatars.githubusercontent.com/u/1324225?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1324225?s=400&v=4
og:image:altAs suggested at #128317 (comment), default to checking stdout's isatty rather than stderr's. Also using the @force_not_colorized_test_class decorator from #127877 to run some tests without ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee840f405b2718e8f2d55aafa9ff27dbce17e29d0c253011d05ea0fea3c78baff
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4ae6027e8ba70c79dc08249bb6cdc1a09d788496
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/128498/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128498%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128498%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/128498/files
Reloadhttps://github.com/python/cpython/pull/128498/files
Reloadhttps://github.com/python/cpython/pull/128498/files
Please reload this pagehttps://github.com/python/cpython/pull/128498/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/128498/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
hugovkhttps://github.com/hugovk
python:mainhttps://github.com/python/cpython/tree/main
hugovk:3.14-color-default-stdouthttps://github.com/hugovk/cpython/tree/3.14-color-default-stdout
Conversation 37 https://github.com/python/cpython/pull/128498
Commits 18 https://github.com/python/cpython/pull/128498/commits
Checks 0 https://github.com/python/cpython/pull/128498/checks
Files changed https://github.com/python/cpython/pull/128498/files
Please reload this pagehttps://github.com/python/cpython/pull/128498/files
gh-128595: Default to stdout isatty for colour detection instead of stderr https://github.com/python/cpython/pull/128498/files#top
Show all changes 18 commits https://github.com/python/cpython/pull/128498/files
4ad090d Add test class helper to force no terminal colour hugovk Dec 11, 2024 https://github.com/python/cpython/pull/128498/commits/4ad090d40872507689b4292c33a75d1468382b92
ab76e1b Refactor hugovk Dec 11, 2024 https://github.com/python/cpython/pull/128498/commits/ab76e1b7aa2f1e92a65d3124c4e5d43fd9e0f106
bb90f89 Default to stdout isatty for colour detection instead of stderr hugovk Jan 4, 2025 https://github.com/python/cpython/pull/128498/commits/bb90f8924934ccdfecf5573fae0251d22f26a2e7
172f8c3 Add NEWS hugovk Jan 7, 2025 https://github.com/python/cpython/pull/128498/commits/172f8c389934bbdfcc0dbf7b9b2ad2839e1c88e2
bf31943 Merge branch 'main' into 3.14-color-default-stdout hugovk Jan 13, 2025 https://github.com/python/cpython/pull/128498/commits/bf31943685b7d76f783088d52382214ed03c50b7
b7855ad Fix merge conflict hugovk Jan 13, 2025 https://github.com/python/cpython/pull/128498/commits/b7855ade9a85b26bcf4c4b9c10d9a495808a7653
8e24cc8 Remove unused import hugovk Jan 13, 2025 https://github.com/python/cpython/pull/128498/commits/8e24cc89d243dd2814b77361a8b87a3f6ad79cc2
2b88c85 Check can_colorize using same output stream as traceback hugovk Jan 9, 2025 https://github.com/python/cpython/pull/128498/commits/2b88c85e729fdc7cbdf5390c95ed4373768d1c69
4aa46c5 Check can_colorize using same output stream as unittest hugovk Jan 9, 2025 https://github.com/python/cpython/pull/128498/commits/4aa46c5f94f8302be294a94d850e063f414a7117
d0ce622 Check get_colors using the same output stream hugovk Jan 13, 2025 https://github.com/python/cpython/pull/128498/commits/d0ce62201d6dd1670ae0de977c5fa141aa622bb5
7debe69 Apply suggestions from code review hugovk Jan 13, 2025 https://github.com/python/cpython/pull/128498/commits/7debe697b40b26d6b7d4f410b6a287779c78c7dd
6faf53c Add missing parenthesis hugovk Jan 13, 2025 https://github.com/python/cpython/pull/128498/commits/6faf53c79b7067a532ba31e0397e0f7fc710d878
e1547d0 Name the argument hugovk Jan 13, 2025 https://github.com/python/cpython/pull/128498/commits/e1547d04407f45e67f94fb8a8c488de108fb85dd
7612bff Also print skips to stderr hugovk Jan 13, 2025 https://github.com/python/cpython/pull/128498/commits/7612bff993ca3087351fdfdb8c9a78238b6fa7a8
44828f0 Check file not sys.stdout hugovk Jan 14, 2025 https://github.com/python/cpython/pull/128498/commits/44828f0f9a883d55b97d857a853f7aa11c940b4e
36eb18e file=stream hugovk Jan 14, 2025 https://github.com/python/cpython/pull/128498/commits/36eb18e1bcfdf4b6470ffb1013b883c235803d0b
f5857b5 Print to stdout hugovk Jan 14, 2025 https://github.com/python/cpython/pull/128498/commits/f5857b5229930465589eefdfbbd8a5baf0e34c8f
3047d2a Log skipped to stdout, log failures to stderr hugovk Jan 14, 2025 https://github.com/python/cpython/pull/128498/commits/3047d2af5f6e98392f655f1e2588ee8038e5a00b
Clear filters https://github.com/python/cpython/pull/128498/files
Please reload this pagehttps://github.com/python/cpython/pull/128498/files
Please reload this pagehttps://github.com/python/cpython/pull/128498/files
_colorize.py https://github.com/python/cpython/pull/128498/files#diff-9df1113be57dfbda10f44550069c7ad7d9c9ebec3e63ee5261897c6d5e30cf17
doctest.py https://github.com/python/cpython/pull/128498/files#diff-ecfd94d9d59a476cc6a2027adf6ec5468dcaaa9c8ad5c6e007ba195ce471db70
single.py https://github.com/python/cpython/pull/128498/files#diff-e795484b2b979b7a4fe0ee745aa74d1e3919d60894ee9fb2a06701fa1300d85e
__init__.py https://github.com/python/cpython/pull/128498/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8d
traceback.py https://github.com/python/cpython/pull/128498/files#diff-96634ca56022c201d0ff677e922810a97e4ad8a55de53258cf0cbc22bd7c9be1
result.py https://github.com/python/cpython/pull/128498/files#diff-ba8a6f32f39f6047ea998da6ddc7356a30eff06dd2b84d19f9a285c3162d2a93
runner.py https://github.com/python/cpython/pull/128498/files#diff-8fce5e301fa724e355a39315e2b1205ce4bbc5b5f193bd530654863d7d8b6a78
2025-01-07-21-48-32.gh-issue-128498.n6jtlW.rst https://github.com/python/cpython/pull/128498/files#diff-3bd2c8ecde1adf894150991cbae1425a1c3329c9c4178bd99dfd75d6edcc4455
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L416
Lib/_colorize.pyhttps://github.com/python/cpython/pull/128498/files#diff-9df1113be57dfbda10f44550069c7ad7d9c9ebec3e63ee5261897c6d5e30cf17
View file https://github.com/hugovk/cpython/blob/3047d2af5f6e98392f655f1e2588ee8038e5a00b/Lib/_colorize.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128498/{{ revealButtonHref }}
https://github.com/python/cpython/pull/128498/files#diff-9df1113be57dfbda10f44550069c7ad7d9c9ebec3e63ee5261897c6d5e30cf17
https://github.com/python/cpython/pull/128498/files#diff-9df1113be57dfbda10f44550069c7ad7d9c9ebec3e63ee5261897c6d5e30cf17
https://github.com/python/cpython/pull/128498/files#diff-9df1113be57dfbda10f44550069c7ad7d9c9ebec3e63ee5261897c6d5e30cf17
Lib/doctest.pyhttps://github.com/python/cpython/pull/128498/files#diff-ecfd94d9d59a476cc6a2027adf6ec5468dcaaa9c8ad5c6e007ba195ce471db70
View file https://github.com/hugovk/cpython/blob/3047d2af5f6e98392f655f1e2588ee8038e5a00b/Lib/doctest.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128498/{{ revealButtonHref }}
https://github.com/python/cpython/pull/128498/files#diff-ecfd94d9d59a476cc6a2027adf6ec5468dcaaa9c8ad5c6e007ba195ce471db70
https://github.com/python/cpython/pull/128498/files#diff-ecfd94d9d59a476cc6a2027adf6ec5468dcaaa9c8ad5c6e007ba195ce471db70
Lib/test/libregrtest/single.pyhttps://github.com/python/cpython/pull/128498/files#diff-e795484b2b979b7a4fe0ee745aa74d1e3919d60894ee9fb2a06701fa1300d85e
View file https://github.com/hugovk/cpython/blob/3047d2af5f6e98392f655f1e2588ee8038e5a00b/Lib/test/libregrtest/single.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128498/{{ revealButtonHref }}
https://github.com/python/cpython/pull/128498/files#diff-e795484b2b979b7a4fe0ee745aa74d1e3919d60894ee9fb2a06701fa1300d85e
https://github.com/python/cpython/pull/128498/files#diff-e795484b2b979b7a4fe0ee745aa74d1e3919d60894ee9fb2a06701fa1300d85e
Please reload this pagehttps://github.com/python/cpython/pull/128498/files
https://github.com/python/cpython/pull/128498/files#diff-e795484b2b979b7a4fe0ee745aa74d1e3919d60894ee9fb2a06701fa1300d85e
https://github.com/python/cpython/pull/128498/files#diff-e795484b2b979b7a4fe0ee745aa74d1e3919d60894ee9fb2a06701fa1300d85e
https://github.com/python/cpython/pull/128498/files#diff-e795484b2b979b7a4fe0ee745aa74d1e3919d60894ee9fb2a06701fa1300d85e
https://github.com/python/cpython/pull/128498/files#diff-e795484b2b979b7a4fe0ee745aa74d1e3919d60894ee9fb2a06701fa1300d85e
Lib/test/support/__init__.pyhttps://github.com/python/cpython/pull/128498/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8d
View file https://github.com/hugovk/cpython/blob/3047d2af5f6e98392f655f1e2588ee8038e5a00b/Lib/test/support/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128498/{{ revealButtonHref }}
https://github.com/python/cpython/pull/128498/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8d
https://github.com/python/cpython/pull/128498/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8d
Lib/traceback.pyhttps://github.com/python/cpython/pull/128498/files#diff-96634ca56022c201d0ff677e922810a97e4ad8a55de53258cf0cbc22bd7c9be1
View file https://github.com/hugovk/cpython/blob/3047d2af5f6e98392f655f1e2588ee8038e5a00b/Lib/traceback.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128498/{{ revealButtonHref }}
https://github.com/python/cpython/pull/128498/files#diff-96634ca56022c201d0ff677e922810a97e4ad8a55de53258cf0cbc22bd7c9be1
https://github.com/python/cpython/pull/128498/files#diff-96634ca56022c201d0ff677e922810a97e4ad8a55de53258cf0cbc22bd7c9be1
Lib/unittest/result.pyhttps://github.com/python/cpython/pull/128498/files#diff-ba8a6f32f39f6047ea998da6ddc7356a30eff06dd2b84d19f9a285c3162d2a93
View file https://github.com/hugovk/cpython/blob/3047d2af5f6e98392f655f1e2588ee8038e5a00b/Lib/unittest/result.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128498/{{ revealButtonHref }}
https://github.com/python/cpython/pull/128498/files#diff-ba8a6f32f39f6047ea998da6ddc7356a30eff06dd2b84d19f9a285c3162d2a93
https://github.com/python/cpython/pull/128498/files#diff-ba8a6f32f39f6047ea998da6ddc7356a30eff06dd2b84d19f9a285c3162d2a93
Lib/unittest/runner.pyhttps://github.com/python/cpython/pull/128498/files#diff-8fce5e301fa724e355a39315e2b1205ce4bbc5b5f193bd530654863d7d8b6a78
View file https://github.com/hugovk/cpython/blob/3047d2af5f6e98392f655f1e2588ee8038e5a00b/Lib/unittest/runner.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128498/{{ revealButtonHref }}
https://github.com/python/cpython/pull/128498/files#diff-8fce5e301fa724e355a39315e2b1205ce4bbc5b5f193bd530654863d7d8b6a78
https://github.com/python/cpython/pull/128498/files#diff-8fce5e301fa724e355a39315e2b1205ce4bbc5b5f193bd530654863d7d8b6a78
https://github.com/python/cpython/pull/128498/files#diff-8fce5e301fa724e355a39315e2b1205ce4bbc5b5f193bd530654863d7d8b6a78
https://github.com/python/cpython/pull/128498/files#diff-8fce5e301fa724e355a39315e2b1205ce4bbc5b5f193bd530654863d7d8b6a78
Misc/NEWS.d/next/Library/2025-01-07-21-48-32.gh-issue-128498.n6jtlW.rsthttps://github.com/python/cpython/pull/128498/files#diff-3bd2c8ecde1adf894150991cbae1425a1c3329c9c4178bd99dfd75d6edcc4455
View file https://github.com/hugovk/cpython/blob/3047d2af5f6e98392f655f1e2588ee8038e5a00b/Misc/NEWS.d/next/Library/2025-01-07-21-48-32.gh-issue-128498.n6jtlW.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128498/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.