René's URL Explorer Experiment


Title: gh-128595: Default to stdout isatty for colour detection instead of stderr by hugovk · Pull Request #128498 · python/cpython · GitHub

Open Graph Title: gh-128595: Default to stdout isatty for colour detection instead of stderr by hugovk · Pull Request #128498 · python/cpython

X Title: gh-128595: Default to stdout isatty for colour detection instead of stderr by hugovk · Pull Request #128498 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: As suggested at #128317 (comment), default to checking stdout's isatty rather than stderr's. Also using the @force_not_colorized_test_class decorator from #127877 to run some tests without ...

X Description: As suggested at #128317 (comment), default to checking stdout's isatty rather than stderr's. Also using the @force_not_colorized_test_class decorator from #127877 to run some tests ...

Opengraph URL: https://github.com/python/cpython/pull/128498

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:0373bd7b-e34f-d2c1-7b14-b91dff35c8d9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE4F0:15E981:9F7DF5:DB3D99:6A51338A
html-safe-nonce3171a9a2f6972df271c6bc63b2394237bb0de26a7c886c6e0a4779a0acb098e7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNEYwOjE1RTk4MTo5RjdERjU6REIzRDk5OjZBNTEzMzhBIiwidmlzaXRvcl9pZCI6IjU5NDkzNzYyNTc2ODI2NDk5OTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4a91e2196c88a2a7eaeffc6dc964d3b88fef08b286f7ebbc9efcf828f8cbe721
hovercard-subject-tagpull_request:2260523450
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/128498/commits
twitter:imagehttps://opengraph.githubassets.com/794d83048db818ad30aff02bddf412c74e9f54ec702c32ebd272b9e76ad98194/python/cpython/pull/128498
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/794d83048db818ad30aff02bddf412c74e9f54ec702c32ebd272b9e76ad98194/python/cpython/pull/128498
og:image:altAs suggested at #128317 (comment), default to checking stdout's isatty rather than stderr's. Also using the @force_not_colorized_test_class decorator from #127877 to run some tests without ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehugovk
hostnamegithub.com
expected-hostnamegithub.com
Nonee840f405b2718e8f2d55aafa9ff27dbce17e29d0c253011d05ea0fea3c78baff
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4ae6027e8ba70c79dc08249bb6cdc1a09d788496
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/128498/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128498%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128498%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/128498/commits
Reloadhttps://github.com/python/cpython/pull/128498/commits
Reloadhttps://github.com/python/cpython/pull/128498/commits
Please reload this pagehttps://github.com/python/cpython/pull/128498/commits
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/128498/commits
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
hugovkhttps://github.com/hugovk
python:mainhttps://github.com/python/cpython/tree/main
hugovk:3.14-color-default-stdouthttps://github.com/hugovk/cpython/tree/3.14-color-default-stdout
Conversationhttps://github.com/python/cpython/pull/128498
Commits18 (18)https://github.com/python/cpython/pull/128498/commits
Checkshttps://github.com/python/cpython/pull/128498/checks
Files changedhttps://github.com/python/cpython/pull/128498/files
gh-128595: Default to stdout isatty for colour detection instead of stderrhttps://github.com/python/cpython/pull/128498/commits#top
hugovkhttps://github.com/hugovk
python:mainhttps://github.com/python/cpython/tree/main
hugovk:3.14-color-default-stdouthttps://github.com/hugovk/cpython/tree/3.14-color-default-stdout
Add test class helper to force no terminal colourhttps://github.com/python/cpython/pull/128498/commits/4ad090d40872507689b4292c33a75d1468382b92
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
4ad090dhttps://github.com/python/cpython/pull/128498/commits/4ad090d40872507689b4292c33a75d1468382b92
https://github.com/python/cpython/tree/4ad090d40872507689b4292c33a75d1468382b92
Refactorhttps://github.com/python/cpython/pull/128498/commits/ab76e1b7aa2f1e92a65d3124c4e5d43fd9e0f106
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
ab76e1bhttps://github.com/python/cpython/pull/128498/commits/ab76e1b7aa2f1e92a65d3124c4e5d43fd9e0f106
https://github.com/python/cpython/tree/ab76e1b7aa2f1e92a65d3124c4e5d43fd9e0f106
Default to stdout isatty for colour detection instead of stderrhttps://github.com/python/cpython/pull/128498/commits/bb90f8924934ccdfecf5573fae0251d22f26a2e7
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
bb90f89https://github.com/python/cpython/pull/128498/commits/bb90f8924934ccdfecf5573fae0251d22f26a2e7
https://github.com/python/cpython/tree/bb90f8924934ccdfecf5573fae0251d22f26a2e7
Add NEWShttps://github.com/python/cpython/pull/128498/commits/172f8c389934bbdfcc0dbf7b9b2ad2839e1c88e2
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
172f8c3https://github.com/python/cpython/pull/128498/commits/172f8c389934bbdfcc0dbf7b9b2ad2839e1c88e2
https://github.com/python/cpython/tree/172f8c389934bbdfcc0dbf7b9b2ad2839e1c88e2
Merge branch 'main' into 3.14-color-default-stdouthttps://github.com/python/cpython/pull/128498/commits/bf31943685b7d76f783088d52382214ed03c50b7
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
bf31943https://github.com/python/cpython/pull/128498/commits/bf31943685b7d76f783088d52382214ed03c50b7
https://github.com/python/cpython/tree/bf31943685b7d76f783088d52382214ed03c50b7
Fix merge conflicthttps://github.com/python/cpython/pull/128498/commits/b7855ade9a85b26bcf4c4b9c10d9a495808a7653
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
b7855adhttps://github.com/python/cpython/pull/128498/commits/b7855ade9a85b26bcf4c4b9c10d9a495808a7653
https://github.com/python/cpython/tree/b7855ade9a85b26bcf4c4b9c10d9a495808a7653
Remove unused importhttps://github.com/python/cpython/pull/128498/commits/8e24cc89d243dd2814b77361a8b87a3f6ad79cc2
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
8e24cc8https://github.com/python/cpython/pull/128498/commits/8e24cc89d243dd2814b77361a8b87a3f6ad79cc2
https://github.com/python/cpython/tree/8e24cc89d243dd2814b77361a8b87a3f6ad79cc2
Check can_colorize using same output stream as tracebackhttps://github.com/python/cpython/pull/128498/commits/2b88c85e729fdc7cbdf5390c95ed4373768d1c69
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
2b88c85https://github.com/python/cpython/pull/128498/commits/2b88c85e729fdc7cbdf5390c95ed4373768d1c69
https://github.com/python/cpython/tree/2b88c85e729fdc7cbdf5390c95ed4373768d1c69
Check can_colorize using same output stream as unittesthttps://github.com/python/cpython/pull/128498/commits/4aa46c5f94f8302be294a94d850e063f414a7117
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
4aa46c5https://github.com/python/cpython/pull/128498/commits/4aa46c5f94f8302be294a94d850e063f414a7117
https://github.com/python/cpython/tree/4aa46c5f94f8302be294a94d850e063f414a7117
Check get_colors using the same output streamhttps://github.com/python/cpython/pull/128498/commits/d0ce62201d6dd1670ae0de977c5fa141aa622bb5
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
d0ce622https://github.com/python/cpython/pull/128498/commits/d0ce62201d6dd1670ae0de977c5fa141aa622bb5
https://github.com/python/cpython/tree/d0ce62201d6dd1670ae0de977c5fa141aa622bb5
Apply suggestions from code reviewhttps://github.com/python/cpython/pull/128498/commits/7debe697b40b26d6b7d4f410b6a287779c78c7dd
7debe69https://github.com/python/cpython/pull/128498/commits/7debe697b40b26d6b7d4f410b6a287779c78c7dd
https://github.com/python/cpython/tree/7debe697b40b26d6b7d4f410b6a287779c78c7dd
Add missing parenthesishttps://github.com/python/cpython/pull/128498/commits/6faf53c79b7067a532ba31e0397e0f7fc710d878
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
6faf53chttps://github.com/python/cpython/pull/128498/commits/6faf53c79b7067a532ba31e0397e0f7fc710d878
https://github.com/python/cpython/tree/6faf53c79b7067a532ba31e0397e0f7fc710d878
Name the argumenthttps://github.com/python/cpython/pull/128498/commits/e1547d04407f45e67f94fb8a8c488de108fb85dd
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
e1547d0https://github.com/python/cpython/pull/128498/commits/e1547d04407f45e67f94fb8a8c488de108fb85dd
https://github.com/python/cpython/tree/e1547d04407f45e67f94fb8a8c488de108fb85dd
Also print skips to stderrhttps://github.com/python/cpython/pull/128498/commits/7612bff993ca3087351fdfdb8c9a78238b6fa7a8
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
7612bffhttps://github.com/python/cpython/pull/128498/commits/7612bff993ca3087351fdfdb8c9a78238b6fa7a8
https://github.com/python/cpython/tree/7612bff993ca3087351fdfdb8c9a78238b6fa7a8
Check file not sys.stdouthttps://github.com/python/cpython/pull/128498/commits/44828f0f9a883d55b97d857a853f7aa11c940b4e
hugovkhttps://github.com/python/cpython/commits?author=hugovk
vstinnerhttps://github.com/python/cpython/commits?author=vstinner
44828f0https://github.com/python/cpython/pull/128498/commits/44828f0f9a883d55b97d857a853f7aa11c940b4e
https://github.com/python/cpython/tree/44828f0f9a883d55b97d857a853f7aa11c940b4e
file=streamhttps://github.com/python/cpython/pull/128498/commits/36eb18e1bcfdf4b6470ffb1013b883c235803d0b
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
36eb18ehttps://github.com/python/cpython/pull/128498/commits/36eb18e1bcfdf4b6470ffb1013b883c235803d0b
https://github.com/python/cpython/tree/36eb18e1bcfdf4b6470ffb1013b883c235803d0b
Print to stdouthttps://github.com/python/cpython/pull/128498/commits/f5857b5229930465589eefdfbbd8a5baf0e34c8f
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
f5857b5https://github.com/python/cpython/pull/128498/commits/f5857b5229930465589eefdfbbd8a5baf0e34c8f
https://github.com/python/cpython/tree/f5857b5229930465589eefdfbbd8a5baf0e34c8f
Log skipped to stdout, log failures to stderrhttps://github.com/python/cpython/pull/128498/commits/3047d2af5f6e98392f655f1e2588ee8038e5a00b
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
3047d2ahttps://github.com/python/cpython/pull/128498/commits/3047d2af5f6e98392f655f1e2588ee8038e5a00b
https://github.com/python/cpython/tree/3047d2af5f6e98392f655f1e2588ee8038e5a00b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.