Title: gh-111178: fix UBSan failures for `gdbmobject` by picnixz · Pull Request #128178 · python/cpython · GitHub
Open Graph Title: gh-111178: fix UBSan failures for `gdbmobject` by picnixz · Pull Request #128178 · python/cpython
X Title: gh-111178: fix UBSan failures for `gdbmobject` by picnixz · Pull Request #128178 · python/cpython
Description: Just for something I thought of when I was doing those UBSan tasks: for static types, I can add an assert on the type. for dynamic types, I need the state if I want my assert. AFAIR, I skipped the assert when the type is internal and dynamic (namely I used a simple pointer cast). For now, I suggest keeping the macro form since it wouldn't really matter if we just have a static inline function without the assertion check. I've also suppressed an unused return value just for my IDE to be happy but I can revert the commit if needed. Issue: gh-111178
Open Graph Description: Just for something I thought of when I was doing those UBSan tasks: for static types, I can add an assert on the type. for dynamic types, I need the state if I want my assert. AFAIR, I skipped th...
X Description: Just for something I thought of when I was doing those UBSan tasks: for static types, I can add an assert on the type. for dynamic types, I need the state if I want my assert. AFAIR, I skipped th...
Opengraph URL: https://github.com/python/cpython/pull/128178
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:346f05cc-0298-80b1-8237-a6f611931fc3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9CC2:1B40D2:C43A77:10F4626:6969F376 |
| html-safe-nonce | c97654365448e018308d60e238ed56c0af3d166cf07932e412e4ccb76ddbaef9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0MyOjFCNDBEMjpDNDNBNzc6MTBGNDYyNjo2OTY5RjM3NiIsInZpc2l0b3JfaWQiOiI3ODMxOTY1MTA5MDM3MTY3NDc4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a9b57f1ad6755680212614042a589def06c2f8c1a851b0be0fa4ad4a57fdaf50 |
| hovercard-subject-tag | pull_request:2248402995 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/128178/files |
| twitter:image | https://avatars.githubusercontent.com/u/10796600?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/10796600?s=400&v=4 |
| og:image:alt | Just for something I thought of when I was doing those UBSan tasks: for static types, I can add an assert on the type. for dynamic types, I need the state if I want my assert. AFAIR, I skipped th... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width