| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:721dbfc8-196f-83e7-7d32-408523cc92da |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A42C:32EF48:4F103E:6B1E98:6969D901 |
| html-safe-nonce | 695bc242395c137bf6eaf6387bcedabf236fa263adf3390a2863bb497599b605 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDJDOjMyRUY0ODo0RjEwM0U6NkIxRTk4OjY5NjlEOTAxIiwidmlzaXRvcl9pZCI6IjM5NzU5NzkxOTE5MzEzNjE1MzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 242ddb55d02d5e25a9895d141b1c85c9ff43109fb1b422223c61244d9f1253a0 |
| hovercard-subject-tag | pull_request:2248402995 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/128178/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/392ac8b86012bf4bb94bce5f6bab1e7f2e25d764f6e25b30b380d359d3aecead/python/cpython/pull/128178 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/392ac8b86012bf4bb94bce5f6bab1e7f2e25d764f6e25b30b380d359d3aecead/python/cpython/pull/128178 |
| og:image:alt | Just for something I thought of when I was doing those UBSan tasks:
for static types, I can add an assert on the type.
for dynamic types, I need the state if I want my assert.
AFAIR, I skipped th... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | picnixz |
| hostname | github.com |
| expected-hostname | github.com |
| None | acedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 83c08c21cdda978090dc44364b71aa5bc6dcea79 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/128178#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128178 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128178 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/128178 |
| Reload | https://github.com/python/cpython/pull/128178 |
| Reload | https://github.com/python/cpython/pull/128178 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/128178 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/128178 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/128178#issue-comment-box |
| encukou | https://github.com/encukou |
| python:main | https://github.com/python/cpython/tree/main |
| picnixz:fix/ubsan/gdbm-111178 | https://github.com/picnixz/cpython/tree/fix/ubsan/gdbm-111178 |
|
gh-111178: fix UBSan failures for gdbmobject
| https://github.com/python/cpython/pull/128178#top |
| encukou | https://github.com/encukou |
| python:main | https://github.com/python/cpython/tree/main |
| picnixz:fix/ubsan/gdbm-111178 | https://github.com/picnixz/cpython/tree/fix/ubsan/gdbm-111178 |
|
Conversation
0
| https://github.com/python/cpython/pull/128178 |
|
Commits
2
| https://github.com/python/cpython/pull/128178/commits |
|
Checks
45
| https://github.com/python/cpython/pull/128178/checks |
|
Files changed
| https://github.com/python/cpython/pull/128178/files |
| Please reload this page | https://github.com/python/cpython/pull/128178 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
| Dec 22, 2024 | https://github.com/python/cpython/pull/128178#issue-2754681051 |
| Please reload this page | https://github.com/python/cpython/pull/128178 |
| UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178 | https://github.com/python/cpython/issues/111178 |
| Please reload this page | https://github.com/python/cpython/pull/128178 |
| picnixz | https://github.com/picnixz |
| December 22, 2024 15:10 | https://github.com/python/cpython/pull/128178#commits-pushed-36de30e |
|
| https://github.com/picnixz |
| fix UBSan failures for gdbmobject | https://github.com/python/cpython/pull/128178/commits/36de30ed54ecbc5f9f44d513d0f07b37344e9c15 |
| 36de30e | https://github.com/python/cpython/pull/128178/commits/36de30ed54ecbc5f9f44d513d0f07b37344e9c15 |
|
| https://github.com/picnixz |
| suppress unused return values | https://github.com/python/cpython/pull/128178/commits/f9a072cb2ef3a56f53c65c113f735197b5e068ea |
| f9a072c | https://github.com/python/cpython/pull/128178/commits/f9a072cb2ef3a56f53c65c113f735197b5e068ea |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
| corona10 | https://github.com/corona10 |
| erlend-aasland | https://github.com/erlend-aasland |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| code owners | https://github.com/python/cpython/blob/b66a4ad9fc32b63da2ba10db24cbc8f4e29f781a/.github/CODEOWNERS#L57 |
| December 22, 2024 14:19 | https://github.com/python/cpython/pull/128178#event-15741688407 |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Dec 22, 2024 | https://github.com/python/cpython/pull/128178#event-15741688532 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
Dec 22, 2024
| https://github.com/python/cpython/pull/128178#ref-issue-1955903601 |
|
UBSan: Calling a function through pointer to incorrect function type is undefined behavior
#111178
| https://github.com/python/cpython/issues/111178 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Dec 22, 2024 | https://github.com/python/cpython/pull/128178#event-15741688645 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
|
Jan 3, 2025
| https://github.com/python/cpython/pull/128178#pullrequestreview-2528842383 |
|
View reviewed changes
| https://github.com/python/cpython/pull/128178/files/f9a072cb2ef3a56f53c65c113f735197b5e068ea |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Jan 3, 2025 | https://github.com/python/cpython/pull/128178#event-15806113488 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| baf6571 | https://github.com/python/cpython/commit/baf65715fc9002e43cd0e1010b8dba9b4c84d503 |
| Jan 10, 2025 | https://github.com/python/cpython/pull/128178#event-15880413433 |
| Please reload this page | https://github.com/python/cpython/pull/128178 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Jan 10, 2025 | https://github.com/python/cpython/pull/128178#event-15880414076 |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
| January 11, 2025 01:06 | https://github.com/python/cpython/pull/128178#event-15890903028 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128178 |
|
| https://github.com/erlend-aasland |
|
erlend-aasland
| https://github.com/erlend-aasland |
|
| https://github.com/python/cpython/pull/128178/files/f9a072cb2ef3a56f53c65c113f735197b5e068ea |
|
| https://github.com/corona10 |
|
corona10
| https://github.com/corona10 |
|
| https://github.com/serhiy-storchaka |
|
serhiy-storchaka
| https://github.com/serhiy-storchaka |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Please reload this page | https://github.com/python/cpython/pull/128178 |
|
| https://github.com/picnixz |
|
| https://github.com/erlend-aasland |
|
| https://github.com/encukou |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |