René's URL Explorer Experiment


Title: gh-127930: use explicit imports in tkinter.simpledialog by tungol · Pull Request #127931 · python/cpython · GitHub

Open Graph Title: gh-127930: use explicit imports in tkinter.simpledialog by tungol · Pull Request #127931 · python/cpython

X Title: gh-127930: use explicit imports in tkinter.simpledialog by tungol · Pull Request #127931 · python/cpython

Description: simpledialog was overlooked when all the other tkinter submodules were updated to use explicit imports in #14864. This MR fixes that. This is relevant to typeshed, where stubtest detects the extra constants imported into tkinter.simpledialog and emits a warning that they're not present in the stubs. Star imports in the stdlib usually indicate an intention to re-export. I don't think this is user-facing enough to need a NEWS entry, but I'm happy to add one if anyone thinks otherwise. Issue: gh-127930

Open Graph Description: simpledialog was overlooked when all the other tkinter submodules were updated to use explicit imports in #14864. This MR fixes that. This is relevant to typeshed, where stubtest detects the extra ...

X Description: simpledialog was overlooked when all the other tkinter submodules were updated to use explicit imports in #14864. This MR fixes that. This is relevant to typeshed, where stubtest detects the extra ...

Opengraph URL: https://github.com/python/cpython/pull/127931

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ce1a57b9-6c0a-53f1-d723-4dfd5a44db60
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9F1A:446DE:3F9DAFE:591AD2A:6A504D1F
html-safe-nonceebbeef6d21e39e19f98e62fb2fc1b2c5de660e20e11893121bb9cb79014df169
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjFBOjQ0NkRFOjNGOURBRkU6NTkxQUQyQTo2QTUwNEQxRiIsInZpc2l0b3JfaWQiOiIyODQwMTA2NjA3MjY1NzI5ODIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5a36c9d61febd5fd767d9aa6bf3cbfc21edc96f79ce6bf9409ff225d9344e1c6
hovercard-subject-tagpull_request:2234574188
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/127931/files
twitter:imagehttps://avatars.githubusercontent.com/u/562175?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/562175?s=400&v=4
og:image:altsimpledialog was overlooked when all the other tkinter submodules were updated to use explicit imports in #14864. This MR fixes that. This is relevant to typeshed, where stubtest detects the extra ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5741a45fe07e5f377d0d4c524a92e3056acc51bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/127931/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F127931%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F127931%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/127931/files
Reloadhttps://github.com/python/cpython/pull/127931/files
Reloadhttps://github.com/python/cpython/pull/127931/files
Please reload this pagehttps://github.com/python/cpython/pull/127931/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/127931/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
hugovkhttps://github.com/hugovk
python:mainhttps://github.com/python/cpython/tree/main
tungol:simpledialoghttps://github.com/tungol/cpython/tree/simpledialog
Conversation 5 https://github.com/python/cpython/pull/127931
Commits 4 https://github.com/python/cpython/pull/127931/commits
Checks 42 https://github.com/python/cpython/pull/127931/checks
Files changed https://github.com/python/cpython/pull/127931/files
Please reload this pagehttps://github.com/python/cpython/pull/127931/files
gh-127930: use explicit imports in tkinter.simpledialog https://github.com/python/cpython/pull/127931/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/127931/files
f7d8816 use explicit imports in tkinter.simpledialog tungol Dec 13, 2024 https://github.com/python/cpython/pull/127931/commits/f7d881602869efebab2346fc8c0baaf537ad09be
23f0115 add __all__ and a NEWS entry tungol Dec 15, 2024 https://github.com/python/cpython/pull/127931/commits/23f0115be6138e5c56d4ba8a52e1d7d82863fd84
54d2b5e Update Misc/NEWS.d/next/Library/2024-12-14-19-51-39.gh-issue-127930.W… tungol Dec 15, 2024 https://github.com/python/cpython/pull/127931/commits/54d2b5e92d70c3ab10a8d19784a4173fc3e08d28
db3cc3f Merge branch 'main' into simpledialog tungol Jul 9, 2025 https://github.com/python/cpython/pull/127931/commits/db3cc3fbd9c5554bbac6346bcc5e7e04b75806cb
Clear filters https://github.com/python/cpython/pull/127931/files
Please reload this pagehttps://github.com/python/cpython/pull/127931/files
Please reload this pagehttps://github.com/python/cpython/pull/127931/files
simpledialog.py https://github.com/python/cpython/pull/127931/files#diff-643651beb28ec5597e36c1b2a4f4a1bd797e6619ce8617032edada250556d52b
2024-12-14-19-51-39.gh-issue-127930.WsGnh9.rst https://github.com/python/cpython/pull/127931/files#diff-158e4bb367d6049bdb849b3e7bbabd4b0df7642762433862c15009789e69be0b
Lib/tkinter/simpledialog.pyhttps://github.com/python/cpython/pull/127931/files#diff-643651beb28ec5597e36c1b2a4f4a1bd797e6619ce8617032edada250556d52b
View file https://github.com/tungol/cpython/blob/db3cc3fbd9c5554bbac6346bcc5e7e04b75806cb/Lib/tkinter/simpledialog.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127931/{{ revealButtonHref }}
https://github.com/python/cpython/pull/127931/files#diff-643651beb28ec5597e36c1b2a4f4a1bd797e6619ce8617032edada250556d52b
https://github.com/python/cpython/pull/127931/files#diff-643651beb28ec5597e36c1b2a4f4a1bd797e6619ce8617032edada250556d52b
Misc/NEWS.d/next/Library/2024-12-14-19-51-39.gh-issue-127930.WsGnh9.rsthttps://github.com/python/cpython/pull/127931/files#diff-158e4bb367d6049bdb849b3e7bbabd4b0df7642762433862c15009789e69be0b
View file https://github.com/tungol/cpython/blob/db3cc3fbd9c5554bbac6346bcc5e7e04b75806cb/Misc/NEWS.d/next/Library/2024-12-14-19-51-39.gh-issue-127930.WsGnh9.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127931/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/127931/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.