René's URL Explorer Experiment


Title: gh-127773: Disable attribute cache on incompatible MRO entries by encukou · Pull Request #127924 · python/cpython · GitHub

Open Graph Title: gh-127773: Disable attribute cache on incompatible MRO entries by encukou · Pull Request #127924 · python/cpython

X Title: gh-127773: Disable attribute cache on incompatible MRO entries by encukou · Pull Request #127924 · python/cpython

Description: This brings back the functionality of Py_TPFLAGS_HAVE_VERSION_TAG, which should have been named “use version tag”, as the field itself is always present -- see #27260 where I mistakenly removed it. The type attribute cache relies on a class being able to invalidate caches of all of its subclasses. If a type's MRO contains an entry that's not that type's base, the cache needs to be disabled. This requires a single bit, which was in tp_flags in 3.9 and below. I'd like to avoid using tp_flags for an internal flag (even one that's currently reserved for ABI compatibility). We already have a mechanism for disabling the cache: it's disabled after 1000 modifications to a single type, using tp_versions_used as a counter. It would be possible to set this to 1000 (MAX_VERSIONS_PER_CLASS) when an incompatible MRO is found. To make the code & logic more understandable, this PR uses a new bigger constant, _Py_ATTR_CACHE_UNUSED. The existing tp_versions_used check is reused. If the tp_versions_used mechanism is dropped in the future, _Py_ATTR_CACHE_UNUSED can become a single bit stored elsewhere in PyTypeObject. Ideally in a private (underscore-prefixed) field; not in tp_flags. @markshannon @colesbury Does this sound right? I'm not much of an attribute cache expert and I don't know about future plans in this area. Issue: gh-127773

Open Graph Description: This brings back the functionality of Py_TPFLAGS_HAVE_VERSION_TAG, which should have been named “use version tag”, as the field itself is always present -- see #27260 where I mistakenly removed it....

X Description: This brings back the functionality of Py_TPFLAGS_HAVE_VERSION_TAG, which should have been named “use version tag”, as the field itself is always present -- see #27260 where I mistakenly removed it....

Opengraph URL: https://github.com/python/cpython/pull/127924

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:17baede6-0d80-e941-7c96-9fe8b1e0b867
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD684:17FB7:41BD5B4:5325776:6B0258A1
html-safe-nonce52f9b84be5259d2b011a2a2882959527777813366d5d74cc0d6fd71ede62bc2d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjg0OjE3RkI3OjQxQkQ1QjQ6NTMyNTc3Njo2QjAyNThBMSIsInZpc2l0b3JfaWQiOiI3NzY1Mjk0NjM2NjcwODAyMDgxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9b8bd84f7a14b53ec936f900cab2ca08b1be498001b1d195c706051553c475ad
hovercard-subject-tagpull_request:2234027116
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/127924/files
twitter:imagehttps://avatars.githubusercontent.com/u/302922?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/302922?s=400&v=4
og:image:altThis brings back the functionality of Py_TPFLAGS_HAVE_VERSION_TAG, which should have been named “use version tag”, as the field itself is always present -- see #27260 where I mistakenly removed it....
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/127924/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F127924%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F127924%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/127924/files
Reloadhttps://github.com/python/cpython/pull/127924/files
Reloadhttps://github.com/python/cpython/pull/127924/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:stale-mro-cachehttps://github.com/encukou/cpython/tree/stale-mro-cache
Conversation 8 https://github.com/python/cpython/pull/127924
Commits 6 https://github.com/python/cpython/pull/127924/commits
Checks 0 https://github.com/python/cpython/pull/127924/checks
Files changed https://github.com/python/cpython/pull/127924/files
Please reload this pagehttps://github.com/python/cpython/pull/127924/files
gh-127773: Disable attribute cache on incompatible MRO entries https://github.com/python/cpython/pull/127924/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/127924/files
6653d17 Add test encukou Dec 12, 2024 https://github.com/python/cpython/pull/127924/commits/6653d173b4768a8c5baa2b551f29d99ecac13991
1d7a635 Set large `tp_versions_used` when type attribute cache should be disa… encukou Dec 13, 2024 https://github.com/python/cpython/pull/127924/commits/1d7a635a354869bfcea8274d948ca8e05aabb31b
b649a96 Link a term in the blurb encukou Dec 16, 2024 https://github.com/python/cpython/pull/127924/commits/b649a960f028a2dc37b323423ae4f2c0963410a7
d69ec0f Use `static_assert` encukou Dec 16, 2024 https://github.com/python/cpython/pull/127924/commits/d69ec0f9d2b62e35d64db027ad9fe053e3e3dfc0
a537cc3 Merge in the main branch encukou Dec 16, 2024 https://github.com/python/cpython/pull/127924/commits/a537cc3166c20d1cee582f7d19d26b3a54ba8c83
5dbbdf4 Use #if and #error encukou Dec 16, 2024 https://github.com/python/cpython/pull/127924/commits/5dbbdf4c0514cfebe668ea4540de475b1f9e0199
Clear filters https://github.com/python/cpython/pull/127924/files
Please reload this pagehttps://github.com/python/cpython/pull/127924/files
Please reload this pagehttps://github.com/python/cpython/pull/127924/files
object.h https://github.com/python/cpython/pull/127924/files#diff-7c8590641fc0d835bdab9395a95dbacfb2abb056cec4217466c0f3ca6cca8270
test_metaclass.py https://github.com/python/cpython/pull/127924/files#diff-8dc13f42c6cf3fca078110fdff2b5b03625c8a6a8f2d8795dd5fa684c28b3d0e
2024-12-13-15-21-45.gh-issue-127773.E-DZR4.rst https://github.com/python/cpython/pull/127924/files#diff-3f79a4a6f70351d117f7a7558ad5b42ba223882ecc048082b217a87804910874
typeobject.c https://github.com/python/cpython/pull/127924/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
Include/cpython/object.hhttps://github.com/python/cpython/pull/127924/files#diff-7c8590641fc0d835bdab9395a95dbacfb2abb056cec4217466c0f3ca6cca8270
View file https://github.com/encukou/cpython/blob/5dbbdf4c0514cfebe668ea4540de475b1f9e0199/Include/cpython/object.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127924/{{ revealButtonHref }}
https://github.com/python/cpython/pull/127924/files#diff-7c8590641fc0d835bdab9395a95dbacfb2abb056cec4217466c0f3ca6cca8270
https://github.com/python/cpython/pull/127924/files#diff-7c8590641fc0d835bdab9395a95dbacfb2abb056cec4217466c0f3ca6cca8270
Lib/test/test_metaclass.pyhttps://github.com/python/cpython/pull/127924/files#diff-8dc13f42c6cf3fca078110fdff2b5b03625c8a6a8f2d8795dd5fa684c28b3d0e
View file https://github.com/encukou/cpython/blob/5dbbdf4c0514cfebe668ea4540de475b1f9e0199/Lib/test/test_metaclass.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127924/{{ revealButtonHref }}
https://github.com/python/cpython/pull/127924/files#diff-8dc13f42c6cf3fca078110fdff2b5b03625c8a6a8f2d8795dd5fa684c28b3d0e
https://github.com/python/cpython/pull/127924/files#diff-8dc13f42c6cf3fca078110fdff2b5b03625c8a6a8f2d8795dd5fa684c28b3d0e
Misc/NEWS.d/next/Core_and_Builtins/2024-12-13-15-21-45.gh-issue-127773.E-DZR4.rsthttps://github.com/python/cpython/pull/127924/files#diff-3f79a4a6f70351d117f7a7558ad5b42ba223882ecc048082b217a87804910874
View file https://github.com/encukou/cpython/blob/5dbbdf4c0514cfebe668ea4540de475b1f9e0199/Misc/NEWS.d/next/Core_and_Builtins/2024-12-13-15-21-45.gh-issue-127773.E-DZR4.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127924/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L217
Objects/typeobject.chttps://github.com/python/cpython/pull/127924/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
View file https://github.com/encukou/cpython/blob/5dbbdf4c0514cfebe668ea4540de475b1f9e0199/Objects/typeobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127924/{{ revealButtonHref }}
https://github.com/python/cpython/pull/127924/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/127924/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/127924/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/127924/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/127924/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/127924/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/127924/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/127924/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.