René's URL Explorer Experiment


Title: gh-115999: Specialize `STORE_ATTR` in free-threaded builds. by nascheme · Pull Request #127838 · python/cpython · GitHub

Open Graph Title: gh-115999: Specialize `STORE_ATTR` in free-threaded builds. by nascheme · Pull Request #127838 · python/cpython

X Title: gh-115999: Specialize `STORE_ATTR` in free-threaded builds. by nascheme · Pull Request #127838 · python/cpython

Description: Fix thread safety issues with specialized opcodes (STORE_ATTR_INSTANCE_VALUE, STORE_ATTR_SLOT, STORE_ATTR_WITH_HINT). Need a combination of locks and atomics to be safe. Fix thread safety issues with _Py_Specialize_StoreAttr . Avoid using borrowed references. Save and store the tp_version_tag from the beginning of the specialization process since it might change. Use helper functions to update opcode. Add unit tests to ensure specialization is happening in free-threaded builds. Add addtional tests to try to trigger data races. Issue: gh-115999

Open Graph Description: Fix thread safety issues with specialized opcodes (STORE_ATTR_INSTANCE_VALUE, STORE_ATTR_SLOT, STORE_ATTR_WITH_HINT). Need a combination of locks and atomics to be safe. Fix thread safety issues w...

X Description: Fix thread safety issues with specialized opcodes (STORE_ATTR_INSTANCE_VALUE, STORE_ATTR_SLOT, STORE_ATTR_WITH_HINT). Need a combination of locks and atomics to be safe. Fix thread safety issues w...

Opengraph URL: https://github.com/python/cpython/pull/127838

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:99548966-9825-6e66-a524-ac012d9dd9a7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB1DA:390B23:CB90E:1161E8:6A56773D
html-safe-nonceb1a839da2d6a6cccbdb853975aeedec4e691edc9a92fe84970d8cb9203f7738d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMURBOjM5MEIyMzpDQjkwRToxMTYxRTg6NkE1Njc3M0QiLCJ2aXNpdG9yX2lkIjoiMjY3MDM2MjEyMDk3NDM5OTI5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2b8030795b346b33f8bfeec52b5ee86c3f7e54650170438367c66ceaa6309d96
hovercard-subject-tagpull_request:2229673701
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/127838/files
twitter:imagehttps://avatars.githubusercontent.com/u/690853?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/690853?s=400&v=4
og:image:altFix thread safety issues with specialized opcodes (STORE_ATTR_INSTANCE_VALUE, STORE_ATTR_SLOT, STORE_ATTR_WITH_HINT). Need a combination of locks and atomics to be safe. Fix thread safety issues w...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None19b5ee9431dcfce15ab4b001d626e4e3a6ba1acb7be814813a52bbebd9a86ef5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseafc01ffdb045f4ff81c6122091366ade7b6166b7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/127838/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F127838%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F127838%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/127838/files
Reloadhttps://github.com/python/cpython/pull/127838/files
Reloadhttps://github.com/python/cpython/pull/127838/files
Please reload this pagehttps://github.com/python/cpython/pull/127838/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/127838/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
naschemehttps://github.com/nascheme
python:mainhttps://github.com/python/cpython/tree/main
nascheme:gh-115999-specialize-store-attrhttps://github.com/nascheme/cpython/tree/gh-115999-specialize-store-attr
Conversation 26 https://github.com/python/cpython/pull/127838
Commits 12 https://github.com/python/cpython/pull/127838/commits
Checks 0 https://github.com/python/cpython/pull/127838/checks
Files changed https://github.com/python/cpython/pull/127838/files
Please reload this pagehttps://github.com/python/cpython/pull/127838/files
gh-115999: Specialize STORE_ATTR in free-threaded builds. https://github.com/python/cpython/pull/127838/files#top
Show all changes 12 commits https://github.com/python/cpython/pull/127838/files
083cbe9 Enable specialization of `STORE_ATTR` free-threaded builds. nascheme Dec 2, 2024 https://github.com/python/cpython/pull/127838/commits/083cbe9f7428bf9aa26185714000635a8c1a7f87
62c8197 Fix issues found in code review. nascheme Dec 13, 2024 https://github.com/python/cpython/pull/127838/commits/62c8197bff11d106672e535cbd1fcf825d67758c
6fb6e4a Small optimization for STORE_ATTR specialize. nascheme Dec 13, 2024 https://github.com/python/cpython/pull/127838/commits/6fb6e4a9a11a78f74e13090a97ea4c490f469b8e
75d9a53 Fix race in specialize_dict_access_inline(). nascheme Dec 13, 2024 https://github.com/python/cpython/pull/127838/commits/75d9a5360692e86a2655faa0c74d151a7a96eb55
476058d Use correct type of load for tp_version_tag. nascheme Dec 13, 2024 https://github.com/python/cpython/pull/127838/commits/476058dbba0d9b5b80121eb2f4a99c681fed7b38
756f939 Avoid overwritting 'dict', needed for unlock. nascheme Dec 13, 2024 https://github.com/python/cpython/pull/127838/commits/756f939c65c0a231bc5bfc66d89062f3c34cda7e
104d972 Add additional tests for STORE_ATTR. nascheme Dec 13, 2024 https://github.com/python/cpython/pull/127838/commits/104d9729e424f7d59236ab305a9af144abe41d09
4981652 Remove unneeded atomic load. nascheme Dec 17, 2024 https://github.com/python/cpython/pull/127838/commits/4981652bcf3ef2e31c0e7d8c415d1c306d34dc8f
6bf9016 Add locking for split dict keys. nascheme Dec 17, 2024 https://github.com/python/cpython/pull/127838/commits/6bf9016a871372366ab7e81480930f09e3d231d1
9015a3f Code cleanup, remove unneeded branches. nascheme Dec 18, 2024 https://github.com/python/cpython/pull/127838/commits/9015a3f1ce121c29daf78c90c788fe687410dc36
14ae6b4 Merge branch 'main' into gh-115999-specialize-store-attr nascheme Dec 19, 2024 https://github.com/python/cpython/pull/127838/commits/14ae6b4b5e29092abab06cc5e020d1ea5f77158c
06a7baf Merge branch 'main' into gh-115999-specialize-store-attr nascheme Dec 19, 2024 https://github.com/python/cpython/pull/127838/commits/06a7baf30007b0ecbe3864451785f830f32e621b
Clear filters https://github.com/python/cpython/pull/127838/files
Please reload this pagehttps://github.com/python/cpython/pull/127838/files
Please reload this pagehttps://github.com/python/cpython/pull/127838/files
pycore_dict.h https://github.com/python/cpython/pull/127838/files#diff-47692c69ef97b2d7cf05ad8e0fa2024b575af96abf9bbc5486f71156ab67ede4
pycore_opcode_metadata.h https://github.com/python/cpython/pull/127838/files#diff-72bc4c0445516cc3eabd536220b2459617491ffaabbdb8a7c5381f36c991e378
pycore_uop_ids.h https://github.com/python/cpython/pull/127838/files#diff-2a420e4d0d58009249c0f73f7c822167b053bd51cb213b20179bd2aebfc66ff9
pycore_uop_metadata.h https://github.com/python/cpython/pull/127838/files#diff-55e65a72fa31e9b746e03076d2c74b716c0c1171663f36960b2339fcbfae9bab
test_races.py https://github.com/python/cpython/pull/127838/files#diff-1e18dbe7edafebe908dbcd077e3d0a15dffcf31397971ecdb445801c6f6b3fa5
test_opcache.py https://github.com/python/cpython/pull/127838/files#diff-dd88a1417bab2a9400460e629e7e43a3f6e798e47b44fe3541f3f804f12430d1
_testinternalcapi.c https://github.com/python/cpython/pull/127838/files#diff-687f4a736f1f6ad4b6cd4ff65c8e0113408304e8d65530dbd41b3f59a081a126
dictobject.c https://github.com/python/cpython/pull/127838/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
bytecodes.c https://github.com/python/cpython/pull/127838/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
executor_cases.c.h https://github.com/python/cpython/pull/127838/files#diff-a1c3430c42a66c16e6d2e154491a6da993b187b27c628545a12a02c7b2a06b81
generated_cases.c.h https://github.com/python/cpython/pull/127838/files#diff-4ef46fa654f95502e49a24f7dc8ee31a4cac9b3433fe9cd2b2d4dd78cfbad448
optimizer_cases.c.h https://github.com/python/cpython/pull/127838/files#diff-ed4567b3e67709ec57bf4df91ef058cfcbe00d7da11cd2a75e38241fa1ca99d2
specialize.c https://github.com/python/cpython/pull/127838/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
Include/internal/pycore_dict.hhttps://github.com/python/cpython/pull/127838/files#diff-47692c69ef97b2d7cf05ad8e0fa2024b575af96abf9bbc5486f71156ab67ede4
View file https://github.com/nascheme/cpython/blob/06a7baf30007b0ecbe3864451785f830f32e621b/Include/internal/pycore_dict.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127838/{{ revealButtonHref }}
https://github.com/python/cpython/pull/127838/files#diff-47692c69ef97b2d7cf05ad8e0fa2024b575af96abf9bbc5486f71156ab67ede4
https://github.com/python/cpython/pull/127838/files#diff-47692c69ef97b2d7cf05ad8e0fa2024b575af96abf9bbc5486f71156ab67ede4
Include/internal/pycore_opcode_metadata.hhttps://github.com/python/cpython/pull/127838/files#diff-72bc4c0445516cc3eabd536220b2459617491ffaabbdb8a7c5381f36c991e378
View file https://github.com/nascheme/cpython/blob/06a7baf30007b0ecbe3864451785f830f32e621b/Include/internal/pycore_opcode_metadata.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/127838/files
Include/internal/pycore_uop_ids.hhttps://github.com/python/cpython/pull/127838/files#diff-2a420e4d0d58009249c0f73f7c822167b053bd51cb213b20179bd2aebfc66ff9
View file https://github.com/nascheme/cpython/blob/06a7baf30007b0ecbe3864451785f830f32e621b/Include/internal/pycore_uop_ids.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/127838/files
Include/internal/pycore_uop_metadata.hhttps://github.com/python/cpython/pull/127838/files#diff-55e65a72fa31e9b746e03076d2c74b716c0c1171663f36960b2339fcbfae9bab
View file https://github.com/nascheme/cpython/blob/06a7baf30007b0ecbe3864451785f830f32e621b/Include/internal/pycore_uop_metadata.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/127838/files
Please reload this pagehttps://github.com/python/cpython/pull/127838/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.