René's URL Explorer Experiment


Title: [3.12] gh-126554: ctypes: Correctly handle NULL dlsym values (GH-126555) by picnixz · Pull Request #127764 · python/cpython · GitHub

Open Graph Title: [3.12] gh-126554: ctypes: Correctly handle NULL dlsym values (GH-126555) by picnixz · Pull Request #127764 · python/cpython

X Title: [3.12] gh-126554: ctypes: Correctly handle NULL dlsym values (GH-126555) by picnixz · Pull Request #127764 · python/cpython

Description: For dlsym(), a return value of NULL does not necessarily indicate an error 1. Therefore, to avoid using stale (or NULL) dlerror() values, we must: clear the previous error state by calling dlerror() call dlsym() call dlerror() If the return value of dlerror() is not NULL, an error occured. In ctypes we choose to treat a NULL return value from dlsym() as a "not found" error. This is the same as the fallback message we use on Windows, Cygwin or when getting/formatting the error reason fails. (cherry picked from commit 8717f79) Co-authored-by: George Alexopoulos giorgosalexo0@gmail.com Signed-off-by: Georgios Alexopoulos grgalex42@gmail.com Signed-off-by: Georgios Alexopoulos grgalex@ba.uoa.gr Co-authored-by: Peter Bierma zintensitydev@gmail.com Co-authored-by: Bénédikt Tran 10796600+picnixz@users.noreply.github.com Co-authored-by: Petr Viktorin encukou@gmail.com Issue: gh-126554

Open Graph Description: For dlsym(), a return value of NULL does not necessarily indicate an error 1. Therefore, to avoid using stale (or NULL) dlerror() values, we must: clear the previous error state by calling dlerror...

X Description: For dlsym(), a return value of NULL does not necessarily indicate an error 1. Therefore, to avoid using stale (or NULL) dlerror() values, we must: clear the previous error state by calling dlerror...

Opengraph URL: https://github.com/python/cpython/pull/127764

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:98f68771-c454-efe7-e4ae-12b03214f234
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA4D0:AC3D5:BBA1EB:F61D11:6B026DF5
html-safe-nonced7ec85c4fdac12e18647e5b0fc0d3e446ffb02b1e253be200c9e1106f6ddd067
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNEQwOkFDM0Q1OkJCQTFFQjpGNjFEMTE6NkIwMjZERjUiLCJ2aXNpdG9yX2lkIjoiNzk1NTY0OTU0NDcxMjYzNzMzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdf6498fe6e8a6f9220c6ec71bbd64e1fd58235786611c8b2410b2c5078010e6f
hovercard-subject-tagpull_request:2223742554
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/127764/files
twitter:imagehttps://avatars.githubusercontent.com/u/10796600?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10796600?s=400&v=4
og:image:altFor dlsym(), a return value of NULL does not necessarily indicate an error 1. Therefore, to avoid using stale (or NULL) dlerror() values, we must: clear the previous error state by calling dlerror...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/127764/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F127764%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F127764%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/127764/files
Reloadhttps://github.com/python/cpython/pull/127764/files
Reloadhttps://github.com/python/cpython/pull/127764/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:3.12https://github.com/python/cpython/tree/3.12
picnixz:bp-8717f792f7cc343599dc60daf80630cceb66145bhttps://github.com/picnixz/cpython/tree/bp-8717f792f7cc343599dc60daf80630cceb66145b
Conversation 2 https://github.com/python/cpython/pull/127764
Commits 3 https://github.com/python/cpython/pull/127764/commits
Checks 0 https://github.com/python/cpython/pull/127764/checks
Files changed https://github.com/python/cpython/pull/127764/files
Please reload this pagehttps://github.com/python/cpython/pull/127764/files
[3.12] gh-126554: ctypes: Correctly handle NULL dlsym values (GH-126555) https://github.com/python/cpython/pull/127764/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/127764/files
1c543d9 gh-126554: ctypes: Correctly handle NULL dlsym values (GH-126555) grgalex Nov 15, 2024 https://github.com/python/cpython/pull/127764/commits/1c543d9c67e63713f5914c58e91fc7a974f81fdb
9179fac fix Windows tests picnixz Dec 15, 2024 https://github.com/python/cpython/pull/127764/commits/9179fac685b2479bd626e74146ca63dea3d95e6c
9fd0eb0 Merge branch '3.12' into bp-8717f792f7cc343599dc60daf80630cceb66145b picnixz Dec 15, 2024 https://github.com/python/cpython/pull/127764/commits/9fd0eb0a5d3a82233970cecf2bc8f0c5b5dd4ebe
Clear filters https://github.com/python/cpython/pull/127764/files
Please reload this pagehttps://github.com/python/cpython/pull/127764/files
Please reload this pagehttps://github.com/python/cpython/pull/127764/files
test_dlerror.py https://github.com/python/cpython/pull/127764/files#diff-3af5e504d494e445186b082040bd423e0a83a3ab263f0c68bd13ab92e85d6a3b
2024-11-07-20-24-58.gh-issue-126554.ri12eb.rst https://github.com/python/cpython/pull/127764/files#diff-b3c861a1394117377efb4c80416615c02aed4898189774696b444c3a156f2067
_ctypes.c https://github.com/python/cpython/pull/127764/files#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
callproc.c https://github.com/python/cpython/pull/127764/files#diff-4e23b3237d0aa08bf4c434d75fab19200a80837bd147051fefccd98b7f2480fa
Lib/test/test_ctypes/test_dlerror.pyhttps://github.com/python/cpython/pull/127764/files#diff-3af5e504d494e445186b082040bd423e0a83a3ab263f0c68bd13ab92e85d6a3b
View file https://github.com/picnixz/cpython/blob/9fd0eb0a5d3a82233970cecf2bc8f0c5b5dd4ebe/Lib/test/test_ctypes/test_dlerror.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127764/{{ revealButtonHref }}
Misc/NEWS.d/next/C_API/2024-11-07-20-24-58.gh-issue-126554.ri12eb.rsthttps://github.com/python/cpython/pull/127764/files#diff-b3c861a1394117377efb4c80416615c02aed4898189774696b444c3a156f2067
View file https://github.com/picnixz/cpython/blob/9fd0eb0a5d3a82233970cecf2bc8f0c5b5dd4ebe/Misc/NEWS.d/next/C_API/2024-11-07-20-24-58.gh-issue-126554.ri12eb.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127764/{{ revealButtonHref }}
Modules/_ctypes/_ctypes.chttps://github.com/python/cpython/pull/127764/files#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
View file https://github.com/picnixz/cpython/blob/9fd0eb0a5d3a82233970cecf2bc8f0c5b5dd4ebe/Modules/_ctypes/_ctypes.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127764/{{ revealButtonHref }}
https://github.com/python/cpython/pull/127764/files#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
https://github.com/python/cpython/pull/127764/files#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
https://github.com/python/cpython/pull/127764/files#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
https://github.com/python/cpython/pull/127764/files#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
https://github.com/python/cpython/pull/127764/files#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
Modules/_ctypes/callproc.chttps://github.com/python/cpython/pull/127764/files#diff-4e23b3237d0aa08bf4c434d75fab19200a80837bd147051fefccd98b7f2480fa
View file https://github.com/picnixz/cpython/blob/9fd0eb0a5d3a82233970cecf2bc8f0c5b5dd4ebe/Modules/_ctypes/callproc.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127764/{{ revealButtonHref }}
https://github.com/python/cpython/pull/127764/files#diff-4e23b3237d0aa08bf4c434d75fab19200a80837bd147051fefccd98b7f2480fa
https://github.com/python/cpython/pull/127764/files#diff-4e23b3237d0aa08bf4c434d75fab19200a80837bd147051fefccd98b7f2480fa
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.