René's URL Explorer Experiment


Title: gh-80192: Use windows api if ssl cert verification fails by tobil4sk · Pull Request #127622 · python/cpython · GitHub

Open Graph Title: gh-80192: Use windows api if ssl cert verification fails by tobil4sk · Pull Request #127622 · python/cpython

X Title: gh-80192: Use windows api if ssl cert verification fails by tobil4sk · Pull Request #127622 · python/cpython

Description: This avoids rejecting certificates that should be accepted, see #80192. Here is the relevant openssl documentation: https://docs.openssl.org/master/man3/SSL_CTX_set_verify/. Also, here are the windows api docs: https://learn.microsoft.com/en-us/windows/win32/api/wincrypt/nf-wincrypt-certverifycertificatechainpolicy https://learn.microsoft.com/en-us/windows/win32/api/wincrypt/ns-wincrypt-cert_chain_policy_status for error status. I've been testing manually by deleting DigiCert Global Root G2 from Third Party Root Certificates in the user certificate store (this is safe, the certificate will be added back automatically), and running the following code: import http.client conn = http.client.HTTPSConnection("www.verisign.com") conn.request("GET", "/") conn.close() The main branch errors with: ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1025) Whereas with this patch, the certificate is verified and the connection is established. Issue: gh-80192

Open Graph Description: This avoids rejecting certificates that should be accepted, see #80192. Here is the relevant openssl documentation: https://docs.openssl.org/master/man3/SSL_CTX_set_verify/. Also, here are the wind...

X Description: This avoids rejecting certificates that should be accepted, see #80192. Here is the relevant openssl documentation: https://docs.openssl.org/master/man3/SSL_CTX_set_verify/. Also, here are the wind...

Opengraph URL: https://github.com/python/cpython/pull/127622

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:25919320-4025-cb9a-6771-9101f663ce67
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD7C2:158720:111EEC:18FC64:6A58A6FA
html-safe-nonce0bc4bf621331bb0fc736f75da36ff73b00f1fc10de42253269ae8fe2eef31566
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0MyOjE1ODcyMDoxMTFFRUM6MThGQzY0OjZBNThBNkZBIiwidmlzaXRvcl9pZCI6Ijg1NjUxODYzMzA3OTk2NzkyMjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc70a91743bfa3eb8968ba049ea372f832304bc029cefc06f7a4b1982e36e2d6e
hovercard-subject-tagpull_request:2216465275
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/127622/files
twitter:imagehttps://avatars.githubusercontent.com/u/41230637?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/41230637?s=400&v=4
og:image:altThis avoids rejecting certificates that should be accepted, see #80192. Here is the relevant openssl documentation: https://docs.openssl.org/master/man3/SSL_CTX_set_verify/. Also, here are the wind...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/127622/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F127622%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F127622%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/127622/files
Reloadhttps://github.com/python/cpython/pull/127622/files
Reloadhttps://github.com/python/cpython/pull/127622/files
Please reload this pagehttps://github.com/python/cpython/pull/127622/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/127622/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
tobil4skhttps://github.com/tobil4sk
python:mainhttps://github.com/python/cpython/tree/main
tobil4sk:fix/ssl-cert-windowshttps://github.com/tobil4sk/cpython/tree/fix/ssl-cert-windows
Conversation 28 https://github.com/python/cpython/pull/127622
Commits 6 https://github.com/python/cpython/pull/127622/commits
Checks 0 https://github.com/python/cpython/pull/127622/checks
Files changed https://github.com/python/cpython/pull/127622/files
Please reload this pagehttps://github.com/python/cpython/pull/127622/files
gh-80192: Use windows api if ssl cert verification fails https://github.com/python/cpython/pull/127622/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/127622/files
9d28198 Use windows api if ssl cert verification fails tobil4sk Dec 5, 2024 https://github.com/python/cpython/pull/127622/commits/9d281987456f9c120b6171ebc316fa41cf60bf60
d3da5df Use const where appropriate tobil4sk Dec 5, 2024 https://github.com/python/cpython/pull/127622/commits/d3da5df46d52bb7be79af71c1cb2458b20eb3274
b8f5bd5 Refactor error translation into separate function tobil4sk Dec 5, 2024 https://github.com/python/cpython/pull/127622/commits/b8f5bd5211ce6b835c56ede7752b01c2d5e7f54c
c9ad0a3 Fix PEP 7 violations tobil4sk Dec 5, 2024 https://github.com/python/cpython/pull/127622/commits/c9ad0a362f549050e1296a8fa05fab390b8e94d4
80b21bd Add reference to news entry tobil4sk Dec 5, 2024 https://github.com/python/cpython/pull/127622/commits/80b21bdd8309e6bc01c10fa8eb4ac7f3dbf05426
2435d4d Fix error translation resulting in test fail tobil4sk Dec 5, 2024 https://github.com/python/cpython/pull/127622/commits/2435d4d6e408debb55b794df88bee42230096317
Clear filters https://github.com/python/cpython/pull/127622/files
Please reload this pagehttps://github.com/python/cpython/pull/127622/files
Please reload this pagehttps://github.com/python/cpython/pull/127622/files
2024-12-05-00-21-11.gh-issue-80192.28PTj4.rst https://github.com/python/cpython/pull/127622/files#diff-2f1226ad52e6018616c7c7d3ba6b3db233c74806582a0c6c352da7c8cb8e8c15
_ssl.c https://github.com/python/cpython/pull/127622/files#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
Misc/NEWS.d/next/Windows/2024-12-05-00-21-11.gh-issue-80192.28PTj4.rsthttps://github.com/python/cpython/pull/127622/files#diff-2f1226ad52e6018616c7c7d3ba6b3db233c74806582a0c6c352da7c8cb8e8c15
View file https://github.com/tobil4sk/cpython/blob/2435d4d6e408debb55b794df88bee42230096317/Misc/NEWS.d/next/Windows/2024-12-05-00-21-11.gh-issue-80192.28PTj4.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127622/{{ revealButtonHref }}
zoobahttps://github.com/zooba
Mar 7, 2025https://github.com/python/cpython/pull/127622/files#r1984887967
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/127622/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L397
Modules/_ssl.chttps://github.com/python/cpython/pull/127622/files#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
View file https://github.com/tobil4sk/cpython/blob/2435d4d6e408debb55b794df88bee42230096317/Modules/_ssl.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127622/{{ revealButtonHref }}
https://github.com/python/cpython/pull/127622/files#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
ZeroIntensityhttps://github.com/ZeroIntensity
Dec 5, 2024https://github.com/python/cpython/pull/127622/files#r1871618976
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/127622/files
tobil4skhttps://github.com/tobil4sk
Dec 5, 2024https://github.com/python/cpython/pull/127622/files#r1871792306
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/127622/files
ZeroIntensityhttps://github.com/ZeroIntensity
Dec 5, 2024https://github.com/python/cpython/pull/127622/files#r1871901048
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/127622/files
Please reload this pagehttps://github.com/python/cpython/pull/127622/files
https://github.com/python/cpython/pull/127622/files#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
https://github.com/python/cpython/pull/127622/files#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
https://github.com/python/cpython/pull/127622/files#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.