Title: gh-127257: ssl: Raise OSError for ERR_LIB_SYS by encukou · Pull Request #127361 · python/cpython · GitHub
Open Graph Title: gh-127257: ssl: Raise OSError for ERR_LIB_SYS by encukou · Pull Request #127361 · python/cpython
X Title: gh-127257: ssl: Raise OSError for ERR_LIB_SYS by encukou · Pull Request #127361 · python/cpython
Description: One way OpenSSL can report a failed syscall is SSL_ERROR_SYSCALL. We have that one covered. But, another way is ERR_LIB_SYS. Apparently, it's being used more now, and causing issues on OpenSSL 3.4.0 on Arch buildbots. From the ERR_raise manpage: ERR_LIB_SYS This "library code" indicates that a system error is being reported. In this case, the reason code given to `ERR_raise()` and `ERR_raise_data()` *must* be `errno(3)`. This PR only handles ERR_LIB_SYS for the high-lever error types SSL_ERROR_SYSCALL and SSL_ERROR_SSL, i.e., not the ones where OpenSSL indicates it has some more information about the issue. I believe it's correct to raise OSError rather that SSLError in these cases. That makes this a backwards-incompatible change (but one we still might want to backport as a bugfix). The error on Arch with OpenSSL 3.4.0 is broken pipe (EPIPE) when a client reads after the server shuts down. On my Arch, raising OSError makes test_poplip pass. Issue: gh-127257
Open Graph Description: One way OpenSSL can report a failed syscall is SSL_ERROR_SYSCALL. We have that one covered. But, another way is ERR_LIB_SYS. Apparently, it's being used more now, and causing issues on OpenSSL ...
X Description: One way OpenSSL can report a failed syscall is SSL_ERROR_SYSCALL. We have that one covered. But, another way is ERR_LIB_SYS. Apparently, it's being used more now, and causing issues on Open...
Opengraph URL: https://github.com/python/cpython/pull/127361
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:2f48b575-dcad-7895-279d-302187923b62 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C9D2:E786A:568B2C:78769E:6A57BF80 |
| html-safe-nonce | 5576a287acb1a940e9093b7c523cd8f5151bfedfd943ede647407dea8464a7b3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUQyOkU3ODZBOjU2OEIyQzo3ODc2OUU6NkE1N0JGODAiLCJ2aXNpdG9yX2lkIjoiMzc0Mzg3NTYzNjI3NTI4MDY0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 989c6178bf6053e7d3c1ae46cfcb9bf121656058f164da73730da12f92c52176 |
| hovercard-subject-tag | pull_request:2205744732 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/127361/files |
| twitter:image | https://avatars.githubusercontent.com/u/302922?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/302922?s=400&v=4 |
| og:image:alt | One way OpenSSL can report a failed syscall is SSL_ERROR_SYSCALL. We have that one covered. But, another way is ERR_LIB_SYS. Apparently, it's being used more now, and causing issues on OpenSSL ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5bf9f84655de1d0e9aa064cd3b2bc9703556c68ae53b94e21b872b7e9f1f7cc1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9e5a4d2583d61726264f5ec9440b26ec7a94eb3f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width