René's URL Explorer Experiment


Title: gh-127298: When in FIPS mode ensure builtin hashes check for usedforsecurity=False by xnox · Pull Request #127301 · python/cpython · GitHub

Open Graph Title: gh-127298: When in FIPS mode ensure builtin hashes check for usedforsecurity=False by xnox · Pull Request #127301 · python/cpython

X Title: gh-127298: When in FIPS mode ensure builtin hashes check for usedforsecurity=False by xnox · Pull Request #127301 · python/cpython

Description: When _hashlib/OpenSSL is available, and OpenSSL is in FIPS mode, ensure that builtin (fallback) hash implementations are wrapped with a check for usedforsecurity=False. It is likely that buitin implementations are FIPS unapproved (either algorithm disallowed; or the implementation not certified by NIST). This enables strict approved-only compliance when usedforsecurity=True on FIPS systems only. And yet it also enables fallback access with usedforsecurity=False for any missing (historical, disallowed or missing certified implementation) algorithms (i.e. blake2, md5, shake/sha3) depending on the runtime configuration of OpenSSL. Issue: gh-127298

Open Graph Description: When _hashlib/OpenSSL is available, and OpenSSL is in FIPS mode, ensure that builtin (fallback) hash implementations are wrapped with a check for usedforsecurity=False. It is likely that buitin imp...

X Description: When _hashlib/OpenSSL is available, and OpenSSL is in FIPS mode, ensure that builtin (fallback) hash implementations are wrapped with a check for usedforsecurity=False. It is likely that buitin imp...

Opengraph URL: https://github.com/python/cpython/pull/127301

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7fd9d0c2-07e4-8f9b-9b7d-b28c7af6b136
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE84:34CBCC:62BE7B:84E38E:6969DDFF
html-safe-nonce0d18a6e1a1d40619be6b8af930834c5a9acc1d12140899f7e9549c1353879476
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTg0OjM0Q0JDQzo2MkJFN0I6ODRFMzhFOjY5NjlEREZGIiwidmlzaXRvcl9pZCI6Ijc2OTg0NDQ5MzUyNjU2Mzk5MzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac73b59de69039bf028be698010eaab864fe1a4eba796bc1526c2b775a259ae1a8
hovercard-subject-tagpull_request:2201524065
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/127301/files
twitter:imagehttps://avatars.githubusercontent.com/u/19779?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/19779?s=400&v=4
og:image:altWhen _hashlib/OpenSSL is available, and OpenSSL is in FIPS mode, ensure that builtin (fallback) hash implementations are wrapped with a check for usedforsecurity=False. It is likely that buitin imp...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/127301/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F127301%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F127301%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/127301/files
Reloadhttps://github.com/python/cpython/pull/127301/files
Reloadhttps://github.com/python/cpython/pull/127301/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/127301/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/127301/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
xnoxhttps://github.com/xnox
python:mainhttps://github.com/python/cpython/tree/main
xnox:hashlib-builtin-fips-checkhttps://github.com/xnox/cpython/tree/hashlib-builtin-fips-check
Conversation 25 https://github.com/python/cpython/pull/127301
Commits 13 https://github.com/python/cpython/pull/127301/commits
Checks 41 https://github.com/python/cpython/pull/127301/checks
Files changed https://github.com/python/cpython/pull/127301/files
Please reload this pagehttps://github.com/python/cpython/pull/127301/files
gh-127298: When in FIPS mode ensure builtin hashes check for usedforsecurity=False https://github.com/python/cpython/pull/127301/files#top
Show all changes 13 commits https://github.com/python/cpython/pull/127301/files
21b30a1 gh-127298: When in FIPS mode ensure builtin hashes check for usedfors… xnox Nov 26, 2024 https://github.com/python/cpython/pull/127301/commits/21b30a1d6fa394dc81c2d70686c4acd6cb37934f
42b912a use != 0 rather than == 1 and update a comment. gpshead Nov 27, 2024 https://github.com/python/cpython/pull/127301/commits/42b912a0477c721969261ce9c5e99ac4ab3988b9
ac9dc6d Update the NEWS to reflect reality. gpshead Nov 27, 2024 https://github.com/python/cpython/pull/127301/commits/ac9dc6d18da3ecd35c6681ac2b9868cbf5519361
4da9f77 address _some_ correctness details in the test. gpshead Nov 27, 2024 https://github.com/python/cpython/pull/127301/commits/4da9f775aea3b9553e7a44e55c54183ad73f7f02
7a954ff avoid repeated calls, reword comment. gpshead Nov 27, 2024 https://github.com/python/cpython/pull/127301/commits/7a954ff0b5b87a65c19bab6c30bcc9c7544972d5
461920d Update 2024-11-26-16-31-40.gh-issue-127298.jqYJvn.rst gpshead Nov 27, 2024 https://github.com/python/cpython/pull/127301/commits/461920d149bf7d8919596c60c8e054f02611e07f
dabed52 avoid rerunning test in refleak hunting mode. gpshead Nov 27, 2024 https://github.com/python/cpython/pull/127301/commits/dabed52d66bfea3a89fe37ae741c2027b142c20a
57241db Change to spawn _test_hashlib_fips from test_hashlib with an env. gpshead Nov 27, 2024 https://github.com/python/cpython/pull/127301/commits/57241dbb2bd9bb74d36827f53e555e202cc42b4d
3910723 Use subTest to id the algorithm. gpshead Nov 27, 2024 https://github.com/python/cpython/pull/127301/commits/3910723fde6bd4edc161925b5943c146c77ff4c5
e8ef380 lint gpshead Nov 27, 2024 https://github.com/python/cpython/pull/127301/commits/e8ef3806238540dc8966061eb6bbe54d31d669e2
3db1eb5 remove the no longer appropriate mention from ssltests. gpshead Nov 27, 2024 https://github.com/python/cpython/pull/127301/commits/3db1eb5ae6d2350f8d3bccdd19e216e1b92c1a61
4e5dddb fix subTest context manager nesting. gpshead Nov 27, 2024 https://github.com/python/cpython/pull/127301/commits/4e5dddb3c1d458d2422e7fd0d569ed36ed48ceac
fd308b4 Use null provider, which is guaranteed to have nothing xnox Sep 8, 2025 https://github.com/python/cpython/pull/127301/commits/fd308b4764902f2bbb21f0ee3096dbb477a639db
Clear filters https://github.com/python/cpython/pull/127301/files
Please reload this pagehttps://github.com/python/cpython/pull/127301/files
Please reload this pagehttps://github.com/python/cpython/pull/127301/files
hashlib.py https://github.com/python/cpython/pull/127301/files#diff-7b5c7281635ea9d475e73fab120a94e42f591eae502af924184140acab4cc189
_test_hashlib_fips.py https://github.com/python/cpython/pull/127301/files#diff-0795a98ffa29db7ca54b89364d0becd7c7f540901c9bca9373467eba0051d80b
openssl.cnf https://github.com/python/cpython/pull/127301/files#diff-fe2bbeb7d88d1da58cdc5e6e1cc3562367e0fee6c90e62c705fb9f1bac8a66f8
script_helper.py https://github.com/python/cpython/pull/127301/files#diff-ab537d38e290ab1e31c5f9dc71ceadec8f26de787bac9c3143d3528b482d2156
test_hashlib.py https://github.com/python/cpython/pull/127301/files#diff-b19facaf857653d4f07afbb090181f595ef4c9381f2abcd2917abd4f3529e8fe
Makefile.pre.in https://github.com/python/cpython/pull/127301/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
2024-11-26-16-31-40.gh-issue-127298.jqYJvn.rst https://github.com/python/cpython/pull/127301/files#diff-44afd0145887504c84f5131f37ed1ef74465e299eb09e939d5681b97f4813ffd
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L384
Lib/hashlib.pyhttps://github.com/python/cpython/pull/127301/files#diff-7b5c7281635ea9d475e73fab120a94e42f591eae502af924184140acab4cc189
View file https://github.com/python/cpython/blob/fd308b4764902f2bbb21f0ee3096dbb477a639db/Lib/hashlib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127301/{{ revealButtonHref }}
https://github.com/python/cpython/pull/127301/files#diff-7b5c7281635ea9d475e73fab120a94e42f591eae502af924184140acab4cc189
https://github.com/python/cpython/pull/127301/files#diff-7b5c7281635ea9d475e73fab120a94e42f591eae502af924184140acab4cc189
https://github.com/python/cpython/pull/127301/files#diff-7b5c7281635ea9d475e73fab120a94e42f591eae502af924184140acab4cc189
https://github.com/python/cpython/pull/127301/files#diff-7b5c7281635ea9d475e73fab120a94e42f591eae502af924184140acab4cc189
https://github.com/python/cpython/pull/127301/files#diff-7b5c7281635ea9d475e73fab120a94e42f591eae502af924184140acab4cc189
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L384
Lib/test/_test_hashlib_fips.pyhttps://github.com/python/cpython/pull/127301/files#diff-0795a98ffa29db7ca54b89364d0becd7c7f540901c9bca9373467eba0051d80b
View file https://github.com/python/cpython/blob/fd308b4764902f2bbb21f0ee3096dbb477a639db/Lib/test/_test_hashlib_fips.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127301/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L387
Lib/test/hashlibdata/openssl.cnfhttps://github.com/python/cpython/pull/127301/files#diff-fe2bbeb7d88d1da58cdc5e6e1cc3562367e0fee6c90e62c705fb9f1bac8a66f8
View file https://github.com/python/cpython/blob/fd308b4764902f2bbb21f0ee3096dbb477a639db/Lib/test/hashlibdata/openssl.cnf
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127301/{{ revealButtonHref }}
Lib/test/support/script_helper.pyhttps://github.com/python/cpython/pull/127301/files#diff-ab537d38e290ab1e31c5f9dc71ceadec8f26de787bac9c3143d3528b482d2156
View file https://github.com/python/cpython/blob/fd308b4764902f2bbb21f0ee3096dbb477a639db/Lib/test/support/script_helper.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127301/{{ revealButtonHref }}
https://github.com/python/cpython/pull/127301/files#diff-ab537d38e290ab1e31c5f9dc71ceadec8f26de787bac9c3143d3528b482d2156
https://github.com/python/cpython/pull/127301/files#diff-ab537d38e290ab1e31c5f9dc71ceadec8f26de787bac9c3143d3528b482d2156
https://github.com/python/cpython/pull/127301/files#diff-ab537d38e290ab1e31c5f9dc71ceadec8f26de787bac9c3143d3528b482d2156
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L384
Lib/test/test_hashlib.pyhttps://github.com/python/cpython/pull/127301/files#diff-b19facaf857653d4f07afbb090181f595ef4c9381f2abcd2917abd4f3529e8fe
View file https://github.com/python/cpython/blob/fd308b4764902f2bbb21f0ee3096dbb477a639db/Lib/test/test_hashlib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127301/{{ revealButtonHref }}
https://github.com/python/cpython/pull/127301/files#diff-b19facaf857653d4f07afbb090181f595ef4c9381f2abcd2917abd4f3529e8fe
https://github.com/python/cpython/pull/127301/files#diff-b19facaf857653d4f07afbb090181f595ef4c9381f2abcd2917abd4f3529e8fe
https://github.com/python/cpython/pull/127301/files#diff-b19facaf857653d4f07afbb090181f595ef4c9381f2abcd2917abd4f3529e8fe
https://github.com/python/cpython/actions/runs/17536172343/job/49799771145?pr=127301
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L84
Makefile.pre.inhttps://github.com/python/cpython/pull/127301/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
View file https://github.com/python/cpython/blob/fd308b4764902f2bbb21f0ee3096dbb477a639db/Makefile.pre.in
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127301/{{ revealButtonHref }}
https://github.com/python/cpython/pull/127301/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
https://github.com/python/cpython/pull/127301/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
Misc/NEWS.d/next/Library/2024-11-26-16-31-40.gh-issue-127298.jqYJvn.rsthttps://github.com/python/cpython/pull/127301/files#diff-44afd0145887504c84f5131f37ed1ef74465e299eb09e939d5681b97f4813ffd
View file https://github.com/python/cpython/blob/fd308b4764902f2bbb21f0ee3096dbb477a639db/Misc/NEWS.d/next/Library/2024-11-26-16-31-40.gh-issue-127298.jqYJvn.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127301/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/127301/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.