René's URL Explorer Experiment


Title: gh-127124: Pass optional state to context watcher callback by rhansen · Pull Request #127140 · python/cpython · GitHub

Open Graph Title: gh-127124: Pass optional state to context watcher callback by rhansen · Pull Request #127140 · python/cpython

X Title: gh-127124: Pass optional state to context watcher callback by rhansen · Pull Request #127140 · python/cpython

Description: This enables users to associate state with the callback without relying on globals. Also: Refactor the tests for improved readability and extensibility, and to cover the new state object. Drop the pointer from the PyContext_WatchCallback typedef. This de-obfuscates the fact that pointers are involved, and makes it possible to forward-declare functions to improve readability: static PyContext_WatchCallback my_callback; int my_callback(PyObject *cbarg, PyContextEvent event, PyObject *obj) { ... } This will conflict with #124741; if one is merged I'll rebase the other. Issue: gh-127124 📚 Documentation preview 📚: https://cpython-previews--127140.org.readthedocs.build/

Open Graph Description: This enables users to associate state with the callback without relying on globals. Also: Refactor the tests for improved readability and extensibility, and to cover the new state object. Drop ...

X Description: This enables users to associate state with the callback without relying on globals. Also: Refactor the tests for improved readability and extensibility, and to cover the new state object. Drop ...

Opengraph URL: https://github.com/python/cpython/pull/127140

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2d943bb6-626d-c2b5-787c-570d5bde9732
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD5A8:187983:44398E:598D7C:6B023B3B
html-safe-nonce092c01c2b122edf8c96d7958c5eedf47cd0b6d9671932bbe2d161d63fa88477d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUE4OjE4Nzk4Mzo0NDM5OEU6NTk4RDdDOjZCMDIzQjNCIiwidmlzaXRvcl9pZCI6IjQ3Mzg2OTgxNDE3MTk3MzkxOTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccd598d3e605afd33c40d08cd8f2a18d7800644565f78b2c699fadcaafab24f5b
hovercard-subject-tagpull_request:2194056685
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/127140/files
twitter:imagehttps://avatars.githubusercontent.com/u/1612291?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1612291?s=400&v=4
og:image:altThis enables users to associate state with the callback without relying on globals. Also: Refactor the tests for improved readability and extensibility, and to cover the new state object. Drop ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/127140/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F127140%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F127140%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/127140/files
Reloadhttps://github.com/python/cpython/pull/127140/files
Reloadhttps://github.com/python/cpython/pull/127140/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
rhansenhttps://github.com/rhansen
python:mainhttps://github.com/python/cpython/tree/main
rhansen:gh-127124-context-watcher-opaque-statehttps://github.com/rhansen/cpython/tree/gh-127124-context-watcher-opaque-state
Conversation 7 https://github.com/python/cpython/pull/127140
Commits 3 https://github.com/python/cpython/pull/127140/commits
Checks 0 https://github.com/python/cpython/pull/127140/checks
Files changed https://github.com/python/cpython/pull/127140/files
Please reload this pagehttps://github.com/python/cpython/pull/127140/files
gh-127124: Pass optional state to context watcher callback https://github.com/python/cpython/pull/127140/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/127140/files
c9e95d4 gh-127124: Pass optional state to context watcher callback rhansen Nov 22, 2024 https://github.com/python/cpython/pull/127140/commits/c9e95d40c9c15194b04b098e846fe2b9eae922ea
133e00c fixup! gh-127124: Pass optional state to context watcher callback rhansen Nov 25, 2024 https://github.com/python/cpython/pull/127140/commits/133e00c08d488b297eb30f9833b2569cb08cd2d3
3e28b5f fixup! gh-127124: Change context watcher callback to a callable object rhansen Nov 26, 2024 https://github.com/python/cpython/pull/127140/commits/3e28b5fa6af7add4676339119612fceba0598741
Clear filters https://github.com/python/cpython/pull/127140/files
Please reload this pagehttps://github.com/python/cpython/pull/127140/files
Please reload this pagehttps://github.com/python/cpython/pull/127140/files
contextvars.rst https://github.com/python/cpython/pull/127140/files#diff-dcba959f99b35e4934a2cd76dfadf4e3387e455b7e717691e71ae94edd838538
context.h https://github.com/python/cpython/pull/127140/files#diff-2c91c78b4215de3e077f4057086cf3ed5de8e29ef0ba9553fdccae4846aedd6a
pycore_interp.h https://github.com/python/cpython/pull/127140/files#diff-cb06b7ba43789a1d6ae5bef46baa8a255b72dbcd2b44bfec7f146ea4e94dbfa0
test_watchers.py https://github.com/python/cpython/pull/127140/files#diff-f13cecf74c62d3b381dfd239e6e1c1c18e83e809b9c3dcb20237d1a8d27c439c
2024-11-22-18-38-33.gh-issue-127124.6k6Qj7.rst https://github.com/python/cpython/pull/127140/files#diff-626bfd705a4c52acba5cc14ad26d9b15b4b5048177817710d7a510d4b9a01c91
watchers.c.h https://github.com/python/cpython/pull/127140/files#diff-4fd62ac4ed272f5a569daeda5d5a1b7d6e2ab9b82ea2fbb1a399d2da32948898
watchers.c https://github.com/python/cpython/pull/127140/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
context.c https://github.com/python/cpython/pull/127140/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
pystate.c https://github.com/python/cpython/pull/127140/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
ignored.tsv https://github.com/python/cpython/pull/127140/files#diff-fa2373a9a002e491408e623369773045f4b7de90114b9f5ba6933bfbf2d8c45c
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L235
Doc/c-api/contextvars.rsthttps://github.com/python/cpython/pull/127140/files#diff-dcba959f99b35e4934a2cd76dfadf4e3387e455b7e717691e71ae94edd838538
View file https://github.com/python/cpython/blob/3e28b5fa6af7add4676339119612fceba0598741/Doc/c-api/contextvars.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127140/{{ revealButtonHref }}
https://github.com/python/cpython/pull/127140/files#diff-dcba959f99b35e4934a2cd76dfadf4e3387e455b7e717691e71ae94edd838538
https://github.com/python/cpython/pull/127140/files#diff-dcba959f99b35e4934a2cd76dfadf4e3387e455b7e717691e71ae94edd838538
https://github.com/python/cpython/pull/127140/files#diff-dcba959f99b35e4934a2cd76dfadf4e3387e455b7e717691e71ae94edd838538
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L237
Include/cpython/context.hhttps://github.com/python/cpython/pull/127140/files#diff-2c91c78b4215de3e077f4057086cf3ed5de8e29ef0ba9553fdccae4846aedd6a
View file https://github.com/python/cpython/blob/3e28b5fa6af7add4676339119612fceba0598741/Include/cpython/context.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127140/{{ revealButtonHref }}
https://github.com/python/cpython/pull/127140/files#diff-2c91c78b4215de3e077f4057086cf3ed5de8e29ef0ba9553fdccae4846aedd6a
https://github.com/python/cpython/pull/127140/files#diff-2c91c78b4215de3e077f4057086cf3ed5de8e29ef0ba9553fdccae4846aedd6a
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L325
Include/internal/pycore_interp.hhttps://github.com/python/cpython/pull/127140/files#diff-cb06b7ba43789a1d6ae5bef46baa8a255b72dbcd2b44bfec7f146ea4e94dbfa0
View file https://github.com/python/cpython/blob/3e28b5fa6af7add4676339119612fceba0598741/Include/internal/pycore_interp.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127140/{{ revealButtonHref }}
https://github.com/python/cpython/pull/127140/files#diff-cb06b7ba43789a1d6ae5bef46baa8a255b72dbcd2b44bfec7f146ea4e94dbfa0
rhansenhttps://github.com/rhansen
Nov 24, 2024https://github.com/python/cpython/pull/127140/files#r1855395895
Please reload this pagehttps://github.com/python/cpython/pull/127140/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/127140/files
https://github.com/python/cpython/pull/127140/files#diff-cb06b7ba43789a1d6ae5bef46baa8a255b72dbcd2b44bfec7f146ea4e94dbfa0
Lib/test/test_capi/test_watchers.pyhttps://github.com/python/cpython/pull/127140/files#diff-f13cecf74c62d3b381dfd239e6e1c1c18e83e809b9c3dcb20237d1a8d27c439c
View file https://github.com/python/cpython/blob/3e28b5fa6af7add4676339119612fceba0598741/Lib/test/test_capi/test_watchers.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127140/{{ revealButtonHref }}
https://github.com/python/cpython/pull/127140/files#diff-f13cecf74c62d3b381dfd239e6e1c1c18e83e809b9c3dcb20237d1a8d27c439c
https://github.com/python/cpython/pull/127140/files#diff-f13cecf74c62d3b381dfd239e6e1c1c18e83e809b9c3dcb20237d1a8d27c439c
https://github.com/python/cpython/pull/127140/files#diff-f13cecf74c62d3b381dfd239e6e1c1c18e83e809b9c3dcb20237d1a8d27c439c
https://github.com/python/cpython/pull/127140/files#diff-f13cecf74c62d3b381dfd239e6e1c1c18e83e809b9c3dcb20237d1a8d27c439c
Misc/NEWS.d/next/C_API/2024-11-22-18-38-33.gh-issue-127124.6k6Qj7.rsthttps://github.com/python/cpython/pull/127140/files#diff-626bfd705a4c52acba5cc14ad26d9b15b4b5048177817710d7a510d4b9a01c91
View file https://github.com/python/cpython/blob/3e28b5fa6af7add4676339119612fceba0598741/Misc/NEWS.d/next/C_API/2024-11-22-18-38-33.gh-issue-127124.6k6Qj7.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/127140/{{ revealButtonHref }}
Modules/_testcapi/clinic/watchers.c.hhttps://github.com/python/cpython/pull/127140/files#diff-4fd62ac4ed272f5a569daeda5d5a1b7d6e2ab9b82ea2fbb1a399d2da32948898
View file https://github.com/python/cpython/blob/3e28b5fa6af7add4676339119612fceba0598741/Modules/_testcapi/clinic/watchers.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/127140/files
Please reload this pagehttps://github.com/python/cpython/pull/127140/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.