René's URL Explorer Experiment


Title: GH-127090: Fix `urllib.response.addinfourl.url` value for opened `file:` URIs by barneygale · Pull Request #127091 · python/cpython · GitHub

Open Graph Title: GH-127090: Fix `urllib.response.addinfourl.url` value for opened `file:` URIs by barneygale · Pull Request #127091 · python/cpython

X Title: GH-127090: Fix `urllib.response.addinfourl.url` value for opened `file:` URIs by barneygale · Pull Request #127091 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: The canonical file: URL (as generated by pathname2url()) is now used as the url attribute of the returned addinfourl object. The addinfourl.url attribute reflects the resolved URL for both file: or...

X Description: The canonical file: URL (as generated by pathname2url()) is now used as the url attribute of the returned addinfourl object. The addinfourl.url attribute reflects the resolved URL for both file: or...

Opengraph URL: https://github.com/python/cpython/pull/127091

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:46275c5d-64dc-3741-1c0c-1e1c023d49fc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCEEA:2E9831:230F6CB:2E1D3AE:6B024B2B
html-safe-nonce95f2e78adc7b59efb1e92248aa1fca24285e6ac0e9965585f37609b670913852
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUVBOjJFOTgzMToyMzBGNkNCOjJFMUQzQUU6NkIwMjRCMkIiLCJ2aXNpdG9yX2lkIjoiMzQxMzc0NjIzMTc4NzI3NzA5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac57b338998c12d2281fe7876cc44e9b88864a8cfe04180be2fafede89a02917c8
hovercard-subject-tagpull_request:2191388504
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/127091/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/da19653b59660aac8a6a12a989fe949ad5eff3b79f6b7791499893c2a375cd0f/python/cpython/pull/127091
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/da19653b59660aac8a6a12a989fe949ad5eff3b79f6b7791499893c2a375cd0f/python/cpython/pull/127091
og:image:altThe canonical file: URL (as generated by pathname2url()) is now used as the url attribute of the returned addinfourl object. The addinfourl.url attribute reflects the resolved URL for both file: or...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebarneygale
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/127091#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F127091
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F127091
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/127091
Reloadhttps://github.com/python/cpython/pull/127091
Reloadhttps://github.com/python/cpython/pull/127091
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
barneygalehttps://github.com/barneygale
python:mainhttps://github.com/python/cpython/tree/main
barneygale:gh-127090https://github.com/barneygale/cpython/tree/gh-127090
Conversationhttps://github.com/python/cpython/pull/127091
Commits8 (8)https://github.com/python/cpython/pull/127091/commits
Checkshttps://github.com/python/cpython/pull/127091/checks
Files changedhttps://github.com/python/cpython/pull/127091/files
GH-127090: Fix urllib.response.addinfourl.url value for opened file: URIshttps://github.com/python/cpython/pull/127091#top
barneygalehttps://github.com/barneygale
python:mainhttps://github.com/python/cpython/tree/main
barneygale:gh-127090https://github.com/barneygale/cpython/tree/gh-127090
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Nov 21, 2024https://github.com/python/cpython/pull/127091#issue-2678164419
Please reload this pagehttps://github.com/python/cpython/pull/127091
urllib.request.urlopen('file:...').url incorrect value #127090https://github.com/python/cpython/issues/127090
Please reload this pagehttps://github.com/python/cpython/pull/127091
https://github.com/barneygale
pythonGH-127090https://github.com/python/cpython/issues/127090
: Fixhttps://github.com/python/cpython/pull/127091/commits/9c6c31308616a144bba295c245606c81a165d27b
urllib.request.addinfourl.urlhttps://github.com/python/cpython/pull/127091/commits/9c6c31308616a144bba295c245606c81a165d27b
forhttps://github.com/python/cpython/pull/127091/commits/9c6c31308616a144bba295c245606c81a165d27b
file:https://github.com/python/cpython/pull/127091/commits/9c6c31308616a144bba295c245606c81a165d27b
URIshttps://github.com/python/cpython/pull/127091/commits/9c6c31308616a144bba295c245606c81a165d27b
9c6c313https://github.com/python/cpython/pull/127091/commits/9c6c31308616a144bba295c245606c81a165d27b
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 21, 2024 https://github.com/python/cpython/pull/127091#ref-issue-2678138415
urllib.request.urlopen('file:...').url incorrect value #127090 https://github.com/python/cpython/issues/127090
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Nov 21, 2024https://github.com/python/cpython/pull/127091#event-15376453597
https://github.com/barneygale
Fix news blurbhttps://github.com/python/cpython/pull/127091/commits/ab171a39ed16d126fa3bf65e2c2384a0202e06b9
ab171a3https://github.com/python/cpython/pull/127091/commits/ab171a39ed16d126fa3bf65e2c2384a0202e06b9
https://github.com/barneygale
barneygalehttps://github.com/barneygale
November 21, 2024 06:29https://github.com/python/cpython/pull/127091#event-15376556978
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 21, 2024https://github.com/python/cpython/pull/127091#event-15376557356
https://github.com/barneygale
barneygalehttps://github.com/barneygale
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Nov 21, 2024https://github.com/python/cpython/pull/127091#event-15376559048
https://github.com/barneygale
barneygalehttps://github.com/barneygale
serhiy-storchakahttps://github.com/serhiy-storchaka
November 21, 2024 20:24https://github.com/python/cpython/pull/127091#event-15387996595
https://github.com/barneygale
Merge branch 'main' intohttps://github.com/python/cpython/pull/127091/commits/2fbe4319e30326a637a6beda1cea5621a74d15fe
pythongh-127090https://github.com/python/cpython/issues/127090
2fbe431https://github.com/python/cpython/pull/127091/commits/2fbe4319e30326a637a6beda1cea5621a74d15fe
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Nov 22, 2024 https://github.com/python/cpython/pull/127091#pullrequestreview-2454477837
View reviewed changes https://github.com/python/cpython/pull/127091/files/2fbe4319e30326a637a6beda1cea5621a74d15fe
serhiy-storchakahttps://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/127091#pullrequestreview-2454477837
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/127091
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Nov 22, 2024 https://github.com/python/cpython/pull/127091#pullrequestreview-2454530187
View reviewed changes https://github.com/python/cpython/pull/127091/files/2fbe4319e30326a637a6beda1cea5621a74d15fe
serhiy-storchakahttps://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/127091#pullrequestreview-2454530187
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
18e4dd7https://github.com/python/cpython/commit/18e4dd74e06a8d036e46336041a72f3dae52b15c
6057ba1https://github.com/python/cpython/commit/6057ba1f97ea19c484b03d5dd2f431e7767fefd1
bpo-8656https://bugs.python.org/issue?@action=redirect&bpo=8656
gh-52902https://github.com/python/cpython/issues/52902
Please reload this pagehttps://github.com/python/cpython/pull/127091
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Nov 23, 2024https://github.com/python/cpython/pull/127091#issuecomment-2495487590
#127125https://github.com/python/cpython/pull/127125
#127194https://github.com/python/cpython/pull/127194
Please reload this pagehttps://github.com/python/cpython/pull/127091
https://github.com/barneygale
barneygalehttps://github.com/barneygale
November 23, 2024 13:55https://github.com/python/cpython/pull/127091#event-15407814361
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 23, 2024https://github.com/python/cpython/pull/127091#event-15407814432
barneygalehttps://github.com/barneygale
November 25, 2024 20:31https://github.com/python/cpython/pull/127091#commits-pushed-1b490b0
https://github.com/barneygale
Merge branch 'main' intohttps://github.com/python/cpython/pull/127091/commits/1b490b0e7ad75291b34e3c5d38ac7bd1d4f3fba8
pythongh-127090https://github.com/python/cpython/issues/127090
1b490b0https://github.com/python/cpython/pull/127091/commits/1b490b0e7ad75291b34e3c5d38ac7bd1d4f3fba8
https://github.com/barneygale
Use pathname2url() to canonicalise URLhttps://github.com/python/cpython/pull/127091/commits/331bec6f3b13479f0a6557f378d8045abf2612ed
331bec6https://github.com/python/cpython/pull/127091/commits/331bec6f3b13479f0a6557f378d8045abf2612ed
https://github.com/barneygale
barneygalehttps://github.com/barneygale
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Nov 25, 2024https://github.com/python/cpython/pull/127091#event-15426642328
barneygalehttps://github.com/barneygale
November 25, 2024 21:05https://github.com/python/cpython/pull/127091#commits-pushed-74f5a49
https://github.com/barneygale
Fix testshttps://github.com/python/cpython/pull/127091/commits/74f5a491e1dff430f17a3ee573f8a144561fd55f
74f5a49https://github.com/python/cpython/pull/127091/commits/74f5a491e1dff430f17a3ee573f8a144561fd55f
https://github.com/barneygale
Test tweakshttps://github.com/python/cpython/pull/127091/commits/6d7cfdb5fde20f6ff317ab3595d29813543e256b
6d7cfdbhttps://github.com/python/cpython/pull/127091/commits/6d7cfdb5fde20f6ff317ab3595d29813543e256b
https://github.com/barneygale
barneygalehttps://github.com/barneygale
November 25, 2024 21:39https://github.com/python/cpython/pull/127091#event-15427097265
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 25, 2024https://github.com/python/cpython/pull/127091#event-15427097689
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Nov 25, 2024https://github.com/python/cpython/pull/127091#issuecomment-2499125094
Please reload this pagehttps://github.com/python/cpython/pull/127091
Please reload this pagehttps://github.com/python/cpython/pull/127091
https://github.com/barneygale
barneygalehttps://github.com/barneygale
serhiy-storchakahttps://github.com/serhiy-storchaka
November 25, 2024 22:02https://github.com/python/cpython/pull/127091#event-15427304080
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Dec 5, 2024 https://github.com/python/cpython/pull/127091#pullrequestreview-2482632883
View reviewed changes https://github.com/python/cpython/pull/127091/files/6d7cfdb5fde20f6ff317ab3595d29813543e256b
Lib/test/test_urllib2.pyhttps://github.com/python/cpython/pull/127091/files/6d7cfdb5fde20f6ff317ab3595d29813543e256b#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
Please reload this pagehttps://github.com/python/cpython/pull/127091
Lib/test/test_urllib2.pyhttps://github.com/python/cpython/pull/127091/files/6d7cfdb5fde20f6ff317ab3595d29813543e256b#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
Please reload this pagehttps://github.com/python/cpython/pull/127091
https://github.com/barneygale
Address review feedbackhttps://github.com/python/cpython/pull/127091/commits/9810737712e2fc7b7a71ee827f617688f690bc0d
9810737https://github.com/python/cpython/pull/127091/commits/9810737712e2fc7b7a71ee827f617688f690bc0d
https://github.com/barneygale
barneygalehttps://github.com/barneygale
serhiy-storchakahttps://github.com/serhiy-storchaka
December 7, 2024 02:20https://github.com/python/cpython/pull/127091#event-15567788708
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Dec 7, 2024 https://github.com/python/cpython/pull/127091#pullrequestreview-2486454360
View reviewed changes https://github.com/python/cpython/pull/127091/files/9810737712e2fc7b7a71ee827f617688f690bc0d
serhiy-storchakahttps://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/127091#pullrequestreview-2486454360
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/127091
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Dec 7, 2024https://github.com/python/cpython/pull/127091#event-15569054902
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Dec 7, 2024https://github.com/python/cpython/pull/127091#event-15569054917
https://github.com/barneygale
barneygalehttps://github.com/barneygale
79b7cabhttps://github.com/python/cpython/commit/79b7cab50a3292a1c01466cf0e69fb7b4e56cfb1
Dec 7, 2024https://github.com/python/cpython/pull/127091#event-15570387904
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Dec 7, 2024https://github.com/python/cpython/pull/127091#event-15570387977
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Dec 8, 2024https://github.com/python/cpython/pull/127091#issuecomment-2525569429
Please reload this pagehttps://github.com/python/cpython/pull/127091
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Dec 8, 2024https://github.com/python/cpython/pull/127091#issuecomment-2525576219
Please reload this pagehttps://github.com/python/cpython/pull/127091
#127090 (comment)https://github.com/python/cpython/issues/127090#issuecomment-2525262927
Please reload this pagehttps://github.com/python/cpython/pull/127091
srinivasreddyhttps://github.com/srinivasreddy
Jan 8, 2025 https://github.com/python/cpython/pull/127091#ref-commit-db1f75c
https://github.com/barneygale
https://github.com/srinivasreddy
pythonGH-127090https://github.com/python/cpython/issues/127090
: Fixhttps://github.com/srinivasreddy/cpython/commit/db1f75ca0fb3cc189eeb9bf294be793cee264ac6
urllib.response.addinfourl.urlhttps://github.com/srinivasreddy/cpython/commit/db1f75ca0fb3cc189eeb9bf294be793cee264ac6
value for opene…https://github.com/srinivasreddy/cpython/commit/db1f75ca0fb3cc189eeb9bf294be793cee264ac6
db1f75chttps://github.com/srinivasreddy/cpython/commit/db1f75ca0fb3cc189eeb9bf294be793cee264ac6
python#127091https://github.com/python/cpython/pull/127091
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F127091
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/127091/files/9810737712e2fc7b7a71ee827f617688f690bc0d
Please reload this pagehttps://github.com/python/cpython/pull/127091
Please reload this pagehttps://github.com/python/cpython/pull/127091
https://github.com/barneygale
https://github.com/serhiy-storchaka
https://github.com/picnixz
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.