| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f8f232ad-e8d7-eb32-fcb4-610d9871e850 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BE74:3E418A:1BFBED6:24B38C0:6B021E97 |
| html-safe-nonce | 0cf3fdc8d663e263772cadb7e561f78ba4ce190160cbe9f558c7e82da92c47db |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTc0OjNFNDE4QToxQkZCRUQ2OjI0QjM4QzA6NkIwMjFFOTciLCJ2aXNpdG9yX2lkIjoiMzU3MzE4MjUzNDU3NTU5NTE1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a3a0b476fce19a2caaa0d8141db6a8070446b87a5fac12634e591c2d07a5745e |
| hovercard-subject-tag | pull_request:2183918855 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/126938/files |
| twitter:image | https://avatars.githubusercontent.com/u/70096546?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/70096546?s=400&v=4 |
| og:image:alt | Used the bit_size_obj as seems to be intended, based on its usage in Lib/ctypes/_layout.py
Tested the change locally informally. Didn't write any tests.
Issue: gh-126937 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/126938/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126938%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126938%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/126938/files |
| Reload | https://github.com/python/cpython/pull/126938/files |
| Reload | https://github.com/python/cpython/pull/126938/files |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| encukou | https://github.com/encukou |
| python:main | https://github.com/python/cpython/tree/main |
| Melissa0x1f992:main | https://github.com/Melissa0x1f992/cpython/tree/main |
|
Conversation
38
| https://github.com/python/cpython/pull/126938 |
|
Commits
20
| https://github.com/python/cpython/pull/126938/commits |
|
Checks
0
| https://github.com/python/cpython/pull/126938/checks |
|
Files changed
| https://github.com/python/cpython/pull/126938/files |
| Please reload this page | https://github.com/python/cpython/pull/126938/files |
|
gh-126937: ctypes: fix TypeError when a field's size is >65535 bytes
| https://github.com/python/cpython/pull/126938/files#top |
|
Show all changes
20 commits
| https://github.com/python/cpython/pull/126938/files |
|
1962567
Fix rejection when non-bitfield fields are larger than 2^16 bytes
Melissa0x1f992 Nov 17, 2024
| https://github.com/python/cpython/pull/126938/commits/1962567aac71c16604a405c060b9a11ec6a82646 |
|
1900cf5
Merge pull request #1 from Melissa0x1f992/use-bitsize-param
Melissa0x1f992 Nov 17, 2024
| https://github.com/python/cpython/pull/126938/commits/1900cf5b4ffa76cb2c0185dda6c8cb930a538834 |
|
2bd972b
📜🤖 Added by blurb_it.
blurb-it[bot] Nov 17, 2024
| https://github.com/python/cpython/pull/126938/commits/2bd972b180e5d750cb5140171b9df35677ecb8f7 |
|
d2954cd
Update Modules/_ctypes/cfield.c
terryjreedy Nov 17, 2024
| https://github.com/python/cpython/pull/126938/commits/d2954cdefdbe3608116c425796b134ff53fd1d60 |
|
0d21229
Remove specific dependency on Python 3.12 for black
Melissa0x1f992 Nov 18, 2024
| https://github.com/python/cpython/pull/126938/commits/0d2122978662f9efc676c22c2c90f0beeda95f30 |
|
d8a6f08
Add test case for large fields
Melissa0x1f992 Nov 18, 2024
| https://github.com/python/cpython/pull/126938/commits/d8a6f080eaaa70a977c8700243a28f492076258d |
|
16bfb44
Merge pull request #2 from Melissa0x1f992/use-bitsize-param
Melissa0x1f992 Nov 18, 2024
| https://github.com/python/cpython/pull/126938/commits/16bfb440f722f69ab5a72a1cfaa93dd540aa233a |
|
7402a8f
Reduce test field size to (2^31 - 1) to support 32 bit systems
Melissa0x1f992 Nov 18, 2024
| https://github.com/python/cpython/pull/126938/commits/7402a8f60767694f2b335a8f855d2cdbdc1df7e2 |
|
8994ad0
Merge branch 'python:main' into main
Melissa0x1f992 Nov 18, 2024
| https://github.com/python/cpython/pull/126938/commits/8994ad041c21f6b450cbc613d29a14f05f7b22ca |
|
db171e0
Reduce test field size to (2^31 - 1) to support 32 bit systems
Melissa0x1f992 Nov 18, 2024
| https://github.com/python/cpython/pull/126938/commits/db171e04a3a6a323e398591b4e235ffc989f15ee |
|
7bc0ceb
Merge pull request #3 from Melissa0x1f992/use-bitsize-param
Melissa0x1f992 Nov 18, 2024
| https://github.com/python/cpython/pull/126938/commits/7bc0cebb10e19004468a28c14aa943b2a7053174 |
|
cd8c011
Merge in the main branch
encukou Dec 4, 2024
| https://github.com/python/cpython/pull/126938/commits/cd8c011684484c557c719a54840789438aee6463 |
|
a3bd171
Remove pre-commit config (moved to #126971)
encukou Dec 4, 2024
| https://github.com/python/cpython/pull/126938/commits/a3bd1714b2873a83a1433288c67da28f9adcc5e7 |
|
5e8aec0
Use PyLong_AsSsize_t to convert to Py_ssize_t
encukou Dec 4, 2024
| https://github.com/python/cpython/pull/126938/commits/5e8aec0419d69a02b179d20412ff4b1719c05662 |
|
7d3bb10
Test maximum field size (sys.maxsize / 8, so we can count bits later)
encukou Dec 4, 2024
| https://github.com/python/cpython/pull/126938/commits/7d3bb107a7376aab67848c05726761bc70d2ad82 |
|
946f261
Rework the asserts.
encukou Dec 4, 2024
| https://github.com/python/cpython/pull/126938/commits/946f26107a913ff77bd39557962d77ca60139e70 |
|
19c1b3b
Test naked c_char as well
encukou Dec 4, 2024
| https://github.com/python/cpython/pull/126938/commits/19c1b3be326fdd2a1b508f7a82e1c45eb5052a9a |
|
dcf97f2
Better name for the test
encukou Dec 4, 2024
| https://github.com/python/cpython/pull/126938/commits/dcf97f2b1c53fce8253e853300dead00eb853443 |
|
03bc32b
Add comment
encukou Dec 4, 2024
| https://github.com/python/cpython/pull/126938/commits/03bc32b33b3d9da23a4cf16a7ffb648b67d277b3 |
|
f61faa6
Reword changelog
encukou Dec 4, 2024
| https://github.com/python/cpython/pull/126938/commits/f61faa680c8f41f4de63408f5880e6493eee0912 |
|
Clear filters
| https://github.com/python/cpython/pull/126938/files |
| Please reload this page | https://github.com/python/cpython/pull/126938/files |
| Please reload this page | https://github.com/python/cpython/pull/126938/files |
|
test_struct_fields.py
| https://github.com/python/cpython/pull/126938/files#diff-6f1a2e3efc217499054a6413e09dd38453c7762b1f65dec32721b1c48bb9df64 |
|
2024-11-17-21-35-55.gh-issue-126937.qluVM0.rst
| https://github.com/python/cpython/pull/126938/files#diff-ebf1a8a40c9201648bc0fcedf589a95a728d2c61a9bc7b057472cb3ac1901c1a |
|
cfield.c
| https://github.com/python/cpython/pull/126938/files#diff-2952ec5c776412a52a7a69a6cf735e480d7454e3862d2b8e02f34c927f600aa1 |
|
stgdict.c
| https://github.com/python/cpython/pull/126938/files#diff-a75c1edda81c7e4ede83ebbd84c2638023c1b91de15b504f574ba7e08b8b0883 |
| Lib/test/test_ctypes/test_struct_fields.py | https://github.com/python/cpython/pull/126938/files#diff-6f1a2e3efc217499054a6413e09dd38453c7762b1f65dec32721b1c48bb9df64 |
|
View file
| https://github.com/Melissa0x1f992/cpython/blob/f61faa680c8f41f4de63408f5880e6493eee0912/Lib/test/test_ctypes/test_struct_fields.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/126938/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/126938/files#diff-6f1a2e3efc217499054a6413e09dd38453c7762b1f65dec32721b1c48bb9df64 |
|
| https://github.com/python/cpython/pull/126938/files#diff-6f1a2e3efc217499054a6413e09dd38453c7762b1f65dec32721b1c48bb9df64 |
|
| https://github.com/python/cpython/pull/126938/files#diff-6f1a2e3efc217499054a6413e09dd38453c7762b1f65dec32721b1c48bb9df64 |
| Misc/NEWS.d/next/Core_and_Builtins/2024-11-17-21-35-55.gh-issue-126937.qluVM0.rst | https://github.com/python/cpython/pull/126938/files#diff-ebf1a8a40c9201648bc0fcedf589a95a728d2c61a9bc7b057472cb3ac1901c1a |
|
View file
| https://github.com/Melissa0x1f992/cpython/blob/f61faa680c8f41f4de63408f5880e6493eee0912/Misc/NEWS.d/next/Core_and_Builtins/2024-11-17-21-35-55.gh-issue-126937.qluVM0.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/126938/{{ revealButtonHref }} |
| Modules/_ctypes/cfield.c | https://github.com/python/cpython/pull/126938/files#diff-2952ec5c776412a52a7a69a6cf735e480d7454e3862d2b8e02f34c927f600aa1 |
|
View file
| https://github.com/Melissa0x1f992/cpython/blob/f61faa680c8f41f4de63408f5880e6493eee0912/Modules/_ctypes/cfield.c |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/126938/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/126938/files#diff-2952ec5c776412a52a7a69a6cf735e480d7454e3862d2b8e02f34c927f600aa1 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Dec 9, 2024 | https://github.com/python/cpython/pull/126938/files#r1875927676 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/126938/files |
| encukou | https://github.com/encukou |
| Dec 9, 2024 | https://github.com/python/cpython/pull/126938/files#r1876046860 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/126938/files |
|
| https://github.com/python/cpython/pull/126938/files#diff-2952ec5c776412a52a7a69a6cf735e480d7454e3862d2b8e02f34c927f600aa1 |
| Modules/_ctypes/stgdict.c | https://github.com/python/cpython/pull/126938/files#diff-a75c1edda81c7e4ede83ebbd84c2638023c1b91de15b504f574ba7e08b8b0883 |
|
View file
| https://github.com/Melissa0x1f992/cpython/blob/f61faa680c8f41f4de63408f5880e6493eee0912/Modules/_ctypes/stgdict.c |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/126938/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/126938/files#diff-a75c1edda81c7e4ede83ebbd84c2638023c1b91de15b504f574ba7e08b8b0883 |
|
| https://github.com/python/cpython/pull/126938/files#diff-a75c1edda81c7e4ede83ebbd84c2638023c1b91de15b504f574ba7e08b8b0883 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Dec 9, 2024 | https://github.com/python/cpython/pull/126938/files#r1875925564 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/126938/files |
| encukou | https://github.com/encukou |
| Dec 9, 2024 | https://github.com/python/cpython/pull/126938/files#r1876046561 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/126938/files |
|
| https://github.com/python/cpython/pull/126938/files#diff-a75c1edda81c7e4ede83ebbd84c2638023c1b91de15b504f574ba7e08b8b0883 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |