René's URL Explorer Experiment


Title: GH-85168: Use filesystem encoding when converting to/from `file` URIs by barneygale · Pull Request #126852 · python/cpython · GitHub

Open Graph Title: GH-85168: Use filesystem encoding when converting to/from `file` URIs by barneygale · Pull Request #126852 · python/cpython

X Title: GH-85168: Use filesystem encoding when converting to/from `file` URIs by barneygale · Pull Request #126852 · python/cpython

Description: Adjust urllib.request.url2pathname() and pathname2url() to use the filesystem encoding when quoting and unquoting file URIs, rather than forcing use of UTF-8. No changes are needed in the nturl2path module because Windows always uses UTF-8, per PEP 529. Issue: gh-85168

Open Graph Description: Adjust urllib.request.url2pathname() and pathname2url() to use the filesystem encoding when quoting and unquoting file URIs, rather than forcing use of UTF-8. No changes are needed in the nturl2pat...

X Description: Adjust urllib.request.url2pathname() and pathname2url() to use the filesystem encoding when quoting and unquoting file URIs, rather than forcing use of UTF-8. No changes are needed in the nturl2pat...

Opengraph URL: https://github.com/python/cpython/pull/126852

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1a3d281c-2620-cdcb-8eb0-fbb0e03c0382
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9D9E:299992:1901216:210084A:6B020E9A
html-safe-nonceb7b1dc0cdcbc5d178d74bff1debbe84d8fc3b6d6cc521a909e3c91f7de8ced16
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDlFOjI5OTk5MjoxOTAxMjE2OjIxMDA4NEE6NkIwMjBFOUEiLCJ2aXNpdG9yX2lkIjoiODUwODcyNzE0NTY2NDE1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac234b18ca060dd0d5e1add13ceac68795041ca9a1494fde6877422b51ea6fa5fd
hovercard-subject-tagpull_request:2180870686
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/126852/files
twitter:imagehttps://avatars.githubusercontent.com/u/960340?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/960340?s=400&v=4
og:image:altAdjust urllib.request.url2pathname() and pathname2url() to use the filesystem encoding when quoting and unquoting file URIs, rather than forcing use of UTF-8. No changes are needed in the nturl2pat...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/126852/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126852%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126852%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/126852/files
Reloadhttps://github.com/python/cpython/pull/126852/files
Reloadhttps://github.com/python/cpython/pull/126852/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
barneygalehttps://github.com/barneygale
python:mainhttps://github.com/python/cpython/tree/main
barneygale:gh-85168https://github.com/barneygale/cpython/tree/gh-85168
Conversation 11 https://github.com/python/cpython/pull/126852
Commits 5 https://github.com/python/cpython/pull/126852/commits
Checks 0 https://github.com/python/cpython/pull/126852/checks
Files changed https://github.com/python/cpython/pull/126852/files
Please reload this pagehttps://github.com/python/cpython/pull/126852/files
GH-85168: Use filesystem encoding when converting to/from file URIs https://github.com/python/cpython/pull/126852/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/126852/files
11b9602 GH-85168: Use filesystem encoding when converting to/from `file` URIs barneygale Nov 15, 2024 https://github.com/python/cpython/pull/126852/commits/11b96023e0283c0a0017066dab17430117118ad6
a6f57d3 Address review feedback barneygale Nov 15, 2024 https://github.com/python/cpython/pull/126852/commits/a6f57d333994ee4066f0e7ba00bc0d8d9c5f090a
f123044 Undo unnecessary import barneygale Nov 15, 2024 https://github.com/python/cpython/pull/126852/commits/f123044ecdfabac7a1e31ce0322bebf725802e45
b03b10d Add test for unquoted non-ASCII character in URL. barneygale Nov 16, 2024 https://github.com/python/cpython/pull/126852/commits/b03b10da3acfebf0bb423cd8681e6ecfb4ae5eee
224c252 Merge branch 'main' into gh-85168 barneygale Nov 19, 2024 https://github.com/python/cpython/pull/126852/commits/224c2521c8a1cb8307b5ed73b7babc56795b8536
Clear filters https://github.com/python/cpython/pull/126852/files
Please reload this pagehttps://github.com/python/cpython/pull/126852/files
Please reload this pagehttps://github.com/python/cpython/pull/126852/files
test_urllib.py https://github.com/python/cpython/pull/126852/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
test_urllib2.py https://github.com/python/cpython/pull/126852/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
request.py https://github.com/python/cpython/pull/126852/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
2024-11-15-01-50-36.gh-issue-85168.bP8VIN.rst https://github.com/python/cpython/pull/126852/files#diff-470407b09cd143450b2e89caffd3b8679338647737b94b1fa65f7fa2caa711d9
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L644
Lib/test/test_urllib.pyhttps://github.com/python/cpython/pull/126852/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
View file https://github.com/barneygale/cpython/blob/224c2521c8a1cb8307b5ed73b7babc56795b8536/Lib/test/test_urllib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/126852/{{ revealButtonHref }}
https://github.com/python/cpython/pull/126852/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
https://github.com/python/cpython/pull/126852/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
https://github.com/python/cpython/pull/126852/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
https://github.com/python/cpython/pull/126852/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
https://github.com/python/cpython/pull/126852/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
https://github.com/python/cpython/pull/126852/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L644
Lib/test/test_urllib2.pyhttps://github.com/python/cpython/pull/126852/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
View file https://github.com/barneygale/cpython/blob/224c2521c8a1cb8307b5ed73b7babc56795b8536/Lib/test/test_urllib2.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/126852/{{ revealButtonHref }}
https://github.com/python/cpython/pull/126852/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
https://github.com/python/cpython/pull/126852/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L643
Lib/urllib/request.pyhttps://github.com/python/cpython/pull/126852/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
View file https://github.com/barneygale/cpython/blob/224c2521c8a1cb8307b5ed73b7babc56795b8536/Lib/urllib/request.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/126852/{{ revealButtonHref }}
https://github.com/python/cpython/pull/126852/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
https://github.com/python/cpython/pull/126852/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
Misc/NEWS.d/next/Library/2024-11-15-01-50-36.gh-issue-85168.bP8VIN.rsthttps://github.com/python/cpython/pull/126852/files#diff-470407b09cd143450b2e89caffd3b8679338647737b94b1fa65f7fa2caa711d9
View file https://github.com/barneygale/cpython/blob/224c2521c8a1cb8307b5ed73b7babc56795b8536/Misc/NEWS.d/next/Library/2024-11-15-01-50-36.gh-issue-85168.bP8VIN.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/126852/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.