| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:965f9bf9-7bd2-09f3-f4d7-4eee6835a346 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8672:1E4FEF:33AFAF5:4375DDE:696B8F95 |
| html-safe-nonce | 7aee520cde19b003cbe048d3207fa2334e76d3128cad5e9eae0409aec237e7d1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjcyOjFFNEZFRjozM0FGQUY1OjQzNzVEREU6Njk2QjhGOTUiLCJ2aXNpdG9yX2lkIjoiNjU1NTMwMTAyNjc4NzQ2MzA2MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | aa202f8b3f1541f247be243fbeb8ebf1bd1f2d20a9845889e5d10965c6223115 |
| hovercard-subject-tag | pull_request:2179582169 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/126830/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/88e4326b83fa9892a547ff2f86467cf96e972a89dc4ebab1d003d79992103160/python/cpython/pull/126830 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/88e4326b83fa9892a547ff2f86467cf96e972a89dc4ebab1d003d79992103160/python/cpython/pull/126830 |
| og:image:alt | Generate slice constants in AST, rather than in codegen.
This could allow more optimizations in earlier steps, albeit in practice it probably only helps rare cases (e.g. "abc"[:1] -> &... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | encukou |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/126830#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126830 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126830 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/126830 |
| Reload | https://github.com/python/cpython/pull/126830 |
| Reload | https://github.com/python/cpython/pull/126830 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/126830 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/126830 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/126830#issue-comment-box |
| encukou | https://github.com/encukou |
| python:main | https://github.com/python/cpython/tree/main |
| encukou:const_slice | https://github.com/encukou/cpython/tree/const_slice |
|
gh-125063: Move slice constant-folding to AST
| https://github.com/python/cpython/pull/126830#top |
| encukou | https://github.com/encukou |
| python:main | https://github.com/python/cpython/tree/main |
| encukou:const_slice | https://github.com/encukou/cpython/tree/const_slice |
|
Conversation
7
| https://github.com/python/cpython/pull/126830 |
|
Commits
2
| https://github.com/python/cpython/pull/126830/commits |
|
Checks
0
| https://github.com/python/cpython/pull/126830/checks |
|
Files changed
| https://github.com/python/cpython/pull/126830/files |
| Please reload this page | https://github.com/python/cpython/pull/126830 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| Nov 14, 2024 | https://github.com/python/cpython/pull/126830#issue-2658635483 |
| Please reload this page | https://github.com/python/cpython/pull/126830 |
| GH-125064 | https://github.com/python/cpython/pull/125064 |
| Emit slices as constants in the bytecode compiler #125063 | https://github.com/python/cpython/issues/125063 |
| Please reload this page | https://github.com/python/cpython/pull/126830 |
| encukou | https://github.com/encukou |
| November 14, 2024 13:05 | https://github.com/python/cpython/pull/126830#commits-pushed-3313406 |
|
| https://github.com/encukou |
| Fold slices of constants into slice constants | https://github.com/python/cpython/pull/126830/commits/3313406b7ec7ec6b7225c64d40c832324e0dd6f0 |
| 3313406 | https://github.com/python/cpython/pull/126830/commits/3313406b7ec7ec6b7225c64d40c832324e0dd6f0 |
|
| https://github.com/encukou |
| Remove the codegen optimization | https://github.com/python/cpython/pull/126830/commits/d4cb362ef846ad66f219fea50b4474b2e5d8c56f |
| d4cb362 | https://github.com/python/cpython/pull/126830/commits/d4cb362ef846ad66f219fea50b4474b2e5d8c56f |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| Eclips4 | https://github.com/Eclips4 |
| iritkatriel | https://github.com/iritkatriel |
| isidentical | https://github.com/isidentical |
| markshannon | https://github.com/markshannon |
| code owners | https://github.com/python/cpython/blob/3966d8d626fc9adcdf0663024d4ae6e6be7ef858/.github/CODEOWNERS#L163 |
| November 14, 2024 12:11 | https://github.com/python/cpython/pull/126830#event-15297617613 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Nov 14, 2024 | https://github.com/python/cpython/pull/126830#event-15297618206 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
Nov 14, 2024
| https://github.com/python/cpython/pull/126830#ref-issue-2571219673 |
|
Emit slices as constants in the bytecode compiler
#125063
| https://github.com/python/cpython/issues/125063 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| Nov 14, 2024 | https://github.com/python/cpython/pull/126830#event-15297619479 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| Nov 14, 2024 | https://github.com/python/cpython/pull/126830#event-15297624083 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Nov 14, 2024 | https://github.com/python/cpython/pull/126830#event-15297627990 |
| https://github.com/iritkatriel |
| iritkatriel | https://github.com/iritkatriel |
|
Nov 14, 2024
| https://github.com/python/cpython/pull/126830#pullrequestreview-2435965557 |
|
View reviewed changes
| https://github.com/python/cpython/pull/126830/files/d4cb362ef846ad66f219fea50b4474b2e5d8c56f |
| Lib/test/test_peepholer.py | https://github.com/python/cpython/pull/126830/files/d4cb362ef846ad66f219fea50b4474b2e5d8c56f#diff-bcf92ed219340e9e0c52401909828c2e9a821541660073e24d64dd996beaf842 |
| iritkatriel | https://github.com/iritkatriel |
| Nov 14, 2024 | https://github.com/python/cpython/pull/126830#discussion_r1842148103 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/126830 |
| Eclips4 | https://github.com/Eclips4 |
| Nov 14, 2024 | https://github.com/python/cpython/pull/126830#discussion_r1842173347 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/126830 |
| https://github.com/markshannon |
| markshannon | https://github.com/markshannon |
| Nov 14, 2024 | https://github.com/python/cpython/pull/126830#issuecomment-2476525196 |
| Please reload this page | https://github.com/python/cpython/pull/126830 |
| https://github.com/markshannon |
| markshannon | https://github.com/markshannon |
| Nov 14, 2024 | https://github.com/python/cpython/pull/126830#issuecomment-2476578457 |
| Please reload this page | https://github.com/python/cpython/pull/126830 |
| https://github.com/Eclips4 |
| Eclips4 | https://github.com/Eclips4 |
| Nov 14, 2024 | https://github.com/python/cpython/pull/126830#issuecomment-2476716496 |
| Please reload this page | https://github.com/python/cpython/pull/126830 |
| Please reload this page | https://github.com/python/cpython/pull/126830 |
| https://github.com/Eclips4 |
| Eclips4 | https://github.com/Eclips4 |
|
Nov 14, 2024
| https://github.com/python/cpython/pull/126830#ref-issue-2659638853 |
|
Move const folding to the peephole optimizer
#126835
| https://github.com/python/cpython/issues/126835 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| Nov 15, 2024 | https://github.com/python/cpython/pull/126830#issuecomment-2478729245 |
| Please reload this page | https://github.com/python/cpython/pull/126830 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| Nov 15, 2024 | https://github.com/python/cpython/pull/126830#event-15311893389 |
| https://github.com/Eclips4 |
| Eclips4 | https://github.com/Eclips4 |
| Nov 15, 2024 | https://github.com/python/cpython/pull/126830#issuecomment-2478924616 |
| Please reload this page | https://github.com/python/cpython/pull/126830 |
| Please reload this page | https://github.com/python/cpython/pull/126830 |
| https://github.com/tomasr8 |
| tomasr8 | https://github.com/tomasr8 |
|
Jan 13, 2025
| https://github.com/python/cpython/pull/126830#ref-pullrequest-2785453685 |
|
gh-126835: Disable tuple folding in the AST optimizer
#128802
| https://github.com/python/cpython/pull/128802 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126830 |
|
| https://github.com/iritkatriel |
|
iritkatriel
| https://github.com/iritkatriel |
|
| https://github.com/python/cpython/pull/126830/files/d4cb362ef846ad66f219fea50b4474b2e5d8c56f |
|
| https://github.com/isidentical |
|
isidentical
| https://github.com/isidentical |
|
| https://github.com/Eclips4 |
|
Eclips4
| https://github.com/Eclips4 |
|
| https://github.com/markshannon |
|
markshannon
| https://github.com/markshannon |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Please reload this page | https://github.com/python/cpython/pull/126830 |
|
| https://github.com/encukou |
|
| https://github.com/markshannon |
|
| https://github.com/Eclips4 |
|
| https://github.com/iritkatriel |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |