René's URL Explorer Experiment


Title: gh-125063: Move slice constant-folding to AST by encukou · Pull Request #126830 · python/cpython · GitHub

Open Graph Title: gh-125063: Move slice constant-folding to AST by encukou · Pull Request #126830 · python/cpython

X Title: gh-125063: Move slice constant-folding to AST by encukou · Pull Request #126830 · python/cpython

Description: Generate slice constants in AST, rather than in codegen. This could allow more optimizations in earlier steps, albeit in practice it probably only helps rare cases (e.g. "abc"[:1] -> "a'). Tests fo...

Open Graph Description: Generate slice constants in AST, rather than in codegen. This could allow more optimizations in earlier steps, albeit in practice it probably only helps rare cases (e.g. "abc"[:1] -> &...

X Description: Generate slice constants in AST, rather than in codegen. This could allow more optimizations in earlier steps, albeit in practice it probably only helps rare cases (e.g. "abc"[:1]...

Opengraph URL: https://github.com/python/cpython/pull/126830

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:965f9bf9-7bd2-09f3-f4d7-4eee6835a346
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8672:1E4FEF:33AFAF5:4375DDE:696B8F95
html-safe-nonce7aee520cde19b003cbe048d3207fa2334e76d3128cad5e9eae0409aec237e7d1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjcyOjFFNEZFRjozM0FGQUY1OjQzNzVEREU6Njk2QjhGOTUiLCJ2aXNpdG9yX2lkIjoiNjU1NTMwMTAyNjc4NzQ2MzA2MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacaa202f8b3f1541f247be243fbeb8ebf1bd1f2d20a9845889e5d10965c6223115
hovercard-subject-tagpull_request:2179582169
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/126830/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/88e4326b83fa9892a547ff2f86467cf96e972a89dc4ebab1d003d79992103160/python/cpython/pull/126830
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/88e4326b83fa9892a547ff2f86467cf96e972a89dc4ebab1d003d79992103160/python/cpython/pull/126830
og:image:altGenerate slice constants in AST, rather than in codegen. This could allow more optimizations in earlier steps, albeit in practice it probably only helps rare cases (e.g. "abc"[:1] -> &...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameencukou
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/126830#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126830
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126830
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/126830
Reloadhttps://github.com/python/cpython/pull/126830
Reloadhttps://github.com/python/cpython/pull/126830
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/126830
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/126830
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/126830#issue-comment-box
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:const_slicehttps://github.com/encukou/cpython/tree/const_slice
gh-125063: Move slice constant-folding to AST https://github.com/python/cpython/pull/126830#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:const_slicehttps://github.com/encukou/cpython/tree/const_slice
Conversation 7 https://github.com/python/cpython/pull/126830
Commits 2 https://github.com/python/cpython/pull/126830/commits
Checks 0 https://github.com/python/cpython/pull/126830/checks
Files changed https://github.com/python/cpython/pull/126830/files
Please reload this pagehttps://github.com/python/cpython/pull/126830
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/encukou
encukouhttps://github.com/encukou
Nov 14, 2024https://github.com/python/cpython/pull/126830#issue-2658635483
Please reload this pagehttps://github.com/python/cpython/pull/126830
GH-125064https://github.com/python/cpython/pull/125064
Emit slices as constants in the bytecode compiler #125063https://github.com/python/cpython/issues/125063
Please reload this pagehttps://github.com/python/cpython/pull/126830
encukouhttps://github.com/encukou
November 14, 2024 13:05https://github.com/python/cpython/pull/126830#commits-pushed-3313406
https://github.com/encukou
Fold slices of constants into slice constantshttps://github.com/python/cpython/pull/126830/commits/3313406b7ec7ec6b7225c64d40c832324e0dd6f0
3313406https://github.com/python/cpython/pull/126830/commits/3313406b7ec7ec6b7225c64d40c832324e0dd6f0
https://github.com/encukou
Remove the codegen optimizationhttps://github.com/python/cpython/pull/126830/commits/d4cb362ef846ad66f219fea50b4474b2e5d8c56f
d4cb362https://github.com/python/cpython/pull/126830/commits/d4cb362ef846ad66f219fea50b4474b2e5d8c56f
https://github.com/encukou
encukouhttps://github.com/encukou
Eclips4https://github.com/Eclips4
iritkatrielhttps://github.com/iritkatriel
isidenticalhttps://github.com/isidentical
markshannonhttps://github.com/markshannon
code ownershttps://github.com/python/cpython/blob/3966d8d626fc9adcdf0663024d4ae6e6be7ef858/.github/CODEOWNERS#L163
November 14, 2024 12:11https://github.com/python/cpython/pull/126830#event-15297617613
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 14, 2024https://github.com/python/cpython/pull/126830#event-15297618206
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 14, 2024 https://github.com/python/cpython/pull/126830#ref-issue-2571219673
Emit slices as constants in the bytecode compiler #125063 https://github.com/python/cpython/issues/125063
https://github.com/encukou
encukouhttps://github.com/encukou
Nov 14, 2024https://github.com/python/cpython/pull/126830#event-15297619479
https://github.com/encukou
encukouhttps://github.com/encukou
Nov 14, 2024https://github.com/python/cpython/pull/126830#event-15297624083
https://github.com/encukou
encukouhttps://github.com/encukou
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Nov 14, 2024https://github.com/python/cpython/pull/126830#event-15297627990
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Nov 14, 2024 https://github.com/python/cpython/pull/126830#pullrequestreview-2435965557
View reviewed changes https://github.com/python/cpython/pull/126830/files/d4cb362ef846ad66f219fea50b4474b2e5d8c56f
Lib/test/test_peepholer.pyhttps://github.com/python/cpython/pull/126830/files/d4cb362ef846ad66f219fea50b4474b2e5d8c56f#diff-bcf92ed219340e9e0c52401909828c2e9a821541660073e24d64dd996beaf842
iritkatrielhttps://github.com/iritkatriel
Nov 14, 2024https://github.com/python/cpython/pull/126830#discussion_r1842148103
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/126830
Eclips4https://github.com/Eclips4
Nov 14, 2024https://github.com/python/cpython/pull/126830#discussion_r1842173347
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/126830
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Nov 14, 2024https://github.com/python/cpython/pull/126830#issuecomment-2476525196
Please reload this pagehttps://github.com/python/cpython/pull/126830
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Nov 14, 2024https://github.com/python/cpython/pull/126830#issuecomment-2476578457
Please reload this pagehttps://github.com/python/cpython/pull/126830
https://github.com/Eclips4
Eclips4https://github.com/Eclips4
Nov 14, 2024https://github.com/python/cpython/pull/126830#issuecomment-2476716496
Please reload this pagehttps://github.com/python/cpython/pull/126830
Please reload this pagehttps://github.com/python/cpython/pull/126830
https://github.com/Eclips4
Eclips4https://github.com/Eclips4
Nov 14, 2024 https://github.com/python/cpython/pull/126830#ref-issue-2659638853
Move const folding to the peephole optimizer #126835 https://github.com/python/cpython/issues/126835
https://github.com/encukou
encukouhttps://github.com/encukou
Nov 15, 2024https://github.com/python/cpython/pull/126830#issuecomment-2478729245
Please reload this pagehttps://github.com/python/cpython/pull/126830
https://github.com/encukou
encukouhttps://github.com/encukou
Nov 15, 2024https://github.com/python/cpython/pull/126830#event-15311893389
https://github.com/Eclips4
Eclips4https://github.com/Eclips4
Nov 15, 2024https://github.com/python/cpython/pull/126830#issuecomment-2478924616
Please reload this pagehttps://github.com/python/cpython/pull/126830
Please reload this pagehttps://github.com/python/cpython/pull/126830
https://github.com/tomasr8
tomasr8https://github.com/tomasr8
Jan 13, 2025 https://github.com/python/cpython/pull/126830#ref-pullrequest-2785453685
gh-126835: Disable tuple folding in the AST optimizer #128802 https://github.com/python/cpython/pull/128802
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126830
https://github.com/iritkatriel
iritkatriel https://github.com/iritkatriel
https://github.com/python/cpython/pull/126830/files/d4cb362ef846ad66f219fea50b4474b2e5d8c56f
https://github.com/isidentical
isidentical https://github.com/isidentical
https://github.com/Eclips4
Eclips4 https://github.com/Eclips4
https://github.com/markshannon
markshannon https://github.com/markshannon
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/126830
https://github.com/encukou
https://github.com/markshannon
https://github.com/Eclips4
https://github.com/iritkatriel
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.