René's URL Explorer Experiment


Title: gh-126606: don't write incomplete pyc files by cfbolz · Pull Request #126627 · python/cpython · GitHub

Open Graph Title: gh-126606: don't write incomplete pyc files by cfbolz · Pull Request #126627 · python/cpython

X Title: gh-126606: don't write incomplete pyc files by cfbolz · Pull Request #126627 · python/cpython

Description: fix corner case in importlib: so far, the code does not check the return value of _io.FileIO.write to see whether a pyc code was fully written to disk. If a ulimit is in place (or the disk is full or something), this could lead to truncated pyc files. After the fix, the written size is checked and the half-written file is removed. Issue: gh-126606

Open Graph Description: fix corner case in importlib: so far, the code does not check the return value of _io.FileIO.write to see whether a pyc code was fully written to disk. If a ulimit is in place (or the disk is full ...

X Description: fix corner case in importlib: so far, the code does not check the return value of _io.FileIO.write to see whether a pyc code was fully written to disk. If a ulimit is in place (or the disk is full ...

Opengraph URL: https://github.com/python/cpython/pull/126627

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ec03a65b-eb39-7053-fb9b-7ed8473d84bd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9FDA:D4839:92A67C:C6162C:6A5292D6
html-safe-nonce0706c5dcece00b3a313fd7950e0e555fac56005fad283bfc7c9b73021bb800a6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RkRBOkQ0ODM5OjkyQTY3QzpDNjE2MkM6NkE1MjkyRDYiLCJ2aXNpdG9yX2lkIjoiNzE0NjYxNDQ5MzI3NTEzMjYzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac26544c0a91fd8ccb32ef539abf48447a4e65dda23fcc22a1460960592be714eb
hovercard-subject-tagpull_request:2171035882
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/126627/files
twitter:imagehttps://avatars.githubusercontent.com/u/85942?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/85942?s=400&v=4
og:image:altfix corner case in importlib: so far, the code does not check the return value of _io.FileIO.write to see whether a pyc code was fully written to disk. If a ulimit is in place (or the disk is full ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/126627/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126627%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126627%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/126627/files
Reloadhttps://github.com/python/cpython/pull/126627/files
Reloadhttps://github.com/python/cpython/pull/126627/files
Please reload this pagehttps://github.com/python/cpython/pull/126627/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/126627/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
brettcannonhttps://github.com/brettcannon
python:mainhttps://github.com/python/cpython/tree/main
cfbolz:gh-126606-dont-write-incomplete-pyc-fileshttps://github.com/cfbolz/cpython/tree/gh-126606-dont-write-incomplete-pyc-files
Conversation 30 https://github.com/python/cpython/pull/126627
Commits 7 https://github.com/python/cpython/pull/126627/commits
Checks 0 https://github.com/python/cpython/pull/126627/checks
Files changed https://github.com/python/cpython/pull/126627/files
Please reload this pagehttps://github.com/python/cpython/pull/126627/files
gh-126606: don't write incomplete pyc files https://github.com/python/cpython/pull/126627/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/126627/files
3746297 check that the pyc file is fully written in _write_atomic cfbolz Nov 9, 2024 https://github.com/python/cpython/pull/126627/commits/374629798e9db454dd8f27b16b7b5e8b81d85470
c87d9bb add news cfbolz Nov 9, 2024 https://github.com/python/cpython/pull/126627/commits/c87d9bb7cb4a265b8b21246dfb01ef36b0dca04e
2c07d2b Update Misc/NEWS.d/next/Core_and_Builtins/2024-11-09-16-10-22.gh-issu… cfbolz Nov 9, 2024 https://github.com/python/cpython/pull/126627/commits/2c07d2b77f08bb4b68bedf1173cf3f8050fdc52f
50f2168 add parens to error, add comment why I'm using an OSError cfbolz Nov 13, 2024 https://github.com/python/cpython/pull/126627/commits/50f21680a120eb993c51566bd87f4e0d7c9c1b46
bffdc02 improve test: cfbolz Nov 13, 2024 https://github.com/python/cpython/pull/126627/commits/bffdc028f4ee2e9fbdc24c7e48d798e53b98ad63
3852b32 Merge branch 'main' into gh-126606-dont-write-incomplete-pyc-files brettcannon Nov 13, 2024 https://github.com/python/cpython/pull/126627/commits/3852b3297473dd8b1ce7b71b9f5b5072de171b18
15b23b5 Tweak a comment brettcannon Nov 13, 2024 https://github.com/python/cpython/pull/126627/commits/15b23b57d0d758d4f7ccc93dc54f6320c4d5044e
Clear filters https://github.com/python/cpython/pull/126627/files
Please reload this pagehttps://github.com/python/cpython/pull/126627/files
Please reload this pagehttps://github.com/python/cpython/pull/126627/files
_bootstrap_external.py https://github.com/python/cpython/pull/126627/files#diff-efefe383b3a81d16150c280db0b64eed7569254299418f64cc0d749f8e16f3a4
test_util.py https://github.com/python/cpython/pull/126627/files#diff-d13bfe3496112854fdea5b6b74909580ce3ee5d57a117b81d7726eea5a1b857f
2024-11-09-16-10-22.gh-issue-126066.9zs4m4.rst https://github.com/python/cpython/pull/126627/files#diff-4f62f7e063c5aee6e34ca43f66bef8fab638eb44b6c5088627f2d435a0136d7a
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L264
Lib/importlib/_bootstrap_external.pyhttps://github.com/python/cpython/pull/126627/files#diff-efefe383b3a81d16150c280db0b64eed7569254299418f64cc0d749f8e16f3a4
View file https://github.com/cfbolz/cpython/blob/15b23b57d0d758d4f7ccc93dc54f6320c4d5044e/Lib/importlib/_bootstrap_external.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/126627/{{ revealButtonHref }}
https://github.com/python/cpython/pull/126627/files#diff-efefe383b3a81d16150c280db0b64eed7569254299418f64cc0d749f8e16f3a4
Please reload this pagehttps://github.com/python/cpython/pull/126627/files
https://github.com/python/cpython/pull/126627/files#diff-efefe383b3a81d16150c280db0b64eed7569254299418f64cc0d749f8e16f3a4
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L264
Lib/test/test_importlib/test_util.pyhttps://github.com/python/cpython/pull/126627/files#diff-d13bfe3496112854fdea5b6b74909580ce3ee5d57a117b81d7726eea5a1b857f
View file https://github.com/cfbolz/cpython/blob/15b23b57d0d758d4f7ccc93dc54f6320c4d5044e/Lib/test/test_importlib/test_util.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/126627/{{ revealButtonHref }}
https://github.com/python/cpython/pull/126627/files#diff-d13bfe3496112854fdea5b6b74909580ce3ee5d57a117b81d7726eea5a1b857f
https://github.com/python/cpython/pull/126627/files#diff-d13bfe3496112854fdea5b6b74909580ce3ee5d57a117b81d7726eea5a1b857f
https://github.com/python/cpython/pull/126627/files#diff-d13bfe3496112854fdea5b6b74909580ce3ee5d57a117b81d7726eea5a1b857f
Misc/NEWS.d/next/Core_and_Builtins/2024-11-09-16-10-22.gh-issue-126066.9zs4m4.rsthttps://github.com/python/cpython/pull/126627/files#diff-4f62f7e063c5aee6e34ca43f66bef8fab638eb44b6c5088627f2d435a0136d7a
View file https://github.com/cfbolz/cpython/blob/15b23b57d0d758d4f7ccc93dc54f6320c4d5044e/Misc/NEWS.d/next/Core_and_Builtins/2024-11-09-16-10-22.gh-issue-126066.9zs4m4.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/126627/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.