René's URL Explorer Experiment


Title: [3.12] gh-126500: test_ssl: Don't stop ThreadedEchoServer on OSError in ConnectionHandler; rely on __exit__ (GH-126503) by miss-islington · Pull Request #126572 · python/cpython · GitHub

Open Graph Title: [3.12] gh-126500: test_ssl: Don't stop ThreadedEchoServer on OSError in ConnectionHandler; rely on __exit__ (GH-126503) by miss-islington · Pull Request #126572 · python/cpython

X Title: [3.12] gh-126500: test_ssl: Don't stop ThreadedEchoServer on OSError in ConnectionHandler; rely on __exit__ (GH-126503) by miss-islington · Pull Request #126572 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: If read() in the ConnectionHandler thread raises OSError (except ConnectionError), the ConnectionHandler shuts down the entire ThreadedEchoServer, preventing further connections. It also does that ...

X Description: If read() in the ConnectionHandler thread raises OSError (except ConnectionError), the ConnectionHandler shuts down the entire ThreadedEchoServer, preventing further connections. It also does that ...

Mail addresses
encukou@gmail.com

Opengraph URL: https://github.com/python/cpython/pull/126572

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d37945f2-02b1-a2df-14b0-c20b93c8e7a0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB218:141AC:6452B1:899406:6A57D3A4
html-safe-nonce8db733b000be909cfd38fb4ed2c699465ffbc724104f48bd2278bbc5a8ed2b8e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjE4OjE0MUFDOjY0NTJCMTo4OTk0MDY6NkE1N0QzQTQiLCJ2aXNpdG9yX2lkIjoiMTI2OTczNjA2MTI2NzMzNDA1MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb947d719938b86bbb3601b684364d2f8bcf44d74c1a7b626f3bee0f5ebff3b15
hovercard-subject-tagpull_request:2169334521
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/126572/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/67b4f64835e29ed423e980a9d71cea211966ae76cf0d3294e208a7049e9cf8dc/python/cpython/pull/126572
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/67b4f64835e29ed423e980a9d71cea211966ae76cf0d3294e208a7049e9cf8dc/python/cpython/pull/126572
og:image:altIf read() in the ConnectionHandler thread raises OSError (except ConnectionError), the ConnectionHandler shuts down the entire ThreadedEchoServer, preventing further connections. It also does that ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemiss-islington
hostnamegithub.com
expected-hostnamegithub.com
None837767abbd14b05f219fd812ef2842c659968b63619e1b966dded83972ab5bca
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9044d0f867aa9892268d1f430238ff123e11ee91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/126572#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126572
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126572
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/126572
Reloadhttps://github.com/python/cpython/pull/126572
Reloadhttps://github.com/python/cpython/pull/126572
Please reload this pagehttps://github.com/python/cpython/pull/126572
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/126572
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
encukouhttps://github.com/encukou
python:3.12https://github.com/python/cpython/tree/3.12
miss-islington:backport-c9cda16-3.12https://github.com/miss-islington/cpython/tree/backport-c9cda16-3.12
Conversationhttps://github.com/python/cpython/pull/126572
Commits1 (1)https://github.com/python/cpython/pull/126572/commits
Checkshttps://github.com/python/cpython/pull/126572/checks
Files changedhttps://github.com/python/cpython/pull/126572/files
[3.12] gh-126500: test_ssl: Don't stop ThreadedEchoServer on OSError in ConnectionHandler; rely on __exit__ (GH-126503)https://github.com/python/cpython/pull/126572#top
encukouhttps://github.com/encukou
python:3.12https://github.com/python/cpython/tree/3.12
miss-islington:backport-c9cda16-3.12https://github.com/miss-islington/cpython/tree/backport-c9cda16-3.12
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Nov 8, 2024https://github.com/python/cpython/pull/126572#issue-2643639507
Please reload this pagehttps://github.com/python/cpython/pull/126572
5b95eb9https://github.com/python/cpython/commit/5b95eb90a7167285b6544b50865227c584943c9a
c9cda16https://github.com/python/cpython/commit/c9cda1608edf7664c10f4f467e24591062c2fe62
test_ssl: ConnectionHandler shuts down ThreadedEchoServer #126500https://github.com/python/cpython/issues/126500
Please reload this pagehttps://github.com/python/cpython/pull/126572
https://github.com/encukou
https://github.com/miss-islington
pythongh-126500https://github.com/python/cpython/issues/126500
: test_ssl: Don't stop ThreadedEchoServer on OSError i…https://github.com/python/cpython/pull/126572/commits/3d390148c05a7ea2d401c4633e7d4db75ebf97d9
3d39014https://github.com/python/cpython/pull/126572/commits/3d390148c05a7ea2d401c4633e7d4db75ebf97d9
pythonGH-126503https://github.com/python/cpython/pull/126503
5b95eb9https://github.com/miss-islington/cpython/commit/5b95eb90a7167285b6544b50865227c584943c9a
c9cda16https://github.com/miss-islington/cpython/commit/c9cda1608edf7664c10f4f467e24591062c2fe62
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Nov 8, 2024https://github.com/python/cpython/pull/126572#event-15210574284
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 8, 2024 https://github.com/python/cpython/pull/126572#ref-pullrequest-2638238599
gh-126500: test_ssl: Don't stop ThreadedEchoServer on OSError in ConnectionHandler; rely on __exit__ #126503 https://github.com/python/cpython/pull/126503
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Nov 8, 2024https://github.com/python/cpython/pull/126572#event-15210576503
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 8, 2024 https://github.com/python/cpython/pull/126572#ref-issue-2638211961
test_ssl: ConnectionHandler shuts down ThreadedEchoServer #126500 https://github.com/python/cpython/issues/126500
https://github.com/encukou
encukouhttps://github.com/encukou
aee80cdhttps://github.com/python/cpython/commit/aee80cd5e7c6be90c69b9aa9c09faa19b91cdccd
Nov 11, 2024https://github.com/python/cpython/pull/126572#event-15250997402
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Nov 11, 2024https://github.com/python/cpython/pull/126572#event-15250998085
https://github.com/pmgdeb
pmgdebhttps://github.com/pmgdeb
Apr 25, 2025 https://github.com/python/cpython/pull/126572#ref-pullrequest-3011210301
Deal with BrokenPipeError since openssl 3.4.x. gevent/gevent#2103 https://github.com/gevent/gevent/pull/2103
https://github.com/encukou
encukouhttps://github.com/encukou
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
Apr 29, 2025https://github.com/python/cpython/pull/126572#event-17453817956
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Apr 29, 2025https://github.com/python/cpython/pull/126572#issuecomment-2838581934
@miss-islingtonhttps://github.com/miss-islington
@encukouhttps://github.com/encukou
Please reload this pagehttps://github.com/python/cpython/pull/126572
miss-islingtonhttps://github.com/miss-islington
Apr 29, 2025 https://github.com/python/cpython/pull/126572#ref-commit-683380e
https://github.com/miss-islington
https://github.com/encukou
[3.12]https://github.com/miss-islington/cpython/commit/683380eb9496f54036396e3a45e3f73813f05c60
pythongh-126500https://github.com/python/cpython/issues/126500
: test_ssl: Don't stop ThreadedEchoServer on OS…https://github.com/miss-islington/cpython/commit/683380eb9496f54036396e3a45e3f73813f05c60
683380ehttps://github.com/miss-islington/cpython/commit/683380eb9496f54036396e3a45e3f73813f05c60
pythonGH-126503https://github.com/python/cpython/pull/126503
pythonGH-126572https://github.com/python/cpython/pull/126572
pythongh-126500https://github.com/python/cpython/issues/126500
pythonGH-126503https://github.com/python/cpython/pull/126503
5b95eb9https://github.com/miss-islington/cpython/commit/5b95eb90a7167285b6544b50865227c584943c9a
c9cda16https://github.com/miss-islington/cpython/commit/c9cda1608edf7664c10f4f467e24591062c2fe62
aee80cdhttps://github.com/miss-islington/cpython/commit/aee80cd5e7c6be90c69b9aa9c09faa19b91cdccd
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 29, 2025https://github.com/python/cpython/pull/126572#issuecomment-2838582903
GH-133148https://github.com/python/cpython/pull/133148
3.11 branchhttps://github.com/python/cpython/tree/3.11
Please reload this pagehttps://github.com/python/cpython/pull/126572
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
Apr 29, 2025https://github.com/python/cpython/pull/126572#event-17453822211
ambvhttps://github.com/ambv
May 14, 2025 https://github.com/python/cpython/pull/126572#ref-commit-461ca2c
https://github.com/miss-islington
https://github.com/encukou
[3.11]https://github.com/python/cpython/commit/461ca2cbfb7c92b80e14463854525f162716b8ff
gh-126500https://github.com/python/cpython/issues/126500
: test_ssl: Don't stop ThreadedEchoServer on OSError …https://github.com/python/cpython/commit/461ca2cbfb7c92b80e14463854525f162716b8ff
461ca2chttps://github.com/python/cpython/commit/461ca2cbfb7c92b80e14463854525f162716b8ff
GH-126503https://github.com/python/cpython/pull/126503
GH-126572https://github.com/python/cpython/pull/126572
GH-133148https://github.com/python/cpython/pull/133148
gh-126500https://github.com/python/cpython/issues/126500
GH-126503https://github.com/python/cpython/pull/126503
5b95eb9https://github.com/python/cpython/commit/5b95eb90a7167285b6544b50865227c584943c9a
c9cda16https://github.com/python/cpython/commit/c9cda1608edf7664c10f4f467e24591062c2fe62
aee80cdhttps://github.com/python/cpython/commit/aee80cd5e7c6be90c69b9aa9c09faa19b91cdccd
https://github.com/encukou
encukouhttps://github.com/encukou
needs backport to 3.10 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.10%22
May 15, 2025https://github.com/python/cpython/pull/126572#event-17665445090
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
May 15, 2025https://github.com/python/cpython/pull/126572#issuecomment-2882695584
@miss-islingtonhttps://github.com/miss-islington
@encukouhttps://github.com/encukou
Please reload this pagehttps://github.com/python/cpython/pull/126572
miss-islingtonhttps://github.com/miss-islington
May 15, 2025 https://github.com/python/cpython/pull/126572#ref-commit-fa8024b
https://github.com/miss-islington
https://github.com/encukou
[3.12]https://github.com/miss-islington/cpython/commit/fa8024bbae147b8f002bf97d81e49de7de37d65c
pythongh-126500https://github.com/python/cpython/issues/126500
: test_ssl: Don't stop ThreadedEchoServer on OS…https://github.com/miss-islington/cpython/commit/fa8024bbae147b8f002bf97d81e49de7de37d65c
fa8024bhttps://github.com/miss-islington/cpython/commit/fa8024bbae147b8f002bf97d81e49de7de37d65c
pythonGH-126503https://github.com/python/cpython/pull/126503
pythonGH-126572https://github.com/python/cpython/pull/126572
pythongh-126500https://github.com/python/cpython/issues/126500
pythonGH-126503https://github.com/python/cpython/pull/126503
5b95eb9https://github.com/miss-islington/cpython/commit/5b95eb90a7167285b6544b50865227c584943c9a
c9cda16https://github.com/miss-islington/cpython/commit/c9cda1608edf7664c10f4f467e24591062c2fe62
aee80cdhttps://github.com/miss-islington/cpython/commit/aee80cd5e7c6be90c69b9aa9c09faa19b91cdccd
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 15, 2025https://github.com/python/cpython/pull/126572#issuecomment-2882695882
GH-134030https://github.com/python/cpython/pull/134030
3.10 branchhttps://github.com/python/cpython/tree/3.10
Please reload this pagehttps://github.com/python/cpython/pull/126572
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.10 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.10%22
May 15, 2025https://github.com/python/cpython/pull/126572#event-17665447675
ambvhttps://github.com/ambv
Jun 1, 2025 https://github.com/python/cpython/pull/126572#ref-commit-f85e71a
https://github.com/miss-islington
https://github.com/encukou
[3.10]https://github.com/python/cpython/commit/f85e71a008cf1cfeae8984c784ccbd7665e5deb9
gh-126500https://github.com/python/cpython/issues/126500
: test_ssl: Don't stop ThreadedEchoServer on OSError …https://github.com/python/cpython/commit/f85e71a008cf1cfeae8984c784ccbd7665e5deb9
f85e71ahttps://github.com/python/cpython/commit/f85e71a008cf1cfeae8984c784ccbd7665e5deb9
GH-126503https://github.com/python/cpython/pull/126503
GH-126572https://github.com/python/cpython/pull/126572
#134030https://github.com/python/cpython/pull/134030
gh-126500https://github.com/python/cpython/issues/126500
GH-126503https://github.com/python/cpython/pull/126503
5b95eb9https://github.com/python/cpython/commit/5b95eb90a7167285b6544b50865227c584943c9a
c9cda16https://github.com/python/cpython/commit/c9cda1608edf7664c10f4f467e24591062c2fe62
aee80cdhttps://github.com/python/cpython/commit/aee80cd5e7c6be90c69b9aa9c09faa19b91cdccd
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
January 2, 2026 18:41https://github.com/python/cpython/pull/126572#event-21830710054
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126572
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Please reload this pagehttps://github.com/python/cpython/pull/126572
https://github.com/miss-islington
https://github.com/encukou
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.