René's URL Explorer Experiment


Title: gh-126499: test_ssl: Don't assume err.reason is a string by encukou · Pull Request #126501 · python/cpython · GitHub

Open Graph Title: gh-126499: test_ssl: Don't assume err.reason is a string by encukou · Pull Request #126501 · python/cpython

X Title: gh-126499: test_ssl: Don't assume err.reason is a string by encukou · Pull Request #126501 · python/cpython

Description: The skipping machinery called getattr(err, "reason", "") on an arbitrary exception. As intermittent Buildbot failures show, sometimes it's set to None. Convert it to string for this specific check....

Open Graph Description: The skipping machinery called getattr(err, "reason", "") on an arbitrary exception. As intermittent Buildbot failures show, sometimes it's set to None. Convert it to string ...

X Description: The skipping machinery called getattr(err, "reason", "") on an arbitrary exception. As intermittent Buildbot failures show, sometimes it's set to None. C...

Opengraph URL: https://github.com/python/cpython/pull/126501

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:171a31a3-0baa-d325-3cf1-036172fbd396
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8F18:25F898:5CA6D:7AFF9:696B2DB5
html-safe-nonce19609c59f27ef9b3e1b93d589c2641d870418ed1c4d8f755121d2fcb14286f47
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjE4OjI1Rjg5ODo1Q0E2RDo3QUZGOTo2OTZCMkRCNSIsInZpc2l0b3JfaWQiOiI5ODk5NzE0MTM1MzI4ODAzMDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6ff984de96539b648b23f13f290bfcc63369fd2bb4fff9e4ed5c562bc5ca1aaf
hovercard-subject-tagpull_request:2165315881
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/126501/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6a2e33313b7606f35740bc71e077a6ce82362c37e60f37ecca0d7515de8d09ca/python/cpython/pull/126501
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6a2e33313b7606f35740bc71e077a6ce82362c37e60f37ecca0d7515de8d09ca/python/cpython/pull/126501
og:image:altThe skipping machinery called getattr(err, "reason", "") on an arbitrary exception. As intermittent Buildbot failures show, sometimes it's set to None. Convert it to string ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameencukou
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/126501#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126501
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126501
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/126501
Reloadhttps://github.com/python/cpython/pull/126501
Reloadhttps://github.com/python/cpython/pull/126501
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/126501
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/126501
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/126501#issue-comment-box
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:intermittent-ssl-failureshttps://github.com/encukou/cpython/tree/intermittent-ssl-failures
gh-126499: test_ssl: Don't assume err.reason is a string https://github.com/python/cpython/pull/126501#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:intermittent-ssl-failureshttps://github.com/encukou/cpython/tree/intermittent-ssl-failures
Conversation 4 https://github.com/python/cpython/pull/126501
Commits 1 https://github.com/python/cpython/pull/126501/commits
Checks 0 https://github.com/python/cpython/pull/126501/checks
Files changed https://github.com/python/cpython/pull/126501/files
Please reload this pagehttps://github.com/python/cpython/pull/126501
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/encukou
encukouhttps://github.com/encukou
Nov 6, 2024https://github.com/python/cpython/pull/126501#issue-2638233085
Please reload this pagehttps://github.com/python/cpython/pull/126501
test_ssl: non_linux_skip_if_other_okay_error assumes err.reason is a string #126499https://github.com/python/cpython/issues/126499
Please reload this pagehttps://github.com/python/cpython/pull/126501
https://github.com/encukou
pythongh-126499https://github.com/python/cpython/issues/126499
: test_ssl: Don't assume err.reason is a stringhttps://github.com/python/cpython/pull/126501/commits/9c9eea66e432be97c1c43f44425ee0b878ecaa02
9c9eea6https://github.com/python/cpython/pull/126501/commits/9c9eea66e432be97c1c43f44425ee0b878ecaa02
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 6, 2024https://github.com/python/cpython/pull/126501#event-15151078747
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 6, 2024 https://github.com/python/cpython/pull/126501#ref-issue-2638206992
test_ssl: non_linux_skip_if_other_okay_error assumes err.reason is a string #126499 https://github.com/python/cpython/issues/126499
https://github.com/encukou
encukouhttps://github.com/encukou
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Nov 6, 2024https://github.com/python/cpython/pull/126501#event-15151128190
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Nov 7, 2024 https://github.com/python/cpython/pull/126501#pullrequestreview-2420029930
View reviewed changes https://github.com/python/cpython/pull/126501/files/9c9eea66e432be97c1c43f44425ee0b878ecaa02
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 7, 2024https://github.com/python/cpython/pull/126501#event-15170480617
https://github.com/encukou
encukouhttps://github.com/encukou
78ad7e6https://github.com/python/cpython/commit/78ad7e632248dc989378cabeb797b9f3d940d9f2
Nov 7, 2024https://github.com/python/cpython/pull/126501#event-15176508527
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Nov 7, 2024https://github.com/python/cpython/pull/126501#event-15176509307
https://github.com/encukou
encukouhttps://github.com/encukou
November 7, 2024 10:07https://github.com/python/cpython/pull/126501#event-15176522830
https://github.com/encukou
encukouhttps://github.com/encukou
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Nov 8, 2024https://github.com/python/cpython/pull/126501#event-15210598456
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Nov 8, 2024https://github.com/python/cpython/pull/126501#issuecomment-2464378862
@encukouhttps://github.com/encukou
Please reload this pagehttps://github.com/python/cpython/pull/126501
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Nov 8, 2024https://github.com/python/cpython/pull/126501#issuecomment-2464378866
@encukouhttps://github.com/encukou
Please reload this pagehttps://github.com/python/cpython/pull/126501
miss-islingtonhttps://github.com/miss-islington
Nov 8, 2024 https://github.com/python/cpython/pull/126501#ref-commit-29fa445
https://github.com/encukou
https://github.com/miss-islington
pythongh-126499https://github.com/python/cpython/issues/126499
: test_ssl: Don't assume err.reason is a string (https://github.com/miss-islington/cpython/commit/29fa44517d6fbc56d8a4e4dd7d07ead38653904e
pytho…https://github.com/python/cpython/pull/126501
29fa445https://github.com/miss-islington/cpython/commit/29fa44517d6fbc56d8a4e4dd7d07ead38653904e
…nGH-126501https://github.com/python/cpython/pull/126501
78ad7e6https://github.com/miss-islington/cpython/commit/78ad7e632248dc989378cabeb797b9f3d940d9f2
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 8, 2024https://github.com/python/cpython/pull/126501#issuecomment-2464379146
GH-126573https://github.com/python/cpython/pull/126573
3.12 branchhttps://github.com/python/cpython/tree/3.12
Please reload this pagehttps://github.com/python/cpython/pull/126501
miss-islingtonhttps://github.com/miss-islington
Nov 8, 2024 https://github.com/python/cpython/pull/126501#ref-commit-7f5096f
https://github.com/encukou
https://github.com/miss-islington
pythongh-126499https://github.com/python/cpython/issues/126499
: test_ssl: Don't assume err.reason is a string (https://github.com/miss-islington/cpython/commit/7f5096f00c610279897ac3a1ffd00702a86c0aae
pytho…https://github.com/python/cpython/pull/126501
7f5096fhttps://github.com/miss-islington/cpython/commit/7f5096f00c610279897ac3a1ffd00702a86c0aae
…nGH-126501https://github.com/python/cpython/pull/126501
78ad7e6https://github.com/miss-islington/cpython/commit/78ad7e632248dc989378cabeb797b9f3d940d9f2
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Nov 8, 2024https://github.com/python/cpython/pull/126501#event-15210605525
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 8, 2024https://github.com/python/cpython/pull/126501#issuecomment-2464379289
GH-126574https://github.com/python/cpython/pull/126574
3.13 branchhttps://github.com/python/cpython/tree/3.13
Please reload this pagehttps://github.com/python/cpython/pull/126501
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Nov 8, 2024https://github.com/python/cpython/pull/126501#event-15210608627
encukouhttps://github.com/encukou
Nov 11, 2024 https://github.com/python/cpython/pull/126501#ref-commit-1e4b9c7
https://github.com/miss-islington
https://github.com/encukou
[3.13]https://github.com/python/cpython/commit/1e4b9c7faedf118d920150488ca2e0bc32f8ed85
gh-126499https://github.com/python/cpython/issues/126499
: test_ssl: Don't assume err.reason is a string (https://github.com/python/cpython/commit/1e4b9c7faedf118d920150488ca2e0bc32f8ed85
GH-1…https://github.com/python/cpython/pull/126501
1e4b9c7https://github.com/python/cpython/commit/1e4b9c7faedf118d920150488ca2e0bc32f8ed85
…26501https://github.com/python/cpython/pull/126501
GH-126574https://github.com/python/cpython/pull/126574
gh-126499https://github.com/python/cpython/issues/126499
GH-126501https://github.com/python/cpython/pull/126501
78ad7e6https://github.com/python/cpython/commit/78ad7e632248dc989378cabeb797b9f3d940d9f2
encukouhttps://github.com/encukou
Nov 11, 2024 https://github.com/python/cpython/pull/126501#ref-commit-d62f100
https://github.com/miss-islington
https://github.com/encukou
[3.12]https://github.com/python/cpython/commit/d62f100fe1184c3d14d1ee51cfaaf3542c236ae7
gh-126499https://github.com/python/cpython/issues/126499
: test_ssl: Don't assume err.reason is a string (https://github.com/python/cpython/commit/d62f100fe1184c3d14d1ee51cfaaf3542c236ae7
GH-1…https://github.com/python/cpython/pull/126501
d62f100https://github.com/python/cpython/commit/d62f100fe1184c3d14d1ee51cfaaf3542c236ae7
…26501https://github.com/python/cpython/pull/126501
GH-126573https://github.com/python/cpython/pull/126573
gh-126499https://github.com/python/cpython/issues/126499
GH-126501https://github.com/python/cpython/pull/126501
78ad7e6https://github.com/python/cpython/commit/78ad7e632248dc989378cabeb797b9f3d940d9f2
picnixzhttps://github.com/picnixz
Dec 8, 2024 https://github.com/python/cpython/pull/126501#ref-commit-53c3f88
https://github.com/encukou
https://github.com/picnixz
pythongh-126499https://github.com/python/cpython/issues/126499
: test_ssl: Don't assume err.reason is a string (https://github.com/picnixz/cpython/commit/53c3f88cf1294830ff03b961c57f8d7597817917
pytho…https://github.com/python/cpython/pull/126501
53c3f88https://github.com/picnixz/cpython/commit/53c3f88cf1294830ff03b961c57f8d7597817917
…nGH-126501https://github.com/python/cpython/pull/126501
ebonnalhttps://github.com/ebonnal
Jan 12, 2025 https://github.com/python/cpython/pull/126501#ref-commit-538ea9a
https://github.com/encukou
https://github.com/ebonnal
pythongh-126499https://github.com/python/cpython/issues/126499
: test_ssl: Don't assume err.reason is a string (https://github.com/ebonnal/cpython/commit/538ea9acea09aa4b2c03d7df03bbda2db7f7295a
pytho…https://github.com/python/cpython/pull/126501
538ea9ahttps://github.com/ebonnal/cpython/commit/538ea9acea09aa4b2c03d7df03bbda2db7f7295a
…nGH-126501https://github.com/python/cpython/pull/126501
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126501
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/python/cpython/pull/126501/files/9c9eea66e432be97c1c43f44425ee0b878ecaa02
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Please reload this pagehttps://github.com/python/cpython/pull/126501
https://github.com/encukou
https://github.com/gpshead
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.