Title: [3.11] gh-87846: test_io: Ignore OpenWrapper in test___all__ by encukou · Pull Request #126478 · python/cpython · GitHub
Open Graph Title: [3.11] gh-87846: test_io: Ignore OpenWrapper in test___all__ by encukou · Pull Request #126478 · python/cpython
X Title: [3.11] gh-87846: test_io: Ignore OpenWrapper in test___all__ by encukou · Pull Request #126478 · python/cpython
Description: @pablogsal, are you interested in fixing 3.11 buildbots that consistently warn, rather than fail? test_io fails if test_openwrapper runs before test___all__. This consistently happens on some refleaks buildbots, for example Windows or Fedora, but it's only marked as a warning: when only test___all__ is re-run in a fresh process, it succeeds. Locally, this can be reproduced by running test_openwrapper and test__all__, twice (since in a single run, test_openwrapper comes after test___all__). I don't know of a more elegant way than: ./python -m test test_io test_io -m '*test_[o_][p_][ea][nl][wl]*' -v The reason is that the deprecated OpenWrapper is added to the module on demand in __getattr__, after which it shows up in dir(io). Add it to not_exported so that check__all__ ignores it when it exists. Issue: gh-87846
Open Graph Description: @pablogsal, are you interested in fixing 3.11 buildbots that consistently warn, rather than fail? test_io fails if test_openwrapper runs before test___all__. This consistently happens on some ref...
X Description: @pablogsal, are you interested in fixing 3.11 buildbots that consistently warn, rather than fail? test_io fails if test_openwrapper runs before test___all__. This consistently happens on some ref...
Opengraph URL: https://github.com/python/cpython/pull/126478
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:fe0e9c43-9ded-1aaa-790f-71e546a347d8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EBF4:6C43E:4E3D36:6C3167:696A753A |
| html-safe-nonce | f8a4231168216b229c71da6f7ebba877bf421f5f5c9a0e43c7de3bd8bea73696 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkY0OjZDNDNFOjRFM0QzNjo2QzMxNjc6Njk2QTc1M0EiLCJ2aXNpdG9yX2lkIjoiODQzNTE5MjczNzQ3OTQyMzI5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c2a29eb16fafe95b4c16ea9b333fe799aa3c82b7f4755ff166da865ffe287943 |
| hovercard-subject-tag | pull_request:2164790318 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/126478/files |
| twitter:image | https://avatars.githubusercontent.com/u/302922?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/302922?s=400&v=4 |
| og:image:alt | @pablogsal, are you interested in fixing 3.11 buildbots that consistently warn, rather than fail? test_io fails if test_openwrapper runs before test___all__. This consistently happens on some ref... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a0b6893c221f98f607598e939299fdf5763435d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width