René's URL Explorer Experiment


Title: gh-116772: Cache `getenv` result in `optimizer.c` to reduce calls by Wulian233 · Pull Request #126439 · python/cpython · GitHub

Open Graph Title: gh-116772: Cache `getenv` result in `optimizer.c` to reduce calls by Wulian233 · Pull Request #126439 · python/cpython

X Title: gh-116772: Cache `getenv` result in `optimizer.c` to reduce calls by Wulian233 · Pull Request #126439 · python/cpython

Description: This is my first time PR for part C, which looks like it might be a small improvement, hopefully I'm not doing anything wrong🙂 About 0.5% faster? (from issue) Issue: gh-116772

Open Graph Description: This is my first time PR for part C, which looks like it might be a small improvement, hopefully I'm not doing anything wrong🙂 About 0.5% faster? (from issue) Issue: gh-116772

X Description: This is my first time PR for part C, which looks like it might be a small improvement, hopefully I'm not doing anything wrong🙂 About 0.5% faster? (from issue) Issue: gh-116772

Opengraph URL: https://github.com/python/cpython/pull/126439

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9f06b4e0-b9e8-47cc-7cb8-a58846af8b14
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE7D4:2D40DE:3A9ED7F:4A822E7:6B023F5F
html-safe-nonce06eb35c06d9b5515d3607265b28ebfb53ed2b725a0b4cd108a32765d5d1bae4f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0Q0OjJENDBERTozQTlFRDdGOjRBODIyRTc6NkIwMjNGNUYiLCJ2aXNpdG9yX2lkIjoiNjEzMTUzOTI2NzIzODEzMjE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca8920e8c96da3cf01e3636bf13edb63dc9c62164e1e121ba4d7768f605250577
hovercard-subject-tagpull_request:2162908254
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/126439/files
twitter:imagehttps://avatars.githubusercontent.com/u/71213467?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/71213467?s=400&v=4
og:image:altThis is my first time PR for part C, which looks like it might be a small improvement, hopefully I'm not doing anything wrong🙂 About 0.5% faster? (from issue) Issue: gh-116772
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/126439/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126439%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126439%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/126439/files
Reloadhttps://github.com/python/cpython/pull/126439/files
Reloadhttps://github.com/python/cpython/pull/126439/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Wulian233https://github.com/Wulian233
python:mainhttps://github.com/python/cpython/tree/main
Wulian233:getenvhttps://github.com/Wulian233/cpython/tree/getenv
Conversation 5 https://github.com/python/cpython/pull/126439
Commits 5 https://github.com/python/cpython/pull/126439/commits
Checks 0 https://github.com/python/cpython/pull/126439/checks
Files changed https://github.com/python/cpython/pull/126439/files
Please reload this pagehttps://github.com/python/cpython/pull/126439/files
gh-116772: Cache getenv result in optimizer.c to reduce calls https://github.com/python/cpython/pull/126439/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/126439/files
537431e Cache getenv result in optimizer.c to reduce calls Nov 5, 2024 https://github.com/python/cpython/pull/126439/commits/537431e61278e5fe374fd1b084fb424e84102634
5c59297 Update optimizer.c Wulian233 Apr 29, 2025 https://github.com/python/cpython/pull/126439/commits/5c5929756582624fd5a185b019fad1d638136ab6
f25a357 try fix Wulian233 Apr 29, 2025 https://github.com/python/cpython/pull/126439/commits/f25a3576f67c25ddda228d672338e7a67d1fdae2
8dace6c Merge branch 'python:main' into getenv Wulian233 Apr 29, 2025 https://github.com/python/cpython/pull/126439/commits/8dace6c23640b00fe9ac02939a7cfc1e8303062a
acad35f not safe WIP Wulian233 Apr 29, 2025 https://github.com/python/cpython/pull/126439/commits/acad35f3d37b672dddddf1a66ae972b1fd068d84
Clear filters https://github.com/python/cpython/pull/126439/files
Please reload this pagehttps://github.com/python/cpython/pull/126439/files
Please reload this pagehttps://github.com/python/cpython/pull/126439/files
2024-11-05-19-44-32.gh-issue-116772.jC4dMr.rst https://github.com/python/cpython/pull/126439/files#diff-8c29b812de5c269fd688005f32ce5498ff30cdf41238b9c476744f7e0737711b
optimizer.c https://github.com/python/cpython/pull/126439/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
Misc/NEWS.d/next/Core_and_Builtins/2024-11-05-19-44-32.gh-issue-116772.jC4dMr.rsthttps://github.com/python/cpython/pull/126439/files#diff-8c29b812de5c269fd688005f32ce5498ff30cdf41238b9c476744f7e0737711b
View file https://github.com/Wulian233/cpython/blob/acad35f3d37b672dddddf1a66ae972b1fd068d84/Misc/NEWS.d/next/Core_and_Builtins/2024-11-05-19-44-32.gh-issue-116772.jC4dMr.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/126439/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L302
Python/optimizer.chttps://github.com/python/cpython/pull/126439/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
View file https://github.com/Wulian233/cpython/blob/acad35f3d37b672dddddf1a66ae972b1fd068d84/Python/optimizer.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/126439/{{ revealButtonHref }}
https://github.com/python/cpython/pull/126439/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Apr 29, 2025https://github.com/python/cpython/pull/126439/files#r2066246721
Please reload this pagehttps://github.com/python/cpython/pull/126439/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/126439/files
https://github.com/python/cpython/pull/126439/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
https://github.com/python/cpython/pull/126439/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
https://github.com/python/cpython/pull/126439/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.