René's URL Explorer Experiment


Title: gh-116772: Cache `getenv` result in `optimizer.c` to reduce calls by Wulian233 · Pull Request #126439 · python/cpython · GitHub

Open Graph Title: gh-116772: Cache `getenv` result in `optimizer.c` to reduce calls by Wulian233 · Pull Request #126439 · python/cpython

X Title: gh-116772: Cache `getenv` result in `optimizer.c` to reduce calls by Wulian233 · Pull Request #126439 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This is my first time PR for part C, which looks like it might be a small improvement, hopefully I'm not doing anything wrong🙂 About 0.5% faster? (from issue) Issue: Optimizer calls getenv on...

X Description: This is my first time PR for part C, which looks like it might be a small improvement, hopefully I'm not doing anything wrong🙂 About 0.5% faster? (from issue) Issue: Optimizer calls geten...

Opengraph URL: https://github.com/python/cpython/pull/126439

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5b9eec09-5848-860b-5b6e-283f53077102
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9DC2:EAD6D:CB43F6:FE5DC2:6B023A82
html-safe-noncec6bbaff3f75c560b7f60cccdf4c242e89f05c94496d800bd8fdfdcd6215ecaf9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5REMyOkVBRDZEOkNCNDNGNjpGRTVEQzI6NkIwMjNBODIiLCJ2aXNpdG9yX2lkIjoiNzM2MzAzMTk0MjUwNzQxMjA5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf570f6dd66b92995974b04eea8e57aacc4194457c50a307268ef79f4a352b835
hovercard-subject-tagpull_request:2162908254
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/126439/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9b6600fa2f1fe761263d8be93a152b945146123ef9cff2efa3e2d086d0057244/python/cpython/pull/126439
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9b6600fa2f1fe761263d8be93a152b945146123ef9cff2efa3e2d086d0057244/python/cpython/pull/126439
og:image:altThis is my first time PR for part C, which looks like it might be a small improvement, hopefully I'm not doing anything wrong🙂 About 0.5% faster? (from issue) Issue: Optimizer calls getenv on...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameWulian233
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/126439#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126439
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126439
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/126439
Reloadhttps://github.com/python/cpython/pull/126439
Reloadhttps://github.com/python/cpython/pull/126439
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
Wulian233https://github.com/Wulian233
python:mainhttps://github.com/python/cpython/tree/main
Wulian233:getenvhttps://github.com/Wulian233/cpython/tree/getenv
Conversationhttps://github.com/python/cpython/pull/126439
Commits5 (5)https://github.com/python/cpython/pull/126439/commits
Checkshttps://github.com/python/cpython/pull/126439/checks
Files changedhttps://github.com/python/cpython/pull/126439/files
gh-116772: Cache getenv result in optimizer.c to reduce callshttps://github.com/python/cpython/pull/126439#top
Wulian233https://github.com/Wulian233
python:mainhttps://github.com/python/cpython/tree/main
Wulian233:getenvhttps://github.com/Wulian233/cpython/tree/getenv
https://github.com/Wulian233
Wulian233https://github.com/Wulian233
Nov 5, 2024https://github.com/python/cpython/pull/126439#issue-2635253191
Please reload this pagehttps://github.com/python/cpython/pull/126439
Optimizer calls getenv on every optimization run #116772https://github.com/python/cpython/issues/116772
Please reload this pagehttps://github.com/python/cpython/pull/126439
Cache getenv result in optimizer.c to reduce callshttps://github.com/python/cpython/pull/126439/commits/537431e61278e5fe374fd1b084fb424e84102634
537431ehttps://github.com/python/cpython/pull/126439/commits/537431e61278e5fe374fd1b084fb424e84102634
https://github.com/Wulian233
Wulian233https://github.com/Wulian233
markshannonhttps://github.com/markshannon
code ownerhttps://github.com/python/cpython/blob/78842e4a98994a218a93992a2a1e3ca3eaa28e79/.github/CODEOWNERS#L42
November 5, 2024 11:55https://github.com/python/cpython/pull/126439#event-15118590320
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Nov 5, 2024https://github.com/python/cpython/pull/126439#event-15118591222
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 5, 2024 https://github.com/python/cpython/pull/126439#ref-issue-2185163001
Optimizer calls getenv on every optimization run #116772 https://github.com/python/cpython/issues/116772
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Nov 5, 2024 https://github.com/python/cpython/pull/126439#pullrequestreview-2415445539
View reviewed changes https://github.com/python/cpython/pull/126439/files/537431e61278e5fe374fd1b084fb424e84102634
Python/optimizer.chttps://github.com/python/cpython/pull/126439/files/537431e61278e5fe374fd1b084fb424e84102634#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Nov 5, 2024https://github.com/python/cpython/pull/126439#discussion_r1829241998
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/126439
https://github.com/Wulian233
Wulian233https://github.com/Wulian233
November 5, 2024 12:44https://github.com/python/cpython/pull/126439#event-15119253922
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Nov 5, 2024https://github.com/python/cpython/pull/126439#event-15119254525
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Nov 5, 2024 https://github.com/python/cpython/pull/126439#pullrequestreview-2416789479
View reviewed changes https://github.com/python/cpython/pull/126439/files/537431e61278e5fe374fd1b084fb424e84102634
Python/optimizer.chttps://github.com/python/cpython/pull/126439/files/537431e61278e5fe374fd1b084fb424e84102634#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
Please reload this pagehttps://github.com/python/cpython/pull/126439
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Nov 5, 2024https://github.com/python/cpython/pull/126439#issuecomment-2458432887
@mdboomhttps://github.com/mdboom
Please reload this pagehttps://github.com/python/cpython/pull/126439
https://github.com/mdboom
mdboomhttps://github.com/mdboom
Nov 6, 2024https://github.com/python/cpython/pull/126439#issuecomment-2460089131
@mdboomhttps://github.com/mdboom
@Wulian233https://github.com/Wulian233
Please reload this pagehttps://github.com/python/cpython/pull/126439
Wulian233https://github.com/Wulian233
April 29, 2025 19:08https://github.com/python/cpython/pull/126439#commits-pushed-5c59297
https://github.com/Wulian233
Update optimizer.chttps://github.com/python/cpython/pull/126439/commits/5c5929756582624fd5a185b019fad1d638136ab6
5c59297https://github.com/python/cpython/pull/126439/commits/5c5929756582624fd5a185b019fad1d638136ab6
https://github.com/Wulian233
try fixhttps://github.com/python/cpython/pull/126439/commits/f25a3576f67c25ddda228d672338e7a67d1fdae2
f25a357https://github.com/python/cpython/pull/126439/commits/f25a3576f67c25ddda228d672338e7a67d1fdae2
https://github.com/Wulian233
Merge branch 'python:main' into getenvhttps://github.com/python/cpython/pull/126439/commits/8dace6c23640b00fe9ac02939a7cfc1e8303062a
8dace6chttps://github.com/python/cpython/pull/126439/commits/8dace6c23640b00fe9ac02939a7cfc1e8303062a
https://github.com/Wulian233
Wulian233https://github.com/Wulian233
April 29, 2025 11:14https://github.com/python/cpython/pull/126439#event-17452970970
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 29, 2025https://github.com/python/cpython/pull/126439#event-17452971599
https://github.com/Wulian233
not safe WIPhttps://github.com/python/cpython/pull/126439/commits/acad35f3d37b672dddddf1a66ae972b1fd068d84
acad35fhttps://github.com/python/cpython/pull/126439/commits/acad35f3d37b672dddddf1a66ae972b1fd068d84
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Apr 29, 2025 https://github.com/python/cpython/pull/126439#pullrequestreview-2803285486
View reviewed changes https://github.com/python/cpython/pull/126439/files/acad35f3d37b672dddddf1a66ae972b1fd068d84
Python/optimizer.chttps://github.com/python/cpython/pull/126439/files/acad35f3d37b672dddddf1a66ae972b1fd068d84#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Apr 29, 2025https://github.com/python/cpython/pull/126439#discussion_r2066246721
Please reload this pagehttps://github.com/python/cpython/pull/126439
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/126439
https://github.com/Wulian233
Wulian233https://github.com/Wulian233
Dec 15, 2025https://github.com/python/cpython/pull/126439#event-21565067603
https://github.com/Wulian233
Wulian233https://github.com/Wulian233
December 15, 2025 12:18https://github.com/python/cpython/pull/126439#event-21565070842
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126439
https://github.com/erlend-aasland
erlend-aasland https://github.com/erlend-aasland
https://github.com/python/cpython/pull/126439/files/537431e61278e5fe374fd1b084fb424e84102634
https://github.com/Fidget-Spinner
Fidget-Spinner https://github.com/Fidget-Spinner
https://github.com/python/cpython/pull/126439/files/acad35f3d37b672dddddf1a66ae972b1fd068d84
https://github.com/markshannon
markshannon https://github.com/markshannon
Please reload this pagehttps://github.com/python/cpython/pull/126439
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Please reload this pagehttps://github.com/python/cpython/pull/126439
https://github.com/Wulian233
https://github.com/Fidget-Spinner
https://github.com/mdboom
https://github.com/erlend-aasland
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.