Title: gh-99108: add HACL*-based 1-shot HMAC implementation by picnixz · Pull Request #126359 · python/cpython · GitHub
Open Graph Title: gh-99108: add HACL*-based 1-shot HMAC implementation by picnixz · Pull Request #126359 · python/cpython
X Title: gh-99108: add HACL*-based 1-shot HMAC implementation by picnixz · Pull Request #126359 · python/cpython
Description: I'm opening a PR but I'm pretty sure that there are multiple things to discuss: HACL* HMAC requires including hash functions headers (by the way, SHA1 and MD5 headers are not included in Hacl_HMAC.h, but they are included in the .c; you might want to check that on your side @msprotz). I decided to create static intermediate libraries just. Otherwise, I'm getting a bunch of "undefined symbols". I know that we have a simplification PR (#119320) to get rid of *.a. The reason I kept (and used) them is the following: When I use normal dependencies in Setup.stdlib.in, I get a bunch of warnings "Makefile:3471: warning: overriding recipe for target 'Modules/_hacl/Hacl_Hash_MD5.o" for instance. In addition, I don't know how to specify that the HMAC module should use libHacl_Hash_Blake2.a (I get "gcc: error: Modules/_hacl/libHacl_Hash_Blake2.a: No such file or directory"). The build I suggest compiles on my machine and I would appreciate if @erlend-aasland could help me in cleanng it up. I'm leaving my dev session in a few hours and won't be back until Wednesday. I need to test the implementatino as well (for SHA1, I think something is weird because I get different results, well mainly junk at the end but I'll need to check again when I'm back). Issue: gh-99108
Open Graph Description: I'm opening a PR but I'm pretty sure that there are multiple things to discuss: HACL* HMAC requires including hash functions headers (by the way, SHA1 and MD5 headers are not included in H...
X Description: I'm opening a PR but I'm pretty sure that there are multiple things to discuss: HACL* HMAC requires including hash functions headers (by the way, SHA1 and MD5 headers are not inclu...
Opengraph URL: https://github.com/python/cpython/pull/126359
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:edc6651b-9528-17f6-d138-b772fc658253 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | B0D8:30006B:97C67B:CB3C0A:6969C031 |
| html-safe-nonce | 26ded0f29df347abc9269ffd756916368c3093a794e00bcc20991a0f5a044c16 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMEQ4OjMwMDA2Qjo5N0M2N0I6Q0IzQzBBOjY5NjlDMDMxIiwidmlzaXRvcl9pZCI6IjkwMzE1NDQxMDE4MDU4NjcwNTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 957bb4332032338fb7a81c953eb55d71a5bd58bc8ae313865cc719d506072070 |
| hovercard-subject-tag | pull_request:2159628763 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/126359/checks |
| twitter:image | https://avatars.githubusercontent.com/u/10796600?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/10796600?s=400&v=4 |
| og:image:alt | I'm opening a PR but I'm pretty sure that there are multiple things to discuss: HACL* HMAC requires including hash functions headers (by the way, SHA1 and MD5 headers are not included in H... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | acedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 83c08c21cdda978090dc44364b71aa5bc6dcea79 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width