| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f48d95f7-6e74-19d8-5ead-bf484d30b110 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C8DE:34E766:8BBC76:BD9FAF:6A554F56 |
| html-safe-nonce | 11eb7d502b11b7deb794b1b590edaa2a21e83ae3084c2f3cf42417985b4b08b6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOERFOjM0RTc2Njo4QkJDNzY6QkQ5RkFGOjZBNTU0RjU2IiwidmlzaXRvcl9pZCI6IjYwMjkzMzkwMzUzODE4Nzg2MTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | dc9fb26c55948e310265b88e8b05d1d0b642ff2d3d377b247bb8bbf9bd3a5db9 |
| hovercard-subject-tag | pull_request:2157970880 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/126272/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6477466726331e6680813353a2e046717010d783cb1043eab69c6a270197d567/python/cpython/pull/126272 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6477466726331e6680813353a2e046717010d783cb1043eab69c6a270197d567/python/cpython/pull/126272 |
| og:image:alt | I propose to deprecate socket.SocketType. There's no reason to publicly expose _socket.socket separately from socket.socket, the only type that moat users should care about.
SocketType isn'... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rruuaanng |
| hostname | github.com |
| expected-hostname | github.com |
| None | cd9eea424140838b22e9eabd53d92b5702617ddd6d76efcd3a37f08d44309ca5 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3084b9f587e8f1e19803bbe0c77ac77ce3c99c5c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/126272#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126272 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126272 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/126272 |
| Reload | https://github.com/python/cpython/pull/126272 |
| Reload | https://github.com/python/cpython/pull/126272 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
35k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| rruuaanng | https://github.com/rruuaanng |
| python:main | https://github.com/python/cpython/tree/main |
| rruuaanng:gh88427 | https://github.com/rruuaanng/cpython/tree/gh88427 |
| Conversation | https://github.com/python/cpython/pull/126272 |
| Commits48 (48) | https://github.com/python/cpython/pull/126272/commits |
| Checks | https://github.com/python/cpython/pull/126272/checks |
| Files changed | https://github.com/python/cpython/pull/126272/files |
| gh-88427: Deprecate socket.SocketType | https://github.com/python/cpython/pull/126272#top |
| rruuaanng | https://github.com/rruuaanng |
| python:main | https://github.com/python/cpython/tree/main |
| rruuaanng:gh88427 | https://github.com/rruuaanng/cpython/tree/gh88427 |
|
| https://github.com/rruuaanng |
| rruuaanng | https://github.com/rruuaanng |
| Nov 1, 2024 | https://github.com/python/cpython/pull/126272#issue-2628923701 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| @JelleZijlstra | https://github.com/JelleZijlstra |
| SocketType documentation misleading #88427 | https://github.com/python/cpython/issues/88427 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| https://github.com/rruuaanng |
| rruuaanng | https://github.com/rruuaanng |
| Nov 1, 2024 | https://github.com/python/cpython/pull/126272#event-15066128079 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
Nov 1, 2024
| https://github.com/python/cpython/pull/126272#ref-issue-1199059273 |
|
SocketType documentation misleading
#88427
| https://github.com/python/cpython/issues/88427 |
| https://github.com/ZeroIntensity |
| ZeroIntensity | https://github.com/ZeroIntensity |
|
Nov 1, 2024
| https://github.com/python/cpython/pull/126272#pullrequestreview-2409984579 |
|
View reviewed changes
| https://github.com/python/cpython/pull/126272/files |
| ZeroIntensity | https://github.com/ZeroIntensity |
| https://github.com/python/cpython/pull/126272#pullrequestreview-2409984579 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| PEP-562 | https://peps.python.org/562 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Nov 1, 2024 | https://github.com/python/cpython/pull/126272#event-15066457034 |
| https://github.com/rruuaanng |
| rruuaanng | https://github.com/rruuaanng |
| Nov 1, 2024 | https://github.com/python/cpython/pull/126272#issuecomment-2451799290 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Nov 1, 2024 | https://github.com/python/cpython/pull/126272#issuecomment-2451929842 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| https://github.com/rruuaanng |
| rruuaanng | https://github.com/rruuaanng |
| Nov 1, 2024 | https://github.com/python/cpython/pull/126272#issuecomment-2451935666 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
|
| https://github.com/rruuaanng |
| deprecated SocketType | https://github.com/python/cpython/pull/126272/commits/341a29e145cb110262009ffaf0e4c7b57e3894a1 |
| 341a29e | https://github.com/python/cpython/pull/126272/commits/341a29e145cb110262009ffaf0e4c7b57e3894a1 |
| https://github.com/rruuaanng |
| rruuaanng | https://github.com/rruuaanng |
| force-pushed | https://github.com/python/cpython/compare/e68ac9b8698ee0b111a8dd20160657b2ce39b7a2..341a29e145cb110262009ffaf0e4c7b57e3894a1 |
| e68ac9b | https://github.com/python/cpython/commit/e68ac9b8698ee0b111a8dd20160657b2ce39b7a2 |
| 341a29e | https://github.com/python/cpython/commit/341a29e145cb110262009ffaf0e4c7b57e3894a1 |
|
Compare
| https://github.com/python/cpython/compare/e68ac9b8698ee0b111a8dd20160657b2ce39b7a2..341a29e145cb110262009ffaf0e4c7b57e3894a1 |
| November 1, 2024 14:51 | https://github.com/python/cpython/pull/126272#event-15070103734 |
| rruuaanng | https://github.com/rruuaanng |
| November 1, 2024 23:09 | https://github.com/python/cpython/pull/126272#commits-pushed-a4ef847 |
|
| https://github.com/rruuaanng |
| _socket.socket change to _socket.SocketType | https://github.com/python/cpython/pull/126272/commits/a4ef847392e221f4c111fb0d79629b7a45cec996 |
| a4ef847 | https://github.com/python/cpython/pull/126272/commits/a4ef847392e221f4c111fb0d79629b7a45cec996 |
|
| https://github.com/rruuaanng |
| Remove return | https://github.com/python/cpython/pull/126272/commits/5a57cb156b48bbbde9ae8540eb9c54f6222a03f6 |
| 5a57cb1 | https://github.com/python/cpython/pull/126272/commits/5a57cb156b48bbbde9ae8540eb9c54f6222a03f6 |
| https://github.com/ZeroIntensity |
| ZeroIntensity | https://github.com/ZeroIntensity |
|
Nov 1, 2024
| https://github.com/python/cpython/pull/126272#pullrequestreview-2410270837 |
|
View reviewed changes
| https://github.com/python/cpython/pull/126272/files/5a57cb156b48bbbde9ae8540eb9c54f6222a03f6 |
| Doc/library/socket.rst | https://github.com/python/cpython/pull/126272/files/5a57cb156b48bbbde9ae8540eb9c54f6222a03f6#diff-e9e93d6b76a8a1cf0825d557b12e7ce3e67081cad650063eee520b81fd651943 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| Lib/socket.py | https://github.com/python/cpython/pull/126272/files/5a57cb156b48bbbde9ae8540eb9c54f6222a03f6#diff-081d33d48e9390350bb1ef860c52de799d1647b58e33b07173ae2549532cbfbe |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| Misc/NEWS.d/next/Library/2024-11-01-20-09-53.gh-issue-88427.chYNT6.rst | https://github.com/python/cpython/pull/126272/files/5a57cb156b48bbbde9ae8540eb9c54f6222a03f6#diff-afc5cf582f347311ff987afb1981f3860ea495451259e8c1bec4e61d084b3f09 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| rruuaanng | https://github.com/rruuaanng |
| November 1, 2024 23:19 | https://github.com/python/cpython/pull/126272#commits-pushed-72f7c3d |
|
| https://github.com/rruuaanng |
| Change docs | https://github.com/python/cpython/pull/126272/commits/72f7c3d3f1399c321fc54ad8d9b82d163a184526 |
| 72f7c3d | https://github.com/python/cpython/pull/126272/commits/72f7c3d3f1399c321fc54ad8d9b82d163a184526 |
|
| https://github.com/rruuaanng |
| Change NEWS | https://github.com/python/cpython/pull/126272/commits/58b305d0a918bf06b086aec0f4d33ee75f193556 |
| 58b305d | https://github.com/python/cpython/pull/126272/commits/58b305d0a918bf06b086aec0f4d33ee75f193556 |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
|
Nov 1, 2024
| https://github.com/python/cpython/pull/126272#pullrequestreview-2410279416 |
|
View reviewed changes
| https://github.com/python/cpython/pull/126272/files/58b305d0a918bf06b086aec0f4d33ee75f193556 |
| Lib/socket.py | https://github.com/python/cpython/pull/126272/files/5a57cb156b48bbbde9ae8540eb9c54f6222a03f6#diff-081d33d48e9390350bb1ef860c52de799d1647b58e33b07173ae2549532cbfbe |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| Doc/library/socket.rst | https://github.com/python/cpython/pull/126272/files/5a57cb156b48bbbde9ae8540eb9c54f6222a03f6#diff-e9e93d6b76a8a1cf0825d557b12e7ce3e67081cad650063eee520b81fd651943 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| Misc/NEWS.d/next/Library/2024-11-01-20-09-53.gh-issue-88427.chYNT6.rst | https://github.com/python/cpython/pull/126272/files/58b305d0a918bf06b086aec0f4d33ee75f193556#diff-afc5cf582f347311ff987afb1981f3860ea495451259e8c1bec4e61d084b3f09 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| rruuaanng | https://github.com/rruuaanng |
| November 1, 2024 23:25 | https://github.com/python/cpython/pull/126272#commits-pushed-73b14ea |
|
| https://github.com/rruuaanng |
| Change docs | https://github.com/python/cpython/pull/126272/commits/73b14eaca1551ee7ac4b5cff1515d83a13bac9ed |
| 73b14ea | https://github.com/python/cpython/pull/126272/commits/73b14eaca1551ee7ac4b5cff1515d83a13bac9ed |
|
| https://github.com/rruuaanng |
| Change NEWS | https://github.com/python/cpython/pull/126272/commits/2c2e8e33ce305f026874a3d80802f93dbe4434d3 |
| 2c2e8e3 | https://github.com/python/cpython/pull/126272/commits/2c2e8e33ce305f026874a3d80802f93dbe4434d3 |
|
| https://github.com/rruuaanng |
| Move import | https://github.com/python/cpython/pull/126272/commits/3ea9169a25947c137cc49551d56eb418435e332b |
| 3ea9169 | https://github.com/python/cpython/pull/126272/commits/3ea9169a25947c137cc49551d56eb418435e332b |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
|
Nov 1, 2024
| https://github.com/python/cpython/pull/126272#pullrequestreview-2410322651 |
|
View reviewed changes
| https://github.com/python/cpython/pull/126272/files/3ea9169a25947c137cc49551d56eb418435e332b |
| Lib/socket.py | https://github.com/python/cpython/pull/126272/files/3ea9169a25947c137cc49551d56eb418435e332b#diff-081d33d48e9390350bb1ef860c52de799d1647b58e33b07173ae2549532cbfbe |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| rruuaanng | https://github.com/rruuaanng |
| November 1, 2024 23:45 | https://github.com/python/cpython/pull/126272#commits-pushed-3b7d187 |
|
| https://github.com/rruuaanng |
| Add return | https://github.com/python/cpython/pull/126272/commits/3b7d187e8fe0559dcaa04becc1cca3e3fd7eef2e |
| 3b7d187 | https://github.com/python/cpython/pull/126272/commits/3b7d187e8fe0559dcaa04becc1cca3e3fd7eef2e |
|
| https://github.com/rruuaanng |
| socket rename to SocketType | https://github.com/python/cpython/pull/126272/commits/188a92418ee068bfb3dca05ae70fc2d6c65f39fe |
| 188a924 | https://github.com/python/cpython/pull/126272/commits/188a92418ee068bfb3dca05ae70fc2d6c65f39fe |
| https://github.com/rruuaanng |
| rruuaanng | https://github.com/rruuaanng |
| Nov 2, 2024 | https://github.com/python/cpython/pull/126272#issuecomment-2452770469 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| rruuaanng | https://github.com/rruuaanng |
| November 2, 2024 08:52 | https://github.com/python/cpython/pull/126272#commits-pushed-ce4bfa6 |
|
| https://github.com/rruuaanng |
| Remove defined | https://github.com/python/cpython/pull/126272/commits/ce4bfa6bd593df1a3ab9216e0ea08cc0d7377357 |
| ce4bfa6 | https://github.com/python/cpython/pull/126272/commits/ce4bfa6bd593df1a3ab9216e0ea08cc0d7377357 |
|
| https://github.com/rruuaanng |
| Return _socket.socket | https://github.com/python/cpython/pull/126272/commits/362dbabdedd1f6e17cbcb47610b4f643338f3005 |
| 362dbab | https://github.com/python/cpython/pull/126272/commits/362dbabdedd1f6e17cbcb47610b4f643338f3005 |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
| Nov 2, 2024 | https://github.com/python/cpython/pull/126272#issuecomment-2452774006 |
| PEP-562 | https://peps.python.org/562 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| https://github.com/rruuaanng |
| rruuaanng | https://github.com/rruuaanng |
| Nov 2, 2024 | https://github.com/python/cpython/pull/126272#issuecomment-2452775246 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| PEP-562 | https://peps.python.org/562 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| https://github.com/ZeroIntensity |
| ZeroIntensity | https://github.com/ZeroIntensity |
| Nov 2, 2024 | https://github.com/python/cpython/pull/126272#issuecomment-2452784308 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
|
| https://github.com/rruuaanng |
| Add AttributeError | https://github.com/python/cpython/pull/126272/commits/5042f2f6ec5b25bce314cdb9eae4f1c282c3fae3 |
| 5042f2f | https://github.com/python/cpython/pull/126272/commits/5042f2f6ec5b25bce314cdb9eae4f1c282c3fae3 |
| https://github.com/rruuaanng |
| rruuaanng | https://github.com/rruuaanng |
| November 2, 2024 01:50 | https://github.com/python/cpython/pull/126272#event-15076230718 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Nov 2, 2024 | https://github.com/python/cpython/pull/126272#event-15076230786 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Nov 19, 2024
| https://github.com/python/cpython/pull/126272#pullrequestreview-2445509588 |
|
View reviewed changes
| https://github.com/python/cpython/pull/126272/files/d584e6ddb585d17d6bb3efbee11e605a4be4fe0d |
| Modules/socketmodule.c | https://github.com/python/cpython/pull/126272/files/d584e6ddb585d17d6bb3efbee11e605a4be4fe0d#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Nov 19, 2024
| https://github.com/python/cpython/pull/126272#pullrequestreview-2445517718 |
|
View reviewed changes
| https://github.com/python/cpython/pull/126272/files/d584e6ddb585d17d6bb3efbee11e605a4be4fe0d |
| vstinner | https://github.com/vstinner |
| https://github.com/python/cpython/pull/126272#pullrequestreview-2445517718 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @rruuaanng | https://github.com/rruuaanng |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| https://github.com/rruuaanng |
| rruuaanng | https://github.com/rruuaanng |
| Nov 19, 2024 | https://github.com/python/cpython/pull/126272#issuecomment-2485776390 |
| @vstinner | https://github.com/vstinner |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
|
| https://github.com/rruuaanng |
| Remove SocketType original definition | https://github.com/python/cpython/pull/126272/commits/4d71bce57ef17ce54b6fe52e901613aa478da37e |
| 4d71bce | https://github.com/python/cpython/pull/126272/commits/4d71bce57ef17ce54b6fe52e901613aa478da37e |
| https://github.com/rruuaanng |
| rruuaanng | https://github.com/rruuaanng |
| November 19, 2024 13:53 | https://github.com/python/cpython/pull/126272#event-15349929584 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Nov 19, 2024 | https://github.com/python/cpython/pull/126272#event-15349930273 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| Nov 19, 2024 | https://github.com/python/cpython/pull/126272#issuecomment-2485807540 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Nov 19, 2024
| https://github.com/python/cpython/pull/126272#pullrequestreview-2445579141 |
|
View reviewed changes
| https://github.com/python/cpython/pull/126272/files/4d71bce57ef17ce54b6fe52e901613aa478da37e |
| Lib/socket.py | https://github.com/python/cpython/pull/126272/files/4d71bce57ef17ce54b6fe52e901613aa478da37e#diff-081d33d48e9390350bb1ef860c52de799d1647b58e33b07173ae2549532cbfbe |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| https://github.com/ZeroIntensity |
| ZeroIntensity | https://github.com/ZeroIntensity |
|
Nov 19, 2024
| https://github.com/python/cpython/pull/126272#pullrequestreview-2445580394 |
|
View reviewed changes
| https://github.com/python/cpython/pull/126272/files/4d71bce57ef17ce54b6fe52e901613aa478da37e |
| Modules/socketmodule.c | https://github.com/python/cpython/pull/126272/files/4d71bce57ef17ce54b6fe52e901613aa478da37e#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| rruuaanng | https://github.com/rruuaanng |
| November 19, 2024 22:09 | https://github.com/python/cpython/pull/126272#commits-pushed-347c8e3 |
|
| https://github.com/rruuaanng |
| _socket.socket change to _socket.SocketType | https://github.com/python/cpython/pull/126272/commits/347c8e359a79ba861e49ce2695804c5529eda94f |
| 347c8e3 | https://github.com/python/cpython/pull/126272/commits/347c8e359a79ba861e49ce2695804c5529eda94f |
|
| https://github.com/rruuaanng |
| strcmp change to PyUnicode_EqualToUTF8 | https://github.com/python/cpython/pull/126272/commits/e625c642ce6ad874bb9642e0289ce68043525cad |
| e625c64 | https://github.com/python/cpython/pull/126272/commits/e625c642ce6ad874bb9642e0289ce68043525cad |
|
| https://github.com/rruuaanng |
| Merge branch 'gh88427' of | https://github.com/python/cpython/pull/126272/commits/a9093330abe731f87de17a5a8f0058919a1b45d2 |
| https://github.com/rruuaanng/cpython | https://github.com/rruuaanng/cpython |
| into g… | https://github.com/python/cpython/pull/126272/commits/a9093330abe731f87de17a5a8f0058919a1b45d2 |
| a909333 | https://github.com/python/cpython/pull/126272/commits/a9093330abe731f87de17a5a8f0058919a1b45d2 |
|
| https://github.com/rruuaanng |
| Use a better implementation | https://github.com/python/cpython/pull/126272/commits/0d836c4572ec7cdeb709fa20a83b8e2572bd3123 |
| 0d836c4 | https://github.com/python/cpython/pull/126272/commits/0d836c4572ec7cdeb709fa20a83b8e2572bd3123 |
|
| https://github.com/rruuaanng |
| Clear CI error | https://github.com/python/cpython/pull/126272/commits/38efc89e0aaca40910614d13f6b8cc5175ebd724 |
| 38efc89 | https://github.com/python/cpython/pull/126272/commits/38efc89e0aaca40910614d13f6b8cc5175ebd724 |
|
| https://github.com/rruuaanng |
| Add cast | https://github.com/python/cpython/pull/126272/commits/e07a9532f20f1dda467010948ea3c0a145b0a892 |
| e07a953 | https://github.com/python/cpython/pull/126272/commits/e07a9532f20f1dda467010948ea3c0a145b0a892 |
| https://github.com/rruuaanng |
| rruuaanng | https://github.com/rruuaanng |
| December 8, 2024 12:37 | https://github.com/python/cpython/pull/126272#event-15572624710 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Dec 8, 2024 | https://github.com/python/cpython/pull/126272#event-15572624821 |
| https://github.com/rruuaanng |
| rruuaanng | https://github.com/rruuaanng |
| ZeroIntensity | https://github.com/ZeroIntensity |
| vstinner | https://github.com/vstinner |
| December 8, 2024 12:37 | https://github.com/python/cpython/pull/126272#event-15572625022 |
|
| https://github.com/rruuaanng |
| use _socket.SocketType | https://github.com/python/cpython/pull/126272/commits/fae620ab379f5d371dfa7f377008f980060eb7dc |
| fae620a | https://github.com/python/cpython/pull/126272/commits/fae620ab379f5d371dfa7f377008f980060eb7dc |
| https://github.com/rruuaanng |
| rruuaanng | https://github.com/rruuaanng |
| Dec 9, 2024 | https://github.com/python/cpython/pull/126272#issuecomment-2527629378 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
|
| https://github.com/rruuaanng |
| Merge branch 'main' into gh88427 | https://github.com/python/cpython/pull/126272/commits/f0298789b0db22af5f56eeacc8e045e1fbc7501e |
| f029878 | https://github.com/python/cpython/pull/126272/commits/f0298789b0db22af5f56eeacc8e045e1fbc7501e |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| Dec 9, 2024 | https://github.com/python/cpython/pull/126272#issuecomment-2527847095 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| https://github.com/rruuaanng |
| rruuaanng | https://github.com/rruuaanng |
| Dec 10, 2024 | https://github.com/python/cpython/pull/126272#issuecomment-2530175727 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| https://github.com/ZeroIntensity |
| ZeroIntensity | https://github.com/ZeroIntensity |
|
Dec 10, 2024
| https://github.com/python/cpython/pull/126272#pullrequestreview-2490896499 |
|
View reviewed changes
| https://github.com/python/cpython/pull/126272/files/f0298789b0db22af5f56eeacc8e045e1fbc7501e |
| Modules/socketmodule.c | https://github.com/python/cpython/pull/126272/files/f0298789b0db22af5f56eeacc8e045e1fbc7501e#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29 |
| ZeroIntensity | https://github.com/ZeroIntensity |
| Dec 10, 2024 | https://github.com/python/cpython/pull/126272#discussion_r1877257898 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| rruuaanng | https://github.com/rruuaanng |
| Dec 10, 2024 | https://github.com/python/cpython/pull/126272#discussion_r1877338387 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| https://github.com/rruuaanng |
| rruuaanng | https://github.com/rruuaanng |
| December 12, 2024 11:41 | https://github.com/python/cpython/pull/126272#event-15633240233 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Dec 12, 2024 | https://github.com/python/cpython/pull/126272#event-15633240871 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Apr 19, 2026 | https://github.com/python/cpython/pull/126272#issuecomment-4275349443 |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
stale
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale |
| Apr 19, 2026 | https://github.com/python/cpython/pull/126272#event-24647049209 |
| https://github.com/gaborbernat |
| gaborbernat | https://github.com/gaborbernat |
|
May 31, 2026
| https://github.com/python/cpython/pull/126272#ref-pullrequest-4558375191 |
|
gh-89554: Document socket.SocketType as a class
#150683
| https://github.com/python/cpython/pull/150683 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126272 |
|
| https://github.com/JelleZijlstra |
|
JelleZijlstra
| https://github.com/JelleZijlstra |
|
| https://github.com/python/cpython/pull/126272/files/02a45bd6e6b34b8371f0d31adfbdf14ef7db67bb |
|
| https://github.com/picnixz |
|
picnixz
| https://github.com/picnixz |
|
| https://github.com/python/cpython/pull/126272/files/705492b7e0e8b394178f36076d57c29bc64e127f |
|
| https://github.com/ZeroIntensity |
|
ZeroIntensity
| https://github.com/ZeroIntensity |
|
| https://github.com/python/cpython/pull/126272/files/f0298789b0db22af5f56eeacc8e045e1fbc7501e |
|
| https://github.com/Eclips4 |
|
Eclips4
| https://github.com/Eclips4 |
|
| https://github.com/python/cpython/pull/126272/files/da2aabe01239cfc9dad81d3c6176ee4acb634fb8 |
|
| https://github.com/vstinner |
|
vstinner
| https://github.com/vstinner |
|
DO-NOT-MERGE
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3ADO-NOT-MERGE |
|
stale
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale |
| Please reload this page | https://github.com/python/cpython/pull/126272 |
|
| https://github.com/rruuaanng |
|
| https://github.com/JelleZijlstra |
|
| https://github.com/picnixz |
|
| https://github.com/ZeroIntensity |
|
| https://github.com/Wulian233 |
|
| https://github.com/vstinner |
|
| https://github.com/Eclips4 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |