René's URL Explorer Experiment


Title: gh-88110: clear concurrent.futures.thread._threads_queues after fork to avoid joining parent process' threads by Drino · Pull Request #126098 · python/cpython · GitHub

Open Graph Title: gh-88110: clear concurrent.futures.thread._threads_queues after fork to avoid joining parent process' threads by Drino · Pull Request #126098 · python/cpython

X Title: gh-88110: clear concurrent.futures.thread._threads_queues after fork to avoid joining parent process' threads by Drino · Pull Request #126098 · python/cpython

Description: I've added a test to marmarek@ PR: #101940 _threads_queues are copied as-is into the fork memory, but there are no threads in the child process, so child process crashes when calling t.join() in _python_exit. I'm facing this issue for the second time during last two years, so I hope it can be fixed :) Issue: gh-88110

Open Graph Description: I've added a test to marmarek@ PR: #101940 _threads_queues are copied as-is into the fork memory, but there are no threads in the child process, so child process crashes when calling t.join() ...

X Description: I've added a test to marmarek@ PR: #101940 _threads_queues are copied as-is into the fork memory, but there are no threads in the child process, so child process crashes when calling t.joi...

Opengraph URL: https://github.com/python/cpython/pull/126098

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:76d0cd6f-55c4-25b4-ea06-b90b524535e0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAA28:69662:45FB6CA:6182B7C:6A4F740A
html-safe-nonce4cbce457ef841498b026b2c37e64883a2420ab704538417ad2601473489c7265
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTI4OjY5NjYyOjQ1RkI2Q0E6NjE4MkI3Qzo2QTRGNzQwQSIsInZpc2l0b3JfaWQiOiIyODgzOTIxMjk1MjI5MDIzMjQyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc8f568280f362aeab31520f72f70326c29adbf9e890b3509661666795a918b51
hovercard-subject-tagpull_request:2150356700
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/126098/files
twitter:imagehttps://avatars.githubusercontent.com/u/208618?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/208618?s=400&v=4
og:image:altI've added a test to marmarek@ PR: #101940 _threads_queues are copied as-is into the fork memory, but there are no threads in the child process, so child process crashes when calling t.join() ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/126098/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126098%2Ffiles
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126098%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/126098/files
Reloadhttps://github.com/python/cpython/pull/126098/files
Reloadhttps://github.com/python/cpython/pull/126098/files
Please reload this pagehttps://github.com/python/cpython/pull/126098/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/126098/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
Drino:bug88110_testshttps://github.com/Drino/cpython/tree/bug88110_tests
Conversation 14 https://github.com/python/cpython/pull/126098
Commits 11 https://github.com/python/cpython/pull/126098/commits
Checks 0 https://github.com/python/cpython/pull/126098/checks
Files changed https://github.com/python/cpython/pull/126098/files
Please reload this pagehttps://github.com/python/cpython/pull/126098/files
gh-88110: clear concurrent.futures.thread._threads_queues after fork to avoid joining parent process' threads https://github.com/python/cpython/pull/126098/files#top
Show all changes 11 commits https://github.com/python/cpython/pull/126098/files
1c35846 gh-88110: clear concurrent.futures.thread._threads_queues after fork marmarek Feb 15, 2023 https://github.com/python/cpython/pull/126098/commits/1c358465fdb2fb611e163e965426c7c1331931d7
5564811 Add NEWS entry marmarek Feb 15, 2023 https://github.com/python/cpython/pull/126098/commits/556481102ded0f5959bacc74b62a1d62fb7f8758
d035c6b Add test Drino Oct 28, 2024 https://github.com/python/cpython/pull/126098/commits/d035c6b4f8ff731cbfd8e1ce8fa6ae628e3b5b8d
cf1d9f1 Fix indentation Drino Oct 28, 2024 https://github.com/python/cpython/pull/126098/commits/cf1d9f1659fb123405096ade683e7ab54554d1a3
18b91ac Fix formatting in description Drino Oct 29, 2024 https://github.com/python/cpython/pull/126098/commits/18b91ac39bba755c1be8b0f381e0f638a05a365d
85d7b8f Ignore the warning about fork with threads Drino Nov 17, 2024 https://github.com/python/cpython/pull/126098/commits/85d7b8fa7a59cfbd513eafd34ff71ba6cc0b321f
ce72fb3 Fix lint Drino Nov 17, 2024 https://github.com/python/cpython/pull/126098/commits/ce72fb3148c5a0cf5908c9e76722e65bab6d4d65
b9dcbe0 Fix comments Drino Nov 20, 2024 https://github.com/python/cpython/pull/126098/commits/b9dcbe0a11f9c2b0ab6c3a2422020ab912a7fbd3
209260e reword the NEWS entry gpshead Nov 20, 2024 https://github.com/python/cpython/pull/126098/commits/209260ef2d73923b25c97edbe6f35384def2cc99
b8d3f31 more NEWS wordsmithing for accuracy gpshead Nov 20, 2024 https://github.com/python/cpython/pull/126098/commits/b8d3f31981ab510a740f226cb9913fe14ed72c20
bbaad99 Fix the test. serhiy-storchaka Nov 22, 2024 https://github.com/python/cpython/pull/126098/commits/bbaad99d9c7ae74c23889f5720541d557fa3fdca
Clear filters https://github.com/python/cpython/pull/126098/files
Please reload this pagehttps://github.com/python/cpython/pull/126098/files
Please reload this pagehttps://github.com/python/cpython/pull/126098/files
thread.py https://github.com/python/cpython/pull/126098/files#diff-692c518556397eee9681b886c6c7e85af5defbd0759a01f0f39c355d48d1fd75
test_thread_pool.py https://github.com/python/cpython/pull/126098/files#diff-96cad7b524bed18724e344ca250f25c2fa0c29a33ecf7326955c8ee35e2f6b8e
2023-02-15-23-54-42.gh-issue-88110.KU6erv.rst https://github.com/python/cpython/pull/126098/files#diff-829a9a03d857f733e0a71a57e5d0898428a057511f24c9a9122d39d0f73b75f5
Lib/concurrent/futures/thread.pyhttps://github.com/python/cpython/pull/126098/files#diff-692c518556397eee9681b886c6c7e85af5defbd0759a01f0f39c355d48d1fd75
View file https://github.com/Drino/cpython/blob/bbaad99d9c7ae74c23889f5720541d557fa3fdca/Lib/concurrent/futures/thread.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/126098/{{ revealButtonHref }}
https://github.com/python/cpython/pull/126098/files#diff-692c518556397eee9681b886c6c7e85af5defbd0759a01f0f39c355d48d1fd75
https://github.com/python/cpython/pull/126098/files#diff-692c518556397eee9681b886c6c7e85af5defbd0759a01f0f39c355d48d1fd75
Lib/test/test_concurrent_futures/test_thread_pool.pyhttps://github.com/python/cpython/pull/126098/files#diff-96cad7b524bed18724e344ca250f25c2fa0c29a33ecf7326955c8ee35e2f6b8e
View file https://github.com/Drino/cpython/blob/bbaad99d9c7ae74c23889f5720541d557fa3fdca/Lib/test/test_concurrent_futures/test_thread_pool.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/126098/{{ revealButtonHref }}
https://github.com/python/cpython/pull/126098/files#diff-96cad7b524bed18724e344ca250f25c2fa0c29a33ecf7326955c8ee35e2f6b8e
https://github.com/python/cpython/pull/126098/files#diff-96cad7b524bed18724e344ca250f25c2fa0c29a33ecf7326955c8ee35e2f6b8e
Misc/NEWS.d/next/Library/2023-02-15-23-54-42.gh-issue-88110.KU6erv.rsthttps://github.com/python/cpython/pull/126098/files#diff-829a9a03d857f733e0a71a57e5d0898428a057511f24c9a9122d39d0f73b75f5
View file https://github.com/Drino/cpython/blob/bbaad99d9c7ae74c23889f5720541d557fa3fdca/Misc/NEWS.d/next/Library/2023-02-15-23-54-42.gh-issue-88110.KU6erv.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/126098/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.