René's URL Explorer Experiment


Title: gh-118201: Simplify conv_confname by mhsmith · Pull Request #126089 · python/cpython · GitHub

Open Graph Title: gh-118201: Simplify conv_confname by mhsmith · Pull Request #126089 · python/cpython

X Title: gh-118201: Simplify conv_confname by mhsmith · Pull Request #126089 · python/cpython

Description: On Android and iOS we've been seeing intermittent buildbot failures where os.confstr, os.pathconf or os.sysconf raise a ValueError. This is not a failure in the underlying system call, but a failure to look up a mapping from strings to integers before making the system call. I haven't been able to explain this (see #118201 for details), but I have found a way to simplify the relevant code, which will hopefully fix the issue, or at least give us some more information about it. All three functions depend onconv_confname, which currently maps from strings to integers using a binary search in a C array. This PR changes it to use os.{confstr,pathconf,sysconf}_names, which are dicts containing the same information. I also took the opportunity to improve the test coverage of this area. Fixes gh-118201 Reverts #118452 Reverts #118453

Open Graph Description: On Android and iOS we've been seeing intermittent buildbot failures where os.confstr, os.pathconf or os.sysconf raise a ValueError. This is not a failure in the underlying system call, but a fa...

X Description: On Android and iOS we've been seeing intermittent buildbot failures where os.confstr, os.pathconf or os.sysconf raise a ValueError. This is not a failure in the underlying system call, but ...

Opengraph URL: https://github.com/python/cpython/pull/126089

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c4c269bf-6f11-4246-bf5f-84011562ed1b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBBDC:6B7DC:2CDDBA:393A15:6B01F87C
html-safe-nonce7e7957e51e179bca60a5497d4cb444e69c5c863e980e41952e02f0c8b4daf5a9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQkRDOjZCN0RDOjJDRERCQTozOTNBMTU6NkIwMUY4N0MiLCJ2aXNpdG9yX2lkIjoiMzM3MzkyMjE2NTQ0MjM0NTA4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf5f076361ed09e2f47dec628c813cf4a830ed542888a603f4adef417f06129a9
hovercard-subject-tagpull_request:2150076350
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/126089/files
twitter:imagehttps://avatars.githubusercontent.com/u/166954?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/166954?s=400&v=4
og:image:altOn Android and iOS we've been seeing intermittent buildbot failures where os.confstr, os.pathconf or os.sysconf raise a ValueError. This is not a failure in the underlying system call, but a fa...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/126089/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126089%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F126089%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/126089/files
Reloadhttps://github.com/python/cpython/pull/126089/files
Reloadhttps://github.com/python/cpython/pull/126089/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
mhsmith:simplify-conv-confnamehttps://github.com/mhsmith/cpython/tree/simplify-conv-confname
Conversation 31 https://github.com/python/cpython/pull/126089
Commits 6 https://github.com/python/cpython/pull/126089/commits
Checks 0 https://github.com/python/cpython/pull/126089/checks
Files changed https://github.com/python/cpython/pull/126089/files
Please reload this pagehttps://github.com/python/cpython/pull/126089/files
gh-118201: Simplify conv_confname https://github.com/python/cpython/pull/126089/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/126089/files
684a31a Simplify conv_confname mhsmith Oct 28, 2024 https://github.com/python/cpython/pull/126089/commits/684a31a35d9c564199a6186437e7a11a82c86ce6
1c2009c Use Argument Clinic correctly mhsmith Oct 28, 2024 https://github.com/python/cpython/pull/126089/commits/1c2009c6796d8199336e5f0ceaaa77dcafbe4314
2a3e50a Test os.sysconf with a key that's available on WASI mhsmith Oct 28, 2024 https://github.com/python/cpython/pull/126089/commits/2a3e50a5587db13af2431bc8811c49acde20c73a
97bee9a Rearrange error handling mhsmith Nov 9, 2024 https://github.com/python/cpython/pull/126089/commits/97bee9a15424da093318a1989962ad87f6679c0b
a214081 Merge branch 'main' into simplify-conv-confname mhsmith Nov 10, 2024 https://github.com/python/cpython/pull/126089/commits/a21408193dbf633d9101ed941e10678335522b66
8a026f1 More error handling improvements mhsmith Nov 18, 2024 https://github.com/python/cpython/pull/126089/commits/8a026f13455b1f2c6bbc632ae5d3bf984aec0838
Clear filters https://github.com/python/cpython/pull/126089/files
Please reload this pagehttps://github.com/python/cpython/pull/126089/files
Please reload this pagehttps://github.com/python/cpython/pull/126089/files
os_helper.py https://github.com/python/cpython/pull/126089/files#diff-affb87b45961a0bcab1280ed70083ca85b1b3d60bfd10233fce565f6b00cb56f
test_os.py https://github.com/python/cpython/pull/126089/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
test_posix.py https://github.com/python/cpython/pull/126089/files#diff-7463633f0a09a482722b0b4dd11801ac43b242b3810eb3a8d42b80f1a28f36a3
2024-10-28-19-49-18.gh-issue-118201.v41XXh.rst https://github.com/python/cpython/pull/126089/files#diff-5b85bcd6865271d81ec7fdf8a74f1d289a3689967f930bbcf5bc80c2febbdf7d
posixmodule.c.h https://github.com/python/cpython/pull/126089/files#diff-f4ec448d9bc73d373452e97931de916ca83058ae93bce4a5853b8ac18c9d2cfa
posixmodule.c https://github.com/python/cpython/pull/126089/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
Lib/test/support/os_helper.pyhttps://github.com/python/cpython/pull/126089/files#diff-affb87b45961a0bcab1280ed70083ca85b1b3d60bfd10233fce565f6b00cb56f
View file https://github.com/mhsmith/cpython/blob/8a026f13455b1f2c6bbc632ae5d3bf984aec0838/Lib/test/support/os_helper.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/126089/{{ revealButtonHref }}
https://github.com/python/cpython/pull/126089/files#diff-affb87b45961a0bcab1280ed70083ca85b1b3d60bfd10233fce565f6b00cb56f
https://github.com/python/cpython/pull/126089/files#diff-affb87b45961a0bcab1280ed70083ca85b1b3d60bfd10233fce565f6b00cb56f
Lib/test/test_os.pyhttps://github.com/python/cpython/pull/126089/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
View file https://github.com/mhsmith/cpython/blob/8a026f13455b1f2c6bbc632ae5d3bf984aec0838/Lib/test/test_os.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/126089/{{ revealButtonHref }}
https://github.com/python/cpython/pull/126089/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
https://github.com/python/cpython/pull/126089/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
Lib/test/test_posix.pyhttps://github.com/python/cpython/pull/126089/files#diff-7463633f0a09a482722b0b4dd11801ac43b242b3810eb3a8d42b80f1a28f36a3
View file https://github.com/mhsmith/cpython/blob/8a026f13455b1f2c6bbc632ae5d3bf984aec0838/Lib/test/test_posix.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/126089/{{ revealButtonHref }}
https://github.com/python/cpython/pull/126089/files#diff-7463633f0a09a482722b0b4dd11801ac43b242b3810eb3a8d42b80f1a28f36a3
https://github.com/python/cpython/pull/126089/files#diff-7463633f0a09a482722b0b4dd11801ac43b242b3810eb3a8d42b80f1a28f36a3
Misc/NEWS.d/next/Library/2024-10-28-19-49-18.gh-issue-118201.v41XXh.rsthttps://github.com/python/cpython/pull/126089/files#diff-5b85bcd6865271d81ec7fdf8a74f1d289a3689967f930bbcf5bc80c2febbdf7d
View file https://github.com/mhsmith/cpython/blob/8a026f13455b1f2c6bbc632ae5d3bf984aec0838/Misc/NEWS.d/next/Library/2024-10-28-19-49-18.gh-issue-118201.v41XXh.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/126089/{{ revealButtonHref }}
Modules/clinic/posixmodule.c.hhttps://github.com/python/cpython/pull/126089/files#diff-f4ec448d9bc73d373452e97931de916ca83058ae93bce4a5853b8ac18c9d2cfa
View file https://github.com/mhsmith/cpython/blob/8a026f13455b1f2c6bbc632ae5d3bf984aec0838/Modules/clinic/posixmodule.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/126089/files
Modules/posixmodule.chttps://github.com/python/cpython/pull/126089/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
View file https://github.com/mhsmith/cpython/blob/8a026f13455b1f2c6bbc632ae5d3bf984aec0838/Modules/posixmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/126089/{{ revealButtonHref }}
https://github.com/python/cpython/pull/126089/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/126089/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/126089/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/126089/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/126089/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/126089/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/126089/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/126089/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/126089/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/126089/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/126089/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/126089/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/126089/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/126089/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/126089/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.