René's URL Explorer Experiment


Title: gh-124872: Mark the thread's default context as entered by rhansen · Pull Request #125638 · python/cpython · GitHub

Open Graph Title: gh-124872: Mark the thread's default context as entered by rhansen · Pull Request #125638 · python/cpython

X Title: gh-124872: Mark the thread's default context as entered by rhansen · Pull Request #125638 · python/cpython

Description: Starting with commit 843d28f (temporarily reverted in d3c82b9 and restored in commit bee112a), it is now technically possible to access a thread's default context created by context_get. Mark that context as entered so that users cannot push that context onto the thread's stack a second time, which would cause a cycle. This change also causes a CONTEXT_SWITCHED event to be emitted when the default context is created, which might be important in some use cases. Also exit the default context when the thread exits, for symmetry and in case the user wants to re-enter it for some reason. (Even if the CONTEXT_SWITCHED event is removed, entering the default context is good defensive practice, and the consistent treatment of all contexts on the stack makes it easier to understand the code.) Issue: gh-124872

Open Graph Description: Starting with commit 843d28f (temporarily reverted in d3c82b9 and restored in commit bee112a), it is now technically possible to access a thread's default context created by context_get. Mark ...

X Description: Starting with commit 843d28f (temporarily reverted in d3c82b9 and restored in commit bee112a), it is now technically possible to access a thread's default context created by context_get. M...

Opengraph URL: https://github.com/python/cpython/pull/125638

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:85adc480-d518-c449-a108-37f25ba4dfcc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBB40:88BC0:556C83:6ACFC0:6B0245FD
html-safe-nonce88f91f70b256825feac219ffc6bf345ad1b6af12b6b3f42c2f7885b6fd1f8549
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjQwOjg4QkMwOjU1NkM4Mzo2QUNGQzA6NkIwMjQ1RkQiLCJ2aXNpdG9yX2lkIjoiODU5ODA0MTc5OTgzMzA0NDQ3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac676e9438331ddbe3a3bb1dc1148a9e0e1d5ce79d3554d7119ba1fc844c23911d
hovercard-subject-tagpull_request:2129488191
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/125638/files
twitter:imagehttps://avatars.githubusercontent.com/u/1612291?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1612291?s=400&v=4
og:image:altStarting with commit 843d28f (temporarily reverted in d3c82b9 and restored in commit bee112a), it is now technically possible to access a thread's default context created by context_get. Mark ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/125638/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F125638%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F125638%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/125638/files
Reloadhttps://github.com/python/cpython/pull/125638/files
Reloadhttps://github.com/python/cpython/pull/125638/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
rhansenhttps://github.com/rhansen
python:mainhttps://github.com/python/cpython/tree/main
rhansen:gh-124872-enter-initialhttps://github.com/rhansen/cpython/tree/gh-124872-enter-initial
Conversation 21 https://github.com/python/cpython/pull/125638
Commits 5 https://github.com/python/cpython/pull/125638/commits
Checks 0 https://github.com/python/cpython/pull/125638/checks
Files changed https://github.com/python/cpython/pull/125638/files
Please reload this pagehttps://github.com/python/cpython/pull/125638/files
gh-124872: Mark the thread's default context as entered https://github.com/python/cpython/pull/125638/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/125638/files
5337fc3 gh-124872: Mark the thread's default context as entered rhansen Oct 16, 2024 https://github.com/python/cpython/pull/125638/commits/5337fc30ede3618e15cbbf990c1982b9764c8357
4f4ba35 Merge branch 'main' into gh-124872-enter-initial rhansen Nov 5, 2024 https://github.com/python/cpython/pull/125638/commits/4f4ba35b099ae13cc698c72de383d81a6bee5a12
4690ea6 fixup! gh-124872: Mark the thread's default context as entered rhansen Nov 6, 2024 https://github.com/python/cpython/pull/125638/commits/4690ea6fda561a75b9f3f8ae5d90aa60bcc3b37e
748f3eb fixup! gh-124872: Mark the thread's default context as entered rhansen Nov 7, 2024 https://github.com/python/cpython/pull/125638/commits/748f3eb5c349fe32d386b8ebabd29f16918e9df2
756d837 fixup! gh-124872: Mark the thread's default context as entered rhansen Nov 10, 2024 https://github.com/python/cpython/pull/125638/commits/756d837ee5c667a2d87ba78e0c752d930717b56d
Clear filters https://github.com/python/cpython/pull/125638/files
Please reload this pagehttps://github.com/python/cpython/pull/125638/files
Please reload this pagehttps://github.com/python/cpython/pull/125638/files
contextvars.rst https://github.com/python/cpython/pull/125638/files#diff-dcba959f99b35e4934a2cd76dfadf4e3387e455b7e717691e71ae94edd838538
context.h https://github.com/python/cpython/pull/125638/files#diff-2c91c78b4215de3e077f4057086cf3ed5de8e29ef0ba9553fdccae4846aedd6a
pycore_context.h https://github.com/python/cpython/pull/125638/files#diff-eab1ba7712d90b687ef7595800ea1fbffcc4eaf34bddc447ab0fe75afd447be1
test_watchers.py https://github.com/python/cpython/pull/125638/files#diff-f13cecf74c62d3b381dfd239e6e1c1c18e83e809b9c3dcb20237d1a8d27c439c
watchers.c https://github.com/python/cpython/pull/125638/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
context.c https://github.com/python/cpython/pull/125638/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
pystate.c https://github.com/python/cpython/pull/125638/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L235
Doc/c-api/contextvars.rsthttps://github.com/python/cpython/pull/125638/files#diff-dcba959f99b35e4934a2cd76dfadf4e3387e455b7e717691e71ae94edd838538
View file https://github.com/python/cpython/blob/756d837ee5c667a2d87ba78e0c752d930717b56d/Doc/c-api/contextvars.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/125638/{{ revealButtonHref }}
https://github.com/python/cpython/pull/125638/files#diff-dcba959f99b35e4934a2cd76dfadf4e3387e455b7e717691e71ae94edd838538
https://github.com/python/cpython/pull/125638/files#diff-dcba959f99b35e4934a2cd76dfadf4e3387e455b7e717691e71ae94edd838538
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L237
Include/cpython/context.hhttps://github.com/python/cpython/pull/125638/files#diff-2c91c78b4215de3e077f4057086cf3ed5de8e29ef0ba9553fdccae4846aedd6a
View file https://github.com/python/cpython/blob/756d837ee5c667a2d87ba78e0c752d930717b56d/Include/cpython/context.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/125638/{{ revealButtonHref }}
https://github.com/python/cpython/pull/125638/files#diff-2c91c78b4215de3e077f4057086cf3ed5de8e29ef0ba9553fdccae4846aedd6a
https://github.com/python/cpython/pull/125638/files#diff-2c91c78b4215de3e077f4057086cf3ed5de8e29ef0ba9553fdccae4846aedd6a
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L238
Include/internal/pycore_context.hhttps://github.com/python/cpython/pull/125638/files#diff-eab1ba7712d90b687ef7595800ea1fbffcc4eaf34bddc447ab0fe75afd447be1
View file https://github.com/python/cpython/blob/756d837ee5c667a2d87ba78e0c752d930717b56d/Include/internal/pycore_context.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/125638/{{ revealButtonHref }}
https://github.com/python/cpython/pull/125638/files#diff-eab1ba7712d90b687ef7595800ea1fbffcc4eaf34bddc447ab0fe75afd447be1
https://github.com/python/cpython/pull/125638/files#diff-eab1ba7712d90b687ef7595800ea1fbffcc4eaf34bddc447ab0fe75afd447be1
https://github.com/python/cpython/pull/125638/files#diff-eab1ba7712d90b687ef7595800ea1fbffcc4eaf34bddc447ab0fe75afd447be1
Lib/test/test_capi/test_watchers.pyhttps://github.com/python/cpython/pull/125638/files#diff-f13cecf74c62d3b381dfd239e6e1c1c18e83e809b9c3dcb20237d1a8d27c439c
View file https://github.com/python/cpython/blob/756d837ee5c667a2d87ba78e0c752d930717b56d/Lib/test/test_capi/test_watchers.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/125638/{{ revealButtonHref }}
https://github.com/python/cpython/pull/125638/files#diff-f13cecf74c62d3b381dfd239e6e1c1c18e83e809b9c3dcb20237d1a8d27c439c
https://github.com/python/cpython/pull/125638/files#diff-f13cecf74c62d3b381dfd239e6e1c1c18e83e809b9c3dcb20237d1a8d27c439c
Modules/_testcapi/watchers.chttps://github.com/python/cpython/pull/125638/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
View file https://github.com/python/cpython/blob/756d837ee5c667a2d87ba78e0c752d930717b56d/Modules/_testcapi/watchers.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/125638/{{ revealButtonHref }}
https://github.com/python/cpython/pull/125638/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/pull/125638/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/pull/125638/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/pull/125638/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L240
Python/context.chttps://github.com/python/cpython/pull/125638/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
View file https://github.com/python/cpython/blob/756d837ee5c667a2d87ba78e0c752d930717b56d/Python/context.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/125638/{{ revealButtonHref }}
https://github.com/python/cpython/pull/125638/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
Please reload this pagehttps://github.com/python/cpython/pull/125638/files
https://github.com/python/cpython/pull/125638/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
https://github.com/python/cpython/pull/125638/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
https://github.com/python/cpython/pull/125638/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
https://github.com/python/cpython/pull/125638/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
https://github.com/python/cpython/pull/125638/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
Please reload this pagehttps://github.com/python/cpython/pull/125638/files
https://github.com/python/cpython/pull/125638/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
https://github.com/python/cpython/pull/125638/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
https://github.com/python/cpython/pull/125638/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
https://github.com/python/cpython/pull/125638/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
https://github.com/python/cpython/pull/125638/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
https://github.com/python/cpython/pull/125638/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
https://github.com/python/cpython/pull/125638/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
https://github.com/python/cpython/pull/125638/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L319
Python/pystate.chttps://github.com/python/cpython/pull/125638/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
View file https://github.com/python/cpython/blob/756d837ee5c667a2d87ba78e0c752d930717b56d/Python/pystate.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/125638/{{ revealButtonHref }}
https://github.com/python/cpython/pull/125638/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/125638/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.