| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8fb359f5-4d7d-d00e-98ca-e3c5dbae932c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D96E:2ED6B1:1322AC:1AB7D3:6B00545B |
| html-safe-nonce | 078625f89b837bbf8cabdbfe6fe3dee7c65aff4b2bc73b59db8f0296e4aec67c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTZFOjJFRDZCMToxMzIyQUM6MUFCN0QzOjZCMDA1NDVCIiwidmlzaXRvcl9pZCI6IjIwODU4NjAxNDE5MzE5NzU3NzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5c80db140d517f04844dbd6e50bd4d038043c3276655ad246948b059c62968e9 |
| hovercard-subject-tag | pull_request:2122819216 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/125446/files |
| twitter:image | https://avatars.githubusercontent.com/u/10796600?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/10796600?s=400&v=4 |
| og:image:alt | I went for the simplest implementation. I could unroll the memory_item call to save some operations but I felt that it would only add noise and make maintenance harder so I went for a cleaner but p... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | f420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26e00df917aba0f128135dc073ea0c5e33a70d40 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/125446/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F125446%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F125446%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/125446/files |
| Reload | https://github.com/python/cpython/pull/125446/files |
| Reload | https://github.com/python/cpython/pull/125446/files |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| JelleZijlstra | https://github.com/JelleZijlstra |
| python:main | https://github.com/python/cpython/tree/main |
| picnixz:fix/memoryview-sequence-api-index-125420 | https://github.com/picnixz/cpython/tree/fix/memoryview-sequence-api-index-125420 |
|
Conversation
3
| https://github.com/python/cpython/pull/125446 |
|
Commits
11
| https://github.com/python/cpython/pull/125446/commits |
|
Checks
0
| https://github.com/python/cpython/pull/125446/checks |
|
Files changed
| https://github.com/python/cpython/pull/125446/files |
| Please reload this page | https://github.com/python/cpython/pull/125446/files |
|
gh-125420: implement Sequence.index API on memoryview objects
| https://github.com/python/cpython/pull/125446/files#top |
|
Show all changes
11 commits
| https://github.com/python/cpython/pull/125446/files |
|
7b78549
add `Sequence.index` to `memoryview` objects
picnixz Oct 14, 2024
| https://github.com/python/cpython/pull/125446/commits/7b78549e6114f19ee7310fcd2def1864ed3f6ad5 |
|
a066924
docs
picnixz Oct 14, 2024
| https://github.com/python/cpython/pull/125446/commits/a06692430ec2592c6eb1df6b217d4ea9cbeb378c |
|
5c2cf08
blurb
picnixz Oct 14, 2024
| https://github.com/python/cpython/pull/125446/commits/5c2cf0863471636836d671de94d906d6dff3644d |
|
10245f8
remove IDE imports
picnixz Oct 14, 2024
| https://github.com/python/cpython/pull/125446/commits/10245f887352f7b602fd7a3c415e3fc34d35a96f |
|
02f94c9
fixup typo!
picnixz Oct 14, 2024
| https://github.com/python/cpython/pull/125446/commits/02f94c996c69832813236c130e8afd9bd3092656 |
|
ea0125d
fixup docs
picnixz Oct 14, 2024
| https://github.com/python/cpython/pull/125446/commits/ea0125db859ca0ca93f9ce300ae9d73cdd406cf0 |
|
9f2efa1
add fast path
picnixz Oct 17, 2024
| https://github.com/python/cpython/pull/125446/commits/9f2efa124f6f59e7b4cec293f073bcd4f772b032 |
|
beca7af
fixup docs
picnixz Oct 27, 2024
| https://github.com/python/cpython/pull/125446/commits/beca7afa3a16e10a493ad35958bebffb2e12a6b6 |
|
5458b14
fixup tests!
picnixz Oct 27, 2024
| https://github.com/python/cpython/pull/125446/commits/5458b14664898866d7a9dd0850ed6fdc59d47416 |
|
748b678
Merge remote-tracking branch 'upstream/main' into fix/memoryview-sequ…
picnixz Nov 3, 2024
| https://github.com/python/cpython/pull/125446/commits/748b6785772b0ae971d6240f07162f2002003837 |
|
3421118
Merge branch 'main' into fix/memoryview/index-125420
picnixz Dec 4, 2024
| https://github.com/python/cpython/pull/125446/commits/3421118c5818d38e59aff9207c392da42cc41724 |
|
Clear filters
| https://github.com/python/cpython/pull/125446/files |
| Please reload this page | https://github.com/python/cpython/pull/125446/files |
| Please reload this page | https://github.com/python/cpython/pull/125446/files |
|
stdtypes.rst
| https://github.com/python/cpython/pull/125446/files#diff-08a31a70dd1f6d97aa8dacdce77db4de04c700d9949be1af611a595186aad5b3 |
|
test_memoryview.py
| https://github.com/python/cpython/pull/125446/files#diff-d41c6bb40a1e03fea5a20d15c4077413e0ddde65651147922b625b03a66a2f16 |
|
2024-10-14-13-28-16.gh-issue-125420.hNKixM.rst
| https://github.com/python/cpython/pull/125446/files#diff-a4705b1b83dcc527df781e1f32ffd1f05fc132ac29a6ab61d398cf04ee3ae3a6 |
|
memoryobject.c.h
| https://github.com/python/cpython/pull/125446/files#diff-15662bab1fa68645da4a33f34431e6276fb1177525d97c8e4790a9acbb783afc |
|
memoryobject.c
| https://github.com/python/cpython/pull/125446/files#diff-7d1cb11da20dc3738b65b0f7381bf02df53132562a9749ba8a22d67a0f05f106 |
| Doc/library/stdtypes.rst | https://github.com/python/cpython/pull/125446/files#diff-08a31a70dd1f6d97aa8dacdce77db4de04c700d9949be1af611a595186aad5b3 |
|
View file
| https://github.com/picnixz/cpython/blob/3421118c5818d38e59aff9207c392da42cc41724/Doc/library/stdtypes.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/125446/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/125446/files#diff-08a31a70dd1f6d97aa8dacdce77db4de04c700d9949be1af611a595186aad5b3 |
|
| https://github.com/python/cpython/pull/125446/files#diff-08a31a70dd1f6d97aa8dacdce77db4de04c700d9949be1af611a595186aad5b3 |
| Lib/test/test_memoryview.py | https://github.com/python/cpython/pull/125446/files#diff-d41c6bb40a1e03fea5a20d15c4077413e0ddde65651147922b625b03a66a2f16 |
|
View file
| https://github.com/picnixz/cpython/blob/3421118c5818d38e59aff9207c392da42cc41724/Lib/test/test_memoryview.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/125446/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/125446/files#diff-d41c6bb40a1e03fea5a20d15c4077413e0ddde65651147922b625b03a66a2f16 |
|
| https://github.com/python/cpython/pull/125446/files#diff-d41c6bb40a1e03fea5a20d15c4077413e0ddde65651147922b625b03a66a2f16 |
|
| https://github.com/python/cpython/pull/125446/files#diff-d41c6bb40a1e03fea5a20d15c4077413e0ddde65651147922b625b03a66a2f16 |
|
| https://github.com/python/cpython/pull/125446/files#diff-d41c6bb40a1e03fea5a20d15c4077413e0ddde65651147922b625b03a66a2f16 |
| Misc/NEWS.d/next/Core_and_Builtins/2024-10-14-13-28-16.gh-issue-125420.hNKixM.rst | https://github.com/python/cpython/pull/125446/files#diff-a4705b1b83dcc527df781e1f32ffd1f05fc132ac29a6ab61d398cf04ee3ae3a6 |
|
View file
| https://github.com/picnixz/cpython/blob/3421118c5818d38e59aff9207c392da42cc41724/Misc/NEWS.d/next/Core_and_Builtins/2024-10-14-13-28-16.gh-issue-125420.hNKixM.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/125446/{{ revealButtonHref }} |
| Objects/clinic/memoryobject.c.h | https://github.com/python/cpython/pull/125446/files#diff-15662bab1fa68645da4a33f34431e6276fb1177525d97c8e4790a9acbb783afc |
|
View file
| https://github.com/picnixz/cpython/blob/3421118c5818d38e59aff9207c392da42cc41724/Objects/clinic/memoryobject.c.h |
|
Open in desktop
| https://desktop.github.com |
| how customized files appear on GitHub | https://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github |
| Please reload this page | https://github.com/python/cpython/pull/125446/files |
| Objects/memoryobject.c | https://github.com/python/cpython/pull/125446/files#diff-7d1cb11da20dc3738b65b0f7381bf02df53132562a9749ba8a22d67a0f05f106 |
|
View file
| https://github.com/picnixz/cpython/blob/3421118c5818d38e59aff9207c392da42cc41724/Objects/memoryobject.c |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/125446/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/125446/files#diff-7d1cb11da20dc3738b65b0f7381bf02df53132562a9749ba8a22d67a0f05f106 |
| Please reload this page | https://github.com/python/cpython/pull/125446/files |
|
| https://github.com/python/cpython/pull/125446/files#diff-7d1cb11da20dc3738b65b0f7381bf02df53132562a9749ba8a22d67a0f05f106 |
|
| https://github.com/python/cpython/pull/125446/files#diff-7d1cb11da20dc3738b65b0f7381bf02df53132562a9749ba8a22d67a0f05f106 |
|
| https://github.com/python/cpython/pull/125446/files#diff-7d1cb11da20dc3738b65b0f7381bf02df53132562a9749ba8a22d67a0f05f106 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |