René's URL Explorer Experiment


Title: gh-125420: implement `Sequence.index` API on `memoryview` objects by picnixz · Pull Request #125446 · python/cpython · GitHub

Open Graph Title: gh-125420: implement `Sequence.index` API on `memoryview` objects by picnixz · Pull Request #125446 · python/cpython

X Title: gh-125420: implement `Sequence.index` API on `memoryview` objects by picnixz · Pull Request #125446 · python/cpython

Description: I went for the simplest implementation. I could unroll the memory_item call to save some operations but I felt that it would only add noise and make maintenance harder so I went for a cleaner but probably a bit slower option. Issue: gh-125420 📚 Documentation preview 📚: https://cpython-previews--125446.org.readthedocs.build/

Open Graph Description: I went for the simplest implementation. I could unroll the memory_item call to save some operations but I felt that it would only add noise and make maintenance harder so I went for a cleaner but p...

X Description: I went for the simplest implementation. I could unroll the memory_item call to save some operations but I felt that it would only add noise and make maintenance harder so I went for a cleaner but p...

Opengraph URL: https://github.com/python/cpython/pull/125446

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8fb359f5-4d7d-d00e-98ca-e3c5dbae932c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD96E:2ED6B1:1322AC:1AB7D3:6B00545B
html-safe-nonce078625f89b837bbf8cabdbfe6fe3dee7c65aff4b2bc73b59db8f0296e4aec67c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTZFOjJFRDZCMToxMzIyQUM6MUFCN0QzOjZCMDA1NDVCIiwidmlzaXRvcl9pZCI6IjIwODU4NjAxNDE5MzE5NzU3NzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5c80db140d517f04844dbd6e50bd4d038043c3276655ad246948b059c62968e9
hovercard-subject-tagpull_request:2122819216
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/125446/files
twitter:imagehttps://avatars.githubusercontent.com/u/10796600?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10796600?s=400&v=4
og:image:altI went for the simplest implementation. I could unroll the memory_item call to save some operations but I felt that it would only add noise and make maintenance harder so I went for a cleaner but p...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26e00df917aba0f128135dc073ea0c5e33a70d40
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/125446/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F125446%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F125446%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/125446/files
Reloadhttps://github.com/python/cpython/pull/125446/files
Reloadhttps://github.com/python/cpython/pull/125446/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/memoryview-sequence-api-index-125420https://github.com/picnixz/cpython/tree/fix/memoryview-sequence-api-index-125420
Conversation 3 https://github.com/python/cpython/pull/125446
Commits 11 https://github.com/python/cpython/pull/125446/commits
Checks 0 https://github.com/python/cpython/pull/125446/checks
Files changed https://github.com/python/cpython/pull/125446/files
Please reload this pagehttps://github.com/python/cpython/pull/125446/files
gh-125420: implement Sequence.index API on memoryview objects https://github.com/python/cpython/pull/125446/files#top
Show all changes 11 commits https://github.com/python/cpython/pull/125446/files
7b78549 add `Sequence.index` to `memoryview` objects picnixz Oct 14, 2024 https://github.com/python/cpython/pull/125446/commits/7b78549e6114f19ee7310fcd2def1864ed3f6ad5
a066924 docs picnixz Oct 14, 2024 https://github.com/python/cpython/pull/125446/commits/a06692430ec2592c6eb1df6b217d4ea9cbeb378c
5c2cf08 blurb picnixz Oct 14, 2024 https://github.com/python/cpython/pull/125446/commits/5c2cf0863471636836d671de94d906d6dff3644d
10245f8 remove IDE imports picnixz Oct 14, 2024 https://github.com/python/cpython/pull/125446/commits/10245f887352f7b602fd7a3c415e3fc34d35a96f
02f94c9 fixup typo! picnixz Oct 14, 2024 https://github.com/python/cpython/pull/125446/commits/02f94c996c69832813236c130e8afd9bd3092656
ea0125d fixup docs picnixz Oct 14, 2024 https://github.com/python/cpython/pull/125446/commits/ea0125db859ca0ca93f9ce300ae9d73cdd406cf0
9f2efa1 add fast path picnixz Oct 17, 2024 https://github.com/python/cpython/pull/125446/commits/9f2efa124f6f59e7b4cec293f073bcd4f772b032
beca7af fixup docs picnixz Oct 27, 2024 https://github.com/python/cpython/pull/125446/commits/beca7afa3a16e10a493ad35958bebffb2e12a6b6
5458b14 fixup tests! picnixz Oct 27, 2024 https://github.com/python/cpython/pull/125446/commits/5458b14664898866d7a9dd0850ed6fdc59d47416
748b678 Merge remote-tracking branch 'upstream/main' into fix/memoryview-sequ… picnixz Nov 3, 2024 https://github.com/python/cpython/pull/125446/commits/748b6785772b0ae971d6240f07162f2002003837
3421118 Merge branch 'main' into fix/memoryview/index-125420 picnixz Dec 4, 2024 https://github.com/python/cpython/pull/125446/commits/3421118c5818d38e59aff9207c392da42cc41724
Clear filters https://github.com/python/cpython/pull/125446/files
Please reload this pagehttps://github.com/python/cpython/pull/125446/files
Please reload this pagehttps://github.com/python/cpython/pull/125446/files
stdtypes.rst https://github.com/python/cpython/pull/125446/files#diff-08a31a70dd1f6d97aa8dacdce77db4de04c700d9949be1af611a595186aad5b3
test_memoryview.py https://github.com/python/cpython/pull/125446/files#diff-d41c6bb40a1e03fea5a20d15c4077413e0ddde65651147922b625b03a66a2f16
2024-10-14-13-28-16.gh-issue-125420.hNKixM.rst https://github.com/python/cpython/pull/125446/files#diff-a4705b1b83dcc527df781e1f32ffd1f05fc132ac29a6ab61d398cf04ee3ae3a6
memoryobject.c.h https://github.com/python/cpython/pull/125446/files#diff-15662bab1fa68645da4a33f34431e6276fb1177525d97c8e4790a9acbb783afc
memoryobject.c https://github.com/python/cpython/pull/125446/files#diff-7d1cb11da20dc3738b65b0f7381bf02df53132562a9749ba8a22d67a0f05f106
Doc/library/stdtypes.rsthttps://github.com/python/cpython/pull/125446/files#diff-08a31a70dd1f6d97aa8dacdce77db4de04c700d9949be1af611a595186aad5b3
View file https://github.com/picnixz/cpython/blob/3421118c5818d38e59aff9207c392da42cc41724/Doc/library/stdtypes.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/125446/{{ revealButtonHref }}
https://github.com/python/cpython/pull/125446/files#diff-08a31a70dd1f6d97aa8dacdce77db4de04c700d9949be1af611a595186aad5b3
https://github.com/python/cpython/pull/125446/files#diff-08a31a70dd1f6d97aa8dacdce77db4de04c700d9949be1af611a595186aad5b3
Lib/test/test_memoryview.pyhttps://github.com/python/cpython/pull/125446/files#diff-d41c6bb40a1e03fea5a20d15c4077413e0ddde65651147922b625b03a66a2f16
View file https://github.com/picnixz/cpython/blob/3421118c5818d38e59aff9207c392da42cc41724/Lib/test/test_memoryview.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/125446/{{ revealButtonHref }}
https://github.com/python/cpython/pull/125446/files#diff-d41c6bb40a1e03fea5a20d15c4077413e0ddde65651147922b625b03a66a2f16
https://github.com/python/cpython/pull/125446/files#diff-d41c6bb40a1e03fea5a20d15c4077413e0ddde65651147922b625b03a66a2f16
https://github.com/python/cpython/pull/125446/files#diff-d41c6bb40a1e03fea5a20d15c4077413e0ddde65651147922b625b03a66a2f16
https://github.com/python/cpython/pull/125446/files#diff-d41c6bb40a1e03fea5a20d15c4077413e0ddde65651147922b625b03a66a2f16
Misc/NEWS.d/next/Core_and_Builtins/2024-10-14-13-28-16.gh-issue-125420.hNKixM.rsthttps://github.com/python/cpython/pull/125446/files#diff-a4705b1b83dcc527df781e1f32ffd1f05fc132ac29a6ab61d398cf04ee3ae3a6
View file https://github.com/picnixz/cpython/blob/3421118c5818d38e59aff9207c392da42cc41724/Misc/NEWS.d/next/Core_and_Builtins/2024-10-14-13-28-16.gh-issue-125420.hNKixM.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/125446/{{ revealButtonHref }}
Objects/clinic/memoryobject.c.hhttps://github.com/python/cpython/pull/125446/files#diff-15662bab1fa68645da4a33f34431e6276fb1177525d97c8e4790a9acbb783afc
View file https://github.com/picnixz/cpython/blob/3421118c5818d38e59aff9207c392da42cc41724/Objects/clinic/memoryobject.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/125446/files
Objects/memoryobject.chttps://github.com/python/cpython/pull/125446/files#diff-7d1cb11da20dc3738b65b0f7381bf02df53132562a9749ba8a22d67a0f05f106
View file https://github.com/picnixz/cpython/blob/3421118c5818d38e59aff9207c392da42cc41724/Objects/memoryobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/125446/{{ revealButtonHref }}
https://github.com/python/cpython/pull/125446/files#diff-7d1cb11da20dc3738b65b0f7381bf02df53132562a9749ba8a22d67a0f05f106
Please reload this pagehttps://github.com/python/cpython/pull/125446/files
https://github.com/python/cpython/pull/125446/files#diff-7d1cb11da20dc3738b65b0f7381bf02df53132562a9749ba8a22d67a0f05f106
https://github.com/python/cpython/pull/125446/files#diff-7d1cb11da20dc3738b65b0f7381bf02df53132562a9749ba8a22d67a0f05f106
https://github.com/python/cpython/pull/125446/files#diff-7d1cb11da20dc3738b65b0f7381bf02df53132562a9749ba8a22d67a0f05f106
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.