René's URL Explorer Experiment


Title: gh-125420: implement `Sequence.index` API on `memoryview` objects by picnixz · Pull Request #125446 · python/cpython · GitHub

Open Graph Title: gh-125420: implement `Sequence.index` API on `memoryview` objects by picnixz · Pull Request #125446 · python/cpython

X Title: gh-125420: implement `Sequence.index` API on `memoryview` objects by picnixz · Pull Request #125446 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: I went for the simplest implementation. I could unroll the memory_item call to save some operations but I felt that it would only add noise and make maintenance harder so I went for a cleaner but p...

X Description: I went for the simplest implementation. I could unroll the memory_item call to save some operations but I felt that it would only add noise and make maintenance harder so I went for a cleaner but p...

Opengraph URL: https://github.com/python/cpython/pull/125446

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b4d7493a-f3a9-b009-b5c8-87868b1a86e0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id935C:308C72:722F0:9E456:6B005153
html-safe-nonce82c0997d90d25e9f39c3bb0c9877ea8f3250301cbd9367afb2ef01ec23172d28
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzVDOjMwOEM3Mjo3MjJGMDo5RTQ1Njo2QjAwNTE1MyIsInZpc2l0b3JfaWQiOiI3MDQ2NTc0Njk3Njg4ODc5NDQzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac28ca179fbfafe173911c526841d6e4022fc9e3c2025e9db2eafa941f3f5625c7
hovercard-subject-tagpull_request:2122819216
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/125446/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9a4db80f00f2485cc7d1b59b610959928bbe46977e0f8c09465e5951c20554e8/python/cpython/pull/125446
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9a4db80f00f2485cc7d1b59b610959928bbe46977e0f8c09465e5951c20554e8/python/cpython/pull/125446
og:image:altI went for the simplest implementation. I could unroll the memory_item call to save some operations but I felt that it would only add noise and make maintenance harder so I went for a cleaner but p...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
Nonef420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26e00df917aba0f128135dc073ea0c5e33a70d40
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/125446#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F125446
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F125446
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/125446
Reloadhttps://github.com/python/cpython/pull/125446
Reloadhttps://github.com/python/cpython/pull/125446
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/memoryview-sequence-api-index-125420https://github.com/picnixz/cpython/tree/fix/memoryview-sequence-api-index-125420
Conversationhttps://github.com/python/cpython/pull/125446
Commits11 (11)https://github.com/python/cpython/pull/125446/commits
Checkshttps://github.com/python/cpython/pull/125446/checks
Files changedhttps://github.com/python/cpython/pull/125446/files
gh-125420: implement Sequence.index API on memoryview objectshttps://github.com/python/cpython/pull/125446#top
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/memoryview-sequence-api-index-125420https://github.com/picnixz/cpython/tree/fix/memoryview-sequence-api-index-125420
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Oct 14, 2024https://github.com/python/cpython/pull/125446#issue-2585754705
Please reload this pagehttps://github.com/python/cpython/pull/125446
memoryview is a Sequence but does not implement the full Sequence API #125420https://github.com/python/cpython/issues/125420
https://cpython-previews--125446.org.readthedocs.build/https://cpython-previews--125446.org.readthedocs.build/
Please reload this pagehttps://github.com/python/cpython/pull/125446
picnixzhttps://github.com/picnixz
October 14, 2024 13:27https://github.com/python/cpython/pull/125446#commits-pushed-7b78549
https://github.com/picnixz
add Sequence.index to memoryview objectshttps://github.com/python/cpython/pull/125446/commits/7b78549e6114f19ee7310fcd2def1864ed3f6ad5
7b78549https://github.com/python/cpython/pull/125446/commits/7b78549e6114f19ee7310fcd2def1864ed3f6ad5
https://github.com/picnixz
docshttps://github.com/python/cpython/pull/125446/commits/a06692430ec2592c6eb1df6b217d4ea9cbeb378c
a066924https://github.com/python/cpython/pull/125446/commits/a06692430ec2592c6eb1df6b217d4ea9cbeb378c
https://github.com/picnixz
blurbhttps://github.com/python/cpython/pull/125446/commits/5c2cf0863471636836d671de94d906d6dff3644d
5c2cf08https://github.com/python/cpython/pull/125446/commits/5c2cf0863471636836d671de94d906d6dff3644d
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Oct 14, 2024https://github.com/python/cpython/pull/125446#event-14633954939
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Oct 14, 2024 https://github.com/python/cpython/pull/125446#ref-issue-2584386709
memoryview is a Sequence but does not implement the full Sequence API #125420 https://github.com/python/cpython/issues/125420
picnixzhttps://github.com/picnixz
October 14, 2024 13:34https://github.com/python/cpython/pull/125446#commits-pushed-10245f8
https://github.com/picnixz
remove IDE importshttps://github.com/python/cpython/pull/125446/commits/10245f887352f7b602fd7a3c415e3fc34d35a96f
10245f8https://github.com/python/cpython/pull/125446/commits/10245f887352f7b602fd7a3c415e3fc34d35a96f
https://github.com/picnixz
fixup typo!https://github.com/python/cpython/pull/125446/commits/02f94c996c69832813236c130e8afd9bd3092656
02f94c9https://github.com/python/cpython/pull/125446/commits/02f94c996c69832813236c130e8afd9bd3092656
https://github.com/picnixz
fixup docshttps://github.com/python/cpython/pull/125446/commits/ea0125db859ca0ca93f9ce300ae9d73cdd406cf0
ea0125dhttps://github.com/python/cpython/pull/125446/commits/ea0125db859ca0ca93f9ce300ae9d73cdd406cf0
https://github.com/corona10
corona10https://github.com/corona10
Oct 14, 2024 https://github.com/python/cpython/pull/125446#pullrequestreview-2366417910
View reviewed changes https://github.com/python/cpython/pull/125446/files/ea0125db859ca0ca93f9ce300ae9d73cdd406cf0
Objects/memoryobject.chttps://github.com/python/cpython/pull/125446/files/ea0125db859ca0ca93f9ce300ae9d73cdd406cf0#diff-7d1cb11da20dc3738b65b0f7381bf02df53132562a9749ba8a22d67a0f05f106
Please reload this pagehttps://github.com/python/cpython/pull/125446
https://github.com/corona10
corona10https://github.com/corona10
JelleZijlstrahttps://github.com/JelleZijlstra
October 14, 2024 12:07https://github.com/python/cpython/pull/125446#event-14634667695
picnixzhttps://github.com/picnixz
October 17, 2024 16:59https://github.com/python/cpython/pull/125446#commits-pushed-9f2efa1
https://github.com/picnixz
add fast pathhttps://github.com/python/cpython/pull/125446/commits/9f2efa124f6f59e7b4cec293f073bcd4f772b032
9f2efa1https://github.com/python/cpython/pull/125446/commits/9f2efa124f6f59e7b4cec293f073bcd4f772b032
https://github.com/picnixz
fixup docshttps://github.com/python/cpython/pull/125446/commits/beca7afa3a16e10a493ad35958bebffb2e12a6b6
beca7afhttps://github.com/python/cpython/pull/125446/commits/beca7afa3a16e10a493ad35958bebffb2e12a6b6
https://github.com/picnixz
fixup tests!https://github.com/python/cpython/pull/125446/commits/5458b14664898866d7a9dd0850ed6fdc59d47416
5458b14https://github.com/python/cpython/pull/125446/commits/5458b14664898866d7a9dd0850ed6fdc59d47416
https://github.com/picnixz
Merge remote-tracking branch 'upstream/main' into fix/memoryview-sequ…https://github.com/python/cpython/pull/125446/commits/748b6785772b0ae971d6240f07162f2002003837
748b678https://github.com/python/cpython/pull/125446/commits/748b6785772b0ae971d6240f07162f2002003837
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Nov 6, 2024https://github.com/python/cpython/pull/125446#issuecomment-2459856329
@JelleZijlstrahttps://github.com/JelleZijlstra
Please reload this pagehttps://github.com/python/cpython/pull/125446
https://github.com/picnixz
Merge branch 'main' into fix/memoryview/index-125420https://github.com/python/cpython/pull/125446/commits/3421118c5818d38e59aff9207c392da42cc41724
3421118https://github.com/python/cpython/pull/125446/commits/3421118c5818d38e59aff9207c392da42cc41724
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Dec 10, 2024 https://github.com/python/cpython/pull/125446#pullrequestreview-2490764615
View reviewed changes https://github.com/python/cpython/pull/125446/files/3421118c5818d38e59aff9207c392da42cc41724
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Dec 10, 2024https://github.com/python/cpython/pull/125446#event-15593542607
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
58c7538https://github.com/python/cpython/commit/58c753827ac7aa3d7f1495ac206c28bf2f6c67e8
Dec 10, 2024https://github.com/python/cpython/pull/125446#event-15593548082
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Dec 10, 2024https://github.com/python/cpython/pull/125446#event-15593548401
https://github.com/picnixz
picnixzhttps://github.com/picnixz
December 10, 2024 08:25https://github.com/python/cpython/pull/125446#event-15596650265
srinivasreddyhttps://github.com/srinivasreddy
Jan 8, 2025 https://github.com/python/cpython/pull/125446#ref-commit-cc2759a
https://github.com/picnixz
https://github.com/srinivasreddy
pythongh-125420https://github.com/python/cpython/issues/125420
: implementhttps://github.com/srinivasreddy/cpython/commit/cc2759a6ff86ef71044e82ddcd9aa6a2a4ab6d76
Sequence.indexhttps://github.com/srinivasreddy/cpython/commit/cc2759a6ff86ef71044e82ddcd9aa6a2a4ab6d76
API onhttps://github.com/srinivasreddy/cpython/commit/cc2759a6ff86ef71044e82ddcd9aa6a2a4ab6d76
memoryviewhttps://github.com/srinivasreddy/cpython/commit/cc2759a6ff86ef71044e82ddcd9aa6a2a4ab6d76
objec…https://github.com/srinivasreddy/cpython/commit/cc2759a6ff86ef71044e82ddcd9aa6a2a4ab6d76
cc2759ahttps://github.com/srinivasreddy/cpython/commit/cc2759a6ff86ef71044e82ddcd9aa6a2a4ab6d76
python#125446https://github.com/python/cpython/pull/125446
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Aug 1, 2026 https://github.com/python/cpython/pull/125446#ref-pullrequest-5036196183
builtins: exception, iterator and function attribute surface parity pyre-lang/pyre#950 https://github.com/pyre-lang/pyre/pull/950
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F125446
https://github.com/corona10
corona10 https://github.com/corona10
https://github.com/python/cpython/pull/125446/files/ea0125db859ca0ca93f9ce300ae9d73cdd406cf0
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
https://github.com/python/cpython/pull/125446/files/3421118c5818d38e59aff9207c392da42cc41724
Please reload this pagehttps://github.com/python/cpython/pull/125446
Please reload this pagehttps://github.com/python/cpython/pull/125446
https://github.com/picnixz
https://github.com/JelleZijlstra
https://github.com/corona10
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.