| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:0ce1f25e-01b6-af89-5a72-9d27d30bcb94 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B066:390AA2:2B92D72:3B9528C:6B005644 |
| html-safe-nonce | ff2df25556a3e4f71b304680902bcaa615a47ab1301cec6467133f9b0b18e686 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDY2OjM5MEFBMjoyQjkyRDcyOjNCOTUyOEM6NkIwMDU2NDQiLCJ2aXNpdG9yX2lkIjoiMzYxMjAwNDM3ODg5MTgwMjE4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f0f4c9e3a287cbae133c82d5655145079bbe58e4074b3fb018f0daaefebf1ef3 |
| hovercard-subject-tag | pull_request:2122720468 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/125443/files |
| twitter:image | https://avatars.githubusercontent.com/u/10796600?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/10796600?s=400&v=4 |
| og:image:alt | Issue: gh-125420
📚 Documentation preview 📚: https://cpython-previews--125443.org.readthedocs.build/ |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | f420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26e00df917aba0f128135dc073ea0c5e33a70d40 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/125443/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F125443%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F125443%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/125443/files |
| Reload | https://github.com/python/cpython/pull/125443/files |
| Reload | https://github.com/python/cpython/pull/125443/files |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| JelleZijlstra | https://github.com/JelleZijlstra |
| python:main | https://github.com/python/cpython/tree/main |
| picnixz:fix/memoryview-sequence-api-count-125420 | https://github.com/picnixz/cpython/tree/fix/memoryview-sequence-api-count-125420 |
|
Conversation
11
| https://github.com/python/cpython/pull/125443 |
|
Commits
15
| https://github.com/python/cpython/pull/125443/commits |
|
Checks
0
| https://github.com/python/cpython/pull/125443/checks |
|
Files changed
| https://github.com/python/cpython/pull/125443/files |
| Please reload this page | https://github.com/python/cpython/pull/125443/files |
|
gh-125420: implement Sequence.count API on memoryview objects
| https://github.com/python/cpython/pull/125443/files#top |
|
Show all changes
15 commits
| https://github.com/python/cpython/pull/125443/files |
|
12a429e
add `count` to memoryview objects
picnixz Oct 14, 2024
| https://github.com/python/cpython/pull/125443/commits/12a429ef0669bd153e7064b7501115f2a378ee4d |
|
8234c5f
docs
picnixz Oct 14, 2024
| https://github.com/python/cpython/pull/125443/commits/8234c5fd05962299d4527ca7bb4fa85dd99d1a16 |
|
a253c9b
blurb
picnixz Oct 14, 2024
| https://github.com/python/cpython/pull/125443/commits/a253c9b88f957f353badbc9bc2575a2457b8b438 |
|
35c3c0a
remove redundant fast path
picnixz Oct 14, 2024
| https://github.com/python/cpython/pull/125443/commits/35c3c0a1c1b3ee4ee4e118882c95080288ea01d4 |
|
be66e19
use of `count++` instead of `count += 1`
picnixz Oct 14, 2024
| https://github.com/python/cpython/pull/125443/commits/be66e19e1f25680a2ca626656add5cada9736fc6 |
|
697b10c
fixups
picnixz Oct 14, 2024
| https://github.com/python/cpython/pull/125443/commits/697b10c76801edaad56709d82f19f20eae4010f6 |
|
2e3d8a7
update docs
picnixz Oct 14, 2024
| https://github.com/python/cpython/pull/125443/commits/2e3d8a79cbad6935298094c33b9f5a8157e908e2 |
|
d311794
increase test coverage
picnixz Oct 14, 2024
| https://github.com/python/cpython/pull/125443/commits/d311794a148c55fd4d1bb23dfc4c4e549becd6fd |
|
41d977a
add a fast path for comparison
picnixz Oct 14, 2024
| https://github.com/python/cpython/pull/125443/commits/41d977a8088b5e0f0910b0d95eabecc348450365 |
|
0c8d8ec
Add note on the impossibility of overflows
picnixz Oct 17, 2024
| https://github.com/python/cpython/pull/125443/commits/0c8d8ec2bc521bff4c05dce79deea6bcf8dcc349 |
|
2a387d5
fixup docs
picnixz Oct 27, 2024
| https://github.com/python/cpython/pull/125443/commits/2a387d5c77b9733e7b65c21923dd78a985a9d17e |
|
83dd0ea
Merge remote-tracking branch 'upstream/main' into fix/memoryview-sequ…
picnixz Nov 3, 2024
| https://github.com/python/cpython/pull/125443/commits/83dd0ea3c9bfc51132873e7800e2c010577f92e0 |
|
d35d124
Merge branch 'main' into fix/memoryview/count-125420
picnixz Dec 4, 2024
| https://github.com/python/cpython/pull/125443/commits/d35d124578e90b334d37b9f38fd16d2c457a97c1 |
|
47c162c
Merge branch 'main' into fix/memoryview-sequence-api-count-125420
JelleZijlstra Dec 10, 2024
| https://github.com/python/cpython/pull/125443/commits/47c162cf4aaca23f7f0e7b56e421db643ffac45c |
|
f68900b
fix clinic
JelleZijlstra Dec 10, 2024
| https://github.com/python/cpython/pull/125443/commits/f68900bd8ff8814d498826dae8c85265ae7fddbc |
|
Clear filters
| https://github.com/python/cpython/pull/125443/files |
| Please reload this page | https://github.com/python/cpython/pull/125443/files |
| Please reload this page | https://github.com/python/cpython/pull/125443/files |
|
stdtypes.rst
| https://github.com/python/cpython/pull/125443/files#diff-08a31a70dd1f6d97aa8dacdce77db4de04c700d9949be1af611a595186aad5b3 |
|
test_memoryview.py
| https://github.com/python/cpython/pull/125443/files#diff-d41c6bb40a1e03fea5a20d15c4077413e0ddde65651147922b625b03a66a2f16 |
|
2024-10-14-12-34-51.gh-issue-125420.jABXoZ.rst
| https://github.com/python/cpython/pull/125443/files#diff-6e7522f4ac9f63e0820c3142794cc8b5e93bc4b0a7eba042b0387c1bfa7a4577 |
|
memoryobject.c.h
| https://github.com/python/cpython/pull/125443/files#diff-15662bab1fa68645da4a33f34431e6276fb1177525d97c8e4790a9acbb783afc |
|
memoryobject.c
| https://github.com/python/cpython/pull/125443/files#diff-7d1cb11da20dc3738b65b0f7381bf02df53132562a9749ba8a22d67a0f05f106 |
| Doc/library/stdtypes.rst | https://github.com/python/cpython/pull/125443/files#diff-08a31a70dd1f6d97aa8dacdce77db4de04c700d9949be1af611a595186aad5b3 |
|
View file
| https://github.com/picnixz/cpython/blob/f68900bd8ff8814d498826dae8c85265ae7fddbc/Doc/library/stdtypes.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/125443/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/125443/files#diff-08a31a70dd1f6d97aa8dacdce77db4de04c700d9949be1af611a595186aad5b3 |
|
| https://github.com/python/cpython/pull/125443/files#diff-08a31a70dd1f6d97aa8dacdce77db4de04c700d9949be1af611a595186aad5b3 |
| Lib/test/test_memoryview.py | https://github.com/python/cpython/pull/125443/files#diff-d41c6bb40a1e03fea5a20d15c4077413e0ddde65651147922b625b03a66a2f16 |
|
View file
| https://github.com/picnixz/cpython/blob/f68900bd8ff8814d498826dae8c85265ae7fddbc/Lib/test/test_memoryview.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/125443/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/125443/files#diff-d41c6bb40a1e03fea5a20d15c4077413e0ddde65651147922b625b03a66a2f16 |
| Please reload this page | https://github.com/python/cpython/pull/125443/files |
|
| https://github.com/python/cpython/pull/125443/files#diff-d41c6bb40a1e03fea5a20d15c4077413e0ddde65651147922b625b03a66a2f16 |
|
| https://github.com/python/cpython/pull/125443/files#diff-d41c6bb40a1e03fea5a20d15c4077413e0ddde65651147922b625b03a66a2f16 |
|
| https://github.com/python/cpython/pull/125443/files#diff-d41c6bb40a1e03fea5a20d15c4077413e0ddde65651147922b625b03a66a2f16 |
| Misc/NEWS.d/next/Core_and_Builtins/2024-10-14-12-34-51.gh-issue-125420.jABXoZ.rst | https://github.com/python/cpython/pull/125443/files#diff-6e7522f4ac9f63e0820c3142794cc8b5e93bc4b0a7eba042b0387c1bfa7a4577 |
|
View file
| https://github.com/picnixz/cpython/blob/f68900bd8ff8814d498826dae8c85265ae7fddbc/Misc/NEWS.d/next/Core_and_Builtins/2024-10-14-12-34-51.gh-issue-125420.jABXoZ.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/125443/{{ revealButtonHref }} |
| Objects/clinic/memoryobject.c.h | https://github.com/python/cpython/pull/125443/files#diff-15662bab1fa68645da4a33f34431e6276fb1177525d97c8e4790a9acbb783afc |
|
View file
| https://github.com/picnixz/cpython/blob/f68900bd8ff8814d498826dae8c85265ae7fddbc/Objects/clinic/memoryobject.c.h |
|
Open in desktop
| https://desktop.github.com |
| how customized files appear on GitHub | https://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github |
| Please reload this page | https://github.com/python/cpython/pull/125443/files |
| Objects/memoryobject.c | https://github.com/python/cpython/pull/125443/files#diff-7d1cb11da20dc3738b65b0f7381bf02df53132562a9749ba8a22d67a0f05f106 |
|
View file
| https://github.com/picnixz/cpython/blob/f68900bd8ff8814d498826dae8c85265ae7fddbc/Objects/memoryobject.c |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/125443/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/125443/files#diff-7d1cb11da20dc3738b65b0f7381bf02df53132562a9749ba8a22d67a0f05f106 |
| Please reload this page | https://github.com/python/cpython/pull/125443/files |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Oct 14, 2024 | https://github.com/python/cpython/pull/125443/files#r1799473513 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/125443/files |
| picnixz | https://github.com/picnixz |
| Oct 14, 2024 | https://github.com/python/cpython/pull/125443/files#r1799503714 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/125443/files |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Oct 14, 2024 | https://github.com/python/cpython/pull/125443/files#r1799469523 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/125443/files |
| picnixz | https://github.com/picnixz |
| Oct 14, 2024 | https://github.com/python/cpython/pull/125443/files#r1799503538 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/125443/files |
|
| https://github.com/python/cpython/pull/125443/files#diff-7d1cb11da20dc3738b65b0f7381bf02df53132562a9749ba8a22d67a0f05f106 |
|
| https://github.com/python/cpython/pull/125443/files#diff-7d1cb11da20dc3738b65b0f7381bf02df53132562a9749ba8a22d67a0f05f106 |
|
| https://github.com/python/cpython/pull/125443/files#diff-7d1cb11da20dc3738b65b0f7381bf02df53132562a9749ba8a22d67a0f05f106 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |