René's URL Explorer Experiment


Title: gh-125243: Fix ZoneInfo data race in free threading build by colesbury · Pull Request #125281 · python/cpython · GitHub

Open Graph Title: gh-125243: Fix ZoneInfo data race in free threading build by colesbury · Pull Request #125281 · python/cpython

X Title: gh-125243: Fix ZoneInfo data race in free threading build by colesbury · Pull Request #125281 · python/cpython

Description: Lock ZoneInfoType to protect accesses to ZONEINFO_STRONG_CACHE. Refactor the tp_new handler to use Argument Clinic so that we can just use @critical_section annotations on the relevant functions. A...

Open Graph Description: Lock ZoneInfoType to protect accesses to ZONEINFO_STRONG_CACHE. Refactor the tp_new handler to use Argument Clinic so that we can just use @critical_section annotations on the relevant functions. A...

X Description: Lock ZoneInfoType to protect accesses to ZONEINFO_STRONG_CACHE. Refactor the tp_new handler to use Argument Clinic so that we can just use @critical_section annotations on the relevant functions. A...

Opengraph URL: https://github.com/python/cpython/pull/125281

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c5c1c7b1-9844-d51d-4238-d5f21743b7e7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9F8A:1DECF9:FCF83B:14A4DBC:696B0BEA
html-safe-nonce0a703da0effbf3cfe027124943bb379dde5b3f955c7554bf2720aaff42eb916c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjhBOjFERUNGOTpGQ0Y4M0I6MTRBNERCQzo2OTZCMEJFQSIsInZpc2l0b3JfaWQiOiI3MDk1MTM5MzMxNjkyMjM1NzU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc5664c231bcc46ed0826dd7a402b41f5ef5184e0f30cfb4e34e44168bb204bc4
hovercard-subject-tagpull_request:2118454631
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/125281/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d38de6762578448ebd1da7039a412c236951f429bcf3fbd5d0f55228cf669dca/python/cpython/pull/125281
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d38de6762578448ebd1da7039a412c236951f429bcf3fbd5d0f55228cf669dca/python/cpython/pull/125281
og:image:altLock ZoneInfoType to protect accesses to ZONEINFO_STRONG_CACHE. Refactor the tp_new handler to use Argument Clinic so that we can just use @critical_section annotations on the relevant functions. A...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecolesbury
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/125281#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F125281
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F125281
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/125281
Reloadhttps://github.com/python/cpython/pull/125281
Reloadhttps://github.com/python/cpython/pull/125281
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/125281
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/125281
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/125281#issue-comment-box
colesburyhttps://github.com/colesbury
python:mainhttps://github.com/python/cpython/tree/main
colesbury:gh-125245-zoneinfohttps://github.com/colesbury/cpython/tree/gh-125245-zoneinfo
gh-125243: Fix ZoneInfo data race in free threading build https://github.com/python/cpython/pull/125281#top
colesburyhttps://github.com/colesbury
python:mainhttps://github.com/python/cpython/tree/main
colesbury:gh-125245-zoneinfohttps://github.com/colesbury/cpython/tree/gh-125245-zoneinfo
Conversation 4 https://github.com/python/cpython/pull/125281
Commits 3 https://github.com/python/cpython/pull/125281/commits
Checks 0 https://github.com/python/cpython/pull/125281/checks
Files changed 3 https://github.com/python/cpython/pull/125281/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Oct 10, 2024https://github.com/python/cpython/pull/125281#issue-2579804500
Please reload this pagehttps://github.com/python/cpython/pull/125281
ZoneInfo comparison fails on free-threaded build #125243https://github.com/python/cpython/issues/125243
Please reload this pagehttps://github.com/python/cpython/pull/125281
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Oct 10, 2024 https://github.com/python/cpython/pull/125281#ref-issue-2578303541
Race condition when importing collections.abc #125245 https://github.com/python/cpython/issues/125245
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Oct 10, 2024 https://github.com/python/cpython/pull/125281#ref-issue-2578257829
ZoneInfo comparison fails on free-threaded build #125243 https://github.com/python/cpython/issues/125243
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Oct 10, 2024https://github.com/python/cpython/pull/125281#event-14597221105
https://github.com/colesbury
pythongh-125243https://github.com/python/cpython/issues/125243
: Fix ZoneInfo data race in free threading buildhttps://github.com/python/cpython/pull/125281/commits/0f4f427c31d896d250da621a58e25c4103e5e5ee
0f4f427https://github.com/python/cpython/pull/125281/commits/0f4f427c31d896d250da621a58e25c4103e5e5ee
https://github.com/colesbury
colesburyhttps://github.com/colesbury
force-pushedhttps://github.com/python/cpython/compare/bcaa72475a1643e835038179ef48841e86f1f40b..0f4f427c31d896d250da621a58e25c4103e5e5ee
bcaa724https://github.com/python/cpython/commit/bcaa72475a1643e835038179ef48841e86f1f40b
0f4f427https://github.com/python/cpython/commit/0f4f427c31d896d250da621a58e25c4103e5e5ee
Compare https://github.com/python/cpython/compare/bcaa72475a1643e835038179ef48841e86f1f40b..0f4f427c31d896d250da621a58e25c4103e5e5ee
October 10, 2024 20:52https://github.com/python/cpython/pull/125281#event-14597239501
https://github.com/colesbury
Regen clinichttps://github.com/python/cpython/pull/125281/commits/282890be5634a2fece5de8b01fb290ba01094fd8
282890bhttps://github.com/python/cpython/pull/125281/commits/282890be5634a2fece5de8b01fb290ba01094fd8
https://github.com/colesbury
colesburyhttps://github.com/colesbury
October 11, 2024 00:42https://github.com/python/cpython/pull/125281#event-14599781226
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Oct 11, 2024https://github.com/python/cpython/pull/125281#event-14599781441
https://github.com/colesbury
colesburyhttps://github.com/colesbury
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Oct 11, 2024https://github.com/python/cpython/pull/125281#event-14599782052
https://github.com/colesbury
colesburyhttps://github.com/colesbury
serhiy-storchakahttps://github.com/serhiy-storchaka
October 11, 2024 00:42https://github.com/python/cpython/pull/125281#event-14599782182
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Oct 11, 2024 https://github.com/python/cpython/pull/125281#pullrequestreview-2362189194
View reviewed changes https://github.com/python/cpython/pull/125281/files/282890be5634a2fece5de8b01fb290ba01094fd8
Modules/_zoneinfo.chttps://github.com/python/cpython/pull/125281/files/282890be5634a2fece5de8b01fb290ba01094fd8#diff-7a27d869df7929eb9c160f1e309e0a00d7059cc81fa7613464c499d775dc0562
Please reload this pagehttps://github.com/python/cpython/pull/125281
https://github.com/colesbury
Use zoneinfo_ZoneInfo_impl in zoneinfo_ZoneInfo__unpickle_implhttps://github.com/python/cpython/pull/125281/commits/89a8cd319788681924f26a42c88323c95d8ee1be
89a8cd3https://github.com/python/cpython/pull/125281/commits/89a8cd319788681924f26a42c88323c95d8ee1be
https://github.com/colesbury
colesburyhttps://github.com/colesbury
serhiy-storchakahttps://github.com/serhiy-storchaka
October 13, 2024 16:48https://github.com/python/cpython/pull/125281#event-14620099306
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Oct 13, 2024 https://github.com/python/cpython/pull/125281#pullrequestreview-2364956440
View reviewed changes https://github.com/python/cpython/pull/125281/files/89a8cd319788681924f26a42c88323c95d8ee1be
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Oct 13, 2024https://github.com/python/cpython/pull/125281#event-14620116482
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Oct 13, 2024 https://github.com/python/cpython/pull/125281#pullrequestreview-2364976444
View reviewed changes https://github.com/python/cpython/pull/125281/files/89a8cd319788681924f26a42c88323c95d8ee1be
serhiy-storchakahttps://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/125281#pullrequestreview-2364976444
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/125281
https://github.com/colesbury
colesburyhttps://github.com/colesbury
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Oct 13, 2024https://github.com/python/cpython/pull/125281#event-14620511107
https://github.com/colesbury
colesburyhttps://github.com/colesbury
f1d33dbhttps://github.com/python/cpython/commit/f1d33dbddd3496b062e1fbe024fb6d7b023a35f5
Oct 13, 2024https://github.com/python/cpython/pull/125281#event-14620512058
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Oct 13, 2024https://github.com/python/cpython/pull/125281#issuecomment-2409111308
@colesburyhttps://github.com/colesbury
Please reload this pagehttps://github.com/python/cpython/pull/125281
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Oct 13, 2024https://github.com/python/cpython/pull/125281#event-14620512148
https://github.com/colesbury
colesburyhttps://github.com/colesbury
October 13, 2024 20:17https://github.com/python/cpython/pull/125281#event-14620512162
miss-islingtonhttps://github.com/miss-islington
Oct 13, 2024 https://github.com/python/cpython/pull/125281#ref-commit-a9c2581
https://github.com/colesbury
https://github.com/miss-islington
pythongh-125243https://github.com/python/cpython/issues/125243
: Fix ZoneInfo data race in free threading build (https://github.com/miss-islington/cpython/commit/a9c2581375fe6d194d248775573d01e9a1bee089
pyth…https://github.com/python/cpython/pull/125281
a9c2581https://github.com/miss-islington/cpython/commit/a9c2581375fe6d194d248775573d01e9a1bee089
…onGH-125281https://github.com/python/cpython/pull/125281
f1d33dbhttps://github.com/miss-islington/cpython/commit/f1d33dbddd3496b062e1fbe024fb6d7b023a35f5
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Oct 13, 2024https://github.com/python/cpython/pull/125281#issuecomment-2409111374
GH-125414https://github.com/python/cpython/pull/125414
3.13 branchhttps://github.com/python/cpython/tree/3.13
Please reload this pagehttps://github.com/python/cpython/pull/125281
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Oct 13, 2024https://github.com/python/cpython/pull/125281#event-14620512583
colesburyhttps://github.com/colesbury
Oct 15, 2024 https://github.com/python/cpython/pull/125281#ref-commit-6474e29
https://github.com/miss-islington
https://github.com/colesbury
[3.13]https://github.com/python/cpython/commit/6474e296c04f136c9d664c899d126795f280ff11
gh-125243https://github.com/python/cpython/issues/125243
: Fix ZoneInfo data race in free threading build (https://github.com/python/cpython/commit/6474e296c04f136c9d664c899d126795f280ff11
GH-…https://github.com/python/cpython/pull/125281
6474e29https://github.com/python/cpython/commit/6474e296c04f136c9d664c899d126795f280ff11
…125281https://github.com/python/cpython/pull/125281
gh-125414https://github.com/python/cpython/pull/125414
f1d33dbhttps://github.com/python/cpython/commit/f1d33dbddd3496b062e1fbe024fb6d7b023a35f5
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F125281
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/125281/files/89a8cd319788681924f26a42c88323c95d8ee1be
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
https://github.com/python/cpython/pull/125281/files/89a8cd319788681924f26a42c88323c95d8ee1be
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Please reload this pagehttps://github.com/python/cpython/pull/125281
https://github.com/colesbury
https://github.com/serhiy-storchaka
https://github.com/kumaraditya303
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.