René's URL Explorer Experiment


Title: gh-115999: Refactor `LOAD_GLOBAL` specializations to avoid reloading {globals, builtins} keys by mpage · Pull Request #124953 · python/cpython · GitHub

Open Graph Title: gh-115999: Refactor `LOAD_GLOBAL` specializations to avoid reloading {globals, builtins} keys by mpage · Pull Request #124953 · python/cpython

X Title: gh-115999: Refactor `LOAD_GLOBAL` specializations to avoid reloading {globals, builtins} keys by mpage · Pull Request #124953 · python/cpython

Description: Each of the LOAD_GLOBAL specializations is implemented roughly as: Load keys version. Load cached keys version. Deopt if (1) and (2) don't match. Load keys. Load cached index into keys. Load object from (4) at offset from (5). This is not thread-safe in free-threaded builds; the keys object may be replaced in between steps (3) and (4). This change refactors the specializations to avoid reloading the keys object and instead pass the keys object from guards to be consumed by downstream uops. Issue: gh-115999

Open Graph Description: Each of the LOAD_GLOBAL specializations is implemented roughly as: Load keys version. Load cached keys version. Deopt if (1) and (2) don't match. Load keys. Load cached index into keys. Load o...

X Description: Each of the LOAD_GLOBAL specializations is implemented roughly as: Load keys version. Load cached keys version. Deopt if (1) and (2) don't match. Load keys. Load cached index into keys. Lo...

Opengraph URL: https://github.com/python/cpython/pull/124953

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bea244f9-941d-2649-f029-81a80af447ed
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA2FE:352C83:864B63:C16C09:6A5619FE
html-safe-nonce31bf389db64a647cc6ac8cbd59acd1cfd3395aba9bf6682312a1f08d9a89580a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkZFOjM1MkM4Mzo4NjRCNjM6QzE2QzA5OjZBNTYxOUZFIiwidmlzaXRvcl9pZCI6IjY3MDgxMjY3MzA2Nzc1MjQ5OTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfd25c06a9d668b9bb60d555d0828702ea8643bd04828ce7f30ed5836cd5e3f1f
hovercard-subject-tagpull_request:2106459854
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/124953/files
twitter:imagehttps://avatars.githubusercontent.com/u/577841?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/577841?s=400&v=4
og:image:altEach of the LOAD_GLOBAL specializations is implemented roughly as: Load keys version. Load cached keys version. Deopt if (1) and (2) don't match. Load keys. Load cached index into keys. Load o...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef4368738fc918fecd9b3958f6b49218bbe60d4185f38e72e3954e11f1ad0213a
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb76b9cc70d30da50674184c9c66c56423fd0b93c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/124953/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124953%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124953%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/124953/files
Reloadhttps://github.com/python/cpython/pull/124953/files
Reloadhttps://github.com/python/cpython/pull/124953/files
Please reload this pagehttps://github.com/python/cpython/pull/124953/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/124953/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
colesburyhttps://github.com/colesbury
python:mainhttps://github.com/python/cpython/tree/main
mpage:gh-115999-refactor-load-globalhttps://github.com/mpage/cpython/tree/gh-115999-refactor-load-global
Conversation 13 https://github.com/python/cpython/pull/124953
Commits 6 https://github.com/python/cpython/pull/124953/commits
Checks 0 https://github.com/python/cpython/pull/124953/checks
Files changed https://github.com/python/cpython/pull/124953/files
Please reload this pagehttps://github.com/python/cpython/pull/124953/files
gh-115999: Refactor LOAD_GLOBAL specializations to avoid reloading {globals, builtins} keys https://github.com/python/cpython/pull/124953/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/124953/files
0a98bc0 Refactor `LOAD_GLOBAL` specializations to avoid reloading {globals, b… mpage Sep 24, 2024 https://github.com/python/cpython/pull/124953/commits/0a98bc0c7cacddd81be96dea064ffff9ddf6b2ff
d00adef Sync stack pointer in ops that consume keys mpage Oct 7, 2024 https://github.com/python/cpython/pull/124953/commits/d00adeffb868e697ff5f66754422f23bf67aff36
e68f7e0 Merge branch 'main' into gh-115999-refactor-load-global mpage Oct 7, 2024 https://github.com/python/cpython/pull/124953/commits/e68f7e024f0fca54155fc7be91ec4cdb680a97a3
7a682cc Mark keys dead mpage Oct 7, 2024 https://github.com/python/cpython/pull/124953/commits/7a682ccb5353aac430fe2c91cd527336a38641cc
93f121b Fix compiler warning in optimizer_cases.c.h mpage Oct 8, 2024 https://github.com/python/cpython/pull/124953/commits/93f121bff00e49b7209285740dbf81bc291345e5
d41b85a Merge branch 'main' into gh-115999-refactor-load-global colesbury Oct 9, 2024 https://github.com/python/cpython/pull/124953/commits/d41b85a44a19c5ad1800c4197ca3733ce9d7bc22
Clear filters https://github.com/python/cpython/pull/124953/files
Please reload this pagehttps://github.com/python/cpython/pull/124953/files
Please reload this pagehttps://github.com/python/cpython/pull/124953/files
pycore_opcode_metadata.h https://github.com/python/cpython/pull/124953/files#diff-72bc4c0445516cc3eabd536220b2459617491ffaabbdb8a7c5381f36c991e378
pycore_uop_ids.h https://github.com/python/cpython/pull/124953/files#diff-2a420e4d0d58009249c0f73f7c822167b053bd51cb213b20179bd2aebfc66ff9
pycore_uop_metadata.h https://github.com/python/cpython/pull/124953/files#diff-55e65a72fa31e9b746e03076d2c74b716c0c1171663f36960b2339fcbfae9bab
bytecodes.c https://github.com/python/cpython/pull/124953/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
executor_cases.c.h https://github.com/python/cpython/pull/124953/files#diff-a1c3430c42a66c16e6d2e154491a6da993b187b27c628545a12a02c7b2a06b81
generated_cases.c.h https://github.com/python/cpython/pull/124953/files#diff-4ef46fa654f95502e49a24f7dc8ee31a4cac9b3433fe9cd2b2d4dd78cfbad448
optimizer_analysis.c https://github.com/python/cpython/pull/124953/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
optimizer_bytecodes.c https://github.com/python/cpython/pull/124953/files#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
optimizer_cases.c.h https://github.com/python/cpython/pull/124953/files#diff-ed4567b3e67709ec57bf4df91ef058cfcbe00d7da11cd2a75e38241fa1ca99d2
Include/internal/pycore_opcode_metadata.hhttps://github.com/python/cpython/pull/124953/files#diff-72bc4c0445516cc3eabd536220b2459617491ffaabbdb8a7c5381f36c991e378
View file https://github.com/mpage/cpython/blob/d41b85a44a19c5ad1800c4197ca3733ce9d7bc22/Include/internal/pycore_opcode_metadata.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/124953/files
Include/internal/pycore_uop_ids.hhttps://github.com/python/cpython/pull/124953/files#diff-2a420e4d0d58009249c0f73f7c822167b053bd51cb213b20179bd2aebfc66ff9
View file https://github.com/mpage/cpython/blob/d41b85a44a19c5ad1800c4197ca3733ce9d7bc22/Include/internal/pycore_uop_ids.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/124953/files
Include/internal/pycore_uop_metadata.hhttps://github.com/python/cpython/pull/124953/files#diff-55e65a72fa31e9b746e03076d2c74b716c0c1171663f36960b2339fcbfae9bab
View file https://github.com/mpage/cpython/blob/d41b85a44a19c5ad1800c4197ca3733ce9d7bc22/Include/internal/pycore_uop_metadata.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/124953/files
Please reload this pagehttps://github.com/python/cpython/pull/124953/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.