René's URL Explorer Experiment


Title: gh-124722: Fix leak in `test_detach_materialized_dict_no_memory` by sobolevn · Pull Request #124769 · python/cpython · GitHub

Open Graph Title: gh-124722: Fix leak in `test_detach_materialized_dict_no_memory` by sobolevn · Pull Request #124769 · python/cpython

X Title: gh-124722: Fix leak in `test_detach_materialized_dict_no_memory` by sobolevn · Pull Request #124769 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: The leak was in setting _testcapi.set_nomemory(0, 1), in other places it is only used together with assert_python_ok I also marked this test as cpython_only and I also skip it if _testcapi is not p...

X Description: The leak was in setting _testcapi.set_nomemory(0, 1), in other places it is only used together with assert_python_ok I also marked this test as cpython_only and I also skip it if _testcapi is not p...

Opengraph URL: https://github.com/python/cpython/pull/124769

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:57b1f092-5011-169c-9a8a-bafd5ac2a1b7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C9E:23E48:9CD96F:C45260:6B022C96
html-safe-nonce0783624b58af962c802997b94a04539223999f82302e1ad296e1231344afd36e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzlFOjIzRTQ4OjlDRDk2RjpDNDUyNjA6NkIwMjJDOTYiLCJ2aXNpdG9yX2lkIjoiNzQ1NzIzNjQwMjI2MzE3NDI5NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaceae92fe21a859dc47a7ac2dd1a526894e1ac90f747bab7b08459cd87a05d964c
hovercard-subject-tagpull_request:2097774983
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/124769/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d5ba09a30a0b027cd0cec511a0410574b3dcadbd294b1630d15c8a081433d2bd/python/cpython/pull/124769
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d5ba09a30a0b027cd0cec511a0410574b3dcadbd294b1630d15c8a081433d2bd/python/cpython/pull/124769
og:image:altThe leak was in setting _testcapi.set_nomemory(0, 1), in other places it is only used together with assert_python_ok I also marked this test as cpython_only and I also skip it if _testcapi is not p...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesobolevn
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/124769#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124769
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124769
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/124769
Reloadhttps://github.com/python/cpython/pull/124769
Reloadhttps://github.com/python/cpython/pull/124769
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
zwarehttps://github.com/zware
python:mainhttps://github.com/python/cpython/tree/main
sobolevn:issue-124722https://github.com/sobolevn/cpython/tree/issue-124722
Conversationhttps://github.com/python/cpython/pull/124769
Commits2 (2)https://github.com/python/cpython/pull/124769/commits
Checkshttps://github.com/python/cpython/pull/124769/checks
Files changedhttps://github.com/python/cpython/pull/124769/files
gh-124722: Fix leak in test_detach_materialized_dict_no_memoryhttps://github.com/python/cpython/pull/124769#top
zwarehttps://github.com/zware
python:mainhttps://github.com/python/cpython/tree/main
sobolevn:issue-124722https://github.com/sobolevn/cpython/tree/issue-124722
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Sep 29, 2024https://github.com/python/cpython/pull/124769#issue-2555134948
Please reload this pagehttps://github.com/python/cpython/pull/124769
test_class.TestInlineValues.test_detach_materialized_dict_no_memory leaks references #124722https://github.com/python/cpython/issues/124722
Please reload this pagehttps://github.com/python/cpython/pull/124769
https://github.com/sobolevn
pythongh-124722https://github.com/python/cpython/issues/124722
: Fix leak inhttps://github.com/python/cpython/pull/124769/commits/d42f6c052863595ebfaedd076893ef57f84b9d2f
test_detach_materialized_dict_no_memoryhttps://github.com/python/cpython/pull/124769/commits/d42f6c052863595ebfaedd076893ef57f84b9d2f
d42f6c0https://github.com/python/cpython/pull/124769/commits/d42f6c052863595ebfaedd076893ef57f84b9d2f
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
DinoVhttps://github.com/DinoV
markshannonhttps://github.com/markshannon
September 29, 2024 20:11https://github.com/python/cpython/pull/124769#event-14446554161
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 29, 2024https://github.com/python/cpython/pull/124769#event-14446554279
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 29, 2024 https://github.com/python/cpython/pull/124769#ref-issue-2553943809
test_class.TestInlineValues.test_detach_materialized_dict_no_memory leaks references #124722 https://github.com/python/cpython/issues/124722
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Sep 29, 2024https://github.com/python/cpython/pull/124769#event-14446554385
https://github.com/sobolevn
pythongh-124722https://github.com/python/cpython/issues/124722
: Fix leak inhttps://github.com/python/cpython/pull/124769/commits/e7a409bef6832f981d0e25e57d23d798458b49d2
test_detach_materialized_dict_no_memoryhttps://github.com/python/cpython/pull/124769/commits/e7a409bef6832f981d0e25e57d23d798458b49d2
e7a409bhttps://github.com/python/cpython/pull/124769/commits/e7a409bef6832f981d0e25e57d23d798458b49d2
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Sep 29, 2024https://github.com/python/cpython/pull/124769#event-14446556889
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Sep 29, 2024 https://github.com/python/cpython/pull/124769#pullrequestreview-2335990969
View reviewed changes https://github.com/python/cpython/pull/124769/files/e7a409bef6832f981d0e25e57d23d798458b49d2
ZeroIntensityhttps://github.com/ZeroIntensity
Please reload this pagehttps://github.com/python/cpython/pull/124769
https://github.com/python/cpython/pull/124769#pullrequestreview-2335990969
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/124769
https://github.com/Eclips4
Eclips4https://github.com/Eclips4
Sep 29, 2024 https://github.com/python/cpython/pull/124769#pullrequestreview-2335991034
View reviewed changes https://github.com/python/cpython/pull/124769/files/e7a409bef6832f981d0e25e57d23d798458b49d2
Eclips4https://github.com/Eclips4
https://github.com/python/cpython/pull/124769#pullrequestreview-2335991034
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/124769
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 29, 2024https://github.com/python/cpython/pull/124769#event-14446567683
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Sep 29, 2024https://github.com/python/cpython/pull/124769#issuecomment-2381593112
@ZeroIntensityhttps://github.com/ZeroIntensity
Please reload this pagehttps://github.com/python/cpython/pull/124769
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Sep 29, 2024https://github.com/python/cpython/pull/124769#issuecomment-2381594472
Please reload this pagehttps://github.com/python/cpython/pull/124769
https://github.com/zware
zwarehttps://github.com/zware
Sep 29, 2024https://github.com/python/cpython/pull/124769#issuecomment-2381621912
Please reload this pagehttps://github.com/python/cpython/pull/124769
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 29, 2024https://github.com/python/cpython/pull/124769#issuecomment-2381621922
@zwarehttps://github.com/zware
e7a409bhttps://github.com/python/cpython/commit/e7a409bef6832f981d0e25e57d23d798458b49d2
Please reload this pagehttps://github.com/python/cpython/pull/124769
https://github.com/zware
zwarehttps://github.com/zware
Sep 30, 2024https://github.com/python/cpython/pull/124769#issuecomment-2381850510
@markshannonhttps://github.com/markshannon
Please reload this pagehttps://github.com/python/cpython/pull/124769
https://github.com/zware
zwarehttps://github.com/zware
6f4d64bhttps://github.com/python/cpython/commit/6f4d64b048133c60d40705fb5ef776f78c7dd710
Sep 30, 2024https://github.com/python/cpython/pull/124769#event-14447863747
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Sep 30, 2024https://github.com/python/cpython/pull/124769#issuecomment-2381850729
@sobolevnhttps://github.com/sobolevn
@zwarehttps://github.com/zware
Please reload this pagehttps://github.com/python/cpython/pull/124769
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Sep 30, 2024https://github.com/python/cpython/pull/124769#event-14447864068
miss-islingtonhttps://github.com/miss-islington
Sep 30, 2024 https://github.com/python/cpython/pull/124769#ref-commit-73d7d1b
https://github.com/sobolevn
https://github.com/miss-islington
pythongh-124722https://github.com/python/cpython/issues/124722
: Fix leak inhttps://github.com/miss-islington/cpython/commit/73d7d1bc274161600c8ac1f38491929f9347009d
test_detach_materialized_dict_no_memoryhttps://github.com/miss-islington/cpython/commit/73d7d1bc274161600c8ac1f38491929f9347009d
(https://github.com/miss-islington/cpython/commit/73d7d1bc274161600c8ac1f38491929f9347009d
73d7d1bhttps://github.com/miss-islington/cpython/commit/73d7d1bc274161600c8ac1f38491929f9347009d
pythonGH-124769https://github.com/python/cpython/pull/124769
6f4d64bhttps://github.com/miss-islington/cpython/commit/6f4d64b048133c60d40705fb5ef776f78c7dd710
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 30, 2024https://github.com/python/cpython/pull/124769#issuecomment-2381850814
GH-124777https://github.com/python/cpython/pull/124777
3.13 branchhttps://github.com/python/cpython/tree/3.13
Please reload this pagehttps://github.com/python/cpython/pull/124769
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Sep 30, 2024https://github.com/python/cpython/pull/124769#event-14447864729
Yhg1shttps://github.com/Yhg1s
Sep 30, 2024 https://github.com/python/cpython/pull/124769#ref-commit-ce0eaa6
https://github.com/miss-islington
https://github.com/sobolevn
[3.13]https://github.com/python/cpython/commit/ce0eaa67032389d64fd2d7fb510e34372082eef8
gh-124722https://github.com/python/cpython/issues/124722
: Fix leak in `test_detach_materialized_dict_no_memor…https://github.com/python/cpython/commit/ce0eaa67032389d64fd2d7fb510e34372082eef8
ce0eaa6https://github.com/python/cpython/commit/ce0eaa67032389d64fd2d7fb510e34372082eef8
GH-124769https://github.com/python/cpython/pull/124769
#124777https://github.com/python/cpython/pull/124777
gh-124722https://github.com/python/cpython/issues/124722
GH-124769https://github.com/python/cpython/pull/124769
6f4d64bhttps://github.com/python/cpython/commit/6f4d64b048133c60d40705fb5ef776f78c7dd710
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124769
https://github.com/ZeroIntensity
ZeroIntensity https://github.com/ZeroIntensity
https://github.com/python/cpython/pull/124769/files/e7a409bef6832f981d0e25e57d23d798458b49d2
https://github.com/Eclips4
Eclips4 https://github.com/Eclips4
https://github.com/python/cpython/pull/124769/files/e7a409bef6832f981d0e25e57d23d798458b49d2
https://github.com/DinoV
DinoV https://github.com/DinoV
https://github.com/markshannon
markshannon https://github.com/markshannon
Please reload this pagehttps://github.com/python/cpython/pull/124769
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Please reload this pagehttps://github.com/python/cpython/pull/124769
https://github.com/sobolevn
https://github.com/ZeroIntensity
https://github.com/zware
https://github.com/bedevere-bot
https://github.com/Eclips4
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.