René's URL Explorer Experiment


Title: gh-124872: Back up exception before calling PyContext_WatchCallback by rhansen · Pull Request #124741 · python/cpython · GitHub

Open Graph Title: gh-124872: Back up exception before calling PyContext_WatchCallback by rhansen · Pull Request #124741 · python/cpython

X Title: gh-124872: Back up exception before calling PyContext_WatchCallback by rhansen · Pull Request #124741 · python/cpython

Description: I believe that the value of a simpler API (and defense against poorly written callbacks) outweighs the cost of backing up and restoring the thread's exception state. Also change the return type from int to void. The callback cannot prevent the event from occurring by raising an exception. Nor should it be able to; any failure to switch contexts would be difficult if not impossible to handle correctly. The API should reflect that the callback is purely informational, and that the context switch will happen even if the callback doesn't want it to. I don't think a NEWS blurb is needed because this amends a feature that is new to v3.14; the existing blurb should suffice. cc @fried Issue: gh-119333 Issue: gh-124872 📚 Documentation preview 📚: https://cpython-previews--124741.org.readthedocs.build/

Open Graph Description: I believe that the value of a simpler API (and defense against poorly written callbacks) outweighs the cost of backing up and restoring the thread's exception state. Also change the return type...

X Description: I believe that the value of a simpler API (and defense against poorly written callbacks) outweighs the cost of backing up and restoring the thread's exception state. Also change the return ...

Opengraph URL: https://github.com/python/cpython/pull/124741

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ed05ee83-726e-98a3-2cb3-965c465c57b2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD59A:8AE25:200A637:2A51137:6B023F56
html-safe-nonce44833fa177b4c3f0666ed50435c4d61532076bc7216f7d75f360d800ac3b4efe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTlBOjhBRTI1OjIwMEE2Mzc6MkE1MTEzNzo2QjAyM0Y1NiIsInZpc2l0b3JfaWQiOiIxNjI1Mjc5MTEwNTEzMzExNTc0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac35ce0eb1555648f3ac544115dfeef284edbf6ce57d25e73bf7de8948eafc14d0
hovercard-subject-tagpull_request:2097335778
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/124741/files
twitter:imagehttps://avatars.githubusercontent.com/u/1612291?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1612291?s=400&v=4
og:image:altI believe that the value of a simpler API (and defense against poorly written callbacks) outweighs the cost of backing up and restoring the thread's exception state. Also change the return type...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/124741/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124741%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124741%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/124741/files
Reloadhttps://github.com/python/cpython/pull/124741/files
Reloadhttps://github.com/python/cpython/pull/124741/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
rhansenhttps://github.com/rhansen
python:mainhttps://github.com/python/cpython/tree/main
rhansen:gh-119333-exceptionhttps://github.com/rhansen/cpython/tree/gh-119333-exception
Conversation 35 https://github.com/python/cpython/pull/124741
Commits 5 https://github.com/python/cpython/pull/124741/commits
Checks 0 https://github.com/python/cpython/pull/124741/checks
Files changed https://github.com/python/cpython/pull/124741/files
Please reload this pagehttps://github.com/python/cpython/pull/124741/files
gh-124872: Back up exception before calling PyContext_WatchCallback https://github.com/python/cpython/pull/124741/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/124741/files
c5789a9 gh-124872: Back up exception before calling PyContext_WatchCallback rhansen Sep 28, 2024 https://github.com/python/cpython/pull/124741/commits/c5789a95cf273dcc699fa6e58045022d41982f38
4c115ab gh-124872: Clarify expected PyContext_WatchCallback return behavior rhansen Oct 14, 2024 https://github.com/python/cpython/pull/124741/commits/4c115ab49233f00af46858b5514a93cdd388968b
300f2fc gh-124872: Change PyContext_WatchCallback return type to void rhansen Sep 28, 2024 https://github.com/python/cpython/pull/124741/commits/300f2fcceacb0d7b31b6e8330053398b6d0cdc7e
f177ad3 fixup! gh-124872: Change PyContext_WatchCallback return type to void rhansen Nov 23, 2024 https://github.com/python/cpython/pull/124741/commits/f177ad375ccfed19210222dbc0756eaea56c8511
f6562b1 fixup! gh-124872: Change PyContext_WatchCallback return type to void rhansen Nov 23, 2024 https://github.com/python/cpython/pull/124741/commits/f6562b15cf9f074e8876a5afc6492eb8f41ddf6d
Clear filters https://github.com/python/cpython/pull/124741/files
Please reload this pagehttps://github.com/python/cpython/pull/124741/files
Please reload this pagehttps://github.com/python/cpython/pull/124741/files
contextvars.rst https://github.com/python/cpython/pull/124741/files#diff-dcba959f99b35e4934a2cd76dfadf4e3387e455b7e717691e71ae94edd838538
context.h https://github.com/python/cpython/pull/124741/files#diff-2c91c78b4215de3e077f4057086cf3ed5de8e29ef0ba9553fdccae4846aedd6a
test_watchers.py https://github.com/python/cpython/pull/124741/files#diff-f13cecf74c62d3b381dfd239e6e1c1c18e83e809b9c3dcb20237d1a8d27c439c
2024-11-22-18-58-20.gh-issue-124872.o2Pl5p.rst https://github.com/python/cpython/pull/124741/files#diff-d9f1f98b6b84711a7cae8e31cf32c3fbf1dc78f95bcd61332cff7a0e41fe89c4
watchers.c https://github.com/python/cpython/pull/124741/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
context.c https://github.com/python/cpython/pull/124741/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L235
Doc/c-api/contextvars.rsthttps://github.com/python/cpython/pull/124741/files#diff-dcba959f99b35e4934a2cd76dfadf4e3387e455b7e717691e71ae94edd838538
View file https://github.com/python/cpython/blob/f6562b15cf9f074e8876a5afc6492eb8f41ddf6d/Doc/c-api/contextvars.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/124741/{{ revealButtonHref }}
https://github.com/python/cpython/pull/124741/files#diff-dcba959f99b35e4934a2cd76dfadf4e3387e455b7e717691e71ae94edd838538
Please reload this pagehttps://github.com/python/cpython/pull/124741/files
https://github.com/python/cpython/pull/124741/files#diff-dcba959f99b35e4934a2cd76dfadf4e3387e455b7e717691e71ae94edd838538
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L237
Include/cpython/context.hhttps://github.com/python/cpython/pull/124741/files#diff-2c91c78b4215de3e077f4057086cf3ed5de8e29ef0ba9553fdccae4846aedd6a
View file https://github.com/python/cpython/blob/f6562b15cf9f074e8876a5afc6492eb8f41ddf6d/Include/cpython/context.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/124741/{{ revealButtonHref }}
https://github.com/python/cpython/pull/124741/files#diff-2c91c78b4215de3e077f4057086cf3ed5de8e29ef0ba9553fdccae4846aedd6a
https://github.com/python/cpython/pull/124741/files#diff-2c91c78b4215de3e077f4057086cf3ed5de8e29ef0ba9553fdccae4846aedd6a
Lib/test/test_capi/test_watchers.pyhttps://github.com/python/cpython/pull/124741/files#diff-f13cecf74c62d3b381dfd239e6e1c1c18e83e809b9c3dcb20237d1a8d27c439c
View file https://github.com/python/cpython/blob/f6562b15cf9f074e8876a5afc6492eb8f41ddf6d/Lib/test/test_capi/test_watchers.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/124741/{{ revealButtonHref }}
https://github.com/python/cpython/pull/124741/files#diff-f13cecf74c62d3b381dfd239e6e1c1c18e83e809b9c3dcb20237d1a8d27c439c
https://github.com/python/cpython/pull/124741/files#diff-f13cecf74c62d3b381dfd239e6e1c1c18e83e809b9c3dcb20237d1a8d27c439c
Misc/NEWS.d/next/C_API/2024-11-22-18-58-20.gh-issue-124872.o2Pl5p.rsthttps://github.com/python/cpython/pull/124741/files#diff-d9f1f98b6b84711a7cae8e31cf32c3fbf1dc78f95bcd61332cff7a0e41fe89c4
View file https://github.com/python/cpython/blob/f6562b15cf9f074e8876a5afc6492eb8f41ddf6d/Misc/NEWS.d/next/C_API/2024-11-22-18-58-20.gh-issue-124872.o2Pl5p.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/124741/{{ revealButtonHref }}
Modules/_testcapi/watchers.chttps://github.com/python/cpython/pull/124741/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
View file https://github.com/python/cpython/blob/f6562b15cf9f074e8876a5afc6492eb8f41ddf6d/Modules/_testcapi/watchers.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/124741/{{ revealButtonHref }}
https://github.com/python/cpython/pull/124741/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/pull/124741/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/pull/124741/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L240
Python/context.chttps://github.com/python/cpython/pull/124741/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
View file https://github.com/python/cpython/blob/f6562b15cf9f074e8876a5afc6492eb8f41ddf6d/Python/context.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/124741/{{ revealButtonHref }}
https://github.com/python/cpython/pull/124741/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
iritkatrielhttps://github.com/iritkatriel
Oct 13, 2024https://github.com/python/cpython/pull/124741/files#r1798401832
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/124741/files
rhansenhttps://github.com/rhansen
Oct 13, 2024https://github.com/python/cpython/pull/124741/files#r1798462789
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/124741/files
iritkatrielhttps://github.com/iritkatriel
Oct 13, 2024https://github.com/python/cpython/pull/124741/files#r1798466030
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/124741/files
rhansenhttps://github.com/rhansen
Oct 13, 2024https://github.com/python/cpython/pull/124741/files#r1798471577
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
gh-99633https://github.com/python/cpython/issues/99633
Please reload this pagehttps://github.com/python/cpython/pull/124741/files
rhansenhttps://github.com/rhansen
Oct 14, 2024https://github.com/python/cpython/pull/124741/files#r1798768283
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/124741/files
1st1https://github.com/1st1
Oct 14, 2024https://github.com/python/cpython/pull/124741/files#r1799999709
Please reload this pagehttps://github.com/python/cpython/pull/124741/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/124741/files
1st1https://github.com/1st1
Oct 14, 2024https://github.com/python/cpython/pull/124741/files#r1800000221
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/124741/files
rhansenhttps://github.com/rhansen
Nov 11, 2024https://github.com/python/cpython/pull/124741/files#r1836063468
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@iritkatrielhttps://github.com/iritkatriel
@1st1https://github.com/1st1
Please reload this pagehttps://github.com/python/cpython/pull/124741/files
iritkatrielhttps://github.com/iritkatriel
Nov 11, 2024https://github.com/python/cpython/pull/124741/files#r1836206696
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/124741/files
1st1https://github.com/1st1
Nov 14, 2024https://github.com/python/cpython/pull/124741/files#r1842729880
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@ambvhttps://github.com/ambv
@pablogsalhttps://github.com/pablogsal
Please reload this pagehttps://github.com/python/cpython/pull/124741/files
https://github.com/python/cpython/pull/124741/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.