| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ed05ee83-726e-98a3-2cb3-965c465c57b2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D59A:8AE25:200A637:2A51137:6B023F56 |
| html-safe-nonce | 44833fa177b4c3f0666ed50435c4d61532076bc7216f7d75f360d800ac3b4efe |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTlBOjhBRTI1OjIwMEE2Mzc6MkE1MTEzNzo2QjAyM0Y1NiIsInZpc2l0b3JfaWQiOiIxNjI1Mjc5MTEwNTEzMzExNTc0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 35ce0eb1555648f3ac544115dfeef284edbf6ce57d25e73bf7de8948eafc14d0 |
| hovercard-subject-tag | pull_request:2097335778 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/124741/files |
| twitter:image | https://avatars.githubusercontent.com/u/1612291?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1612291?s=400&v=4 |
| og:image:alt | I believe that the value of a simpler API (and defense against poorly written callbacks) outweighs the cost of backing up and restoring the thread's exception state.
Also change the return type... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/124741/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124741%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124741%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/124741/files |
| Reload | https://github.com/python/cpython/pull/124741/files |
| Reload | https://github.com/python/cpython/pull/124741/files |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| rhansen | https://github.com/rhansen |
| python:main | https://github.com/python/cpython/tree/main |
| rhansen:gh-119333-exception | https://github.com/rhansen/cpython/tree/gh-119333-exception |
|
Conversation
35
| https://github.com/python/cpython/pull/124741 |
|
Commits
5
| https://github.com/python/cpython/pull/124741/commits |
|
Checks
0
| https://github.com/python/cpython/pull/124741/checks |
|
Files changed
| https://github.com/python/cpython/pull/124741/files |
| Please reload this page | https://github.com/python/cpython/pull/124741/files |
|
gh-124872: Back up exception before calling PyContext_WatchCallback
| https://github.com/python/cpython/pull/124741/files#top |
|
Show all changes
5 commits
| https://github.com/python/cpython/pull/124741/files |
|
c5789a9
gh-124872: Back up exception before calling PyContext_WatchCallback
rhansen Sep 28, 2024
| https://github.com/python/cpython/pull/124741/commits/c5789a95cf273dcc699fa6e58045022d41982f38 |
|
4c115ab
gh-124872: Clarify expected PyContext_WatchCallback return behavior
rhansen Oct 14, 2024
| https://github.com/python/cpython/pull/124741/commits/4c115ab49233f00af46858b5514a93cdd388968b |
|
300f2fc
gh-124872: Change PyContext_WatchCallback return type to void
rhansen Sep 28, 2024
| https://github.com/python/cpython/pull/124741/commits/300f2fcceacb0d7b31b6e8330053398b6d0cdc7e |
|
f177ad3
fixup! gh-124872: Change PyContext_WatchCallback return type to void
rhansen Nov 23, 2024
| https://github.com/python/cpython/pull/124741/commits/f177ad375ccfed19210222dbc0756eaea56c8511 |
|
f6562b1
fixup! gh-124872: Change PyContext_WatchCallback return type to void
rhansen Nov 23, 2024
| https://github.com/python/cpython/pull/124741/commits/f6562b15cf9f074e8876a5afc6492eb8f41ddf6d |
|
Clear filters
| https://github.com/python/cpython/pull/124741/files |
| Please reload this page | https://github.com/python/cpython/pull/124741/files |
| Please reload this page | https://github.com/python/cpython/pull/124741/files |
|
contextvars.rst
| https://github.com/python/cpython/pull/124741/files#diff-dcba959f99b35e4934a2cd76dfadf4e3387e455b7e717691e71ae94edd838538 |
|
context.h
| https://github.com/python/cpython/pull/124741/files#diff-2c91c78b4215de3e077f4057086cf3ed5de8e29ef0ba9553fdccae4846aedd6a |
|
test_watchers.py
| https://github.com/python/cpython/pull/124741/files#diff-f13cecf74c62d3b381dfd239e6e1c1c18e83e809b9c3dcb20237d1a8d27c439c |
|
2024-11-22-18-58-20.gh-issue-124872.o2Pl5p.rst
| https://github.com/python/cpython/pull/124741/files#diff-d9f1f98b6b84711a7cae8e31cf32c3fbf1dc78f95bcd61332cff7a0e41fe89c4 |
|
watchers.c
| https://github.com/python/cpython/pull/124741/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead |
|
context.c
| https://github.com/python/cpython/pull/124741/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149 |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L235 |
| Doc/c-api/contextvars.rst | https://github.com/python/cpython/pull/124741/files#diff-dcba959f99b35e4934a2cd76dfadf4e3387e455b7e717691e71ae94edd838538 |
|
View file
| https://github.com/python/cpython/blob/f6562b15cf9f074e8876a5afc6492eb8f41ddf6d/Doc/c-api/contextvars.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/124741/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/124741/files#diff-dcba959f99b35e4934a2cd76dfadf4e3387e455b7e717691e71ae94edd838538 |
| Please reload this page | https://github.com/python/cpython/pull/124741/files |
|
| https://github.com/python/cpython/pull/124741/files#diff-dcba959f99b35e4934a2cd76dfadf4e3387e455b7e717691e71ae94edd838538 |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L237 |
| Include/cpython/context.h | https://github.com/python/cpython/pull/124741/files#diff-2c91c78b4215de3e077f4057086cf3ed5de8e29ef0ba9553fdccae4846aedd6a |
|
View file
| https://github.com/python/cpython/blob/f6562b15cf9f074e8876a5afc6492eb8f41ddf6d/Include/cpython/context.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/124741/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/124741/files#diff-2c91c78b4215de3e077f4057086cf3ed5de8e29ef0ba9553fdccae4846aedd6a |
|
| https://github.com/python/cpython/pull/124741/files#diff-2c91c78b4215de3e077f4057086cf3ed5de8e29ef0ba9553fdccae4846aedd6a |
| Lib/test/test_capi/test_watchers.py | https://github.com/python/cpython/pull/124741/files#diff-f13cecf74c62d3b381dfd239e6e1c1c18e83e809b9c3dcb20237d1a8d27c439c |
|
View file
| https://github.com/python/cpython/blob/f6562b15cf9f074e8876a5afc6492eb8f41ddf6d/Lib/test/test_capi/test_watchers.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/124741/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/124741/files#diff-f13cecf74c62d3b381dfd239e6e1c1c18e83e809b9c3dcb20237d1a8d27c439c |
|
| https://github.com/python/cpython/pull/124741/files#diff-f13cecf74c62d3b381dfd239e6e1c1c18e83e809b9c3dcb20237d1a8d27c439c |
| Misc/NEWS.d/next/C_API/2024-11-22-18-58-20.gh-issue-124872.o2Pl5p.rst | https://github.com/python/cpython/pull/124741/files#diff-d9f1f98b6b84711a7cae8e31cf32c3fbf1dc78f95bcd61332cff7a0e41fe89c4 |
|
View file
| https://github.com/python/cpython/blob/f6562b15cf9f074e8876a5afc6492eb8f41ddf6d/Misc/NEWS.d/next/C_API/2024-11-22-18-58-20.gh-issue-124872.o2Pl5p.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/124741/{{ revealButtonHref }} |
| Modules/_testcapi/watchers.c | https://github.com/python/cpython/pull/124741/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead |
|
View file
| https://github.com/python/cpython/blob/f6562b15cf9f074e8876a5afc6492eb8f41ddf6d/Modules/_testcapi/watchers.c |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/124741/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/124741/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead |
|
| https://github.com/python/cpython/pull/124741/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead |
|
| https://github.com/python/cpython/pull/124741/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L240 |
| Python/context.c | https://github.com/python/cpython/pull/124741/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149 |
|
View file
| https://github.com/python/cpython/blob/f6562b15cf9f074e8876a5afc6492eb8f41ddf6d/Python/context.c |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/124741/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/124741/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149 |
| iritkatriel | https://github.com/iritkatriel |
| Oct 13, 2024 | https://github.com/python/cpython/pull/124741/files#r1798401832 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/124741/files |
| rhansen | https://github.com/rhansen |
| Oct 13, 2024 | https://github.com/python/cpython/pull/124741/files#r1798462789 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/124741/files |
| iritkatriel | https://github.com/iritkatriel |
| Oct 13, 2024 | https://github.com/python/cpython/pull/124741/files#r1798466030 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/124741/files |
| rhansen | https://github.com/rhansen |
| Oct 13, 2024 | https://github.com/python/cpython/pull/124741/files#r1798471577 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| gh-99633 | https://github.com/python/cpython/issues/99633 |
| Please reload this page | https://github.com/python/cpython/pull/124741/files |
| rhansen | https://github.com/rhansen |
| Oct 14, 2024 | https://github.com/python/cpython/pull/124741/files#r1798768283 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/124741/files |
| 1st1 | https://github.com/1st1 |
| Oct 14, 2024 | https://github.com/python/cpython/pull/124741/files#r1799999709 |
| Please reload this page | https://github.com/python/cpython/pull/124741/files |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/124741/files |
| 1st1 | https://github.com/1st1 |
| Oct 14, 2024 | https://github.com/python/cpython/pull/124741/files#r1800000221 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/124741/files |
| rhansen | https://github.com/rhansen |
| Nov 11, 2024 | https://github.com/python/cpython/pull/124741/files#r1836063468 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @iritkatriel | https://github.com/iritkatriel |
| @1st1 | https://github.com/1st1 |
| Please reload this page | https://github.com/python/cpython/pull/124741/files |
| iritkatriel | https://github.com/iritkatriel |
| Nov 11, 2024 | https://github.com/python/cpython/pull/124741/files#r1836206696 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/124741/files |
| 1st1 | https://github.com/1st1 |
| Nov 14, 2024 | https://github.com/python/cpython/pull/124741/files#r1842729880 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @ambv | https://github.com/ambv |
| @pablogsal | https://github.com/pablogsal |
| Please reload this page | https://github.com/python/cpython/pull/124741/files |
|
| https://github.com/python/cpython/pull/124741/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |