| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:865d506c-0bf1-12a9-bf5e-ac32627b9298 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DFA6:388B78:252F000:30908F2:696B5966 |
| html-safe-nonce | 1668476ce0192cf87162a00f769d7ede4bcd8a40b8dcb777ac3012f1ffa876d3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERkE2OjM4OEI3ODoyNTJGMDAwOjMwOTA4RjI6Njk2QjU5NjYiLCJ2aXNpdG9yX2lkIjoiNDM1MTgzODc2NzkxNjIxMDUzNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d162057c9c84cab1baf085bcef0c0225d9ead5f10b1a34e7f8d84e9860c85feb |
| hovercard-subject-tag | pull_request:2096664080 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/124716/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7f032468071306f350fba90ac7857c72cb7074525bc97ee568d06df37f37d5db/python/cpython/pull/124716 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7f032468071306f350fba90ac7857c72cb7074525bc97ee568d06df37f37d5db/python/cpython/pull/124716 |
| og:image:alt | This is an update of my GH-89060 PR, ported to current 'main' branch. The issue and fix are still the same as when the original Roundup bug was created: https://bugs.python.org/issue44897
... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | nascheme |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/124716#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124716 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124716 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/124716 |
| Reload | https://github.com/python/cpython/pull/124716 |
| Reload | https://github.com/python/cpython/pull/124716 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/124716 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/124716 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/124716#issue-comment-box |
| nascheme | https://github.com/nascheme |
| python:main | https://github.com/python/cpython/tree/main |
| nascheme:trashcan_all_gc | https://github.com/nascheme/cpython/tree/trashcan_all_gc |
|
GH-124715: trashcan protection for all GC objects
| https://github.com/python/cpython/pull/124716#top |
| nascheme | https://github.com/nascheme |
| python:main | https://github.com/python/cpython/tree/main |
| nascheme:trashcan_all_gc | https://github.com/nascheme/cpython/tree/trashcan_all_gc |
|
Conversation
6
| https://github.com/python/cpython/pull/124716 |
|
Commits
6
| https://github.com/python/cpython/pull/124716/commits |
|
Checks
0
| https://github.com/python/cpython/pull/124716/checks |
|
Files changed
| https://github.com/python/cpython/pull/124716/files |
| Please reload this page | https://github.com/python/cpython/pull/124716 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/nascheme |
| nascheme | https://github.com/nascheme |
| Sep 27, 2024 | https://github.com/python/cpython/pull/124716#issue-2553836699 |
| Please reload this page | https://github.com/python/cpython/pull/124716 |
| GH-89060 | https://github.com/python/cpython/issues/89060 |
| https://bugs.python.org/issue44897 | https://bugs.python.org/issue44897 |
| Not all types have "trashcan" protection and tp_dealloc can overflow stack #124715 | https://github.com/python/cpython/issues/124715 |
| Please reload this page | https://github.com/python/cpython/pull/124716 |
| nascheme | https://github.com/nascheme |
| September 27, 2024 12:44 | https://github.com/python/cpython/pull/124716#commits-pushed-2173832 |
|
| https://github.com/nascheme |
| wip: add trashcan protection to all GC objects | https://github.com/python/cpython/pull/124716/commits/2173832f0f8de29f612dd23ad8f39c4d772b9be1 |
| 2173832 | https://github.com/python/cpython/pull/124716/commits/2173832f0f8de29f612dd23ad8f39c4d772b9be1 |
|
| https://github.com/nascheme |
| wip: fix _PyObject_GC_UNTRACK calls | https://github.com/python/cpython/pull/124716/commits/73644a76b8313756d78eca64afc09df3d5c5267e |
| 73644a7 | https://github.com/python/cpython/pull/124716/commits/73644a76b8313756d78eca64afc09df3d5c5267e |
|
| https://github.com/nascheme |
| wip: add and use _PyObject_GC_TRACK_SAFE | https://github.com/python/cpython/pull/124716/commits/64a26ee47862d4d3899eccbdb2ea1a800cd5b46d |
| 64a26ee | https://github.com/python/cpython/pull/124716/commits/64a26ee47862d4d3899eccbdb2ea1a800cd5b46d |
|
| https://github.com/nascheme |
| wip: remove _PyObject_GC_TRACK_SAFE | https://github.com/python/cpython/pull/124716/commits/dd4db33d7035d0f60b1ee896e74581f6e02f3acf |
| dd4db33 | https://github.com/python/cpython/pull/124716/commits/dd4db33d7035d0f60b1ee896e74581f6e02f3acf |
| https://github.com/nascheme |
| nascheme | https://github.com/nascheme |
| 1st1 | https://github.com/1st1 |
| iritkatriel | https://github.com/iritkatriel |
| markshannon | https://github.com/markshannon |
| methane | https://github.com/methane |
| rhettinger | https://github.com/rhettinger |
| code owners | https://github.com/python/cpython/blob/1ba35ea38562bfc0301bab4e098aa124e114b886/.github/CODEOWNERS#L23 |
| September 27, 2024 22:32 | https://github.com/python/cpython/pull/124716#event-14437820063 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Sep 27, 2024 | https://github.com/python/cpython/pull/124716#event-14437820326 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
Sep 27, 2024
| https://github.com/python/cpython/pull/124716#ref-issue-2553825335 |
|
Not all types have "trashcan" protection and tp_dealloc can overflow stack
#124715
| https://github.com/python/cpython/issues/124715 |
| https://github.com/nascheme |
| nascheme | https://github.com/nascheme |
|
Sep 27, 2024
| https://github.com/python/cpython/pull/124716#ref-pullrequest-968173604 |
|
bpo-44897: WIP: Integrate trashcan into _Py_Dealloc
#27738
| https://github.com/python/cpython/pull/27738 |
|
| https://github.com/nascheme |
| Add blurb. | https://github.com/python/cpython/pull/124716/commits/31b2edee58da402f0a6b57ca22bfac7fb93aacb6 |
| 31b2ede | https://github.com/python/cpython/pull/124716/commits/31b2edee58da402f0a6b57ca22bfac7fb93aacb6 |
| https://github.com/nascheme |
| nascheme | https://github.com/nascheme |
|
Sep 27, 2024
| https://github.com/python/cpython/pull/124716#ref-issue-1199063342 |
|
Integrate trashcan mechanism into _Py_Dealloc
#89060
| https://github.com/python/cpython/issues/89060 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Sep 28, 2024
| https://github.com/python/cpython/pull/124716#pullrequestreview-2334974812 |
|
View reviewed changes
| https://github.com/python/cpython/pull/124716/files/31b2edee58da402f0a6b57ca22bfac7fb93aacb6 |
| Include/cpython/object.h | https://github.com/python/cpython/pull/124716/files/31b2edee58da402f0a6b57ca22bfac7fb93aacb6#diff-7c8590641fc0d835bdab9395a95dbacfb2abb056cec4217466c0f3ca6cca8270 |
| vstinner | https://github.com/vstinner |
| Sep 28, 2024 | https://github.com/python/cpython/pull/124716#discussion_r1779450700 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/124716 |
| nascheme | https://github.com/nascheme |
| Sep 28, 2024 | https://github.com/python/cpython/pull/124716#discussion_r1779694376 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/124716 |
| https://github.com/colesbury |
| colesbury | https://github.com/colesbury |
|
Sep 30, 2024
| https://github.com/python/cpython/pull/124716#pullrequestreview-2338294596 |
|
View reviewed changes
| https://github.com/python/cpython/pull/124716/files/31b2edee58da402f0a6b57ca22bfac7fb93aacb6 |
| Objects/object.c | https://github.com/python/cpython/pull/124716/files/31b2edee58da402f0a6b57ca22bfac7fb93aacb6#diff-ba56d44ce0dd731d979970b966fde9d8dd15d12a82f727a052a8ad48d4a49363 |
| colesbury | https://github.com/colesbury |
| Sep 30, 2024 | https://github.com/python/cpython/pull/124716#discussion_r1781567847 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| cpython/Python/ceval.c | https://github.com/python/cpython/blob/35541c410d894d4fa18002f7fdbebfe522f8320e/Python/ceval.c#L87-L88 |
| 35541c4 | https://github.com/python/cpython/commit/35541c410d894d4fa18002f7fdbebfe522f8320e |
| Please reload this page | https://github.com/python/cpython/pull/124716 |
| nascheme | https://github.com/nascheme |
| Sep 30, 2024 | https://github.com/python/cpython/pull/124716#discussion_r1781609650 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/124716 |
| nascheme | https://github.com/nascheme |
| Oct 1, 2024 | https://github.com/python/cpython/pull/124716#discussion_r1783431922 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/124716 |
| https://github.com/rhettinger |
| rhettinger | https://github.com/rhettinger |
| September 30, 2024 23:15 | https://github.com/python/cpython/pull/124716#event-14463488340 |
|
| https://github.com/nascheme |
| Call _Py_Dealloc from ceval.c. | https://github.com/python/cpython/pull/124716/commits/8443e847c9ca6ee30b5392a91c9114cfd0a4f5b5 |
| 8443e84 | https://github.com/python/cpython/pull/124716/commits/8443e847c9ca6ee30b5392a91c9114cfd0a4f5b5 |
| https://github.com/nascheme |
| nascheme | https://github.com/nascheme |
| Apr 8, 2025 | https://github.com/python/cpython/pull/124716#issuecomment-2787620620 |
| GH-132280 | https://github.com/python/cpython/pull/132280 |
| Please reload this page | https://github.com/python/cpython/pull/124716 |
| https://github.com/nascheme |
| nascheme | https://github.com/nascheme |
| Apr 8, 2025 | https://github.com/python/cpython/pull/124716#event-17177720664 |
| https://github.com/nascheme |
| nascheme | https://github.com/nascheme |
|
Jun 17, 2025
| https://github.com/python/cpython/pull/124716#ref-issue-3115438334 |
|
test_weakref.test_threaded_weak_key_dict_deepcopy crash: merged objects should have ob_tid == 0
#135106
| https://github.com/python/cpython/issues/135106 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124716 |
|
| https://github.com/vstinner |
|
vstinner
| https://github.com/vstinner |
|
| https://github.com/python/cpython/pull/124716/files/31b2edee58da402f0a6b57ca22bfac7fb93aacb6 |
|
| https://github.com/colesbury |
|
colesbury
| https://github.com/colesbury |
|
| https://github.com/python/cpython/pull/124716/files/31b2edee58da402f0a6b57ca22bfac7fb93aacb6 |
|
| https://github.com/iritkatriel |
|
iritkatriel
| https://github.com/iritkatriel |
|
| https://github.com/markshannon |
|
markshannon
| https://github.com/markshannon |
|
| https://github.com/methane |
|
methane
| https://github.com/methane |
|
| https://github.com/1st1 |
|
1st1
| https://github.com/1st1 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Please reload this page | https://github.com/python/cpython/pull/124716 |
|
| https://github.com/nascheme |
|
| https://github.com/vstinner |
|
| https://github.com/colesbury |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |