| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:43b7169e-3bcb-4a69-9dab-cb1180fe6024 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D35C:3DCD28:17B0583:1F6192C:6B020AEB |
| html-safe-nonce | d10400c4a6680bbcfd3dc641e65637451803fba663fc12e3dc0913c99d99154e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzVDOjNEQ0QyODoxN0IwNTgzOjFGNjE5MkM6NkIwMjBBRUIiLCJ2aXNpdG9yX2lkIjoiNjM2OTIyNjA1MjY2MDc1OTI3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ce380f241fa8e79bc5b9f97691837a7c28a35e0cc3d94ebf6b6f177d3e1aefc1 |
| hovercard-subject-tag | pull_request:2096333442 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/124692/files |
| twitter:image | https://avatars.githubusercontent.com/u/36469655?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/36469655?s=400&v=4 |
| og:image:alt | Original PR: #124455
Added two tests for two cases that weren't covered in original PR:
Using custom descriptors
Wrapping function before making it a property
Issue: gh-90562 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/124692/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124692%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124692%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/124692/files |
| Reload | https://github.com/python/cpython/pull/124692/files |
| Reload | https://github.com/python/cpython/pull/124692/files |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Bobronium | https://github.com/Bobronium |
| python:main | https://github.com/python/cpython/tree/main |
| Bobronium:issue-90562-dataclasses-zero-argument-super-fix | https://github.com/Bobronium/cpython/tree/issue-90562-dataclasses-zero-argument-super-fix |
|
Conversation
29
| https://github.com/python/cpython/pull/124692 |
|
Commits
17
| https://github.com/python/cpython/pull/124692/commits |
|
Checks
51
| https://github.com/python/cpython/pull/124692/checks |
|
Files changed
| https://github.com/python/cpython/pull/124692/files |
| Please reload this page | https://github.com/python/cpython/pull/124692/files |
|
gh-90562: Improve zero argument support for super() in dataclasses when slots=True
| https://github.com/python/cpython/pull/124692/files#top |
|
Show all changes
17 commits
| https://github.com/python/cpython/pull/124692/files |
|
475794b
Improve zero argument support for `super()` in dataclasses
Bobronium Sep 27, 2024
| https://github.com/python/cpython/pull/124692/commits/475794bf8e5f31281fca3f9ae9b6a2a1c97a7a46 |
|
75e769d
Fix NEWS.d formatting
Bobronium Sep 27, 2024
| https://github.com/python/cpython/pull/124692/commits/75e769d26d6af73f0c5773f3724c4ccc4a48a3f2 |
|
3c09e3a
Add explanation for _depth use and tests
Bobronium Sep 27, 2024
| https://github.com/python/cpython/pull/124692/commits/3c09e3a035ca219a775a99ad3c7084a6ecbd8832 |
|
d53d538
Fix incorrect variable reference
Bobronium Sep 27, 2024
| https://github.com/python/cpython/pull/124692/commits/d53d538bee96aa9bddc9800c3f572230246a4f21 |
|
a9c4319
Correctly unwrap descriptor function
Bobronium Sep 27, 2024
| https://github.com/python/cpython/pull/124692/commits/a9c43198fa163de9c14ca228e88e19ab64407995 |
|
26e13e7
Add test with using partial as custom wrapper
Bobronium Sep 27, 2024
| https://github.com/python/cpython/pull/124692/commits/26e13e7fc47ff1a4626c537c6e34f2aee68bf55b |
|
3a08b0e
Rephrase comment explaining _depth argument
Bobronium Sep 27, 2024
| https://github.com/python/cpython/pull/124692/commits/3a08b0e7964173883d08df8f20571da1c6c13562 |
|
2e9588d
Add clarification for function search priority
Bobronium Sep 27, 2024
| https://github.com/python/cpython/pull/124692/commits/2e9588d2584021f64b2e33062d01a3c0dde3a290 |
|
fb4bc9f
Ues consistent grammar throughout comments
Bobronium Sep 27, 2024
| https://github.com/python/cpython/pull/124692/commits/fb4bc9fc3e63070397d7f62e3656d1c014c1c693 |
|
bdaeb1f
Fix breaking out from outer loop when handling property
Bobronium Sep 27, 2024
| https://github.com/python/cpython/pull/124692/commits/bdaeb1f486b4f4688e6787ae0c4cc5a767729e1b |
|
8f6140a
Use generator expression with any() instead of classic loop
Bobronium Sep 27, 2024
| https://github.com/python/cpython/pull/124692/commits/8f6140afff0c580d079836e0d0ee8ddc31de9cef |
|
13c2dc7
Apply suggestions from code review
Bobronium Sep 28, 2024
| https://github.com/python/cpython/pull/124692/commits/13c2dc71dc2922e6e40759b585a546b81412b9b9 |
|
9d3d49f
Remove leading underscores from seen and depth args
Bobronium Sep 28, 2024
| https://github.com/python/cpython/pull/124692/commits/9d3d49ff0828ae94941c112020850ffc2865f760 |
|
d095864
Prevent user-defined code execution during attribute scanning
Bobronium Sep 28, 2024
| https://github.com/python/cpython/pull/124692/commits/d0958641b95af18b5132d532ebfba1ff2170af4a |
|
6848c1b
Use inspect.getattr_static instead of _safe_get_attributes
Bobronium Oct 5, 2024
| https://github.com/python/cpython/pull/124692/commits/6848c1b66730a3e0d061a2a0abf3646795718ac6 |
|
1d443e7
Put back the comment in _update_func_cell_for__class__
Bobronium Oct 5, 2024
| https://github.com/python/cpython/pull/124692/commits/1d443e754f80a81fa27934b5bfc20a42fe80975a |
|
5a7037b
Rely on inspect.getmembers_static()
Bobronium Oct 5, 2024
| https://github.com/python/cpython/pull/124692/commits/5a7037bc5d94e5c252571292922247751698bc39 |
|
Clear filters
| https://github.com/python/cpython/pull/124692/files |
| Please reload this page | https://github.com/python/cpython/pull/124692/files |
| Please reload this page | https://github.com/python/cpython/pull/124692/files |
|
dataclasses.py
| https://github.com/python/cpython/pull/124692/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5 |
|
__init__.py
| https://github.com/python/cpython/pull/124692/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676 |
|
2024-09-27-19-50-30.gh-issue-90562.HeL_JA.rst
| https://github.com/python/cpython/pull/124692/files#diff-c5ad1e14b69f7b91a89a67ceffa500effc04c58df3745ea9220b31adf1fface9 |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L422 |
| Lib/dataclasses.py | https://github.com/python/cpython/pull/124692/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5 |
|
View file
| https://github.com/python/cpython/blob/5a7037bc5d94e5c252571292922247751698bc39/Lib/dataclasses.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/124692/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/124692/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5 |
| Please reload this page | https://github.com/python/cpython/pull/124692/files |
|
| https://github.com/python/cpython/pull/124692/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5 |
|
| https://github.com/python/cpython/pull/124692/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5 |
|
| https://github.com/python/cpython/pull/124692/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5 |
|
| https://github.com/python/cpython/pull/124692/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5 |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L423 |
| Lib/test/test_dataclasses/__init__.py | https://github.com/python/cpython/pull/124692/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676 |
|
View file
| https://github.com/python/cpython/blob/5a7037bc5d94e5c252571292922247751698bc39/Lib/test/test_dataclasses/__init__.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/124692/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/124692/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676 |
|
| https://github.com/python/cpython/pull/124692/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676 |
|
| https://github.com/python/cpython/pull/124692/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676 |
|
| https://github.com/python/cpython/pull/124692/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676 |
| Misc/NEWS.d/next/Library/2024-09-27-19-50-30.gh-issue-90562.HeL_JA.rst | https://github.com/python/cpython/pull/124692/files#diff-c5ad1e14b69f7b91a89a67ceffa500effc04c58df3745ea9220b31adf1fface9 |
|
View file
| https://github.com/python/cpython/blob/5a7037bc5d94e5c252571292922247751698bc39/Misc/NEWS.d/next/Library/2024-09-27-19-50-30.gh-issue-90562.HeL_JA.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/124692/{{ revealButtonHref }} |
| Please reload this page | https://github.com/python/cpython/pull/124692/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |