René's URL Explorer Experiment


Title: gh-90562: Improve zero argument support for `super()` in dataclasses when `slots=True` by Bobronium · Pull Request #124692 · python/cpython · GitHub

Open Graph Title: gh-90562: Improve zero argument support for `super()` in dataclasses when `slots=True` by Bobronium · Pull Request #124692 · python/cpython

X Title: gh-90562: Improve zero argument support for `super()` in dataclasses when `slots=True` by Bobronium · Pull Request #124692 · python/cpython

Description: Original PR: #124455 Added two tests for two cases that weren't covered in original PR: Using custom descriptors Wrapping function before making it a property Issue: gh-90562

Open Graph Description: Original PR: #124455 Added two tests for two cases that weren't covered in original PR: Using custom descriptors Wrapping function before making it a property Issue: gh-90562

X Description: Original PR: #124455 Added two tests for two cases that weren't covered in original PR: Using custom descriptors Wrapping function before making it a property Issue: gh-90562

Opengraph URL: https://github.com/python/cpython/pull/124692

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:43b7169e-3bcb-4a69-9dab-cb1180fe6024
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD35C:3DCD28:17B0583:1F6192C:6B020AEB
html-safe-nonced10400c4a6680bbcfd3dc641e65637451803fba663fc12e3dc0913c99d99154e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzVDOjNEQ0QyODoxN0IwNTgzOjFGNjE5MkM6NkIwMjBBRUIiLCJ2aXNpdG9yX2lkIjoiNjM2OTIyNjA1MjY2MDc1OTI3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacce380f241fa8e79bc5b9f97691837a7c28a35e0cc3d94ebf6b6f177d3e1aefc1
hovercard-subject-tagpull_request:2096333442
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/124692/files
twitter:imagehttps://avatars.githubusercontent.com/u/36469655?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/36469655?s=400&v=4
og:image:altOriginal PR: #124455 Added two tests for two cases that weren't covered in original PR: Using custom descriptors Wrapping function before making it a property Issue: gh-90562
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/124692/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124692%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124692%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/124692/files
Reloadhttps://github.com/python/cpython/pull/124692/files
Reloadhttps://github.com/python/cpython/pull/124692/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Bobroniumhttps://github.com/Bobronium
python:mainhttps://github.com/python/cpython/tree/main
Bobronium:issue-90562-dataclasses-zero-argument-super-fixhttps://github.com/Bobronium/cpython/tree/issue-90562-dataclasses-zero-argument-super-fix
Conversation 29 https://github.com/python/cpython/pull/124692
Commits 17 https://github.com/python/cpython/pull/124692/commits
Checks 51 https://github.com/python/cpython/pull/124692/checks
Files changed https://github.com/python/cpython/pull/124692/files
Please reload this pagehttps://github.com/python/cpython/pull/124692/files
gh-90562: Improve zero argument support for super() in dataclasses when slots=True https://github.com/python/cpython/pull/124692/files#top
Show all changes 17 commits https://github.com/python/cpython/pull/124692/files
475794b Improve zero argument support for `super()` in dataclasses Bobronium Sep 27, 2024 https://github.com/python/cpython/pull/124692/commits/475794bf8e5f31281fca3f9ae9b6a2a1c97a7a46
75e769d Fix NEWS.d formatting Bobronium Sep 27, 2024 https://github.com/python/cpython/pull/124692/commits/75e769d26d6af73f0c5773f3724c4ccc4a48a3f2
3c09e3a Add explanation for _depth use and tests Bobronium Sep 27, 2024 https://github.com/python/cpython/pull/124692/commits/3c09e3a035ca219a775a99ad3c7084a6ecbd8832
d53d538 Fix incorrect variable reference Bobronium Sep 27, 2024 https://github.com/python/cpython/pull/124692/commits/d53d538bee96aa9bddc9800c3f572230246a4f21
a9c4319 Correctly unwrap descriptor function Bobronium Sep 27, 2024 https://github.com/python/cpython/pull/124692/commits/a9c43198fa163de9c14ca228e88e19ab64407995
26e13e7 Add test with using partial as custom wrapper Bobronium Sep 27, 2024 https://github.com/python/cpython/pull/124692/commits/26e13e7fc47ff1a4626c537c6e34f2aee68bf55b
3a08b0e Rephrase comment explaining _depth argument Bobronium Sep 27, 2024 https://github.com/python/cpython/pull/124692/commits/3a08b0e7964173883d08df8f20571da1c6c13562
2e9588d Add clarification for function search priority Bobronium Sep 27, 2024 https://github.com/python/cpython/pull/124692/commits/2e9588d2584021f64b2e33062d01a3c0dde3a290
fb4bc9f Ues consistent grammar throughout comments Bobronium Sep 27, 2024 https://github.com/python/cpython/pull/124692/commits/fb4bc9fc3e63070397d7f62e3656d1c014c1c693
bdaeb1f Fix breaking out from outer loop when handling property Bobronium Sep 27, 2024 https://github.com/python/cpython/pull/124692/commits/bdaeb1f486b4f4688e6787ae0c4cc5a767729e1b
8f6140a Use generator expression with any() instead of classic loop Bobronium Sep 27, 2024 https://github.com/python/cpython/pull/124692/commits/8f6140afff0c580d079836e0d0ee8ddc31de9cef
13c2dc7 Apply suggestions from code review Bobronium Sep 28, 2024 https://github.com/python/cpython/pull/124692/commits/13c2dc71dc2922e6e40759b585a546b81412b9b9
9d3d49f Remove leading underscores from seen and depth args Bobronium Sep 28, 2024 https://github.com/python/cpython/pull/124692/commits/9d3d49ff0828ae94941c112020850ffc2865f760
d095864 Prevent user-defined code execution during attribute scanning Bobronium Sep 28, 2024 https://github.com/python/cpython/pull/124692/commits/d0958641b95af18b5132d532ebfba1ff2170af4a
6848c1b Use inspect.getattr_static instead of _safe_get_attributes Bobronium Oct 5, 2024 https://github.com/python/cpython/pull/124692/commits/6848c1b66730a3e0d061a2a0abf3646795718ac6
1d443e7 Put back the comment in _update_func_cell_for__class__ Bobronium Oct 5, 2024 https://github.com/python/cpython/pull/124692/commits/1d443e754f80a81fa27934b5bfc20a42fe80975a
5a7037b Rely on inspect.getmembers_static() Bobronium Oct 5, 2024 https://github.com/python/cpython/pull/124692/commits/5a7037bc5d94e5c252571292922247751698bc39
Clear filters https://github.com/python/cpython/pull/124692/files
Please reload this pagehttps://github.com/python/cpython/pull/124692/files
Please reload this pagehttps://github.com/python/cpython/pull/124692/files
dataclasses.py https://github.com/python/cpython/pull/124692/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
__init__.py https://github.com/python/cpython/pull/124692/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676
2024-09-27-19-50-30.gh-issue-90562.HeL_JA.rst https://github.com/python/cpython/pull/124692/files#diff-c5ad1e14b69f7b91a89a67ceffa500effc04c58df3745ea9220b31adf1fface9
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L422
Lib/dataclasses.pyhttps://github.com/python/cpython/pull/124692/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
View file https://github.com/python/cpython/blob/5a7037bc5d94e5c252571292922247751698bc39/Lib/dataclasses.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/124692/{{ revealButtonHref }}
https://github.com/python/cpython/pull/124692/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
Please reload this pagehttps://github.com/python/cpython/pull/124692/files
https://github.com/python/cpython/pull/124692/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/124692/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/124692/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/124692/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L423
Lib/test/test_dataclasses/__init__.pyhttps://github.com/python/cpython/pull/124692/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676
View file https://github.com/python/cpython/blob/5a7037bc5d94e5c252571292922247751698bc39/Lib/test/test_dataclasses/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/124692/{{ revealButtonHref }}
https://github.com/python/cpython/pull/124692/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676
https://github.com/python/cpython/pull/124692/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676
https://github.com/python/cpython/pull/124692/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676
https://github.com/python/cpython/pull/124692/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676
Misc/NEWS.d/next/Library/2024-09-27-19-50-30.gh-issue-90562.HeL_JA.rsthttps://github.com/python/cpython/pull/124692/files#diff-c5ad1e14b69f7b91a89a67ceffa500effc04c58df3745ea9220b31adf1fface9
View file https://github.com/python/cpython/blob/5a7037bc5d94e5c252571292922247751698bc39/Misc/NEWS.d/next/Library/2024-09-27-19-50-30.gh-issue-90562.HeL_JA.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/124692/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/124692/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.