René's URL Explorer Experiment


Title: gh-90562: Improve zero argument support for `super()` in dataclasses when `slots=True` by Bobronium · Pull Request #124692 · python/cpython · GitHub

Open Graph Title: gh-90562: Improve zero argument support for `super()` in dataclasses when `slots=True` by Bobronium · Pull Request #124692 · python/cpython

X Title: gh-90562: Improve zero argument support for `super()` in dataclasses when `slots=True` by Bobronium · Pull Request #124692 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Original PR: gh-90562: Support zero argument super with dataclasses when slots=True #124455 Added two tests for two cases that weren't covered in original PR: Using custom descriptors Wrappin...

X Description: Original PR: gh-90562: Support zero argument super with dataclasses when slots=True #124455 Added two tests for two cases that weren't covered in original PR: Using custom descriptors Wra...

Opengraph URL: https://github.com/python/cpython/pull/124692

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d2bd0b3e-5412-490e-ec51-0132950202fb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA720:1FE434:17B7A3F:1F49EFB:6B02083B
html-safe-nonce9c502295305240d1259ac6dbe1109e252cdad425b8d9217dfda4679c9587841b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzIwOjFGRTQzNDoxN0I3QTNGOjFGNDlFRkI6NkIwMjA4M0IiLCJ2aXNpdG9yX2lkIjoiMzU4MjcwNzE1NzEzMDQxNDEzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd34a0da37dbcf33187a6d85be204ffec6e455dcb9913b013b61dcb4b01af3174
hovercard-subject-tagpull_request:2096333442
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/124692/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fb83ef6e5bf37dd3bb29d184fc0bb273abefe454b7c929e5c7e7fc05fc1953a5/python/cpython/pull/124692
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fb83ef6e5bf37dd3bb29d184fc0bb273abefe454b7c929e5c7e7fc05fc1953a5/python/cpython/pull/124692
og:image:altOriginal PR: gh-90562: Support zero argument super with dataclasses when slots=True #124455 Added two tests for two cases that weren't covered in original PR: Using custom descriptors Wrappin...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBobronium
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/124692#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124692
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124692
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/124692
Reloadhttps://github.com/python/cpython/pull/124692
Reloadhttps://github.com/python/cpython/pull/124692
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
Bobroniumhttps://github.com/Bobronium
python:mainhttps://github.com/python/cpython/tree/main
Bobronium:issue-90562-dataclasses-zero-argument-super-fixhttps://github.com/Bobronium/cpython/tree/issue-90562-dataclasses-zero-argument-super-fix
Conversationhttps://github.com/python/cpython/pull/124692
Commits17 (17)https://github.com/python/cpython/pull/124692/commits
Checkshttps://github.com/python/cpython/pull/124692/checks
Files changedhttps://github.com/python/cpython/pull/124692/files
gh-90562: Improve zero argument support for super() in dataclasses when slots=Truehttps://github.com/python/cpython/pull/124692#top
Bobroniumhttps://github.com/Bobronium
python:mainhttps://github.com/python/cpython/tree/main
Bobronium:issue-90562-dataclasses-zero-argument-super-fixhttps://github.com/Bobronium/cpython/tree/issue-90562-dataclasses-zero-argument-super-fix
https://github.com/Bobronium
Bobroniumhttps://github.com/Bobronium
Sep 27, 2024https://github.com/python/cpython/pull/124692#issue-2553467135
Please reload this pagehttps://github.com/python/cpython/pull/124692
gh-90562: Support zero argument super with dataclasses when slots=True #124455https://github.com/python/cpython/pull/124455
RFE: @dataclasses.dataclass(slots=True) doesn't support methods using zero-arg super() #90562https://github.com/python/cpython/issues/90562
Please reload this pagehttps://github.com/python/cpython/pull/124692
https://github.com/Bobronium
Bobroniumhttps://github.com/Bobronium
ericvsmithhttps://github.com/ericvsmith
code ownerhttps://github.com/python/cpython/blob/10d504aecc56f9481114fe3d0a8d1721d38db7e3/.github/CODEOWNERS#L212
September 27, 2024 18:05https://github.com/python/cpython/pull/124692#event-14434609596
https://github.com/ghost
ghosthttps://github.com/ghost
Sep 27, 2024https://github.com/python/cpython/pull/124692#issuecomment-2379803192
Please reload this pagehttps://github.com/python/cpython/pull/124692
https://cpython-clabot.herokuapp.com/signed-contributor-license-agreement?version=96a49432-b8b1-11ec-9bf5-bfe9ad6c72c4
Please reload this pagehttps://github.com/python/cpython/pull/124692
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 27, 2024https://github.com/python/cpython/pull/124692#event-14434610214
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 27, 2024 https://github.com/python/cpython/pull/124692#ref-issue-1199073227
RFE: @dataclasses.dataclass(slots=True) doesn't support methods using zero-arg super() #90562 https://github.com/python/cpython/issues/90562
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
carljmhttps://github.com/carljm
September 27, 2024 18:10https://github.com/python/cpython/pull/124692#event-14434664077
https://github.com/Bobronium
Bobroniumhttps://github.com/Bobronium
force-pushedhttps://github.com/python/cpython/compare/2e0ca0118ee804defe6ca63c1276f9bafba465ea..3b65acf8d66e7e42ad25746976b55dc0bd7d71d8
2e0ca01https://github.com/python/cpython/commit/2e0ca0118ee804defe6ca63c1276f9bafba465ea
3b65acfhttps://github.com/python/cpython/commit/3b65acf8d66e7e42ad25746976b55dc0bd7d71d8
Compare https://github.com/python/cpython/compare/2e0ca0118ee804defe6ca63c1276f9bafba465ea..3b65acf8d66e7e42ad25746976b55dc0bd7d71d8
September 27, 2024 18:10https://github.com/python/cpython/pull/124692#event-14434665437
https://github.com/ericvsmith
ericvsmithhttps://github.com/ericvsmith
Sep 27, 2024 https://github.com/python/cpython/pull/124692#pullrequestreview-2334662043
View reviewed changes https://github.com/python/cpython/pull/124692/files
Lib/dataclasses.pyhttps://github.com/python/cpython/pull/124692/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
Please reload this pagehttps://github.com/python/cpython/pull/124692
Lib/dataclasses.pyhttps://github.com/python/cpython/pull/124692/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
ericvsmithhttps://github.com/ericvsmith
Sep 27, 2024https://github.com/python/cpython/pull/124692#discussion_r1779175950
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/124692
Bobroniumhttps://github.com/Bobronium
Sep 27, 2024https://github.com/python/cpython/pull/124692#discussion_r1779290316
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/124692
Lib/dataclasses.pyhttps://github.com/python/cpython/pull/124692/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
ericvsmithhttps://github.com/ericvsmith
Sep 27, 2024https://github.com/python/cpython/pull/124692#discussion_r1779182056
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/124692
Bobroniumhttps://github.com/Bobronium
Sep 27, 2024https://github.com/python/cpython/pull/124692#discussion_r1779245143
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
cpython/Lib/dataclasses.pyhttps://github.com/python/cpython/blob/3b65acf8d66e7e42ad25746976b55dc0bd7d71d8/Lib/dataclasses.py#L1336-L1339
3b65acfhttps://github.com/python/cpython/commit/3b65acf8d66e7e42ad25746976b55dc0bd7d71d8
Please reload this pagehttps://github.com/python/cpython/pull/124692
ericvsmithhttps://github.com/ericvsmith
Sep 27, 2024https://github.com/python/cpython/pull/124692#discussion_r1779267474
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/124692
Bobroniumhttps://github.com/Bobronium
Sep 27, 2024https://github.com/python/cpython/pull/124692#discussion_r1779302699
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/124692
https://github.com/ericvsmith
ericvsmithhttps://github.com/ericvsmith
Sep 27, 2024 https://github.com/python/cpython/pull/124692#pullrequestreview-2334776689
View reviewed changes https://github.com/python/cpython/pull/124692/files
Lib/dataclasses.pyhttps://github.com/python/cpython/pull/124692/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
Please reload this pagehttps://github.com/python/cpython/pull/124692
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Sep 28, 2024 https://github.com/python/cpython/pull/124692#pullrequestreview-2334882702
View reviewed changes https://github.com/python/cpython/pull/124692/files
sobolevnhttps://github.com/sobolevn
https://github.com/python/cpython/pull/124692#pullrequestreview-2334882702
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/124692
Lib/dataclasses.pyhttps://github.com/python/cpython/pull/124692/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
Please reload this pagehttps://github.com/python/cpython/pull/124692
Lib/dataclasses.pyhttps://github.com/python/cpython/pull/124692/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
Please reload this pagehttps://github.com/python/cpython/pull/124692
Lib/dataclasses.pyhttps://github.com/python/cpython/pull/124692/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
sobolevnhttps://github.com/sobolevn
Sep 28, 2024https://github.com/python/cpython/pull/124692#discussion_r1779371384
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/124692
Bobroniumhttps://github.com/Bobronium
Sep 28, 2024https://github.com/python/cpython/pull/124692#discussion_r1779754258
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/124692
Lib/test/test_dataclasses/__init__.pyhttps://github.com/python/cpython/pull/124692/files#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676
Please reload this pagehttps://github.com/python/cpython/pull/124692
https://github.com/carljm
carljmhttps://github.com/carljm
Oct 1, 2024 https://github.com/python/cpython/pull/124692#pullrequestreview-2341563315
View reviewed changes https://github.com/python/cpython/pull/124692/files
carljmhttps://github.com/carljm
https://github.com/python/cpython/pull/124692#pullrequestreview-2341563315
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@ericvsmithhttps://github.com/ericvsmith
Please reload this pagehttps://github.com/python/cpython/pull/124692
Lib/dataclasses.pyhttps://github.com/python/cpython/pull/124692/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
Please reload this pagehttps://github.com/python/cpython/pull/124692
https://github.com/ericvsmith
ericvsmithhttps://github.com/ericvsmith
Oct 2, 2024https://github.com/python/cpython/pull/124692#issuecomment-2388743612
Please reload this pagehttps://github.com/python/cpython/pull/124692
https://github.com/Bobronium
Bobroniumhttps://github.com/Bobronium
Oct 5, 2024https://github.com/python/cpython/pull/124692#issuecomment-2395055579
Please reload this pagehttps://github.com/python/cpython/pull/124692
https://github.com/Bobronium
Bobroniumhttps://github.com/Bobronium
Nov 3, 2024https://github.com/python/cpython/pull/124692#issuecomment-2453431619
@carljmhttps://github.com/carljm
Please reload this pagehttps://github.com/python/cpython/pull/124692
https://github.com/carljm
carljmhttps://github.com/carljm
Nov 4, 2024https://github.com/python/cpython/pull/124692#issuecomment-2455869546
@ericvsmithhttps://github.com/ericvsmith
Please reload this pagehttps://github.com/python/cpython/pull/124692
https://github.com/ericvsmith
ericvsmithhttps://github.com/ericvsmith
Nov 4, 2024https://github.com/python/cpython/pull/124692#issuecomment-2455906354
Please reload this pagehttps://github.com/python/cpython/pull/124692
https://github.com/ZetaTwo
ZetaTwohttps://github.com/ZetaTwo
Dec 17, 2024 https://github.com/python/cpython/pull/124692#ref-pullrequest-2743688525
Use dataclass slots to decrease memory usage SiegeEngineers/genieutils-py#4 https://github.com/SiegeEngineers/genieutils-py/pull/4
https://github.com/nthykier
nthykierhttps://github.com/nthykier
Sep 21, 2025 https://github.com/python/cpython/pull/124692#ref-issue-3437917230
Breaks super call with @dataclasses.dataclass(slots=True) asottile/pyupgrade#1032 https://github.com/asottile/pyupgrade/issues/1032
https://github.com/danielhollas
danielhollashttps://github.com/danielhollas
Feb 2, 2026 https://github.com/python/cpython/pull/124692#ref-pullrequest-3884068058
gh-137855: Lazy import inspect module in dataclasses #144387 https://github.com/python/cpython/pull/144387
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Apr 18, 2026https://github.com/python/cpython/pull/124692#issuecomment-4273612462
Please reload this pagehttps://github.com/python/cpython/pull/124692
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
Apr 18, 2026https://github.com/python/cpython/pull/124692#event-24636624896
Bobroniumhttps://github.com/Bobronium
October 20, 2026 23:14https://github.com/python/cpython/pull/124692#commits-pushed-475794b
https://github.com/Bobronium
https://github.com/ambv
Improve zero argument support for super() in dataclasseshttps://github.com/python/cpython/pull/124692/commits/475794bf8e5f31281fca3f9ae9b6a2a1c97a7a46
475794bhttps://github.com/python/cpython/pull/124692/commits/475794bf8e5f31281fca3f9ae9b6a2a1c97a7a46
https://github.com/Bobronium
https://github.com/ambv
Fix NEWS.d formattinghttps://github.com/python/cpython/pull/124692/commits/75e769d26d6af73f0c5773f3724c4ccc4a48a3f2
75e769dhttps://github.com/python/cpython/pull/124692/commits/75e769d26d6af73f0c5773f3724c4ccc4a48a3f2
https://github.com/Bobronium
https://github.com/ambv
Add explanation for _depth use and testshttps://github.com/python/cpython/pull/124692/commits/3c09e3a035ca219a775a99ad3c7084a6ecbd8832
3c09e3ahttps://github.com/python/cpython/pull/124692/commits/3c09e3a035ca219a775a99ad3c7084a6ecbd8832
https://github.com/Bobronium
https://github.com/ambv
Fix incorrect variable referencehttps://github.com/python/cpython/pull/124692/commits/d53d538bee96aa9bddc9800c3f572230246a4f21
d53d538https://github.com/python/cpython/pull/124692/commits/d53d538bee96aa9bddc9800c3f572230246a4f21
https://github.com/Bobronium
https://github.com/ambv
Correctly unwrap descriptor functionhttps://github.com/python/cpython/pull/124692/commits/a9c43198fa163de9c14ca228e88e19ab64407995
a9c4319https://github.com/python/cpython/pull/124692/commits/a9c43198fa163de9c14ca228e88e19ab64407995
https://github.com/Bobronium
https://github.com/ambv
Add test with using partial as custom wrapperhttps://github.com/python/cpython/pull/124692/commits/26e13e7fc47ff1a4626c537c6e34f2aee68bf55b
26e13e7https://github.com/python/cpython/pull/124692/commits/26e13e7fc47ff1a4626c537c6e34f2aee68bf55b
https://github.com/Bobronium
https://github.com/ambv
Rephrase comment explaining _depth argumenthttps://github.com/python/cpython/pull/124692/commits/3a08b0e7964173883d08df8f20571da1c6c13562
3a08b0ehttps://github.com/python/cpython/pull/124692/commits/3a08b0e7964173883d08df8f20571da1c6c13562
https://github.com/Bobronium
https://github.com/ambv
Add clarification for function search priorityhttps://github.com/python/cpython/pull/124692/commits/2e9588d2584021f64b2e33062d01a3c0dde3a290
2e9588dhttps://github.com/python/cpython/pull/124692/commits/2e9588d2584021f64b2e33062d01a3c0dde3a290
https://github.com/Bobronium
https://github.com/ambv
Ues consistent grammar throughout commentshttps://github.com/python/cpython/pull/124692/commits/fb4bc9fc3e63070397d7f62e3656d1c014c1c693
fb4bc9fhttps://github.com/python/cpython/pull/124692/commits/fb4bc9fc3e63070397d7f62e3656d1c014c1c693
https://github.com/Bobronium
https://github.com/ambv
Fix breaking out from outer loop when handling propertyhttps://github.com/python/cpython/pull/124692/commits/bdaeb1f486b4f4688e6787ae0c4cc5a767729e1b
bdaeb1fhttps://github.com/python/cpython/pull/124692/commits/bdaeb1f486b4f4688e6787ae0c4cc5a767729e1b
Bobroniumhttps://github.com/Bobronium
October 20, 2026 23:14https://github.com/python/cpython/pull/124692#commits-pushed-8f6140a
https://github.com/Bobronium
https://github.com/ambv
Use generator expression with any() instead of classic loophttps://github.com/python/cpython/pull/124692/commits/8f6140afff0c580d079836e0d0ee8ddc31de9cef
8f6140ahttps://github.com/python/cpython/pull/124692/commits/8f6140afff0c580d079836e0d0ee8ddc31de9cef
https://github.com/Bobronium
https://github.com/sobolevn
https://github.com/ambv
Apply suggestions from code reviewhttps://github.com/python/cpython/pull/124692/commits/13c2dc71dc2922e6e40759b585a546b81412b9b9
13c2dc7https://github.com/python/cpython/pull/124692/commits/13c2dc71dc2922e6e40759b585a546b81412b9b9
https://github.com/Bobronium
https://github.com/ambv
Remove leading underscores from seen and depth argshttps://github.com/python/cpython/pull/124692/commits/9d3d49ff0828ae94941c112020850ffc2865f760
9d3d49fhttps://github.com/python/cpython/pull/124692/commits/9d3d49ff0828ae94941c112020850ffc2865f760
https://github.com/Bobronium
https://github.com/ambv
Prevent user-defined code execution during attribute scanninghttps://github.com/python/cpython/pull/124692/commits/d0958641b95af18b5132d532ebfba1ff2170af4a
d095864https://github.com/python/cpython/pull/124692/commits/d0958641b95af18b5132d532ebfba1ff2170af4a
https://github.com/Bobronium
https://github.com/ambv
Use inspect.getattr_static instead of _safe_get_attributeshttps://github.com/python/cpython/pull/124692/commits/6848c1b66730a3e0d061a2a0abf3646795718ac6
6848c1bhttps://github.com/python/cpython/pull/124692/commits/6848c1b66730a3e0d061a2a0abf3646795718ac6
https://github.com/Bobronium
https://github.com/ambv
Put back the comment in _update_func_cell_for__class__https://github.com/python/cpython/pull/124692/commits/1d443e754f80a81fa27934b5bfc20a42fe80975a
1d443e7https://github.com/python/cpython/pull/124692/commits/1d443e754f80a81fa27934b5bfc20a42fe80975a
https://github.com/Bobronium
https://github.com/ambv
Rely on inspect.getmembers_static()https://github.com/python/cpython/pull/124692/commits/5a7037bc5d94e5c252571292922247751698bc39
5a7037bhttps://github.com/python/cpython/pull/124692/commits/5a7037bc5d94e5c252571292922247751698bc39
https://github.com/ambv
ambvhttps://github.com/ambv
force-pushedhttps://github.com/python/cpython/compare/5bfea4d299566099b780f0bd17e616b157d41046..5a7037bc5d94e5c252571292922247751698bc39
5bfea4dhttps://github.com/python/cpython/commit/5bfea4d299566099b780f0bd17e616b157d41046
5a7037bhttps://github.com/python/cpython/commit/5a7037bc5d94e5c252571292922247751698bc39
Compare https://github.com/python/cpython/compare/5bfea4d299566099b780f0bd17e616b157d41046..5a7037bc5d94e5c252571292922247751698bc39
October 20, 2026 21:17https://github.com/python/cpython/pull/124692#event-33786431119
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
type-feature https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-feature
Oct 20, 2026https://github.com/python/cpython/pull/124692#event-33786436242
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
Oct 25, 2026https://github.com/python/cpython/pull/124692#event-34156738933
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124692
https://github.com/carljm
carljm https://github.com/carljm
https://github.com/python/cpython/pull/124692/files/d0173d8e39bf6d2b91995aba774bf744bb7ce193
https://github.com/ericvsmith
ericvsmith https://github.com/ericvsmith
https://github.com/python/cpython/pull/124692/files/22eeb8f762e1819762843e5f5b725ae89b2af26f
https://github.com/sobolevn
sobolevn https://github.com/sobolevn
https://github.com/python/cpython/pull/124692/files/6ef5317c5420b3236e403e187de3d07bcae59559
Please reload this pagehttps://github.com/python/cpython/pull/124692
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
type-feature https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-feature
Please reload this pagehttps://github.com/python/cpython/pull/124692
https://github.com/Bobronium
https://github.com/ericvsmith
https://github.com/carljm
https://github.com/sobolevn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.