René's URL Explorer Experiment


Title: gh-119180: Avoid going through AST and eval() when possible in annotationlib by JelleZijlstra · Pull Request #124337 · python/cpython · GitHub

Open Graph Title: gh-119180: Avoid going through AST and eval() when possible in annotationlib by JelleZijlstra · Pull Request #124337 · python/cpython

X Title: gh-119180: Avoid going through AST and eval() when possible in annotationlib by JelleZijlstra · Pull Request #124337 · python/cpython

Description: Often, ForwardRefs represent a single simple name. In that case, we can avoid going through the overhead of creating AST nodes and code objects and calling eval(): we can simply look up the name directly in the relevant namespaces. This PR incorporates the changes from #124326 (which fixes a bug that I discovered while working on this change). Issue: gh-119180

Open Graph Description: Often, ForwardRefs represent a single simple name. In that case, we can avoid going through the overhead of creating AST nodes and code objects and calling eval(): we can simply look up the name di...

X Description: Often, ForwardRefs represent a single simple name. In that case, we can avoid going through the overhead of creating AST nodes and code objects and calling eval(): we can simply look up the name di...

Opengraph URL: https://github.com/python/cpython/pull/124337

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d44562e4-c844-b199-3e0b-31fda0867d82
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id847A:DEDFE:1BE25BF:250C6B3:696AF941
html-safe-nonce0b6b672798e7de97af3689c28861ad9ae72c60ec9d2f251f251129be1b6724e7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDdBOkRFREZFOjFCRTI1QkY6MjUwQzZCMzo2OTZBRjk0MSIsInZpc2l0b3JfaWQiOiI0MzYwMDA3NjYyNTY5MTkxNzQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac874b51b9340ad9a85e7fb8d4d36467e7e4503ed9f401476e6308edb1c59ae799
hovercard-subject-tagpull_request:2086756719
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/124337/files
twitter:imagehttps://avatars.githubusercontent.com/u/906600?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/906600?s=400&v=4
og:image:altOften, ForwardRefs represent a single simple name. In that case, we can avoid going through the overhead of creating AST nodes and code objects and calling eval(): we can simply look up the name di...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/124337/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124337%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124337%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/124337/files
Reloadhttps://github.com/python/cpython/pull/124337/files
Reloadhttps://github.com/python/cpython/pull/124337/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/124337/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/124337/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
JelleZijlstra:pep649-optannohttps://github.com/JelleZijlstra/cpython/tree/pep649-optanno
Conversation 8 https://github.com/python/cpython/pull/124337
Commits 11 https://github.com/python/cpython/pull/124337/commits
Checks 0 https://github.com/python/cpython/pull/124337/checks
Files changed https://github.com/python/cpython/pull/124337/files
Please reload this pagehttps://github.com/python/cpython/pull/124337/files
gh-119180: Avoid going through AST and eval() when possible in annotationlib https://github.com/python/cpython/pull/124337/files#top
Show all changes 11 commits https://github.com/python/cpython/pull/124337/files
293fb0a gh-119180: Fix bug where fwdrefs were evaluated in the annotationlib … JelleZijlstra Sep 22, 2024 https://github.com/python/cpython/pull/124337/commits/293fb0aad9504ddccc68423a5648f5d456ee1068
3cfa504 gh-119180: Optimize annotationlib to avoid creation of AST nodes and … JelleZijlstra Sep 22, 2024 https://github.com/python/cpython/pull/124337/commits/3cfa5048b7de0fae7d412845a11efdc497e90ceb
eaea393 add a test case JelleZijlstra Sep 23, 2024 https://github.com/python/cpython/pull/124337/commits/eaea393ec63c19a9a4a13dff86dbdbe0c3b2b17a
e274f99 more tests JelleZijlstra Sep 23, 2024 https://github.com/python/cpython/pull/124337/commits/e274f998644153e817d5f7a267934e9004039c1a
0dc0a68 fmt JelleZijlstra Sep 23, 2024 https://github.com/python/cpython/pull/124337/commits/0dc0a68239fd45621cc665c75e1dbd4f5c166e03
2f5d504 Merge branch 'main' into pep649-optanno JelleZijlstra Sep 24, 2024 https://github.com/python/cpython/pull/124337/commits/2f5d5048ae7deebdf9d62cbee2e9a2ca9b833b6f
892efe9 Merge remote-tracking branch 'upstream/main' into pep649-optanno JelleZijlstra Sep 24, 2024 https://github.com/python/cpython/pull/124337/commits/892efe9ebc677f02f2f06f69100c12a6e4cec85a
fefa126 one more test JelleZijlstra Sep 24, 2024 https://github.com/python/cpython/pull/124337/commits/fefa1263cb4c943bc432d75a98ad2313bfa5c39a
ab30124 Apply suggestions from code review JelleZijlstra Sep 24, 2024 https://github.com/python/cpython/pull/124337/commits/ab30124a3d1f233b5c4bcc5d6ad393f27b592c56
4b1214e Merge remote-tracking branch 'upstream/main' into pep649-optanno JelleZijlstra Sep 25, 2024 https://github.com/python/cpython/pull/124337/commits/4b1214e5e1778b63e5d7fa9a0e6efdf3223ff2a3
cebb78e PR feedback JelleZijlstra Sep 25, 2024 https://github.com/python/cpython/pull/124337/commits/cebb78e4ecb5ce7b703ed8995e319549ba5ba2ab
Clear filters https://github.com/python/cpython/pull/124337/files
Please reload this pagehttps://github.com/python/cpython/pull/124337/files
Please reload this pagehttps://github.com/python/cpython/pull/124337/files
annotationlib.py https://github.com/python/cpython/pull/124337/files#diff-55449988e121f54fcc768a9fef3619f9209ae218260193de8f44bef68e13c583
test_annotationlib.py https://github.com/python/cpython/pull/124337/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L358
Lib/annotationlib.pyhttps://github.com/python/cpython/pull/124337/files#diff-55449988e121f54fcc768a9fef3619f9209ae218260193de8f44bef68e13c583
View file https://github.com/JelleZijlstra/cpython/blob/cebb78e4ecb5ce7b703ed8995e319549ba5ba2ab/Lib/annotationlib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/124337/{{ revealButtonHref }}
https://github.com/python/cpython/pull/124337/files#diff-55449988e121f54fcc768a9fef3619f9209ae218260193de8f44bef68e13c583
https://github.com/python/cpython/pull/124337/files#diff-55449988e121f54fcc768a9fef3619f9209ae218260193de8f44bef68e13c583
https://github.com/python/cpython/pull/124337/files#diff-55449988e121f54fcc768a9fef3619f9209ae218260193de8f44bef68e13c583
https://github.com/python/cpython/pull/124337/files#diff-55449988e121f54fcc768a9fef3619f9209ae218260193de8f44bef68e13c583
https://github.com/python/cpython/pull/124337/files#diff-55449988e121f54fcc768a9fef3619f9209ae218260193de8f44bef68e13c583
https://github.com/python/cpython/pull/124337/files#diff-55449988e121f54fcc768a9fef3619f9209ae218260193de8f44bef68e13c583
https://github.com/python/cpython/pull/124337/files#diff-55449988e121f54fcc768a9fef3619f9209ae218260193de8f44bef68e13c583
https://github.com/python/cpython/pull/124337/files#diff-55449988e121f54fcc768a9fef3619f9209ae218260193de8f44bef68e13c583
https://github.com/python/cpython/pull/124337/files#diff-55449988e121f54fcc768a9fef3619f9209ae218260193de8f44bef68e13c583
https://github.com/python/cpython/pull/124337/files#diff-55449988e121f54fcc768a9fef3619f9209ae218260193de8f44bef68e13c583
https://github.com/python/cpython/pull/124337/files#diff-55449988e121f54fcc768a9fef3619f9209ae218260193de8f44bef68e13c583
https://github.com/python/cpython/pull/124337/files#diff-55449988e121f54fcc768a9fef3619f9209ae218260193de8f44bef68e13c583
https://github.com/python/cpython/pull/124337/files#diff-55449988e121f54fcc768a9fef3619f9209ae218260193de8f44bef68e13c583
https://github.com/python/cpython/pull/124337/files#diff-55449988e121f54fcc768a9fef3619f9209ae218260193de8f44bef68e13c583
https://github.com/python/cpython/pull/124337/files#diff-55449988e121f54fcc768a9fef3619f9209ae218260193de8f44bef68e13c583
https://github.com/python/cpython/pull/124337/files#diff-55449988e121f54fcc768a9fef3619f9209ae218260193de8f44bef68e13c583
https://github.com/python/cpython/pull/124337/files#diff-55449988e121f54fcc768a9fef3619f9209ae218260193de8f44bef68e13c583
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L359
Lib/test/test_annotationlib.pyhttps://github.com/python/cpython/pull/124337/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
View file https://github.com/JelleZijlstra/cpython/blob/cebb78e4ecb5ce7b703ed8995e319549ba5ba2ab/Lib/test/test_annotationlib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/124337/{{ revealButtonHref }}
https://github.com/python/cpython/pull/124337/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
https://github.com/python/cpython/pull/124337/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
https://github.com/python/cpython/pull/124337/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
Please reload this pagehttps://github.com/python/cpython/pull/124337/files
https://github.com/python/cpython/pull/124337/files#diff-68e8ce66befd2f080ec5c1b5cc5536c8a62147a4be63211d0852468870fbeeaa
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.