René's URL Explorer Experiment


Title: gh-117376: Fix off-by-ones in conversion functions by Fidget-Spinner · Pull Request #124301 · python/cpython · GitHub

Open Graph Title: gh-117376: Fix off-by-ones in conversion functions by Fidget-Spinner · Pull Request #124301 · python/cpython

X Title: gh-117376: Fix off-by-ones in conversion functions by Fidget-Spinner · Pull Request #124301 · python/cpython

Description: This wasn't caught because the specializations are currently not tested in the free-threaded builds. To test this, apply the following patch to main: diff --git a/Python/ceval_macros.h b/Python/ceval_macros.h index 9e1540674d4..7ca2400529d 100644 --- a/Python/ceval_macros.h +++ b/Python/ceval_macros.h @@ -441,28 +441,13 @@ do { \ /* How much scratch space to give stackref to PyObject* conversion. */ #define MAX_STACKREF_SCRATCH 10 -#ifdef Py_GIL_DISABLED #define STACKREFS_TO_PYOBJECTS(ARGS, ARG_COUNT, NAME) \ /* +1 because vectorcall might use -1 to write self */ \ PyObject *NAME##_temp[MAX_STACKREF_SCRATCH+1]; \ PyObject **NAME = _PyObjectArray_FromStackRefArray(ARGS, ARG_COUNT, NAME##_temp + 1); -#else -#define STACKREFS_TO_PYOBJECTS(ARGS, ARG_COUNT, NAME) \ - PyObject **NAME = (PyObject **)ARGS; \ - assert(NAME != NULL); -#endif -#ifdef Py_GIL_DISABLED #define STACKREFS_TO_PYOBJECTS_CLEANUP(NAME) \ /* +1 because we +1 previously */ \ - _PyObjectArray_Free(NAME - 1, NAME##_temp); -#else -#define STACKREFS_TO_PYOBJECTS_CLEANUP(NAME) \ - (void)(NAME); -#endif + // _PyObjectArray_Free(NAME - 1, NAME##_temp); -#ifdef Py_GIL_DISABLED #define CONVERSION_FAILED(NAME) ((NAME) == NULL) -#else -#define CONVERSION_FAILED(NAME) (0) -#endif Note that Python fails to build on main, but passes on this branch. Issue: gh-117376

Open Graph Description: This wasn't caught because the specializations are currently not tested in the free-threaded builds. To test this, apply the following patch to main: diff --git a/Python/ceval_macros.h b/Python...

X Description: This wasn't caught because the specializations are currently not tested in the free-threaded builds. To test this, apply the following patch to main: diff --git a/Python/ceval_macros.h b/Py...

Opengraph URL: https://github.com/python/cpython/pull/124301

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4a344d7d-2825-b12f-7e6c-391540443a02
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8F76:3E418A:20DB4E1:2B05865:6B023B6D
html-safe-nonce3722330dca7418af8ffdf5334994f4e319bf9667447a23244427e3b72cfc9a26
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Rjc2OjNFNDE4QToyMERCNEUxOjJCMDU4NjU6NkIwMjNCNkQiLCJ2aXNpdG9yX2lkIjoiODYxMzAwNTI1NTQzODkwODI2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8b620a224d4de01ff3155882832eb1444d967ab0690bfa438db6d19cb1d4cfd2
hovercard-subject-tagpull_request:2084492324
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/124301/files
twitter:imagehttps://avatars.githubusercontent.com/u/28750310?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/28750310?s=400&v=4
og:image:altThis wasn't caught because the specializations are currently not tested in the free-threaded builds. To test this, apply the following patch to main: diff --git a/Python/ceval_macros.h b/Python...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/124301/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124301%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124301%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/124301/files
Reloadhttps://github.com/python/cpython/pull/124301/files
Reloadhttps://github.com/python/cpython/pull/124301/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Fidget-Spinnerhttps://github.com/Fidget-Spinner
python:mainhttps://github.com/python/cpython/tree/main
Fidget-Spinner:fix_some_off_by_oneshttps://github.com/Fidget-Spinner/cpython/tree/fix_some_off_by_ones
Conversation 2 https://github.com/python/cpython/pull/124301
Commits 1 https://github.com/python/cpython/pull/124301/commits
Checks 0 https://github.com/python/cpython/pull/124301/checks
Files changed https://github.com/python/cpython/pull/124301/files
Please reload this pagehttps://github.com/python/cpython/pull/124301/files
gh-117376: Fix off-by-ones in conversion functions https://github.com/python/cpython/pull/124301/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/124301/files
35b22fa Fix off-by-ones in conversion function Fidget-Spinner Sep 21, 2024 https://github.com/python/cpython/pull/124301/commits/35b22fa15c651ab8b05fbb03ec7d63af0095c9eb
Clear filters https://github.com/python/cpython/pull/124301/files
Please reload this pagehttps://github.com/python/cpython/pull/124301/files
Please reload this pagehttps://github.com/python/cpython/pull/124301/files
bytecodes.c https://github.com/python/cpython/pull/124301/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
executor_cases.c.h https://github.com/python/cpython/pull/124301/files#diff-a1c3430c42a66c16e6d2e154491a6da993b187b27c628545a12a02c7b2a06b81
generated_cases.c.h https://github.com/python/cpython/pull/124301/files#diff-4ef46fa654f95502e49a24f7dc8ee31a4cac9b3433fe9cd2b2d4dd78cfbad448
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L222
Python/bytecodes.chttps://github.com/python/cpython/pull/124301/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
View file https://github.com/Fidget-Spinner/cpython/blob/35b22fa15c651ab8b05fbb03ec7d63af0095c9eb/Python/bytecodes.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/124301/{{ revealButtonHref }}
https://github.com/python/cpython/pull/124301/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
https://github.com/python/cpython/pull/124301/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
https://github.com/python/cpython/pull/124301/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
https://github.com/python/cpython/pull/124301/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
Python/executor_cases.c.hhttps://github.com/python/cpython/pull/124301/files#diff-a1c3430c42a66c16e6d2e154491a6da993b187b27c628545a12a02c7b2a06b81
View file https://github.com/Fidget-Spinner/cpython/blob/35b22fa15c651ab8b05fbb03ec7d63af0095c9eb/Python/executor_cases.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/124301/files
Python/generated_cases.c.hhttps://github.com/python/cpython/pull/124301/files#diff-4ef46fa654f95502e49a24f7dc8ee31a4cac9b3433fe9cd2b2d4dd78cfbad448
View file https://github.com/Fidget-Spinner/cpython/blob/35b22fa15c651ab8b05fbb03ec7d63af0095c9eb/Python/generated_cases.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/124301/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.