René's URL Explorer Experiment


Title: gh-121459: Add missing return to _PyDict_LoadGlobalStackRef by colesbury · Pull Request #124085 · python/cpython · GitHub

Open Graph Title: gh-121459: Add missing return to _PyDict_LoadGlobalStackRef by colesbury · Pull Request #124085 · python/cpython

X Title: gh-121459: Add missing return to _PyDict_LoadGlobalStackRef by colesbury · Pull Request #124085 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: We need to return immediately if there's an error during dictionary lookup. Also avoid the conditional-if operator. The Windows 10 buildbot seems to miscompile that for unknown reasons. Issue...

X Description: We need to return immediately if there's an error during dictionary lookup. Also avoid the conditional-if operator. The Windows 10 buildbot seems to miscompile that for unknown reasons. I...

Opengraph URL: https://github.com/python/cpython/pull/124085

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b4fbb131-bca0-bbc5-0d37-9bbd002c9924
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC156:24749A:8E58D7:C12B3E:6A55A633
html-safe-nonce4556c37fb33748def6def01332e69983ee4deba525f2ee6e9d6490bcaccb0e3e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTU2OjI0NzQ5QTo4RTU4RDc6QzEyQjNFOjZBNTVBNjMzIiwidmlzaXRvcl9pZCI6IjQ1OTQzNzkyNjA1MTM1OTI4ODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacece3ce55a43e21aa1a7a8971f4f77026870025dc843a025701933d1a8290d3ee
hovercard-subject-tagpull_request:2071863309
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/124085/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9cca9c28489033334ca68617aefa57e7aa99af6cf26d26126c2f856620051336/python/cpython/pull/124085
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9cca9c28489033334ca68617aefa57e7aa99af6cf26d26126c2f856620051336/python/cpython/pull/124085
og:image:altWe need to return immediately if there's an error during dictionary lookup. Also avoid the conditional-if operator. The Windows 10 buildbot seems to miscompile that for unknown reasons. Issue...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecolesbury
hostnamegithub.com
expected-hostnamegithub.com
Noneb5665c84831ed9ac4fb79519c16c9c5580ba8092fb8bb6e3e72972ec7197348e
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release653fccf1e27344851c0d3de3fa6faa526197f072
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/124085#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124085
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124085
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/124085
Reloadhttps://github.com/python/cpython/pull/124085
Reloadhttps://github.com/python/cpython/pull/124085
Please reload this pagehttps://github.com/python/cpython/pull/124085
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/124085
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
colesburyhttps://github.com/colesbury
python:mainhttps://github.com/python/cpython/tree/main
colesbury:gh-121459-missing-returnhttps://github.com/colesbury/cpython/tree/gh-121459-missing-return
Conversationhttps://github.com/python/cpython/pull/124085
Commits1 (1)https://github.com/python/cpython/pull/124085/commits
Checkshttps://github.com/python/cpython/pull/124085/checks
Files changedhttps://github.com/python/cpython/pull/124085/files
gh-121459: Add missing return to _PyDict_LoadGlobalStackRefhttps://github.com/python/cpython/pull/124085#top
colesburyhttps://github.com/colesbury
python:mainhttps://github.com/python/cpython/tree/main
colesbury:gh-121459-missing-returnhttps://github.com/colesbury/cpython/tree/gh-121459-missing-return
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Sep 14, 2024https://github.com/python/cpython/pull/124085#issue-2525914848
Please reload this pagehttps://github.com/python/cpython/pull/124085
PEP 703 Deferred reference counts #121459https://github.com/python/cpython/issues/121459
Please reload this pagehttps://github.com/python/cpython/pull/124085
https://github.com/colesbury
pythongh-121459https://github.com/python/cpython/issues/121459
: Add missing return to _PyDict_LoadGlobalStackRefhttps://github.com/python/cpython/pull/124085/commits/c8c59a1250ae3e39c80b84a471ff2f25d9fb3fec
c8c59a1https://github.com/python/cpython/pull/124085/commits/c8c59a1250ae3e39c80b84a471ff2f25d9fb3fec
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 14, 2024 https://github.com/python/cpython/pull/124085#ref-issue-2394094688
PEP 703 Deferred reference counts #121459 https://github.com/python/cpython/issues/121459
https://github.com/colesbury
colesburyhttps://github.com/colesbury
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Sep 14, 2024https://github.com/python/cpython/pull/124085#event-14256064380
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Sep 14, 2024https://github.com/python/cpython/pull/124085#issuecomment-2350763979
Please reload this pagehttps://github.com/python/cpython/pull/124085
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 14, 2024https://github.com/python/cpython/pull/124085#issuecomment-2350764000
@colesburyhttps://github.com/colesbury
c8c59a1https://github.com/python/cpython/commit/c8c59a1250ae3e39c80b84a471ff2f25d9fb3fec
Please reload this pagehttps://github.com/python/cpython/pull/124085
https://github.com/colesbury
colesburyhttps://github.com/colesbury
September 14, 2024 01:32https://github.com/python/cpython/pull/124085#event-14256114109
https://github.com/colesbury
colesburyhttps://github.com/colesbury
markshannonhttps://github.com/markshannon
methanehttps://github.com/methane
code ownershttps://github.com/python/cpython/blob/38809171b8768517824fb62d48abe2cb0aff8429/.github/CODEOWNERS#L28
September 14, 2024 01:32https://github.com/python/cpython/pull/124085#event-14256114141
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 14, 2024https://github.com/python/cpython/pull/124085#event-14256114335
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Fidget-Spinnerhttps://github.com/Fidget-Spinner
zwarehttps://github.com/zware
September 14, 2024 01:32https://github.com/python/cpython/pull/124085#event-14256115071
https://github.com/colesbury
colesburyhttps://github.com/colesbury
OS-windows https://github.com/python/cpython/issues?q=state%3Aopen%20label%3AOS-windows
Sep 14, 2024https://github.com/python/cpython/pull/124085#event-14256115694
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Sep 14, 2024 https://github.com/python/cpython/pull/124085#pullrequestreview-2304345682
View reviewed changes https://github.com/python/cpython/pull/124085/files/c8c59a1250ae3e39c80b84a471ff2f25d9fb3fec
Objects/dictobject.chttps://github.com/python/cpython/pull/124085/files/c8c59a1250ae3e39c80b84a471ff2f25d9fb3fec#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
colesburyhttps://github.com/colesbury
Sep 14, 2024https://github.com/python/cpython/pull/124085#discussion_r1759637299
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/124085
colesburyhttps://github.com/colesbury
Sep 14, 2024https://github.com/python/cpython/pull/124085#discussion_r1759640615
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://gcc.godbolt.org/z/ezr9rsvM4https://gcc.godbolt.org/z/ezr9rsvM4
Please reload this pagehttps://github.com/python/cpython/pull/124085
https://github.com/colesbury
colesburyhttps://github.com/colesbury
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Sep 14, 2024https://github.com/python/cpython/pull/124085#event-14256124058
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Sep 14, 2024 https://github.com/python/cpython/pull/124085#ref-pullrequest-2525460494
gh-124068: Fix reference leak with generators in the free-threaded build #124069 https://github.com/python/cpython/pull/124069
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Sep 14, 2024 https://github.com/python/cpython/pull/124085#ref-pullrequest-2525741400
Revert "gh-121459: Deferred LOAD_GLOBAL (GH-123128)" #124077 https://github.com/python/cpython/pull/124077
https://github.com/zware
zwarehttps://github.com/zware
Sep 14, 2024 https://github.com/python/cpython/pull/124085#pullrequestreview-2304739693
View reviewed changes https://github.com/python/cpython/pull/124085/files/c8c59a1250ae3e39c80b84a471ff2f25d9fb3fec
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 14, 2024https://github.com/python/cpython/pull/124085#event-14259742695
https://github.com/colesbury
colesburyhttps://github.com/colesbury
401fff7https://github.com/python/cpython/commit/401fff7423ca3c8bf1d02e594edfd1412616a559
Sep 14, 2024https://github.com/python/cpython/pull/124085#event-14260314507
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Sep 14, 2024https://github.com/python/cpython/pull/124085#event-14260314704
https://github.com/colesbury
colesburyhttps://github.com/colesbury
September 14, 2024 18:29https://github.com/python/cpython/pull/124085#event-14260314733
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Sep 16, 2024 https://github.com/python/cpython/pull/124085#ref-pullrequest-2526848394
gh-121459: Deferred LOAD_ATTR (methods) #124101 https://github.com/python/cpython/pull/124101
savannahostrowskihttps://github.com/savannahostrowski
Sep 22, 2024 https://github.com/python/cpython/pull/124085#ref-commit-eeca0b5
https://github.com/colesbury
https://github.com/savannahostrowski
pythongh-121459https://github.com/python/cpython/issues/121459
: Add missing return to _PyDict_LoadGlobalStackRef (https://github.com/savannahostrowski/cpython/commit/eeca0b5a993d833c4f49a03bfc56e71794153535
py…https://github.com/python/cpython/pull/124085
eeca0b5https://github.com/savannahostrowski/cpython/commit/eeca0b5a993d833c4f49a03bfc56e71794153535
…thon#124085https://github.com/python/cpython/pull/124085
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Oct 21, 2024 https://github.com/python/cpython/pull/124085#pullrequestreview-2382280357
View reviewed changes https://github.com/python/cpython/pull/124085/files/c8c59a1250ae3e39c80b84a471ff2f25d9fb3fec
Objects/dictobject.chttps://github.com/python/cpython/pull/124085/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
colesburyhttps://github.com/colesbury
Oct 21, 2024https://github.com/python/cpython/pull/124085#discussion_r1808926217
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@fiona02https://github.com/fiona02
Please reload this pagehttps://github.com/python/cpython/pull/124085
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124085
https://github.com/zware
zware https://github.com/zware
https://github.com/python/cpython/pull/124085/files/c8c59a1250ae3e39c80b84a471ff2f25d9fb3fec
https://github.com/methane
methane https://github.com/methane
https://github.com/markshannon
markshannon https://github.com/markshannon
https://github.com/Fidget-Spinner
Fidget-Spinner https://github.com/Fidget-Spinner
OS-windows https://github.com/python/cpython/issues?q=state%3Aopen%20label%3AOS-windows
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Please reload this pagehttps://github.com/python/cpython/pull/124085
https://github.com/colesbury
https://github.com/bedevere-bot
https://github.com/zware
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.