René's URL Explorer Experiment


Title: gh-122957: Fix test flakiness in free-thread build by lesteve · Pull Request #124039 · python/cpython · GitHub

Open Graph Title: gh-122957: Fix test flakiness in free-thread build by lesteve · Pull Request #124039 · python/cpython

X Title: gh-122957: Fix test flakiness in free-thread build by lesteve · Pull Request #124039 · python/cpython

Description: Fix #122957. Locally I tested this by running the test 1000 times with the command and the diff below. It fails around 10-20 times out of 1000 on main and does not fail out of 1000 times with the fix on this PR. ./python -m test.test_asyncio.test_threads -k concurrent -v diff --git a/Lib/test/test_asyncio/test_threads.py b/Lib/test/test_asyncio/test_threads.py index 774380270a7..8504544aaba 100644 --- a/Lib/test/test_asyncio/test_threads.py +++ b/Lib/test/test_asyncio/test_threads.py @@ -63,4 +63,10 @@ def get_ctx(): if __name__ == "__main__": - unittest.main() + nb_tests = 1000 + suite = unittest.TestSuite( + [ToThreadTests("test_to_thread_concurrent") for _ in range(nb_tests)] + ) + + test_runner = unittest.TextTestRunner() + test_runner.run(suite) Issue: gh-122957

Open Graph Description: Fix #122957. Locally I tested this by running the test 1000 times with the command and the diff below. It fails around 10-20 times out of 1000 on main and does not fail out of 1000 times with the f...

X Description: Fix #122957. Locally I tested this by running the test 1000 times with the command and the diff below. It fails around 10-20 times out of 1000 on main and does not fail out of 1000 times with the f...

Opengraph URL: https://github.com/python/cpython/pull/124039

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:71f28fc7-e0c2-1bd5-1baa-6ce5b821d795
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD836:2F0FE8:2A746AD:3926C79:6A53AE32
html-safe-nonce37605d8e47d1324f8f924b2e28857894873fb63d0acd8052d92fcaca91054c0a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODM2OjJGMEZFODoyQTc0NkFEOjM5MjZDNzk6NkE1M0FFMzIiLCJ2aXNpdG9yX2lkIjoiMjk1MjcwNjg5NzI4MTc4OTQ5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac67e0aae6f3290438aa7ae6cf4f019e80cfd3dccc39aea659d0f78614f6cfa721
hovercard-subject-tagpull_request:2070250794
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/124039/files
twitter:imagehttps://avatars.githubusercontent.com/u/1680079?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1680079?s=400&v=4
og:image:altFix #122957. Locally I tested this by running the test 1000 times with the command and the diff below. It fails around 10-20 times out of 1000 on main and does not fail out of 1000 times with the f...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/124039/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124039%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F124039%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/124039/files
Reloadhttps://github.com/python/cpython/pull/124039/files
Reloadhttps://github.com/python/cpython/pull/124039/files
Please reload this pagehttps://github.com/python/cpython/pull/124039/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/124039/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
lesteve:fix-free-threaded-asyncio-test-threadshttps://github.com/lesteve/cpython/tree/fix-free-threaded-asyncio-test-threads
Conversation 7 https://github.com/python/cpython/pull/124039
Commits 1 https://github.com/python/cpython/pull/124039/commits
Checks 0 https://github.com/python/cpython/pull/124039/checks
Files changed https://github.com/python/cpython/pull/124039/files
Please reload this pagehttps://github.com/python/cpython/pull/124039/files
gh-122957: Fix test flakiness in free-thread build https://github.com/python/cpython/pull/124039/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/124039/files
565d117 Fix race condition in test_asyncio in free-threaded build lesteve Sep 10, 2024 https://github.com/python/cpython/pull/124039/commits/565d11741f59eb78a50653df1c4b101e764c7d26
Clear filters https://github.com/python/cpython/pull/124039/files
Please reload this pagehttps://github.com/python/cpython/pull/124039/files
Please reload this pagehttps://github.com/python/cpython/pull/124039/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L380
Lib/test/test_asyncio/test_threads.pyhttps://github.com/python/cpython/pull/124039/files#diff-ed773344f1e59dd41bd61fad9d7a752ffa972e539dbd58d6b318eff74ba5369b
View file https://github.com/lesteve/cpython/blob/565d11741f59eb78a50653df1c4b101e764c7d26/Lib/test/test_asyncio/test_threads.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/124039/{{ revealButtonHref }}
https://github.com/python/cpython/pull/124039/files#diff-ed773344f1e59dd41bd61fad9d7a752ffa972e539dbd58d6b318eff74ba5369b
https://github.com/python/cpython/pull/124039/files#diff-ed773344f1e59dd41bd61fad9d7a752ffa972e539dbd58d6b318eff74ba5369b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.